Re: [PATCH] Media: video: uvc: integer overflow in uvc_ioctl_ctrl_map()

2011-11-29 Thread Haogang Chen
The hard limit sounds good to me. But if you want to centralize error handling, please make sure that "goto done" only frees map, but not map->menu_info in that case. - Haogang On Tue, Nov 29, 2011 at 8:22 PM, Laurent Pinchart wrote: > Hi Haogang, > > On Tuesday 29 November 2011 22:32:25 Haog

Re: [PATCH] omap3isp: video: Don't WARN() on unknown pixel formats

2011-11-29 Thread Laurent Pinchart
Hi Sakari, On Monday 28 November 2011 17:01:12 Sakari Ailus wrote: > On Mon, Nov 28, 2011 at 12:37:34PM +0100, Laurent Pinchart wrote: > > When mapping from a V4L2 pixel format to a media bus format in the > > VIDIOC_TRY_FMT and VIDIOC_S_FMT handlers, the requested format may be > > unsupported by

Re: uvcvideo: Failed to query (SET_CUR) UVC control 10 on unit 2: -32 (exp. 2).

2011-11-29 Thread Laurent Pinchart
Hi Alex, On Monday 28 November 2011 22:53:19 Alex wrote: > On 11/28/2011 10:20 PM, Laurent Pinchart wrote: > > On Monday 28 November 2011 20:14:25 Alex wrote: > >> On 11/28/2011 10:08 PM, Laurent Pinchart wrote: > >>> On Monday 28 November 2011 19:04:22 Alex wrote: > Fortunately my laptop is

Re: [PATCH v2 1/2] v4l: Add new alpha component control

2011-11-29 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 29 November 2011 20:39:39 Sylwester Nawrocki wrote: > On 11/29/2011 07:10 PM, Laurent Pinchart wrote: > > On Tuesday 29 November 2011 17:40:10 Sylwester Nawrocki wrote: > >> On 11/29/2011 12:08 PM, Hans Verkuil wrote: > >>> On Monday 28 November 2011 14:02:49 Sylwester Naw

Re: [PATCH] Media: video: uvc: integer overflow in uvc_ioctl_ctrl_map()

2011-11-29 Thread Laurent Pinchart
Hi Haogang, On Tuesday 29 November 2011 22:32:25 Haogang Chen wrote: > There is a potential integer overflow in uvc_ioctl_ctrl_map(). When a > large xmap->menu_count is passed from the userspace, the subsequent call > to kmalloc() will allocate a buffer smaller than expected. > map->menu_count and

Re: [PATCH] [media] V4L: soc-camera: change order of removing device

2011-11-29 Thread Guennadi Liakhovetski
Hi Lei On Tue, 29 Nov 2011, Lei Wen wrote: > Hi, > > On Tue, Nov 22, 2011 at 10:04 PM, Lei Wen wrote: > > As our general practice, we use stream off before we close > > the video node. So that the drivers its stream off function > > would be called before its remove function. > > > > But for th

[PATCH] Media: video: uvc: integer overflow in uvc_ioctl_ctrl_map()

2011-11-29 Thread Haogang Chen
There is a potential integer overflow in uvc_ioctl_ctrl_map(). When a large xmap->menu_count is passed from the userspace, the subsequent call to kmalloc() will allocate a buffer smaller than expected. map->menu_count and map->menu_info would later be used in a loop (e.g. in uvc_query_v4l2_ctrl), w

Re: Status of RTL283xU support?

2011-11-29 Thread poma
On 26.11.2011 17:20, Maik Zumstrull wrote: > On Sat, Nov 26, 2011 at 13:47, Maik Zumstrull wrote: .. > FYI, someone has contacted me off-list to point out that the newest(?) > Realtek tree for these devices is available online: > > Alessandro Ambrosini wrote: > >> Dear maik, >> >> I've read you

Re: [PATCH v2 1/2] v4l: Add new alpha component control

2011-11-29 Thread Sylwester Nawrocki
Hi Laurent! On 11/29/2011 07:10 PM, Laurent Pinchart wrote: > Hi Sylwester, > > On Tuesday 29 November 2011 17:40:10 Sylwester Nawrocki wrote: >> On 11/29/2011 12:08 PM, Hans Verkuil wrote: >>> On Monday 28 November 2011 14:02:49 Sylwester Nawrocki wrote: On 11/28/2011 01:39 PM, Hans Verkuil

Re: [PATCH v2 1/2] v4l: Add new alpha component control

2011-11-29 Thread Laurent Pinchart
Hi Hans, On Tuesday 29 November 2011 19:30:25 Hans Verkuil wrote: > On Tuesday, November 29, 2011 19:10:39 Laurent Pinchart wrote: > > On Tuesday 29 November 2011 17:40:10 Sylwester Nawrocki wrote: > > > On 11/29/2011 12:08 PM, Hans Verkuil wrote: > > > > On Monday 28 November 2011 14:02:49 Sylwes

cron job: media_tree daily build: ERRORS

2011-11-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Nov 29 19:00:16 CET 2011 git hash:36d36b884c745c507d9b3f60eb42925749f7d758 gcc version: i686-linux-gcc (GCC

Re: [PATCH v2 1/2] v4l: Add new alpha component control

2011-11-29 Thread Hans Verkuil
On Tuesday, November 29, 2011 19:10:39 Laurent Pinchart wrote: > Hi Sylwester, > > On Tuesday 29 November 2011 17:40:10 Sylwester Nawrocki wrote: > > On 11/29/2011 12:08 PM, Hans Verkuil wrote: > > > On Monday 28 November 2011 14:02:49 Sylwester Nawrocki wrote: > > >> On 11/28/2011 01:39 PM, Hans

Re: [PATCH v4 2/3] v4l: Add V4L2_PIX_FMT_NV24 and V4L2_PIX_FMT_NV42 formats

2011-11-29 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 29 November 2011 18:19:09 Sylwester Nawrocki wrote: > On 11/29/2011 11:26 AM, Laurent Pinchart wrote: > > NV24 and NV42 are planar YCbCr 4:4:4 and YCrCb 4:4:4 formats with a > > luma plane followed by an interleaved chroma plane. > > > > Signed-off-by: Laurent Pinchart >

Re: [PATCH v2 1/2] v4l: Add new alpha component control

2011-11-29 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 29 November 2011 17:40:10 Sylwester Nawrocki wrote: > On 11/29/2011 12:08 PM, Hans Verkuil wrote: > > On Monday 28 November 2011 14:02:49 Sylwester Nawrocki wrote: > >> On 11/28/2011 01:39 PM, Hans Verkuil wrote: > >>> On Monday 28 November 2011 13:13:32 Sylwester Nawrocki

[PATCH v3 3/3] s5p-fimc: Add support for alpha component configuration

2011-11-29 Thread Sylwester Nawrocki
On Exynos SoCs the FIMC IP allows to configure globally the alpha component of all pixels for V4L2_PIX_FMT_RGB32, V4L2_PIX_FMT_RGB555 and V4L2_PIX_FMT_RGB444 image formats. This patch adds a v4l2 control in order to let the applications control the alpha component value. The alpha value range depe

[PATCH 1/3] v4l-ctrl: Add a method for control value range update

2011-11-29 Thread Sylwester Nawrocki
From: Hans Verkuil --- This patch is not for merging, I'm just resending it as patch 3/3 depends on this one. --- drivers/media/video/v4l2-ctrls.c | 147 +++--- include/linux/videodev2.h|1 + include/media/v4l2-ctrls.h | 17 + 3 files cha

[PATCH v3 2/3] v4l: Add new alpha component control

2011-11-29 Thread Sylwester Nawrocki
The V4L2_CID_ALPHA_COMPONENT control is intended for the video capture or memory-to-memory devices that are capable of setting up the per-pixel alpha component to some arbitrary value. It allows to set the alpha component for all pixels to an arbitrary value. Signed-off-by: Sylwester Nawrocki Sig

[PATCH/RFC v3] Add new V4L2_CID_ALPHA_COMPONENT control

2011-11-29 Thread Sylwester Nawrocki
Hello, This changeset adds new V4L2_CID_ALPHA_COMPONENT control that allows to configure an alpha component of all pixels on the video capture device or on capture queue of a mem-to-mem device. This is meant for devices that allow to set a per-pixel alpha at the pipeline output to a desired va

Re: [RFC] JPEG encoders control class

2011-11-29 Thread Jean-Francois Moine
On Mon, 28 Nov 2011 19:48:28 +0100 Luca Risolia wrote: > > Note that et61x251 and sn9c102 are going to be deprecated and removed at > > some > > time in the future (gspca will support these devices). > > Has this been discussed yet? Also, last time I tried the gspca driver > with a number of

Re: [PATCH v4 2/3] v4l: Add V4L2_PIX_FMT_NV24 and V4L2_PIX_FMT_NV42 formats

2011-11-29 Thread Sylwester Nawrocki
Hi Laurent, On 11/29/2011 11:26 AM, Laurent Pinchart wrote: > NV24 and NV42 are planar YCbCr 4:4:4 and YCrCb 4:4:4 formats with a > luma plane followed by an interleaved chroma plane. > > Signed-off-by: Laurent Pinchart > --- ... > + > + > + > + > + I think this comment chunk

Re: [PATCH resent] Fix logic in sanity check

2011-11-29 Thread Sylwester Nawrocki
Hi Thomas, On 11/29/2011 01:26 PM, Thomas Jarosch wrote: > On Sunday, 20. November 2011 18:26:13 Sylwester Nawrocki wrote: >> If you care to resend the patch, please add "m5mols:" as a subsystem name >> in the subject so it looks something like: >> >> [PATCH ...] m5mols: Fix ... >> --- >

Re: [PATCH v2 1/2] v4l: Add new alpha component control

2011-11-29 Thread Sylwester Nawrocki
Hi Hans, On 11/29/2011 12:08 PM, Hans Verkuil wrote: > On Monday 28 November 2011 14:02:49 Sylwester Nawrocki wrote: >> On 11/28/2011 01:39 PM, Hans Verkuil wrote: >>> On Monday 28 November 2011 13:13:32 Sylwester Nawrocki wrote: On 11/28/2011 12:38 PM, Hans Verkuil wrote: > On Friday 25

Re: drm pixel formats update

2011-11-29 Thread Tomi Valkeinen
On Tue, 2011-11-29 at 13:10 +0100, Laurent Pinchart wrote: > To make it perfectly clear, I want to emphasize that I'm not trying to > replace > DRM, FBDEV and V4L2 with a new shared subsystem. What I would like to see in > the (near future) is collaboration and sharing of core features that mak

[PATCH] stv090x: implement function for reading uncorrected blocks count

2011-11-29 Thread Mariusz Bialonczyk
This patch add support for reading UNC blocks for stv090x frontend. Partially based on stv0900 code by Abylay Ospan Signed-off-by: Mariusz Bialonczyk --- drivers/media/dvb/frontends/stv090x.c | 32 +++- 1 files changed, 31 insertions(+), 1 deletions(-) diff --git

Re: gnutv should not ignore SIGPIPE

2011-11-29 Thread Brian J. Murrell
On 11-11-25 08:36 AM, Brian J. Murrell wrote: > > Yes, that is the other way to skin that cat I suppose. I couldn't figure out what the right thing for writer thread to do to terminate the application so I used SIGPIPE instead. Here's the patch: --- linuxtv-dvb-apps-1.1.1+rev1273~/util/gnutv/gn

Re: drm pixel formats update

2011-11-29 Thread Hans Verkuil
On Tuesday 29 November 2011 13:10:35 Laurent Pinchart wrote: > Hi Ville, > > Sorry for the late reply. > > (Cross-posting to the linux-fbdev and linux-media mailing lists, as the > topics I'm about to discuss are of interest to everybody) > > On Wednesday 16 November 2011 19:42:23 ville.syrj...@

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

2011-11-29 Thread Andreas Oberritter
On 29.11.2011 13:04, Jens Erdmann wrote: > Hi Andreas, > > On Monday, November 28, 2011 05:57:35 PM you wrote: >> Hello Jens, >> >> On 28.11.2011 16:41, Jens Erdmann wrote: >>> Hi folks, >>> >>> just a few quetstions: >>> 1. Why is the device named EM2884_BOARD_CINERGY_HTC_STICK and not >>> >>>

Re: [PATCH resent] Fix logic in sanity check

2011-11-29 Thread Thomas Jarosch
Hi Sylwester, On Sunday, 20. November 2011 18:26:13 Sylwester Nawrocki wrote: > If you care to resend the patch, please add "m5mols:" as a subsystem name > in the subject so it looks something like: > > [PATCH ...] m5mols: Fix ... > > >> --- > >> > >> drivers/media/video/m5mols/m5mols_core.c

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

2011-11-29 Thread Jens Erdmann
Hi Andreas, On Monday, November 28, 2011 05:57:35 PM you wrote: > Hello Jens, > > On 28.11.2011 16:41, Jens Erdmann wrote: > > Hi folks, > > > > just a few quetstions: > > 1. Why is the device named EM2884_BOARD_CINERGY_HTC_STICK and not > > > > EM2884_BOARD_TERRATEC_HTC_STICK like all the

Re: drm pixel formats update

2011-11-29 Thread Laurent Pinchart
Hi Ville, Sorry for the late reply. (Cross-posting to the linux-fbdev and linux-media mailing lists, as the topics I'm about to discuss are of interest to everybody) On Wednesday 16 November 2011 19:42:23 ville.syrj...@linux.intel.com wrote: > I decided to go all out with the pixel format defin

Re: HVR-900H dvb-t regression(s)

2011-11-29 Thread Fabio M. Di Nitto
On 11/29/2011 12:35 PM, Mauro Carvalho Chehab wrote: > On 29-11-2011 02:53, Fabio M. Di Nitto wrote: >>> [ 7867.776612] tm6000: Found Generic tm6010 board >>> [ 7867.841177] tm6000 #1: i2c eeprom 00: 00 00 00 00 00 00 00 00 00 00 >>> 00 00 00 00 00 00 >> [SNIP] >>> [ 7869.707769]

Re: HVR-900H dvb-t regression(s)

2011-11-29 Thread Fabio M. Di Nitto
On 11/28/2011 10:07 PM, Mauro Carvalho Chehab wrote: > Btw, Stefan sent some fixes to the ML. I'll test if the patch solves the > audio issue with HVR-900H on analog mode. I just finished testing those ones and they seem to fix my specific issue. There is still one thing that puzzles me, but may

Re: HVR-900H dvb-t regression(s)

2011-11-29 Thread Mauro Carvalho Chehab
On 29-11-2011 02:53, Fabio M. Di Nitto wrote: On 11/28/2011 10:07 PM, Mauro Carvalho Chehab wrote: On 28-11-2011 12:41, Fabio M. Di Nitto wrote: Hi all, short summary is that dvb-t on $subject doesn´t work with head of the tree (for_3.3 branch) and scan or mplayer stop working. Here is the br

Re: [PATCH] [media] convert drivers/media/* to use module_platform_driver()

2011-11-29 Thread Matti J. Aaltonen
Hello. On Sat, 2011-11-26 at 14:48 +0800, ext Axel Lin wrote: > This patch converts the drivers in drivers/media/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. > > Cc: Mauro Carvalho Chehab > Cc: Laurent Pinchart > Cc: Kyungmin Park > Cc: Hans V

Re: [PATCH v2 1/2] v4l: Add new alpha component control

2011-11-29 Thread Hans Verkuil
On Monday 28 November 2011 14:02:49 Sylwester Nawrocki wrote: > On 11/28/2011 01:39 PM, Hans Verkuil wrote: > > On Monday 28 November 2011 13:13:32 Sylwester Nawrocki wrote: > >> On 11/28/2011 12:38 PM, Hans Verkuil wrote: > >>> On Friday 25 November 2011 16:39:31 Sylwester Nawrocki wrote: > T

[PATCH v4 3/3] fbdev: sh_mobile_lcdc: Support FOURCC-based format API

2011-11-29 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart --- arch/arm/mach-shmobile/board-ag5evm.c |2 +- arch/arm/mach-shmobile/board-ap4evb.c |4 +- arch/arm/mach-shmobile/board-mackerel.c |4 +- arch/sh/boards/mach-ap325rxa/setup.c|2 +- arch/sh/boards/mach-ecovec24/setup.c|2 +- arch/s

[PATCH v4 2/3] v4l: Add V4L2_PIX_FMT_NV24 and V4L2_PIX_FMT_NV42 formats

2011-11-29 Thread Laurent Pinchart
NV24 and NV42 are planar YCbCr 4:4:4 and YCrCb 4:4:4 formats with a luma plane followed by an interleaved chroma plane. Signed-off-by: Laurent Pinchart --- Documentation/DocBook/media/v4l/pixfmt-nv24.xml | 129 +++ Documentation/DocBook/media/v4l/pixfmt.xml |1 + in

[PATCH v4 1/3] fbdev: Add FOURCC-based format configuration API

2011-11-29 Thread Laurent Pinchart
This API will be used to support YUV frame buffer formats in a standard way. Last but not least, create a much needed fbdev API documentation and document the format setting APIs. Signed-off-by: Laurent Pinchart --- Documentation/fb/api.txt | 306 ++

[PATCH v4 0/3] fbdev: Add FOURCC-based format configuration API

2011-11-29 Thread Laurent Pinchart
Hi everybody, Here's the fourth version of the fbdev FOURCC-based format configuration API. The third version nearly got merged, but we noticed that gcc choked on anonymous union initializers. This has been fixed in gcc 4.6, but I don't have the power to force Linux to set the base gcc version to

Support for multiple section feeds with same PIDs

2011-11-29 Thread Hamad Kadmany
Hello Question on the current behavior of dvb_dmxdev_filter_start (dmxdev.c) In case of DMXDEV_TYPE_SEC, the code restricts of having multiple sections feeds allocated (allocate_section_feed) with same PID. From my experience, applications might request allocating several section feeds using same