Re: Question about USB interface index restriction in gspca

2011-09-13 Thread Jean-Francois Moine
On Tue, 13 Sep 2011 21:14:28 +0200 Frank Schäfer wrote: > I have a question about the following code in gspca.c: > > in function gspca_dev_probe(...): > ... > /* the USB video interface must be the first one */ > if (dev->config->desc.bNumInterfaces != 1 > && intf->cur_altsetting-

Re: recursive locking problem

2011-09-13 Thread Daniel Glöckner
On Wed, Sep 14, 2011 at 04:03:58AM +0300, Antti Palosaari wrote: > On 09/09/2011 02:46 PM, Daniel Glöckner wrote: > >On Thu, Sep 08, 2011 at 07:34:32PM +0300, Antti Palosaari wrote: > >>I am working with AF9015 I2C-adapter lock. I need lock I2C-bus since > >>there is two tuners having same I2C addr

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Scott Jiang
>> > I think, the direct use of vb2_plane_cookie() is discouraged. >> > vb2_dma_contig_plane_dma_addr() should work for you. >> > >> I guess you mean vb2_dma_contig_plane_paddr > > no, in the current kernel it's vb2_dma_contig_plane_dma_addr(). See > > http://git.linuxtv.org/media_tree.git/shortlog

Asking advice for Camera/ISP driver framework design

2011-09-13 Thread Cliff Cai
Dear guys, I'm currently working on a camera/ISP Linux driver project.Of course,I want it to be a V4L2 driver,but I got a problem about how to design the driver framework. let me introduce the background of this ISP(Image signal processor) a little bit. 1.The ISP has two output paths,first one cal

Re: [uclinux-dist-devel] [PATCH 3/4] v4l2: add vs6624 sensor driver

2011-09-13 Thread Mike Frysinger
On Tue, Sep 13, 2011 at 14:34, Scott Jiang wrote: > --- a/drivers/media/video/Makefile > +++ b/drivers/media/video/Makefile > > +obj-$(CONFIG_VIDEO_VS6624)  += vs6624.o >  obj-$(CONFIG_VIDEO_VPX3220) += vpx3220.o should be after vpx, not before ? > --- /dev/null > +++ b/drivers/media/video/vs6624

Re: [uclinux-dist-devel] [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Mike Frysinger
On Tue, Sep 13, 2011 at 14:34, Scott Jiang wrote: > --- /dev/null > +++ b/drivers/media/video/blackfin/Kconfig > @@ -0,0 +1,10 @@ > +config VIDEO_BLACKFIN_CAPTURE > +       tristate "Blackfin Video Capture Driver" > +       depends on VIDEO_DEV && BLACKFIN > +       select VIDEOBUF2_DMA_CONTIG sin

Re: [uclinux-dist-devel] [PATCH 2/4] v4l2: add adv7183 decoder driver

2011-09-13 Thread Mike Frysinger
On Tue, Sep 13, 2011 at 14:34, Scott Jiang wrote: > --- /dev/null > +++ b/drivers/media/video/adv7183_regs.h > > +#define        ADV7183_IN_CTRL            0x00 /* Input control */ should be a space after the #define, not a tab > --- /dev/null > +++ b/include/media/adv7183.h > > +#define        A

tm6010 based tv tuner uses the correct firmware? or the audio part problem

2011-09-13 Thread hendry zhang
hi, My tm6010 based tv tuner is WINTV-HVR-900H, Model number is 66009, and USB id is 2040:6600. According to the guide, I use the firmware xc3028L-v36.fw from http://www.stefanringel.de/pub/xc3028L-v36.fw. I'm sure this firmware is for Xceive products and is also suitable for this product? I'm able

Re: recursive locking problem

2011-09-13 Thread Antti Palosaari
On 09/09/2011 02:46 PM, Daniel Glöckner wrote: On Thu, Sep 08, 2011 at 07:34:32PM +0300, Antti Palosaari wrote: I am working with AF9015 I2C-adapter lock. I need lock I2C-bus since there is two tuners having same I2C address on same bus, demod I2C gate is used to select correct tuner. Would it

Re: Compro U680F USB stick receiver for FM/DAB/DAB+/DVB-T.

2011-09-13 Thread Antti Palosaari
On 09/14/2011 01:31 AM, Erik Dam wrote: I recently came across this interesting little USB device which seems the so far best bet on covering all the relevant standards for these parts of the woods (although it still misses out on DVB-T2 support). However, I have so far been unable to determine w

Compro U680F USB stick receiver for FM/DAB/DAB+/DVB-T.

2011-09-13 Thread Erik Dam
I recently came across this interesting little USB device which seems the so far best bet on covering all the relevant standards for these parts of the woods (although it still misses out on DVB-T2 support). However, I have so far been unable to determine whether any level of linux support exis

Re: recursive locking problem

2011-09-13 Thread Steven Toth
> I would take Steven Toth's explanation as more authoritative than mine > any day of the week.  It's possible that I may have been misinformed > regarding the rationale for why the gate is required. In general, complete bus isolation lowers noise levels, whether through RF coupling or needless in

Re: recursive locking problem

2011-09-13 Thread Devin Heitmueller
On Tue, Sep 13, 2011 at 5:58 PM, Steven Toth wrote: >> Can any one shed some light on this? I appreciate it's not a linux or >> indeed linux-media specific issue as the hardware itself is designed >> this way. > > i2c gates exist to isolate the downstream components from any spurious > RF noise ge

Re: recursive locking problem

2011-09-13 Thread Devin Heitmueller
On Tue, Sep 13, 2011 at 5:34 PM, Steve Kerrison wrote: > At the risk of sounding silly, why do we rely on i2c gating so much? The > whole point of i2c is that you can sit a bunch of devices on the same > pair of wires and talk to one at a time. Steve, There are essentially two issues here. To a

Re: recursive locking problem

2011-09-13 Thread Steven Toth
> Can any one shed some light on this? I appreciate it's not a linux or > indeed linux-media specific issue as the hardware itself is designed > this way. i2c gates exist to isolate the downstream components from any spurious RF noise generated by noisy components on the i2c bus. You don't want to

Re: recursive locking problem

2011-09-13 Thread Steve Kerrison
At the risk of sounding silly, why do we rely on i2c gating so much? The whole point of i2c is that you can sit a bunch of devices on the same pair of wires and talk to one at a time. Why not just open up the gates and be done with it, except for situations where the i2c chain foolishly has two de

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Sylwester Nawrocki
Hi Scott, On 09/13/2011 08:34 PM, Scott Jiang wrote: > this is a v4l2 bridge driver for Blackfin video capture device, > support ppi interface > > Signed-off-by: Scott Jiang > --- > drivers/media/video/Makefile|2 + > drivers/media/video/blackfin/Kconfig| 10 + >

Re: [PATCH v4] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Guennadi Liakhovetski
Hi Sylwester On Tue, 13 Sep 2011, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 09/13/2011 04:48 PM, Guennadi Liakhovetski wrote: > > Currently only very few drivers actually use video_device nodes, embedded > > in struct v4l2_subdev. Allocate these nodes dynamically for those drivers > > to s

Re: recursive locking problem

2011-09-13 Thread Antti Palosaari
On 09/09/2011 01:45 PM, David Waring wrote: On 08/09/11 17:34, Antti Palosaari wrote: [snip] Is there any lock can do recursive locking but unlock frees all locks? Like that: gate_open +gate_open +gate_close == lock is free AFAIK mutex can do only simple lock() + unlock(). Semaphore can do re

Re: [PATCH 1/1] EM28xx - fix deadlock when unplugging and replugging a DVB adapter

2011-09-13 Thread Chris Rankin
On 13/09/11 21:04, Antti Palosaari wrote: On 08/21/2011 03:32 PM, Chris Rankin wrote: It occurred to me this morning that since we're no longer supposed to be holding the device lock when taking the device list lock, then the em28xx_usb_disconnect() function needs changing too. Signed-off-by: C

Re: [PATCH 1/1] EM28xx - fix deadlock when unplugging and replugging a DVB adapter

2011-09-13 Thread Antti Palosaari
On 08/21/2011 03:32 PM, Chris Rankin wrote: It occurred to me this morning that since we're no longer supposed to be holding the device lock when taking the device list lock, then the em28xx_usb_disconnect() function needs changing too. Signed-off-by: Chris Rankin I ran that also when re-plug

[GIT PULL FOR 3.2] PCTV DVB-S2 Stick 460e

2011-09-13 Thread Antti Palosaari
Morjens Mauro This patch series adds support for PCTV DVB-S2 Stick 460e, that is DVB-S2 USB stick. Is is based of; * Empia EM28174 * NXP TDA10071 & Conexant CX24118A combo * Allegro A8293 It introduces two new chipset drivers namely tda10071 and a8293 - former is DVB-S/S2 demod + tuner combo

Question about USB interface index restriction in gspca

2011-09-13 Thread Frank Schäfer
Hi, I have a question about the following code in gspca.c: in function gspca_dev_probe(...): ... /* the USB video interface must be the first one */ if (dev->config->desc.bNumInterfaces != 1 && intf->cur_altsetting->desc.bInterfaceNumber != 0) return -ENODEV; ... Is

cron job: media_tree daily build: ERRORS

2011-09-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Sep 13 19:00:30 CEST 2011 git hash:2d04c13a507f5a01daa7422cd52250809573cfdb gcc version: i686-linux-gcc (GC

Re: Cinergy T USB XXS (HD): wrong keymap loaded

2011-09-13 Thread Sander Devrieze
Hello, Watching television works out of the box, but the remote control does not work by default. The remote uses the NEC protocol as is also noted on http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_XXS#Cinergy_T_USB_XXS_.28HD.29_.280ccd:00ab.29 However the RC5 protocol is loaded wit

Re: [PATCH v4] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 13 September 2011 16:48:10 Guennadi Liakhovetski wrote: > Currently only very few drivers actually use video_device nodes, embedded > in struct v4l2_subdev. Allocate these nodes dynamically for those drivers > to save memory for the rest. > > Signed-off-by: Guennadi Liakho

Re: [PATCH v4] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Sylwester Nawrocki
Hi Guennadi, On 09/13/2011 04:48 PM, Guennadi Liakhovetski wrote: > Currently only very few drivers actually use video_device nodes, embedded > in struct v4l2_subdev. Allocate these nodes dynamically for those drivers > to save memory for the rest. > > Signed-off-by: Guennadi Liakhovetski I hav

ngene/cxd2099 occasional timeouts/errors

2011-09-13 Thread Eric Petit
Hello, I am trying to run Mystique SaTiX-S2 CI Dual cards to fetch and decrypt a number of channels 24/7. I got it to work with the ngene/cxd2099 drivers (passing the stream through the sec0 device etc), but one remaining issue is that the driver occasionally reports a command timeout followed

Re: Fwd: V4L2 driver EM28xx

2011-09-13 Thread Mauro Carvalho Chehab
Em 12-09-2011 18:56, Lukas Sukdol escreveu: > Hello, > I can't get working USB DVR Box (4 video channels / 2 audio) with the > EM2860 chip. > The USB device is recognized, but it doesn't work with any of 77 cards > in the list... > I'm using Fedora 14 (2.6.35.14-96.fc14.i686). > > See details in a

[PATCH v4] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Guennadi Liakhovetski
Currently only very few drivers actually use video_device nodes, embedded in struct v4l2_subdev. Allocate these nodes dynamically for those drivers to save memory for the rest. Signed-off-by: Guennadi Liakhovetski --- v4: 1. added "static" in v4l2_device_release_subdev_node() definition 2. remo

soc-camera: future directions

2011-09-13 Thread Guennadi Liakhovetski
Hi all (a slightly more complete version of this post with some background information is available at http://www.open-technology.de/index.php?/archives/80-soc-camera-3.2-and-beyond-roadmap.html ) As you all are certainly aware, the soc-camera framework in its present state, as published at h

Re: [RFC] New class for low level sensors controls?

2011-09-13 Thread Guennadi Liakhovetski
On Tue, 13 Sep 2011, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 08 September 2011 14:35:54 Guennadi Liakhovetski wrote: > > On Tue, 6 Sep 2011, Sakari Ailus wrote: > > > On Tue, Sep 06, 2011 at 01:41:11PM +0200, Laurent Pinchart wrote: > > > > On Tuesday 06 September 2011 13:36:53 Sak

Re: [PATCH v3] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Guennadi Liakhovetski
On Tue, 13 Sep 2011, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 13 September 2011 11:26:23 Guennadi Liakhovetski wrote: > > On Tue, 13 Sep 2011, Laurent Pinchart wrote: > > > On Monday 12 September 2011 12:55:46 Guennadi Liakhovetski wrote: > > > > Currently only very few drivers actua

Re: omap3isp as a wakeup source

2011-09-13 Thread Enrico
On Tue, Sep 13, 2011 at 12:29 PM, Tero Kristo wrote: > Powerdomain is automatically on if there are any clocks enabled on it. > If you make sure that ISP has some activity ongoing, then it should be > on. You can check the state of the camera powerdomain > from /sys/kernel/debug/pm_debug/count fil

Re: [RFC] New class for low level sensors controls?

2011-09-13 Thread Laurent Pinchart
Hi Sakari, On Tuesday 13 September 2011 14:00:36 Sakari Ailus wrote: > On Tue, Sep 13, 2011 at 12:33:58PM +0200, Laurent Pinchart wrote: > > On Thursday 08 September 2011 13:44:28 Sakari Ailus wrote: > > > On Thu, Sep 08, 2011 at 04:54:23PM +0530, Subash Patel wrote: > > > > On 09/06/2011 05:52 PM

Re: [RFC] New class for low level sensors controls?

2011-09-13 Thread Sakari Ailus
On Tue, Sep 13, 2011 at 12:33:58PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday 08 September 2011 13:44:28 Sakari Ailus wrote: > > On Thu, Sep 08, 2011 at 04:54:23PM +0530, Subash Patel wrote: > > > On 09/06/2011 05:52 PM, Sakari Ailus wrote: > > > > On Tue, Sep 06, 2011 at 01:41:11

Re: omap3isp as a wakeup source

2011-09-13 Thread Sakari Ailus
On Tue, Sep 13, 2011 at 12:28:12PM +0200, Enrico wrote: > On Tue, Sep 13, 2011 at 11:48 AM, Tero Kristo wrote: > > On Tue, 2011-09-13 at 08:49 +0200, Sakari Ailus wrote: > >> anish singh wrote: > >> > On Tue, Sep 13, 2011 at 1:58 AM, Sakari Ailus > >> > wrote: > >> >> On Mon, Sep 12, 2011 at 04:

[PATCH 2/2] drivers/media/video/stk-webcam.c: coding style issue

2011-09-13 Thread Arvydas Sidorenko
checkpatch.pl gave some coding style errors, so on the way to the first patch I added the fix to them. Signed-off-by: Arvydas Sidorenko --- drivers/media/video/stk-webcam.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/media/video/stk-webcam.c

[PATCH 1/2] drivers/media/video/stk-webcam.c: webcam LED bug fix

2011-09-13 Thread Arvydas Sidorenko
The probem was on my DC-1125 webcam chip from Syntek. Whenever the webcam turns on, the LED light on it is turn on also and never turns off again unless system is shut downed or restarted. This patch will fix this issue - the LED will be turned off whenever the device is released. Signed-off-by:

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Guennadi Liakhovetski
On Tue, 13 Sep 2011, Scott Jiang wrote: > >> + > >> +struct bcap_format { > >> +     u8 *desc; > >> +     u32 pixelformat; > >> +     enum v4l2_mbus_pixelcode mbus_code; > >> +     int bpp; /* bytes per pixel */ > > > > Don't you think you might have to process 12 bpp formats at some point, > > li

Re: Questions regarding Devices/Subdevices/MediaController usage in case of a SoC

2011-09-13 Thread Laurent Pinchart
Hi Alain, On Tuesday 13 September 2011 11:07:02 Alain VOLMAT wrote: > Hi Sakari, Hi Laurent, > > Thanks for your replies. Sorry for taking so much time. > > I don't have perfect graphs to explain our device but the following links > helps a little. Device as this one are targeted: > http://ww

Re: [RFC] Reserved fields in v4l2_mbus_framefmt, v4l2_subdev_format alignment

2011-09-13 Thread Laurent Pinchart
Hi Sylwester, On Friday 09 September 2011 19:37:55 Sylwester Nawrocki wrote: > On 09/08/2011 12:21 PM, Laurent Pinchart wrote: > > On Tuesday 06 September 2011 23:07:43 Sakari Ailus wrote: > >> On Tue, Sep 06, 2011 at 09:10:17PM +0200, Sylwester Nawrocki wrote: > >>> On 09/05/2011 05:55 PM, Sakari

Re: [RFC] New class for low level sensors controls?

2011-09-13 Thread Laurent Pinchart
Hi Sakari, On Thursday 08 September 2011 13:44:28 Sakari Ailus wrote: > On Thu, Sep 08, 2011 at 04:54:23PM +0530, Subash Patel wrote: > > On 09/06/2011 05:52 PM, Sakari Ailus wrote: > > > On Tue, Sep 06, 2011 at 01:41:11PM +0200, Laurent Pinchart wrote: > > > > > > > > Other controls often found i

Re: [RFC] New class for low level sensors controls?

2011-09-13 Thread Laurent Pinchart
Hi Guennadi, On Thursday 08 September 2011 14:35:54 Guennadi Liakhovetski wrote: > On Tue, 6 Sep 2011, Sakari Ailus wrote: > > On Tue, Sep 06, 2011 at 01:41:11PM +0200, Laurent Pinchart wrote: > > > On Tuesday 06 September 2011 13:36:53 Sakari Ailus wrote: [snip] > > > > Typically such sensors a

Re: omap3isp as a wakeup source

2011-09-13 Thread Tero Kristo
On Tue, 2011-09-13 at 12:08 +0200, Enrico wrote: > On Tue, Sep 13, 2011 at 11:48 AM, Tero Kristo wrote: > > On Tue, 2011-09-13 at 08:49 +0200, Sakari Ailus wrote: > >> anish singh wrote: > >> > On Tue, Sep 13, 2011 at 1:58 AM, Sakari Ailus > >> > wrote: > >> >> On Mon, Sep 12, 2011 at 04:50:42PM

Re: omap3isp as a wakeup source

2011-09-13 Thread Enrico
On Tue, Sep 13, 2011 at 11:48 AM, Tero Kristo wrote: > On Tue, 2011-09-13 at 08:49 +0200, Sakari Ailus wrote: >> anish singh wrote: >> > On Tue, Sep 13, 2011 at 1:58 AM, Sakari Ailus wrote: >> >> On Mon, Sep 12, 2011 at 04:50:42PM +0200, Enrico wrote: >> >>> Hi, >> >> >> >> Hi Enrico, >> >> >> >>

Re: omap3isp as a wakeup source

2011-09-13 Thread Enrico
On Tue, Sep 13, 2011 at 11:48 AM, Tero Kristo wrote: > On Tue, 2011-09-13 at 08:49 +0200, Sakari Ailus wrote: >> anish singh wrote: >> > On Tue, Sep 13, 2011 at 1:58 AM, Sakari Ailus wrote: >> >> On Mon, Sep 12, 2011 at 04:50:42PM +0200, Enrico wrote: >> >>> Hi, >> >> >> >> Hi Enrico, >> >> >> >>

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Scott Jiang
>> + >> +struct bcap_format { >> +     u8 *desc; >> +     u32 pixelformat; >> +     enum v4l2_mbus_pixelcode mbus_code; >> +     int bpp; /* bytes per pixel */ > > Don't you think you might have to process 12 bpp formats at some point, > like YUV 4:2:0, or NV12? Maybe better calculate in bits from

Re: omap3isp as a wakeup source

2011-09-13 Thread Tero Kristo
On Tue, 2011-09-13 at 08:49 +0200, Sakari Ailus wrote: > anish singh wrote: > > On Tue, Sep 13, 2011 at 1:58 AM, Sakari Ailus wrote: > >> On Mon, Sep 12, 2011 at 04:50:42PM +0200, Enrico wrote: > >>> Hi, > >> > >> Hi Enrico, > >> > >>> While testing omap3isp+tvp5150 with latest Deepthy bt656 patch

Re: [PATCH v3] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 13 September 2011 11:26:23 Guennadi Liakhovetski wrote: > On Tue, 13 Sep 2011, Laurent Pinchart wrote: > > On Monday 12 September 2011 12:55:46 Guennadi Liakhovetski wrote: > > > Currently only very few drivers actually use video_device nodes, > > > embedded in struct v4l2_

Re: [PATCH v3] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Guennadi Liakhovetski
On Tue, 13 Sep 2011, Laurent Pinchart wrote: > Hi Guennadi, > > On Monday 12 September 2011 12:55:46 Guennadi Liakhovetski wrote: > > Currently only very few drivers actually use video_device nodes, embedded > > in struct v4l2_subdev. Allocate these nodes dynamically for those drivers > > to save

Re: [PATCH v3] V4L: dynamically allocate video_device nodes in subdevices

2011-09-13 Thread Laurent Pinchart
Hi Guennadi, On Monday 12 September 2011 12:55:46 Guennadi Liakhovetski wrote: > Currently only very few drivers actually use video_device nodes, embedded > in struct v4l2_subdev. Allocate these nodes dynamically for those drivers > to save memory for the rest. > > Signed-off-by: Guennadi Liakhov

Re: omap3isp as a wakeup source

2011-09-13 Thread Laurent Pinchart
Hi Enrico, On Monday 12 September 2011 16:50:42 Enrico wrote: > > While testing omap3isp+tvp5150 with latest Deepthy bt656 patches > (kernel 3.1rc4) i noticed that yavta hangs very often when grabbing > or, if not hanged, it grabs at max ~10fps. > > Then i noticed that tapping on the (serial) co

RE: Questions regarding Devices/Subdevices/MediaController usage in case of a SoC

2011-09-13 Thread Alain VOLMAT
Hi Sakari, Hi Laurent, Thanks for your replies. Sorry for taking so much time. I don't have perfect graphs to explain our device but the following links helps a little. Device as this one are targeted: http://www.st.com/internet/imag_video/product/251021.jsp Corresponding circuit diagram:

Re: [PATCH] uvcvideo: Fix crash when linking entities

2011-09-13 Thread Laurent Pinchart
Hi Jonathan, On Monday 12 September 2011 19:22:33 Jonathan Nieder wrote: > Laurent Pinchart wrote: > > I've just sent a pull request to Mauro. > > Thanks! Looks good to me, for what little that's worth. My only nits > are that in the future it might be nice to "Cc: stable" and credit > testers

Re: [PATCH 1/4] v4l2: add vb2_get_unmapped_area in vb2 core

2011-09-13 Thread Scott Jiang
> > Hm, wouldn't it be better to use vb2_mmap() and provide a dummy .mmap() > method in videobuf2-dma-contig.c for the NOMMU case? > these are two different file operations called by mm system. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to maj

Re: [PATCH 3/4] v4l2: add vs6624 sensor driver

2011-09-13 Thread Guennadi Liakhovetski
On Tue, 13 Sep 2011, Scott Jiang wrote: > >> +#define VGA_WIDTH       640 > >> +#define VGA_HEIGHT      480 > >> +#define QVGA_WIDTH      320 > >> +#define QVGA_HEIGHT     240 > >> +#define QQVGA_WIDTH     160 > >> +#define QQVGA_HEIGHT    120 > >> +#define CIF_WIDTH       352 > >> +#define CIF_HE

Re: [PATCH 3/4] v4l2: add vs6624 sensor driver

2011-09-13 Thread Scott Jiang
>> +#define VGA_WIDTH       640 >> +#define VGA_HEIGHT      480 >> +#define QVGA_WIDTH      320 >> +#define QVGA_HEIGHT     240 >> +#define QQVGA_WIDTH     160 >> +#define QQVGA_HEIGHT    120 >> +#define CIF_WIDTH       352 >> +#define CIF_HEIGHT      288 >> +#define QCIF_WIDTH      176 >> +#define

Re: [PATCH 1/4] v4l2: add vb2_get_unmapped_area in vb2 core

2011-09-13 Thread Guennadi Liakhovetski
On Tue, 13 Sep 2011, Scott Jiang wrote: > no mmu system needs get_unmapped_area file operations to do mmap > > Signed-off-by: Scott Jiang > --- > drivers/media/video/videobuf2-core.c | 31 +++ > include/media/videobuf2-core.h |7 +++ > 2 files changed

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Guennadi Liakhovetski
Again, no complete review, just a couple of remarks On Tue, 13 Sep 2011, Scott Jiang wrote: > this is a v4l2 bridge driver for Blackfin video capture device, > support ppi interface > > Signed-off-by: Scott Jiang > --- [snip] > diff --git a/drivers/media/video/blackfin/bfin_capture.c > b/dri

Re: [PATCH 3/4] v4l2: add vs6624 sensor driver

2011-09-13 Thread Guennadi Liakhovetski
Hi Scott Thanks for the patch. I am not doing a full review, just a couple of notes: On Tue, 13 Sep 2011, Scott Jiang wrote: > this is a v4l2 sensor-level driver for the ST VS6624 camera > > Signed-off-by: Scott Jiang > --- [snip] > diff --git a/drivers/media/video/vs6624.c b/drivers/media/v

RE: [PATCH 1/8] omap3evm: Enable regulators for camera interface

2011-09-13 Thread Ravi, Deepthy
Hi, > > From: Laurent Pinchart [laurent.pinch...@ideasonboard.com] > Sent: Thursday, September 08, 2011 10:21 PM > To: Ravi, Deepthy > Cc: linux-o...@vger.kernel.org; t...@atomide.com; li...@arm.linux.org.uk; > linux-arm-ker...@lists.infradead.org; linux-ke