RE: [PATCH 2/2] v4l: simulate old crop API using extended crop/compose API

2011-05-08 Thread Jonghun Han
Hi Tomasz Stanislawski, On Thursday, May 05, 2011 6:40 PM Tomasz Stanislawski wrote: > This patch allows new drivers to work correctly with applications that use > old-style crop API. > The old crop ioctl is simulated by using selection ioctls. > > Signed-off-by: Tomasz Stanislawski > --- > dr

Re: [PATCH 2/8] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-05-08 Thread Mauro Carvalho Chehab
Em 09-05-2011 05:58, Mauro Carvalho Chehab escreveu: > Em 09-05-2011 01:03, Andreas Oberritter escreveu: >> - Use const pointers and remove assignments. > > That's OK. > >> - delivery_system already gets assigned by DTV_DELIVERY_SYSTEM >> and dtv_property_cache_sync. > > The logic for those le

Re: [PATCH 2/8] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-05-08 Thread Mauro Carvalho Chehab
Em 09-05-2011 01:03, Andreas Oberritter escreveu: > - Use const pointers and remove assignments. That's OK. > - delivery_system already gets assigned by DTV_DELIVERY_SYSTEM > and dtv_property_cache_sync. The logic for those legacy params is too complex. It is easy that a latter patch to break

Re: [PATCH 0/6] DVB-T2 API updates, documentation and accompanying small fixes

2011-05-08 Thread Mauro Carvalho Chehab
Em 08-05-2011 19:26, Andreas Oberritter escreveu: > On 05/08/2011 07:17 PM, Steve Kerrison wrote: >> Quick question about resubmission: >> >> Do I resubmit all 6 (5 after fold) patches as v2, or can I ignore what >> is currently patch 5 as it is uncommented? I don't know enough about >> patchwork t

Re: DVB nGene CI : TS Discontinuities issues

2011-05-08 Thread Issa Gorissen
On 07/05/11 23:34, Ralph Metzler wrote: > I do not have any cxd2099 issues. > I have a simple test program which includes a 32bit counter as payload > and can pump data through the CI with full speed and have no packet > loss. I only tested decoding with an ORF stream and an Alphacrypt CAM > but a

Re: [PATCH] Ngene cam device name

2011-05-08 Thread Martin Vidovic
Hi Andreas, Andreas Oberritter wrote: Hello Martin, Binding to bus id is not a problem. However, especially for USB devices, it may be useful to have adapter MAC address in sysfs. a DVB adapter isn't required to have a unique MAC address, but we could add this attribute to sysfs, if present

http://linuxtv.org/hg/dvb-apps/file/5e68946b0e0d/util/scan/atsc/us-Cable-Standard-center-frequencies-QAM256

2011-05-08 Thread Cotie Jones
# US EIA/NCTA Standard Cable center frequencies, added missing muxes # Channels are in ascending EIA/NCTA channel designation order #2 A 5700 QAM256 A 6300 QAM256 A 6900 QAM256 A 7900 QAM256 A 8500 QAM256 A 17700 QAM256 A 18300 QAM256 A 18900 QAM256 #10 A 19500

[PATCH 2/8] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-05-08 Thread Andreas Oberritter
- Use const pointers and remove assignments. - delivery_system already gets assigned by DTV_DELIVERY_SYSTEM and dtv_property_cache_sync. Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff

[PATCH 8/8] DVB: allow to read back of detected parameters through S2API

2011-05-08 Thread Andreas Oberritter
Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index b41e5dc..a0f0458 100644 --- a/dr

[PATCH 1/8] DVB: return meaningful error codes in dvb_frontend

2011-05-08 Thread Andreas Oberritter
- Return values should not be ORed. Abort early instead. - Return -EINVAL instead of -1. Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/media/dvb/dvb-cor

[PATCH 6/8] DVB: dvb_frontend: use shortcut to access fe->dtv_property_cache

2011-05-08 Thread Andreas Oberritter
Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c | 211 +++-- 1 files changed, 108 insertions(+), 103 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index 9775cdc..d4485c8 10

[PATCH 4/8] DVB: dvb_frontend: rename parameters to parameters_in

2011-05-08 Thread Andreas Oberritter
- Preparation to distinguish input parameters from output parameters. Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c | 60 ++-- 1 files changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b

[PATCH 7/8] DVB: dvb_frontend: add parameters_out

2011-05-08 Thread Andreas Oberritter
- Holds the parameters detected by the demod. - Updated on every call to get_frontend, either through ioctl or when a frontend event occurs. - Reset to input parameters after every call to set_frontend, tune or search/track. Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dv

[PATCH 3/8] DVB: call get_property at the end of dtv_property_process_get

2011-05-08 Thread Andreas Oberritter
- Drivers should be able to override properties returned to the user. - The default values get prefilled from the cache. Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 0/8] dvb_frontend cleanup, S2API regression fix

2011-05-08 Thread Andreas Oberritter
Here are some patches to clean up some dvb_frontend code and to allow reading back detected tuning parameters through S2API. The patches have only been compile-tested for now. Feedback would be appreciated, to minimize the risk of new regressions. They apply on top of two of the DVB-T2 patches pr

[PATCH 5/8] DVB: dvb_frontend: remove unused assignments

2011-05-08 Thread Andreas Oberritter
Signed-off-by: Andreas Oberritter --- drivers/media/dvb/dvb-core/dvb_frontend.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index aca8457..9775cdc 100644 --- a/drivers/media/dvb/dv

Re: [PATCH v2 1/5] DVB: Add basic API support for DVB-T2 and bump minor version

2011-05-08 Thread Andreas Oberritter
On 05/09/2011 12:22 AM, Andreas Oberritter wrote: > > Please also include the following (only compile-tested) lines within this > commit: > > From 4329b836a6590421b178710160fcca3b39f64e18 Mon Sep 17 00:00:00 2001 > From: Andreas Oberritter > Date: Sun, 8 May 2011 22:14:07 + > Subject: [PATC

Re: [PATCH 0/6] DVB-T2 API updates, documentation and accompanying small fixes

2011-05-08 Thread Andreas Oberritter
On 05/08/2011 07:17 PM, Steve Kerrison wrote: > Quick question about resubmission: > > Do I resubmit all 6 (5 after fold) patches as v2, or can I ignore what > is currently patch 5 as it is uncommented? I don't know enough about > patchwork to know whether changing the PATCH x/n will break things

Re: [PATCH v2 1/5] DVB: Add basic API support for DVB-T2 and bump minor version

2011-05-08 Thread Andreas Oberritter
On 05/08/2011 09:17 PM, Steve Kerrison wrote: > From: Andreas Oberritter > > st...@stevekerrison.com: Remove private definitions from cxd2820r that > existed before API was defined > > Signed-off-by: Andreas Oberritter > Signed-off-by: Steve Kerrison > --- > drivers/media/dvb/dvb-core/dvb_fr

Re: [PATCH v2 3/5] mxl5005: Fix warning caused by new entries in an enum

2011-05-08 Thread Andreas Oberritter
On 05/08/2011 09:17 PM, Steve Kerrison wrote: > Additional bandwidth modes have been added in frontend.h > mxl5005s.c had no default case so the compiler was warning about > a non-exhausive switch statement. > > Signed-off-by: Steve Kerrison > --- > drivers/media/common/tuners/mxl5005s.c |4

Re: [PATCH v2 2/5] drxd: Fix warning caused by new entries in an enum

2011-05-08 Thread Andreas Oberritter
On 05/08/2011 09:17 PM, Steve Kerrison wrote: > Additional bandwidth modes have been added in frontend.h > drxd_hard.c had no default case so the compiler was warning about > a non-exhausive switch statement. > > This has been fixed by making the default behaviour the same as > BANDWIDTH_AUTO, wit

Re: [RFC v4] V4L2 API for flash devices

2011-05-08 Thread Sakari Ailus
Sylwester Nawrocki wrote: > Hi Hans, Hi Sylwester, Hans, > On 05/07/2011 02:46 PM, Hans Verkuil wrote: >> On Thursday, May 05, 2011 20:49:21 Sakari Ailus wrote: >>> Hi, >>> >>> This is a fourth proposal for an interface for controlling flash devices >>> on the V4L2/v4l2_subdev APIs. >>> >>> I wan

Re: [PATCH 6/6] Documentation: Update to include DVB-T2 additions

2011-05-08 Thread Andreas Oberritter
On 05/08/2011 09:13 PM, Steve Kerrison wrote: > Hi Mauro > >> +3) DVB-T specifies 2K and 8K as valid sizes. >>> + 4) DVB-T2 specifies 1K, 2K, 4K, 8K, 16K and 32K. >> >> It makes sense to add here that ISDB-T specifies 2K, 4K and 8K. >> (yeah, sorry, it is my fault that I didn

Re: [RFC v4] V4L2 API for flash devices

2011-05-08 Thread Sakari Ailus
Hans Verkuil wrote: [clip] >> V4L2_CID_FLASH_STROBE (button; wo; LED, xenon) >> >> Strobe the flash using software strobe from the host, typically over I2C >> or a GPIO. The flash is NOT synchronised to sensor pixel are exposure >> since the command is given asynchronously. Alternatively, if t

[PATCH v2 5/5] Documentation: Update to include DVB-T2 additions

2011-05-08 Thread Steve Kerrison
A few new capabilities added to frontend.h for DVB-T2. Added these to the documentation plus some notes explaining that they are used by the T2 delivery system. Signed-off-by: Steve Kerrison --- Documentation/DocBook/dvb/dvbproperty.xml | 36 ++-- Documentation/DocBook/

[PATCH v2 4/5] cxd2820r: Update frontend capabilities to advertise QAM-256

2011-05-08 Thread Steve Kerrison
This is supported in DVB-T2 mode, so added to the T/T2 frontend. Signed-off-by: Steve Kerrison --- drivers/media/dvb/frontends/cxd2820r_core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/frontends/cxd2820r_core.c b/drivers/media/dvb/frontends/cxd

[PATCH v2 3/5] mxl5005: Fix warning caused by new entries in an enum

2011-05-08 Thread Steve Kerrison
Additional bandwidth modes have been added in frontend.h mxl5005s.c had no default case so the compiler was warning about a non-exhausive switch statement. Signed-off-by: Steve Kerrison --- drivers/media/common/tuners/mxl5005s.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH v2 2/5] drxd: Fix warning caused by new entries in an enum

2011-05-08 Thread Steve Kerrison
Additional bandwidth modes have been added in frontend.h drxd_hard.c had no default case so the compiler was warning about a non-exhausive switch statement. This has been fixed by making the default behaviour the same as BANDWIDTH_AUTO, with the addition of a printk to notify if this ever happens.

[PATCH v2 0/5] DVB-T2 API updates, documentation and accompanying small fixes

2011-05-08 Thread Steve Kerrison
Good evening all, This is the second version of my patch set for DVB-T2 and PCTV nanoStick T2 290e support. Changes to cxd2820r_priv.h have been rolled into patch 1 as requested by Mauro. I hope I have done this in an appropriate way. I have updated my drxd and mxl5005 patches to include a comme

[PATCH v2 1/5] DVB: Add basic API support for DVB-T2 and bump minor version

2011-05-08 Thread Steve Kerrison
From: Andreas Oberritter st...@stevekerrison.com: Remove private definitions from cxd2820r that existed before API was defined Signed-off-by: Andreas Oberritter Signed-off-by: Steve Kerrison --- drivers/media/dvb/dvb-core/dvb_frontend.c |7 +++ drivers/media/dvb/frontends/cxd2820r_

Re: [PATCH 6/6] Documentation: Update to include DVB-T2 additions

2011-05-08 Thread Steve Kerrison
Hi Mauro > + 3) DVB-T specifies 2K and 8K as valid sizes. > > + 4) DVB-T2 specifies 1K, 2K, 4K, 8K, 16K and 32K. > > It makes sense to add here that ISDB-T specifies 2K, 4K and 8K. > (yeah, sorry, it is my fault that I didn't notice it before ;) ) Actually note 1) in that l

[cron job] v4l-dvb daily build: ERRORS

2011-05-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Sun May 8 19:00:30 CEST 2011 git hash:966825c2a416a7ca3950e35e60fa8720f1251e37 gcc version: i686-linux-gcc (GCC) 4.5

Re: [PATCH] Ngene cam device name

2011-05-08 Thread Andreas Oberritter
Hello Martin, On 05/08/2011 12:05 PM, Martin Vidovic wrote: > Andreas Oberritter wrote: >> On 05/05/2011 04:43 PM, Martin Vidovic wrote: >>> >>> a) Plug two TerraTec Cinergy T RC MKII and try to distinguish between >>> them. >> >> I don't have any USB or PCI hardware within reach, but if udev is a

Re: DVB nGene CI : TS Discontinuities issues

2011-05-08 Thread Issa Gorissen
On 07/05/11 23:34, Ralph Metzler wrote: > Before blaming packet loss on the CI data path also please make > certain that you have no buffer overflows in the input part of > the sec device. > In the ngene driver you can e.g. add a printk in tsin_exchange(): > > if (dvb_ringbuffer_free(&dev->tsin_rb

Re: [PATCH] Various modifications to MB86A20S driver

2011-05-08 Thread Mauro Carvalho Chehab
Em 07-05-2011 04:22, Manoel PN escreveu: > Hi everyone, > > I made several modifications on the driver for the MB86A20S demodulator and > would like to receive comments regarding the modifications. > > The modifications were necessary to allow the use of other drivers, as what > I'm finishing f

Re: [PATCH 6/6] Documentation: Update to include DVB-T2 additions

2011-05-08 Thread Mauro Carvalho Chehab
Em 08-05-2011 12:51, Steve Kerrison escreveu: > A few new capabilities added to frontend.h for DVB-T2. Added these > to the documentation plus some notes explaining that they are > used by the T2 delivery system. > > Signed-off-by: Steve Kerrison > --- > Documentation/DocBook/dvb/dvbproperty.xml

Re: [PATCH 2/6] cxd2820r: Remove temporary T2 API hack

2011-05-08 Thread Mauro Carvalho Chehab
Em 08-05-2011 12:51, Steve Kerrison escreveu: > Unimplemented delivery system and modes were #define'd to > arbitrary values for internal use. API now includes these values > so we can remove this hack. > > Signed-off-by: Steve Kerrison > --- > drivers/media/dvb/frontends/cxd2820r_priv.h | 12

Re: [PATCH 0/6] DVB-T2 API updates, documentation and accompanying small fixes

2011-05-08 Thread Mauro Carvalho Chehab
Em 08-05-2011 12:51, Steve Kerrison escreveu: > Hi Mauro, Antti, Andreas, > > I hope this patch set is formed appropriately - it is my first patch > submission direct to the linux-media group. They look sane on my eyes. I'll comment patch by patch were needed. Non-commented patches mean that the

Re: gspca_zc3xx (HV7131R sensor) driver brocken

2011-05-08 Thread Jean-Francois Moine
On Sun, 8 May 2011 13:37:52 +0200 "Roman B." wrote: > since the upgrade of the kernel to 2.6.37.1 my webcamera (046d:08d7 > Logitech, Inc. QuickCam Communicate STX) is brocken. The problem is > exactly the same as in this bug report: > https://bugzilla.kernel.org/show_bug.cgi?id=24242 The problem

[PATCH 2/6] cxd2820r: Remove temporary T2 API hack

2011-05-08 Thread Steve Kerrison
Unimplemented delivery system and modes were #define'd to arbitrary values for internal use. API now includes these values so we can remove this hack. Signed-off-by: Steve Kerrison --- drivers/media/dvb/frontends/cxd2820r_priv.h | 12 1 files changed, 0 insertions(+), 12 deletions

[PATCH 4/6] mxl5005: Fix warning caused by new entries in an enum

2011-05-08 Thread Steve Kerrison
Additional bandwidth modes have been added in frontend.h mxl5005s.c had no default case so the compiler was warning about a non-exhausive switch statement. Signed-off-by: Steve Kerrison --- drivers/media/common/tuners/mxl5005s.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

[PATCH 6/6] Documentation: Update to include DVB-T2 additions

2011-05-08 Thread Steve Kerrison
A few new capabilities added to frontend.h for DVB-T2. Added these to the documentation plus some notes explaining that they are used by the T2 delivery system. Signed-off-by: Steve Kerrison --- Documentation/DocBook/dvb/dvbproperty.xml | 21 ++--- Documentation/DocBook/dvb/fro

[PATCH 3/6] drxd: Fix warning caused by new entries in an enum

2011-05-08 Thread Steve Kerrison
Additional bandwidth modes have been added in frontend.h drxd_hard.c had no default case so the compiler was warning about a non-exhausive switch statement. This has been fixed by making the default behaviour the same as BANDWIDTH_AUTO, with the addition of a printk to notify if this ever happens.

[PATCH 1/6] DVB: Add basic API support for DVB-T2 and bump minor version

2011-05-08 Thread Steve Kerrison
From: Andreas Oberritter Signed-off-by: Andreas Oberritter Signed-off-by: Steve Kerrison --- drivers/media/dvb/dvb-core/dvb_frontend.c |7 +++ include/linux/dvb/frontend.h | 20 include/linux/dvb/version.h |2 +- 3 files changed, 20

[PATCH 5/6] cxd2820r: Update frontend capabilities to advertise QAM-256

2011-05-08 Thread Steve Kerrison
This is supported in DVB-T2 mode, so added to the T/T2 frontend. Signed-off-by: Steve Kerrison --- drivers/media/dvb/frontends/cxd2820r_core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/frontends/cxd2820r_core.c b/drivers/media/dvb/frontends/cxd

[PATCH 0/6] DVB-T2 API updates, documentation and accompanying small fixes

2011-05-08 Thread Steve Kerrison
Hi Mauro, Antti, Andreas, I hope this patch set is formed appropriately - it is my first patch submission direct to the linux-media group. Following the pull of Antti's work on support for the cxd2820r and PCTV nanoStick T2 290e, this patch set implements Andreas' modifications to the API to give

tm6000: video buffer

2011-05-08 Thread Stefan Ringel
Hi Mauro, I have a few little problems. 1. How I can set up buffer field? - Alternate - Top - Bottom etc. 2. How I can add time code to buffer? PTS packet send an 32 bit long frame number, that count edge half frame. 3. How I can set up aspect ratio? - 4:3 - 16:9 incl.

gspca_zc3xx (HV7131R sensor) driver brocken

2011-05-08 Thread Roman B.
Dear list, dear Jean-Francois, since the upgrade of the kernel to 2.6.37.1 my webcamera (046d:08d7 Logitech, Inc. QuickCam Communicate STX) is brocken. The problem is exactly the same as in this bug report: https://bugzilla.kernel.org/show_bug.cgi?id=24242 The problem of contrast seems to dissapea

Re: [PATCH] Ngene cam device name

2011-05-08 Thread Issa Gorissen
On 08/05/11 11:53, Andreas Oberritter wrote: > Hello Issa, > > On 05/06/2011 08:29 PM, Issa Gorissen wrote: >> From: Andreas Oberritter >>> On 05/06/2011 03:47 PM, Issa Gorissen wrote: Also, it seems linux en50221 stack provides for the slot selection. So, >> why would you need two ca no

Re: [libv4l] [PATCH] Webcam image upside down on Asus Eee PC T101MT (13d3:5122)

2011-05-08 Thread Hans de Goede
Hi, Thanks, applied. Regards, Hans On 05/06/2011 08:04 AM, Stefan Löffler wrote: The caption pretty much says it all. Owing to different IDs, the flags for similar Asus products don't cut in. Originally reported for Ubuntu at https://bugs.launchpad.net/ubuntu/+source/libv4l/+bug/774123. Reg

Re: [PATCH] Ngene cam device name

2011-05-08 Thread Martin Vidovic
Andreas Oberritter wrote: On 05/05/2011 04:43 PM, Martin Vidovic wrote: a) Plug two TerraTec Cinergy T RC MKII and try to distinguish between them. I don't have any USB or PCI hardware within reach, but if udev is able to create the devices, there should be some way to connect adapters to the

Re: [linux-dvb] Pinnacle PCTV Dual DVB-T Pro PCI 2000i

2011-05-08 Thread Hans-Frieder Vogt
Am Samstag, 9. April 2011 schrieb Devin Heitmueller: > On Fri, Apr 8, 2011 at 5:35 AM, pigeonskil...@libero.it > > wrote: > > Pinnacle PCTV Dual DVB-T Pro PCI 2000i > > (http://linuxtv.org/wiki/index.php/DVB- T_PCI_Cards#Pinnacle) was > > introduced in 2006 and after 5 years it is still unsupport

Re: [PATCH] Ngene cam device name

2011-05-08 Thread Andreas Oberritter
Hello Issa, On 05/06/2011 08:29 PM, Issa Gorissen wrote: > From: Andreas Oberritter >> On 05/06/2011 03:47 PM, Issa Gorissen wrote: >>> Also, it seems linux en50221 stack provides for the slot selection. So, > why >>> would you need two ca nodes ? >> >> Because it's the most obvious way to use it

Re: [linux-dvb] TeVii S470 (cx23885 / ds3000) makes the machine unstable

2011-05-08 Thread Andrew Junev
Hi, Friday, May 6, 2011, 1:58:22 AM, you wrote: > I have 2.6.32-5-686 kernel and I have this output on dmesg: > [ 11.459771] cx23885 driver version 0.0.2 loaded > [ 11.460894] ACPI: PCI Interrupt Link [LN4A] enabled at IRQ 19 > [ 11.460914] cx23885 :05:00.0: PCI INT A -> Link[LN4A] ->