Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Hans Verkuil
On Wednesday, November 17, 2010 08:16:27 Figo.zhang wrote: > On 11/17/2010 03:11 PM, Hans Verkuil wrote: > > On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: > diff --git a/drivers/media/video/videobuf-dma-contig.c > >>> b/drivers/media/video/videobuf-dma-contig.c > index c9691

Re: An article on the media controller

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 23:18:02 Jonathan Corbet wrote: > I've just spent a fair while looking through the September posting of > the media controller code (is there a more recent version?). The > result is a high-level review which interested people can read here: > > http://lwn.net/

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Figo.zhang
On 11/17/2010 03:11 PM, Hans Verkuil wrote: On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: diff --git a/drivers/media/video/videobuf-dma-contig.c b/drivers/media/video/videobuf-dma-contig.c index c969111..f7e0f86 100644 --- a/drivers/media/video/videobuf-dma-contig.c +++ b/drivers

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 21:24:43 ac...@nvidia.com wrote: > From: Andrew Chew > > There are two struct list_head's in struct videobuf_buffer. > Prior to this fix, all we did for initialization of struct videobuf_buffer > was to zero out its memory. This does not properly initialize this str

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Hans Verkuil
On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: > > > diff --git a/drivers/media/video/videobuf-dma-contig.c > > b/drivers/media/video/videobuf-dma-contig.c > > > index c969111..f7e0f86 100644 > > > --- a/drivers/media/video/videobuf-dma-contig.c > > > +++ b/drivers/media/video/videobu

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-11-16 Thread Guennadi Liakhovetski
On Wed, 10 Nov 2010, Baruch Siach wrote: > Guennadi Liakhovetski gmx.de> writes: > > > On Wed, 27 Oct 2010, Baruch Siach wrote: > > > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, > > > otherwise we get > > > the inverted behaviour. > > Seems logical to me, that if this is true

[patch 3/3] [media] lirc_dev: fixes in lirc_dev_fop_read()

2010-11-16 Thread Dan Carpenter
This makes several changes but they're in one function and sort of related: "buf" was leaked on error. The leak if we try to read an invalid length is the main concern because it could be triggered over and over. If the copy_to_user() failed, then the original code returned the number of bytes

[patch 2/3] [media] lirc_dev: add some __user annotations

2010-11-16 Thread Dan Carpenter
Sparse complains because there are no __user annotations. drivers/media/IR/lirc_dev.c:156:27: warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) drivers/media/IR/lirc_dev.c:156:27:expected int ( *read )( ... ) drivers/media/IR/lirc_dev.c:156:27

[patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll()

2010-11-16 Thread Dan Carpenter
We shouldn't unlock here. I think this was a cut and paste error. Signed-off-by: Dan Carpenter diff --git a/drivers/media/IR/lirc_dev.c b/drivers/media/IR/lirc_dev.c index 8418b14..8ab9d87 100644 --- a/drivers/media/IR/lirc_dev.c +++ b/drivers/media/IR/lirc_dev.c @@ -522,10 +522,8 @@ unsigned i

Re: [GIT PATCHES FOR 2.6.38] mantis for_2.6.38

2010-11-16 Thread Mauro Carvalho Chehab
Hi Bjørn, Em 13-11-2010 12:45, Bjørn Mork escreveu: > Mauro Carvalho Chehab writes: > >> Em 12-11-2010 12:43, Bjørn Mork escreveu: >>> >>> git://git.mork.no/mantis.git for_2.6.38 >> >> Didn't work: >> >> git pull git://git.mork.no/mantis.git for_2.6.38 >> fatal: Couldn't find remote ref for_2.

Re: hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-16 Thread Mauro Carvalho Chehab
Em 14-11-2010 18:48, Manu Abraham escreveu: > Mauro, > > Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/ > > for the following changes. > > > changeset 15168:baa4e8008db5 Mantis, hopper: use MODULE_DEVICE_TABLE > http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/baa4e8008d

Re: [PATCH] drivers/media: nuvoton: always true expression

2010-11-16 Thread Mauro Carvalho Chehab
Em 16-11-2010 19:54, Jarod Wilson escreveu: > On Tue, Nov 16, 2010 at 09:19:53PM +0100, Nicolas Kaiser wrote: >> I noticed that the second part of this conditional is always true. >> Would the intention be to strictly check on both chip_major and >> chip_minor? >> >> Signed-off-by: Nicolas Kaiser

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Figo.zhang
于 11/17/2010 09:38 AM, Andrew Chew 写道: diff --git a/drivers/media/video/videobuf-dma-contig.c b/drivers/media/video/videobuf-dma-contig.c index c969111..f7e0f86 100644 --- a/drivers/media/video/videobuf-dma-contig.c +++ b/drivers/media/video/videobuf-dma-contig.c @@ -193,6 +193,8 @@ static stru

Re: [PATCH v4 2/6] drivers:staging: ti-st: fmdrv_v4l2 sources

2010-11-16 Thread Figo.zhang
于 11/16/2010 09:18 PM, manjunatha_ha...@ti.com 写道: > From: Manjunatha Halli > > This module interfaces V4L2 subsystem and FM common > module. It registers itself with V4L2 as Radio module. > > Signed-off-by: Manjunatha Halli > --- > drivers/staging/ti-st/fmdrv_v4l2.c | 757 > +

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Figo.zhang
> > diff --git a/drivers/media/video/videobuf-dma-contig.c > b/drivers/media/video/videobuf-dma-contig.c > index c969111..f7e0f86 100644 > --- a/drivers/media/video/videobuf-dma-contig.c > +++ b/drivers/media/video/videobuf-dma-contig.c > @@ -193,6 +193,8 @@ static struct videobuf_buffer *__vide

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-16 Thread Jonathan Corbet
Here's the first of my more specific comments - probably the only file I'll get to today... > The media_devnode structure provides support for registering and > unregistering character devices using a dynamic major number. Reference > counting is handled internally, making device drivers easier to

Translation faults with OMAP ISP

2010-11-16 Thread Lane Brooks
Laurent, I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output. If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out: omap-io

media_tree.git weirdness

2010-11-16 Thread David Härdeman
Mauro, the current state of the staging/for_v2.6.38 branch seems a bit weird with regard to the three patches to use raw decoding for the Encore FM 5.3, resulting cleanups to saa7134 and removal of ir-common. I still see drivers/media/rc/ir-functions.c in my local repo (and using the web interfac

Re: [RFC PATCH 0/2] Apple remote support

2010-11-16 Thread David Härdeman
On Tue, Nov 16, 2010 at 10:08:29AM -0200, Mauro Carvalho Chehab wrote: >Em 15-11-2010 02:11, Jarod Wilson escreveu: >> Gives us support for using the full 32-bit codes right now w/o having >> to change any tables yet, but does require a modparam to skip the >> checksum checks, unless its an apple r

Re: An article on the media controller

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 15:18 -0700, Jonathan Corbet wrote: > I've just spent a fair while looking through the September posting of > the media controller code (is there a more recent version?). The > result is a high-level review which interested people can read here: > > http://lwn.net/Subs

Re: [RFCv2 PATCH 15/15] cx18: convert to unlocked_ioctl.

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 22:56 +0100, Hans Verkuil wrote: > Signed-off-by: Hans Verkuil > --- > drivers/media/video/cx18/cx18-streams.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/cx18/cx18-streams.c > b/drivers/media/video/cx18/cx18-streams.c

RE: Question about setting V4L2_CID_AUTO_WHITE_BALANCE control to FALSE

2010-11-16 Thread Shuzhen Wang
Nevermind. I think behavior #1 makes more sense. -Shuzhen -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media-ow...@vger.kernel.org] On Behalf Of Shuzhen Wang Sent: Tuesday, November 16, 2010 11:30 AM To: linux-media@vger.kernel.org Subject: Question about setti

An article on the media controller

2010-11-16 Thread Jonathan Corbet
I've just spent a fair while looking through the September posting of the media controller code (is there a more recent version?). The result is a high-level review which interested people can read here: http://lwn.net/SubscriberLink/415714/1e837f01b8579eb7/ Most people will not see it f

[RFCv2 PATCH 15/15] cx18: convert to unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Signed-off-by: Hans Verkuil --- drivers/media/video/cx18/cx18-streams.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx18/cx18-streams.c b/drivers/media/video/cx18/cx18-streams.c index 9045f1e..ab461e2 100644 --- a/drivers/media/video/cx18/cx18-st

[RFCv2 PATCH 14/15] V4L: improve the BKL replacement heuristic

2010-11-16 Thread Hans Verkuil
The BKL replacement mutex had some serious performance side-effects on V4L drivers. It is replaced by a better heuristic that works around the worst of the side-effects. Read the v4l2-dev.c comments for the whole sorry story. This is a temporary measure only until we can convert all v4l drivers to

[RFCv2 PATCH 11/15] cafe_ccic: replace ioctl by unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Trivial change, approved by Jonathan Corbet . Signed-off-by: Hans Verkuil --- drivers/media/video/cafe_ccic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c index d147525..f85c933 100644 --- a/drivers/me

[RFCv2 PATCH 13/15] radio-timb: convert to unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-timb.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/radio-timb.c b/drivers/media/radio/radio-timb.c index b8bb3ef..a185610 100644 --- a/drivers/media/radio/radio-timb.c +++ b/drivers/medi

[RFCv2 PATCH 12/15] sh_vou: convert to unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Signed-off-by: Hans Verkuil --- drivers/media/video/sh_vou.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/sh_vou.c b/drivers/media/video/sh_vou.c index 0f49061..858b2f8 100644 --- a/drivers/media/video/sh_vou.c +++ b/drivers/media/video/

[RFCv2 PATCH 08/15] BKL: trivial ioctl -> unlocked_ioctl video driver conversions

2010-11-16 Thread Hans Verkuil
These drivers could be trivially converted to unlocked_ioctl since they already did locking. Signed-off-by: Hans Verkuil --- drivers/media/video/arv.c |2 +- drivers/media/video/bw-qcam.c |2 +- drivers/media/video/c-qcam.c |2 +- drivers/media/video/meye.c| 14 +++

[RFCv2 PATCH 09/15] sn9c102: convert to unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Trivial conversion, this driver used a mutex already. Signed-off-by: Hans Verkuil --- drivers/media/video/sn9c102/sn9c102_core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/sn9c102/sn9c102_core.c b/drivers/media/video/sn9c102/sn9c102_core.c inde

[RFCv2 PATCH 10/15] et61x251_core: trivial conversion to unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Signed-off-by: Hans Verkuil --- drivers/media/video/et61x251/et61x251_core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/et61x251/et61x251_core.c b/drivers/media/video/et61x251/et61x251_core.c index a5cfc76..bb16409 100644 --- a/drivers/media/vid

[RFCv2 PATCH 07/15] dsbr100: convert to unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Trivial conversion to unlocked_ioctl. Signed-off-by: Hans Verkuil --- drivers/media/radio/dsbr100.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c index ed9cd7a..c3e952f 100644 --- a/drivers/media/radio/dsbr

[RFCv2 PATCH 05/15] si4713: convert to unlocked_ioctl

2010-11-16 Thread Hans Verkuil
Convert ioctl to unlocked_ioctl. Note that for this driver the locking is done inside the sub-device. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-si4713.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/

[RFCv2 PATCH 06/15] typhoon: convert to unlocked_ioctl.

2010-11-16 Thread Hans Verkuil
Convert the typhoon driver from ioctl to unlocked_ioctl. When doing this I noticed a bug where curfreq was not initialized correctly to mutefreq (it wasn't multiplied by 16). The initialization is now also done before the device node is created. Signed-off-by: Hans Verkuil --- drivers/media/ra

[RFCv2 PATCH 04/15] tea5764: convert to unlocked_ioctl

2010-11-16 Thread Hans Verkuil
Convert from ioctl to unlocked_ioctl using the v4l2 core lock. Also removed the 'exclusive access' limitation. There was no need for it and it violates the v4l2 spec as well. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-tea5764.c | 49 ++ 1 files c

[RFCv2 PATCH 01/15] v4l2-dev: use mutex_lock_interruptible instead of plain mutex_lock

2010-11-16 Thread Hans Verkuil
Where reasonable use mutex_lock_interruptible instead of mutex_lock. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-dev.c | 44 +-- 1 files changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media/vide

[RFCv2 PATCH 02/15] BKL: trivial BKL removal from V4L2 radio drivers

2010-11-16 Thread Hans Verkuil
The patch converts a bunch of V4L2 radio drivers to unlocked_ioctl. These are all simple conversions: most already had a lock and so the ioctl fop could simply be replaced by unlocked_ioctl. radio-miropcm20.c was converted to use the new V4L2 core lock. While doing this work I noticed that many

[RFCv2 PATCH 03/15] cadet: use unlocked_ioctl

2010-11-16 Thread Hans Verkuil
Converted from ioctl to unlocked_ioctl. This driver already used an internal lock, but it was missing in cadet_open and cadet_release and it was not used correctly in cadet_read. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-cadet.c | 12 +--- 1 files changed, 9 insertions

[RFCv2 PATCH 00/15] BKL removal

2010-11-16 Thread Hans Verkuil
This is my second patch series for the BKL removal project. While this series is against the v2.6.38 staging tree I think it would be good to target 2.6.37 instead. A lot of files are changed, but the changes are all trivial. And this will hopefully take care of most of the BKL removal problems, e

Re: [PATCH] drivers/media: nuvoton: always true expression

2010-11-16 Thread Jarod Wilson
On Tue, Nov 16, 2010 at 09:19:53PM +0100, Nicolas Kaiser wrote: > I noticed that the second part of this conditional is always true. > Would the intention be to strictly check on both chip_major and > chip_minor? > > Signed-off-by: Nicolas Kaiser Hrm, yeah, looks like I screwed that one up. You'

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

2010-11-16 Thread Sam Ravnborg
On Tue, Nov 16, 2010 at 04:41:06PM -0500, Arnaud Lacombe wrote: > Hi, > > On Tue, Nov 16, 2010 at 12:44 PM, Mauro Carvalho Chehab > wrote: > > Em 15-11-2010 14:57, Arnaud Lacombe escreveu: > >> Hi all > >> > >> On Sat, Nov 6, 2010 at 5:30 PM, Arnaud Lacombe wrote: > >>> This option is aimed to a

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 22:32:57 David Ellingsworth wrote: > Hans, > > I've had some patches pending for a while now that affect the dsbr100 > driver. The patches can be seen here: > http://desource.dyndns.org/~atog/gitweb/?p=linux-media.git in the > dsbr100 branch. The first patch in the se

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

2010-11-16 Thread Arnaud Lacombe
Hi, On Tue, Nov 16, 2010 at 12:44 PM, Mauro Carvalho Chehab wrote: > Em 15-11-2010 14:57, Arnaud Lacombe escreveu: >> Hi all >> >> On Sat, Nov 6, 2010 at 5:30 PM, Arnaud Lacombe wrote: >>> This option is aimed to add the possibility to control a menu's visibility >>> without adding dependency to

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread David Ellingsworth
Hans, I've had some patches pending for a while now that affect the dsbr100 driver. The patches can be seen here: http://desource.dyndns.org/~atog/gitweb/?p=linux-media.git in the dsbr100 branch. The first patch in the series fixes locking issues throughout the driver and converts it to use the un

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 21:29:11 Hans Verkuil wrote: > On Tuesday, November 16, 2010 20:59:41 Andy Walls wrote: > > On Tue, 2010-11-16 at 19:38 +0100, Hans Verkuil wrote: > > > On Tuesday, November 16, 2010 17:49:05 Hans Verkuil wrote: > > > > On Tuesday, November 16, 2010 17:01:36 Arnd Bergm

Re: HVR900H : IR Remote Control

2010-11-16 Thread Stefan Ringel
Am 16.11.2010 21:42, schrieb Massis Sirapian: Le 16/11/2010 21:32, Stefan Ringel a écrit : Am 16.11.2010 21:26, schrieb Massis Sirapian: Le 15/11/2010 22:08, Stefan Ringel a écrit : Am 15.11.2010 22:00, schrieb Massis Sirapian: Le 15/11/2010 18:43, Stefan Ringel a écrit : Am 15.11.2010 10:1

Re: HVR900H : IR Remote Control

2010-11-16 Thread Massis Sirapian
Le 16/11/2010 21:32, Stefan Ringel a écrit : Am 16.11.2010 21:26, schrieb Massis Sirapian: Le 15/11/2010 22:08, Stefan Ringel a écrit : Am 15.11.2010 22:00, schrieb Massis Sirapian: Le 15/11/2010 18:43, Stefan Ringel a écrit : Am 15.11.2010 10:15, schrieb Richard Zidlicky: On Sun, Nov 14, 20

Re: HVR900H : IR Remote Control

2010-11-16 Thread Stefan Ringel
Am 16.11.2010 21:26, schrieb Massis Sirapian: Le 15/11/2010 22:08, Stefan Ringel a écrit : Am 15.11.2010 22:00, schrieb Massis Sirapian: Le 15/11/2010 18:43, Stefan Ringel a écrit : Am 15.11.2010 10:15, schrieb Richard Zidlicky: On Sun, Nov 14, 2010 at 08:22:44PM +0100, Massis Sirapian wrote

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 20:59:41 Andy Walls wrote: > On Tue, 2010-11-16 at 19:38 +0100, Hans Verkuil wrote: > > On Tuesday, November 16, 2010 17:49:05 Hans Verkuil wrote: > > > On Tuesday, November 16, 2010 17:01:36 Arnd Bergmann wrote: > > > > On Tuesday 16 November 2010, Hans Verkuil wrote:

[PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread achew
From: Andrew Chew There are two struct list_head's in struct videobuf_buffer. Prior to this fix, all we did for initialization of struct videobuf_buffer was to zero out its memory. This does not properly initialize this struct's two list_head members. This patch immediately calls INIT_LIST_HEAD

Re: HVR900H : IR Remote Control

2010-11-16 Thread Massis Sirapian
Le 15/11/2010 22:08, Stefan Ringel a écrit : Am 15.11.2010 22:00, schrieb Massis Sirapian: Le 15/11/2010 18:43, Stefan Ringel a écrit : Am 15.11.2010 10:15, schrieb Richard Zidlicky: On Sun, Nov 14, 2010 at 08:22:44PM +0100, Massis Sirapian wrote: Thanks Stefan. I've checked the /drivers/med

[PATCH] drivers/media: nuvoton: always true expression

2010-11-16 Thread Nicolas Kaiser
I noticed that the second part of this conditional is always true. Would the intention be to strictly check on both chip_major and chip_minor? Signed-off-by: Nicolas Kaiser --- drivers/media/IR/nuvoton-cir.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/medi

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 19:38 +0100, Hans Verkuil wrote: > On Tuesday, November 16, 2010 17:49:05 Hans Verkuil wrote: > > On Tuesday, November 16, 2010 17:01:36 Arnd Bergmann wrote: > > > On Tuesday 16 November 2010, Hans Verkuil wrote: > > > > > I think there is a misunderstanding. One V4L device (e

RE: [PATCH 01/10] MCDE: Add hardware abstraction layer

2010-11-16 Thread Joe Perches
On Tue, 2010-11-16 at 16:29 +0100, Jimmy RUBIN wrote: > > > +/* Channel path */ > > > +#define MCDE_CHNLPATH(__chnl, __fifo, __type, __ifc, __link) \ > > > + (((__chnl) << 16) | ((__fifo) << 12) | \ > > > + ((__type) << 8) | ((__ifc) << 4) | ((__link) << 0)) > > > +enum mcde_chnl_path { > > > + /*

Question about setting V4L2_CID_AUTO_WHITE_BALANCE control to FALSE

2010-11-16 Thread Shuzhen Wang
Hello, When I set V4L2_CID_AUTO_WHITE_BALANCE control to FALSE, which one of the following is the expected behavior? 1. Hold the current white balance settting. 2. Set the white balance to whatever V4L2_CID_WHITE_BALANCE_TEMPERATURE control is set to. The V4L2 API spec doesn't specify this clea

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Arnd Bergmann
On Tuesday 16 November 2010, Hans Verkuil wrote: > I consider class 3 unacceptable for commonly seen devices. I did a quick scan > of the v4l drivers and the only common driver that falls in that class is uvc. If uvc is the only important one, that should be easy enough to fix by adding a per-devi

Re: Fwd: [PATH] Fix rc-tbs-nec table after converting the cx88 driver to ir-core

2010-11-16 Thread Dmitry Torokhov
On Tuesday, November 16, 2010 09:39:09 am Mauro Carvalho Chehab wrote: > Hi Dmitry, > > This patch fixes an IR table. The patch is trivial, but there are two > buttons on this IR that are not directly supported currently (buttons 10- > and 10+). In a matter of fact, some other IR's use other key c

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 17:49:05 Hans Verkuil wrote: > On Tuesday, November 16, 2010 17:01:36 Arnd Bergmann wrote: > > On Tuesday 16 November 2010, Hans Verkuil wrote: > > > > I think there is a misunderstanding. One V4L device (e.g. a TV capture > > > > card, a webcam, etc.) has one v4l2_dev

Fwd: [PATH] Fix rc-tbs-nec table after converting the cx88 driver to ir-core

2010-11-16 Thread Mauro Carvalho Chehab
Hi Dmitry, This patch fixes an IR table. The patch is trivial, but there are two buttons on this IR that are not directly supported currently (buttons 10- and 10+). In a matter of fact, some other IR's use other key codes (KEY_DOT, KEY_KPPLUS, KEY_DIGITS) for a similar keyboard key (100+). Mariu

[cron job] v4l-dvb daily build: WARNINGS

2010-11-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Tue Nov 16 19:00:17 CET 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 15167:abd3aac6644e git master:

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

2010-11-16 Thread Mauro Carvalho Chehab
Em 15-11-2010 14:57, Arnaud Lacombe escreveu: > Hi all > > On Sat, Nov 6, 2010 at 5:30 PM, Arnaud Lacombe wrote: >> This option is aimed to add the possibility to control a menu's visibility >> without adding dependency to the expression to all the submenu. >> >> Signed-off-by: Arnaud Lacombe >>

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 17:01:36 Arnd Bergmann wrote: > On Tuesday 16 November 2010, Hans Verkuil wrote: > > > I think there is a misunderstanding. One V4L device (e.g. a TV capture > > > card, a webcam, etc.) has one v4l2_device struct. But it can have multiple > > > V4L device nodes (/dev/v

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Mauro Carvalho Chehab
Em 16-11-2010 14:01, Arnd Bergmann escreveu: > On Tuesday 16 November 2010, Hans Verkuil wrote: >>> I think there is a misunderstanding. One V4L device (e.g. a TV capture >>> card, a webcam, etc.) has one v4l2_device struct. But it can have multiple >>> V4L device nodes (/dev/video0, /dev/radio0, e

Re: [PATCH 01/10] MCDE: Add hardware abstraction layer

2010-11-16 Thread Arnd Bergmann
sent out too early... On Tuesday 16 November 2010, Arnd Bergmann wrote: > > > This looks a bit like you actually have multiple interrupt lines > > > multiplexed > > > through a private interrupt controller. Have you considered making this > > > controller > > > a separate device to multiplex the i

Re: [PATCH 01/10] MCDE: Add hardware abstraction layer

2010-11-16 Thread Arnd Bergmann
On Tuesday 16 November 2010, Jimmy RUBIN wrote: > > > Even static variables like these can cause problems. Ideally all of > > these > > are referenced through a driver private data structure that is passed > > around > > with the device. This way you can trivially support multiple devices if > > t

[GIT PATCHES FOR 2.6.38] Fixes for driver pwc

2010-11-16 Thread Hans de Goede
Hi, While investigating the following bug: https://bugzilla.redhat.com/show_bug.cgi?id=624103 I found several errors in the handling of isoc transfers in the pwc driver. The fixes in this pull request fix these. Even with this fixed, the pwc driver is still far from ideal in various places, esp

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Arnd Bergmann
On Tuesday 16 November 2010, Hans Verkuil wrote: > > I think there is a misunderstanding. One V4L device (e.g. a TV capture > > card, a webcam, etc.) has one v4l2_device struct. But it can have multiple > > V4L device nodes (/dev/video0, /dev/radio0, etc.), each represented by a > > struct video_de

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
> >> On Tuesday 16 November 2010, Hans Verkuil wrote: >>> A pointer to this struct is available in vdev->v4l2_dev. However, not >>> all >>> drivers implement struct v4l2_device. But on the other hand, most >>> relevant >>> drivers do. So as a fallback we would still need a static mutex. >> >> Woul

RE: [PATCH 01/10] MCDE: Add hardware abstraction layer

2010-11-16 Thread Jimmy RUBIN
Hi, Thank you Arnd for your comments. > A "hardware abstraction layer" is generally considered a bad thing, > you're usually better off not advertising your code as being one. > > As a rule, the device driver *is* the hardware abstraction, so you > should not add another one ;-) > > > +static v

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
> On Tuesday 16 November 2010, Hans Verkuil wrote: >> A pointer to this struct is available in vdev->v4l2_dev. However, not >> all >> drivers implement struct v4l2_device. But on the other hand, most >> relevant >> drivers do. So as a fallback we would still need a static mutex. > > Wouldn't that

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Arnd Bergmann
On Tuesday 16 November 2010, Hans Verkuil wrote: > A pointer to this struct is available in vdev->v4l2_dev. However, not all > drivers implement struct v4l2_device. But on the other hand, most relevant > drivers do. So as a fallback we would still need a static mutex. Wouldn't that suffer the same

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
> On Tuesday 16 November 2010, Hans Verkuil wrote: >> No, it will also affect e.g. two bttv cards that you capture from in >> parallel. Or two webcams, or... > > Would it be safe to turn the global mutex into a per-driver or per-device > mutex? That would largely mitigate the impact as far as I ca

RE: [omap3isp][PATCH v2 0/9] YUV support for CCDC + cleanups

2010-11-16 Thread Aguirre, Sergio
> -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Tuesday, November 16, 2010 5:45 AM > To: Aguirre, Sergio > Cc: linux-media@vger.kernel.org > Subject: Re: [omap3isp][PATCH v2 0/9] YUV support for CCDC + cleanups > > Hi Sergio, Hi Laurent,

[GIT PULL REQUEST v2.] WL1273 FM Radio driver.

2010-11-16 Thread Matti J. Aaltonen
Hi. The radio pull request, now using http protocol. The following changes since commit f6614b7bb405a9b35dd28baea989a749492c46b2: Linus Torvalds (1): Merge git://git.kernel.org/.../sfrench/cifs-2.6 are available in the git repository at: http://git.gitorious.org/wl1273-fm-driver/wl1

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
> Em 16-11-2010 10:35, Hans Verkuil escreveu: >> >>> Em 15-11-2010 07:49, Hans Verkuil escreveu: > On Sunday 14 November 2010 23:48:51 Hans Verkuil wrote: >> On Sunday, November 14, 2010 22:53:29 Arnd Bergmann wrote: >>> On Sunday 14 November 2010, Hans Verkuil wrote: Thi

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Mauro Carvalho Chehab
Em 16-11-2010 10:35, Hans Verkuil escreveu: > >> Em 15-11-2010 07:49, Hans Verkuil escreveu: >>> On Sunday 14 November 2010 23:48:51 Hans Verkuil wrote: > On Sunday, November 14, 2010 22:53:29 Arnd Bergmann wrote: >> On Sunday 14 November 2010, Hans Verkuil wrote: >>> This patch s

[PATCH v4 4/6] drivers:staging: ti-st: fmdrv_rx sources

2010-11-16 Thread manjunatha_halli
From: Manjunatha Halli This has implementation for FM RX functionality. It communicates with FM V4l2 module and FM common module. Signed-off-by: Manjunatha Halli --- drivers/staging/ti-st/fmdrv_rx.c | 979 ++ drivers/staging/ti-st/fmdrv_rx.h | 59 +++ 2 f

[PATCH v4 2/6] drivers:staging: ti-st: fmdrv_v4l2 sources

2010-11-16 Thread manjunatha_halli
From: Manjunatha Halli This module interfaces V4L2 subsystem and FM common module. It registers itself with V4L2 as Radio module. Signed-off-by: Manjunatha Halli --- drivers/staging/ti-st/fmdrv_v4l2.c | 757 drivers/staging/ti-st/fmdrv_v4l2.h | 32 ++ 2

[PATCH v4 6/6] drivers:staging: ti-st: Kconfig & Makefile change

2010-11-16 Thread manjunatha_halli
From: Manjunatha Halli Add new menu option in Kconfig and compilation option in Makefile for TI FM driver. Signed-off-by: Manjunatha Halli --- drivers/staging/ti-st/Kconfig | 10 ++ drivers/staging/ti-st/Makefile |2 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --g

[PATCH v4 0/6] FM V4L2 drivers for WL128x

2010-11-16 Thread manjunatha_halli
From: Manjunatha Halli Mauro, Hans and the list, This is the v4 version of the TI WL128x FM V4L2 drivers patchset. Texas Instrument's WL128x chipset packs BT, FM, GPS and WLAN in a single die with BT, FM and GPS being interfaced over a single UART. This driver works on top of the shared transpor

[PATCH v4 5/6] drivers:staging: ti-st: fmdrv_tx sources

2010-11-16 Thread manjunatha_halli
From: Manjunatha Halli This has implementation for FM TX functionality. It communicates with FM V4l2 module and FM common module. Signed-off-by: Manjunatha Halli --- drivers/staging/ti-st/fmdrv_tx.c | 461 ++ drivers/staging/ti-st/fmdrv_tx.h | 37 +++ 2 f

[PATCH v4 1/6] drivers:staging: ti-st: fmdrv common header file

2010-11-16 Thread manjunatha_halli
From: Manjunatha Halli These are common headers used in FM submodules (FM V4L2, FM common, FM Rx,and FM TX). Signed-off-by: Manjunatha Halli --- drivers/staging/ti-st/fmdrv.h | 259 + 1 files changed, 259 insertions(+), 0 deletions(-) create mode 10064

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Hans Verkuil
> Em 15-11-2010 07:49, Hans Verkuil escreveu: >> >>> On Sunday 14 November 2010 23:48:51 Hans Verkuil wrote: On Sunday, November 14, 2010 22:53:29 Arnd Bergmann wrote: > On Sunday 14 November 2010, Hans Verkuil wrote: >> This patch series converts 24 v4l drivers to unlocked_ioctl. The

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Mauro Carvalho Chehab
Em 15-11-2010 07:49, Hans Verkuil escreveu: > >> On Sunday 14 November 2010 23:48:51 Hans Verkuil wrote: >>> On Sunday, November 14, 2010 22:53:29 Arnd Bergmann wrote: On Sunday 14 November 2010, Hans Verkuil wrote: > This patch series converts 24 v4l drivers to unlocked_ioctl. These >>>

Re: [RFC PATCH 0/2] Apple remote support

2010-11-16 Thread Mauro Carvalho Chehab
Em 15-11-2010 02:11, Jarod Wilson escreveu: > On Fri, Nov 5, 2010 at 9:27 AM, David Härdeman wrote: >> On Thu, 04 Nov 2010 15:43:33 -0400, Mauro Carvalho Chehab >> wrote: >>> Em 04-11-2010 15:38, David Härdeman escreveu: On Thu, Nov 04, 2010 at 11:54:25AM -0400, Jarod Wilson wrote: > Oka

Re: [omap3isp][PATCH v2 0/9] YUV support for CCDC + cleanups

2010-11-16 Thread Laurent Pinchart
Hi Sergio, Thanks for the patches. I've reviewed and tested them and found no issue. They will be a small delay as I need to sync our internal tree with the public tree before applying them. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media"

Re: [PATCH] media: video: do not clear 'driver' from an i2c_client

2010-11-16 Thread Jean Delvare
Hi Wolfram, Sorry for the late answer. On Mon, 15 Nov 2010 23:28:15 +0100, Wolfram Sang wrote: > On Wed, Nov 10, 2010 at 03:14:13PM +0100, Wolfram Sang wrote: > > The i2c-core does this already. > > > > Reported-by: Jean Delvare > > Signed-off-by: Wolfram Sang > > --- > > > > Not sure if this

RE: Allocating videobuf_buffer, but lists not being initialized

2010-11-16 Thread Marek Szyprowski
Hello, On Tuesday, November 16, 2010 8:38 AM Hans Verkuil wrote: > On Tuesday, November 16, 2010 02:10:39 Andrew Chew wrote: > > I'm looking at drivers/media/video/videobuf-dma-contig.c's > > __videobuf_alloc() routine. We call > kzalloc() to allocate the videobuf_buffer. However, I don't see

Re: af9015 and nxp tda182128 support

2010-11-16 Thread Davor Emard
On Mon, Nov 15, 2010 at 05:44:55PM +0100, Okkel Klaver wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hello everybody, > > > I own a brandless hdtv usb dvb-t stick. > > lsusb identifies it as: > Bus 001 Device 005: ID 15a4:9016 Afatech Technologies, Inc. AF9015 DVB-T > USB2.0 sti

Re: Allocating videobuf_buffer, but lists not being initialized

2010-11-16 Thread Figo.zhang
于 11/16/2010 03:37 PM, Hans Verkuil 写道: On Tuesday, November 16, 2010 02:10:39 Andrew Chew wrote: I'm looking at drivers/media/video/videobuf-dma-contig.c's __videobuf_alloc() routine. We call kzalloc() to allocate the videobuf_buffer. However, I don't see where the two lists (vb->stream and

Re: Allocating videobuf_buffer, but lists not being initialized

2010-11-16 Thread Figo.zhang
于 11/16/2010 03:40 PM, Hans Verkuil 写道: On Tuesday, November 16, 2010 06:29:53 Pawel Osciak wrote: On Mon, Nov 15, 2010 at 17:10, Andrew Chew wrote: I'm looking at drivers/media/video/videobuf-dma-contig.c's __videobuf_alloc() routine. We call kzalloc() to allocate the videobuf_buffer. Howe