[patch] media: ir-keytable: null dereference in debug code

2010-08-05 Thread Dan Carpenter
"ir_dev->props" can be NULL. We only use raw mode if "ir_dev->props" is non-NULL and "ir_dev->props->driver_type == RC_DRIVER_IR_RAW". Signed-off-by: Dan Carpenter diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 15a0f19..cf97427 100644 --- a/drivers/media/IR/i

Re: dvb_usb_rtl2831u module cause "oops" on kernel 2.6.32 when loading

2010-08-05 Thread Jan Hoogenraad
Can you test the current version ? Thomas Holzeisen wrote: Hi, i am using a DVB-T USB-Stick with Realtek RTL2831 chip (14aa:0160) on Debian Lenny having the lastest Backport kernel 2.6.32. $ uname -a Linux xbmc 2.6.32-bpo.5-686 #1 SMP Fri Jun 11 22:20:29 UTC 2010 i686 GNU/Linux For v4l I

Re: Help wanted on removing dibusb_rc_keys from dvb_usb_rtl2831u module

2010-08-05 Thread Jan Hoogenraad
OK. I found the solution by looking at the sources at: http://lxr.free-electrons.com/source/drivers/media/dvb/dvb-usb/dibusb-common.c What needed was a rename over all sources affected: struct dvb_usb_rc_key dibusb_rc_keys[] => struct dvb_usb_rc_key ir_codes_dibusb_table[] I also fixed missing

Re: PULL of cx23885-mpx series

2010-08-05 Thread Mauro Carvalho Chehab
Em 05-08-2010 19:32, Andy Walls escreveu: > Mauro, > > Stoth and I chatted and I'm OK with his cx23885-mpx series going in as is, > since there is a plan in place to move cx23885/7/8 AV core handling out of > cx25840. > > So, > > Reviewed-by: Andy Walls > Acked-by: Andy Walls I'm OK with th

Re: Fwd: No audio in HW Compressed MPEG2 container on HVR-1300

2010-08-05 Thread Shane Harrison
On Wed, Aug 4, 2010 at 1:48 AM, lawrence rust wrote: [snip} >> >> Still to try the patch - will let you know.  Unfortunately our >> HVR-1300 is in the process of being swapped out since the supplier >> wanted to try swapping boards first :-( > > Let us know how you get on. > > -- Lawrence Rust We

Re: [PULL] http://www.kernellabs.com/hg/~stoth/cx23885-mpx

2010-08-05 Thread Mauro Carvalho Chehab
Hi Steven, Em 31-07-2010 13:31, Steven Toth escreveu: > Mauro, > > Please pull from http://www.kernellabs.com/hg/~stoth/cx23885-mpx > >- cx23885: prepare the cx23885 makefile for alsa support >- cx23885: merge mijhail's header changes for alsa >- cx23885: ALSA support >- cx23

[PULL] V4L, soc-camera: 2.6.36 #2

2010-08-05 Thread Guennadi Liakhovetski
Hi Mauro As discussed today (yesterday for me) on IRC, here's the second soc-camera pull for 2.6.36. The main reason for it is a dependency on the ARM tree. Would be nice if we could get it in for 2.6.36. Please note, that my tree is now based on Linus' tree of a couple of hours ago, so, you mi

Re: PULL of cx23885-mpx series

2010-08-05 Thread Andy Walls
Mauro, Stoth and I chatted and I'm OK with his cx23885-mpx series going in as is, since there is a plan in place to move cx23885/7/8 AV core handling out of cx25840. So, Reviewed-by: Andy Walls Acked-by: Andy Walls Sent via my Gmail account from my phone since the electrical storm here knoc

Re: [PATCH 42/42] drivers/media/video/bt8xx: Adjust confusing if indentation

2010-08-05 Thread Arnd Bergmann
On Thursday 05 August 2010 22:51:12 Luca Tettamanti wrote: > > diff --git a/drivers/media/video/bt8xx/bttv-i2c.c > > b/drivers/media/video/bt8xx/bttv-i2c.c > > index 685d659..695765c 100644 > > --- a/drivers/media/video/bt8xx/bttv-i2c.c > > +++ b/drivers/media/video/bt8xx/bttv-i2c.c > > @@ -123,7

Re: [PATCH 42/42] drivers/media/video/bt8xx: Adjust confusing if indentation

2010-08-05 Thread Julia Lawall
From: Julia Lawall Indent the branch of an if. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r disable braces4@ position p1,p2; statement S1,S2; @@ ( if (...) { ... } | if (...) s...@p1 s...@p2 ) @script:python@ p1 << r.p1; p2 << r.p2; @@ if (p1[

Re: [PATCH 5/5] mx2_camera: add informative camera clock frequency printout

2010-08-05 Thread Michael Grzeschik
On Thu, Aug 05, 2010 at 10:30:39PM +0200, Guennadi Liakhovetski wrote: > On Tue, 3 Aug 2010, Michael Grzeschik wrote: > > > ported mx27_camera to 2.6.33.2 > > Sorry, do not understand what this description has to do with the contents The Description is of topic from a previous patchseries from T

Re: [PATCH 42/42] drivers/media/video/bt8xx: Adjust confusing if indentation

2010-08-05 Thread Luca Tettamanti
Hi, one minor comment: On Thu, Aug 5, 2010 at 10:29 PM, Julia Lawall wrote: > From: Julia Lawall > > Indent the branch of an if. [...] > diff --git a/drivers/media/video/bt8xx/bttv-i2c.c > b/drivers/media/video/bt8xx/bttv-i2c.c > index 685d659..695765c 100644 > --- a/drivers/media/video/bt8xx/b

Re: [PATCH 5/5] mx2_camera: add informative camera clock frequency printout

2010-08-05 Thread Guennadi Liakhovetski
On Tue, 3 Aug 2010, Michael Grzeschik wrote: > ported mx27_camera to 2.6.33.2 Sorry, do not understand what this description has to do with the contents - adding a printk to a driver? I don't think this is something critical enough to be handled urgently now for 2.6.36, right? Thanks Guennadi

[PATCH 42/42] drivers/media/video/bt8xx: Adjust confusing if indentation

2010-08-05 Thread Julia Lawall
From: Julia Lawall Indent the branch of an if. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r disable braces4@ position p1,p2; statement S1,S2; @@ ( if (...) { ... } | if (...) s...@p1 s...@p2 ) @script:python@ p1 << r.p1; p2 << r.p2; @@ if (p1[

Re: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-05 Thread Richard Röjfors
On 08/04/2010 12:34 PM, Pawel Osciak wrote: Richard Röjfors wrote: On 08/04/2010 11:50 AM, Pawel Osciak wrote: How do you propose to allocate the buffers? They need to be contiguous and using uncached memory gave really bad performance. 829440 bytes is a quite a lot and one can't reliably de

[PATCH 19/42] drivers/media/video: Adjust confusing if indentation

2010-08-05 Thread Julia Lawall
From: Julia Lawall In cx23885/cx23885-video.c, cx88/cx88-video.c, davinci/vpif_capture.c, and davinci/vpif_display.c, group the aligned code into a single if branch. In saa7134/saa7134-video.c, outdent the code following the if. The semantic match that finds this problem is as follows: (http://

Re: [PATCH 1/5] mx2_camera: change to register and probe

2010-08-05 Thread Guennadi Liakhovetski
On Tue, 3 Aug 2010, Michael Grzeschik wrote: > change this driver back to register and probe, since some platforms > first have to initialize an already registered power regulator to switch > on the camera. I shall be preparing a pull-request for 2.6.36-rc1 #2, but since we haven't finished disc

Re: [RFC/PATCH v3 06/10] media: Entities, pads and links enumeration

2010-08-05 Thread Marko Ristola
05.08.2010 12:38, Laurent Pinchart wrote: Hi Marko, On Wednesday 04 August 2010 21:28:22 Marko Ristola wrote: Hi Hans and Laurent. I hope my thoughts help you further. Thank you for sharing them. Thank you for taking time to answer for me. [ snip ] There's probably some confusion here.

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-08-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Aug 5 19:00:33 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14994:a14d56c730c4 git master:

Re: [PATCH 2/5] mx2_camera: remove emma limitation for RGB565

2010-08-05 Thread Guennadi Liakhovetski
On Wed, 4 Aug 2010, Michael Grzeschik wrote: > On Wed, Aug 04, 2010 at 11:55:39AM +0200, Guennadi Liakhovetski wrote: > > On Tue, 3 Aug 2010, Michael Grzeschik wrote: > > > > > In the current source status the emma has no limitation for any PIXFMT > > > since the data is parsed raw and unprocesse

Re: OMAP3 Bridge Problems

2010-08-05 Thread Lane Brooks
On 08/05/2010 10:06 AM, Lane Brooks wrote: On 08/04/2010 02:57 PM, Laurent Pinchart wrote: Hi Lane, On Tuesday 03 August 2010 17:26:48 Lane Brooks wrote: [snip] My question: - Are there other things I need to when I enable the parallel bridge? For example, do I need to change a clock rat

Re: OMAP3 Bridge Problems

2010-08-05 Thread Lane Brooks
On 08/05/2010 10:06 AM, Lane Brooks wrote: On 08/04/2010 02:57 PM, Laurent Pinchart wrote: Hi Lane, On Tuesday 03 August 2010 17:26:48 Lane Brooks wrote: [snip] My question: - Are there other things I need to when I enable the parallel bridge? For example, do I need to change a clock rate

[PATCH/RFC] V4L2: add a generic function to find the nearest discrete format

2010-08-05 Thread Guennadi Liakhovetski
Many video drivers implement a discrete set of frame formats and thus face a task of finding the best match for a user-requested format. Implementing this in a generic function has also an advantage, that different drivers with similar supported format sets will select the same format for the u

Re: OMAP3 Bridge Problems

2010-08-05 Thread Lane Brooks
On 08/04/2010 02:57 PM, Laurent Pinchart wrote: Hi Lane, On Tuesday 03 August 2010 17:26:48 Lane Brooks wrote: [snip] My question: - Are there other things I need to when I enable the parallel bridge? For example, do I need to change a clock rate somewhere? From the TRM, it seems like it s

Re: V4L hg tree fails to compile against latest stable kernel 2.6.35

2010-08-05 Thread Douglas Schilling Landgraf
Hello, On Thu, Aug 5, 2010 at 2:44 AM, VDR User wrote: > On Wed, Aug 4, 2010 at 10:19 PM, Douglas Schilling Landgraf > wrote: >> Hello Derek, >> >> On Tue, Aug 3, 2010 at 10:37 AM, Mauro Carvalho Chehab >> wrote: >>> Em 03-08-2010 03:44, VDR User escreveu: On Mon, Aug 2, 2010 at 11:36 PM,

Re: V4L Kconfig defaults

2010-08-05 Thread Mauro Carvalho Chehab
Em 05-08-2010 07:32, Guennadi Liakhovetski escreveu: > Hi Mauro > > At some point the usefullness of the VIDEO_HELPER_CHIPS_AUTO option has > been questioned and a patch has even been submitted to disable this on > embedded systems [1], which, somehow, doesn't seem to have been > successful, ev

Re: [PULL] http://www.kernellabs.com/hg/~stoth/cx23885-mpx

2010-08-05 Thread Steven Toth
On Thu, Aug 5, 2010 at 8:11 AM, Andy Walls wrote: > On Wed, 2010-08-04 at 11:40 -0400, Steven Toth wrote: >> On 7/31/10 2:28 PM, Andy Walls wrote: >> > On Sat, 2010-07-31 at 12:31 -0400, Steven Toth wrote: >> >> Mauro, >> >> >> >> Please pull from http://www.kernellabs.com/hg/~stoth/cx23885-mpx >>

Re: [PULL] http://www.kernellabs.com/hg/~stoth/cx23885-mpx

2010-08-05 Thread Andy Walls
On Wed, 2010-08-04 at 11:40 -0400, Steven Toth wrote: > On 7/31/10 2:28 PM, Andy Walls wrote: > > On Sat, 2010-07-31 at 12:31 -0400, Steven Toth wrote: > >> Mauro, > >> > >> Please pull from http://www.kernellabs.com/hg/~stoth/cx23885-mpx > > >> A pretty large patch set which adds a number of impo

Re: Not able to capture video frames

2010-08-05 Thread Jean-Francois Moine
On Thu, 5 Aug 2010 11:34:28 +0530 Sudhindra Nayak wrote: > As you requested, I'm including the lsusb output below: Hi Sudhindra, The USB information indicate that the webcam uses uses isochronous transfer. The driver ov534 you used as a base uses bulk transfer. So, you must either remove the 'c

V4L Kconfig defaults

2010-08-05 Thread Guennadi Liakhovetski
Hi Mauro At some point the usefullness of the VIDEO_HELPER_CHIPS_AUTO option has been questioned and a patch has even been submitted to disable this on embedded systems [1], which, somehow, doesn't seem to have been successful, even though there haven't been any objections. Or was I expected t

Re: [RFC/PATCH v3 06/10] media: Entities, pads and links enumeration

2010-08-05 Thread Laurent Pinchart
Hi Marko, On Wednesday 04 August 2010 21:28:22 Marko Ristola wrote: > Hi Hans and Laurent. > > I hope my thoughts help you further. Thank you for sharing them. > 03.08.2010 12:22, Laurent Pinchart wrote: > > On Monday 02 August 2010 23:01:55 Hans Verkuil wrote: > >> On Monday 02 August 2010 16:

Re: V4L hg tree fails to compile against latest stable kernel 2.6.35

2010-08-05 Thread Douglas Schilling Landgraf
Hello Derek, On Tue, Aug 3, 2010 at 10:37 AM, Mauro Carvalho Chehab wrote: > Em 03-08-2010 03:44, VDR User escreveu: >> On Mon, Aug 2, 2010 at 11:36 PM, VDR User wrote: >>> Any idea when this will be fixed? > > It is up to Douglas to do the backport, but you can just use the latest > git tree, w