RE: omap2 camera

2010-03-22 Thread Viral Mehta
From: Aguirre, Sergio [saagui...@ti.com] Sent: Tuesday, March 23, 2010 11:54 AM To: Sakari Ailus; Viral Mehta Cc: linux-media@vger.kernel.org Subject: RE: omap2 camera > > From: Sakari Ailus [sakari.ai...@maxwell.re

[PULL] http://kernellabs.com/hg/~dheitmueller/ngene2-bullshit

2010-03-22 Thread Devin Heitmueller
Ok, here's take two of the PULL request issued yesterday. It's basically the same as yesterday, but except instead of moving the unused code to separate files where it might actually be useful to someone else in the future, I delete it entirely because Mauro's scripts mangle the patches when pulli

RE: omap2 camera

2010-03-22 Thread Aguirre, Sergio
> > From: Sakari Ailus [sakari.ai...@maxwell.research.nokia.com] > Sent: Monday, March 22, 2010 11:50 PM > To: Viral Mehta > Cc: Aguirre, Sergio; linux-media@vger.kernel.org > Subject: Re: omap2 camera > > Viral Mehta wrote: > > Hi Sakari, > > Hi Viral, >

Re: [PATCH] drivers/media/video: avoid NULL dereference

2010-03-22 Thread Julia Lawall
> I think we can pretty safely assume that we never get here with ov==NULL. > > Oh well, I'll leave the test there for others to ponder. OK. I didn't read far enough in this email and sent another patch, in case it's useful. julia -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] drivers/media/video: avoid NULL dereference

2010-03-22 Thread Julia Lawall
From: Julia Lawall It seems impossible for ov to be NULL at this point. The semantic match that finds the problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression E, E1; identifier f; statement S1,S3; iterator iter; @@ if ((E == NULL && ...) || ...) { ... when != false (

Re: [PATCH] drivers/media/video: avoid NULL dereference

2010-03-22 Thread Andrew Morton
On Sun, 21 Mar 2010 22:31:06 +0100 (CET) Julia Lawall wrote: > From: Julia Lawall > > If ov is NULL, it will not be possible to take the lock in the first place, > so move the test up earlier. > > ... > > --- a/drivers/media/video/ov511.c > +++ b/drivers/media/video/ov511.c > @@ -5913,14 +5913

Re: omap2 camera

2010-03-22 Thread Sakari Ailus
Viral Mehta wrote: > Hi Sakari, Hi Viral, > > From: Sakari Ailus [sakari.ai...@maxwell.research.nokia.com] > Sent: Monday, March 22, 2010 10:51 PM > To: Aguirre, Sergio > Cc: Viral Mehta; linux-media@vger.kernel.org > Subject: Re: omap2 camera > > Aguirre

RE: omap2 camera

2010-03-22 Thread Viral Mehta
Hi Sakari, From: Sakari Ailus [sakari.ai...@maxwell.research.nokia.com] Sent: Monday, March 22, 2010 10:51 PM To: Aguirre, Sergio Cc: Viral Mehta; linux-media@vger.kernel.org Subject: Re: omap2 camera Aguirre, Sergio wrote: > Hi Viral, > >> -Original Me

FM1216ME MK5 radio

2010-03-22 Thread hermann pitton
Hi Dmitry, please have a look at tveeprom concerning your FM1216ME/I MK5. It still maps to the MK3 and should break for radio. Cheers, Hermann -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-22 Thread Wolfram Sang
> > > Personally I'd much rather just not bother setting the driver data in > > > the removal path, it seems unneeded. I had assumed that the subsystem > > > code cared for some reason when I saw the patch series. > > > > Anyway, should this really be necessary, then for the media drivers this >

Re: Kworld Plus TV Hybrid PCI (DVB-T 210SE)

2010-03-22 Thread hermann pitton
Hi Peter, Am Samstag, den 20.03.2010, 16:20 +1100 schrieb 0123pe...@gmail.com: > on Wed, 17 Mar 2010 09:12 am > in the Usenet newsgroup gmane.linux.drivers.video-input-infrastructure > hermann pitton wrote: > > [snip] > > > > unfortunately the problem with these cards is known, but no good > > s

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-22 Thread Mark Brown
On Mon, Mar 22, 2010 at 09:33:58PM +0100, Jean Delvare wrote: > On Sun, 21 Mar 2010 17:09:56 +0100, Hans Verkuil wrote: > > On Sunday 21 March 2010 15:14:17 Mark Brown wrote: > > > I agree with this. There are also some use cases where the device data > > > is actually static (eg, a generic descr

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: WARNINGS

2010-03-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Mon Mar 22 19:00:21 CET 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14494:929298149eba git master:

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-22 Thread Jean Delvare
Replying to myself... On Sun, 21 Mar 2010 14:46:55 +0100, Jean Delvare wrote: > I get the feeling that this would be a job for managed resources as > some drivers already do for I/O ports and IRQs. Managed resources don't > care about symmetry of allocation and freeing, by design (so it can > viol

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-22 Thread Jean Delvare
Hi Hans, Mark, Wolfram, On Sun, 21 Mar 2010 17:09:56 +0100, Hans Verkuil wrote: > On Sunday 21 March 2010 15:14:17 Mark Brown wrote: > > On Sun, Mar 21, 2010 at 02:46:55PM +0100, Jean Delvare wrote: > > > On Sat, 20 Mar 2010 23:02:49 +0100, Hans Verkuil wrote: > > > > > > I feel I am missing some

Re: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c

2010-03-22 Thread Olimpiu Pascariu
> > Missing a space there. Otherwise looks good. > In the previous mail I have resent the patch with the missing space added. Regards, Olimpiu Pascariu -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c

2010-03-22 Thread Olimpiu Pascariu
>From 32591165a537a03f472c68289798044d6eeea2e0 Mon Sep 17 00:00:00 2001 From: Olimpiu Pascariu Date: Mon, 22 Mar 2010 22:07:20 +0200 Subject: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c This is a patch to cx25821-medusa-video.c file that fixes up warnings and

Re: av7110 and budget_av are broken!

2010-03-22 Thread e9hack
Am 20.3.2010 22:37, schrieb Hans Verkuil: > On Saturday 20 March 2010 17:03:01 e9hack wrote: > OK, I know that. But does the patch I mailed you last time fix this problem > without causing new ones? If so, then I'll post that patch to the list. With your last patch, I've no problems. I'm using a a

Re: [PATCH] DTV2000 H Plus issues

2010-03-22 Thread istva...@mailbox.hu
On 03/15/2010 05:15 AM, Devin Heitmueller wrote: > I'll try to go through my tree and see if I can get something upstream > this week which you could build on. Are there any news on this ? By the way, I have just received this mail from Mirek Slugen, with a patch for PxDVR3200 with XC4000 tuner.

[PATCH] V4L/DVB: ds3000: fix divide-by-zero error in ds3000_read_snr()

2010-03-22 Thread Nicolas Noirbent
Fix a divide-by-zero error in ds3000's ds3000_read_snr(), when getting a very low signal reading (dvbs2_signal_reading >= 1). This prevents some nasty EIPs when running szap-s2 with a very low signal strength. Signed-off-by: Nicolas Noirbent --- drivers/media/dvb/frontends/ds3000.c |2 +- 1

Re: em28xx - Your board has no unique USB ID and thus need a hint to be detected

2010-03-22 Thread Devin Heitmueller
On Mon, Mar 22, 2010 at 1:45 PM, Steffen Pankratz wrote: > Hi Devin, > > I don't want to push you but are there any news? I've been too buried in other projects to work on it. In the meantime, you can add "card=53" as a modprobe option to em28xx, and it should start working for you. Devin --

Re: em28xx - Your board has no unique USB ID and thus need a hint to be detected

2010-03-22 Thread Steffen Pankratz
On Fri, 19 Mar 2010 13:17:20 -0400 Devin Heitmueller wrote: > On Fri, Mar 19, 2010 at 1:13 PM, Steffen Pankratz wrote: > > On Fri, 19 Mar 2010 13:07:23 -0400 > > Devin Heitmueller wrote: > > > >> On Fri, Mar 19, 2010 at 1:01 PM, Steffen Pankratz wrote: > >> > Hi, > >> > > >> > this USB stick i

Re: Questions to ngene/dvb_frontend driver [Original email was "Problems with ngene based DVB cards (Digital Devices Cine S2 Dual DVB-S2 , Mystique SaTiX S2 Dual)"]

2010-03-22 Thread Michael Repplinger
Hi list, in addition to my previous tests, I found that the problems with long tuning delays only occurs when switching to an SD channel. If I switch to an HD channel, e.g., using adapter 0, I always get fast tuning times (see my tests below). Since the large delays only occur when switching to

Re: omap2 camera

2010-03-22 Thread Sakari Ailus
Aguirre, Sergio wrote: > Hi Viral, > >> -Original Message- >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Viral Mehta >> Sent: Monday, March 22, 2010 5:20 AM >> To: linux-media@vger.kernel.org >> Subject: omap2 camera >> >> Hi list, >

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 19:54:30 +0300, Dan Carpenter wrote: > > On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote: > > At Mon, 22 Mar 2010 08:43:47 -0700, > > Joe Perches wrote: > > > > > > On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > > > > card->driver is 15 characters and a

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Dan Carpenter
On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote: > At Mon, 22 Mar 2010 08:43:47 -0700, > Joe Perches wrote: > > > > On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > > > card->driver is 15 characters and a NULL, the original code could > > > cause a buffer overflow. > > > >

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 08:43:47 -0700, Joe Perches wrote: > > On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > > card->driver is 15 characters and a NULL, the original code could > > cause a buffer overflow. > > > In version 2, I used a better name that Takashi Iwai suggested. > > Perhaps

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Joe Perches
On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > card->driver is 15 characters and a NULL, the original code could > cause a buffer overflow. > In version 2, I used a better name that Takashi Iwai suggested. Perhaps it's better to use strncpy as well. -- To unsubscribe from this list:

[patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Dan Carpenter
card->driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter --- In version 2, I used a better name that Takashi Iwai suggested. diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c in

Re: [patch] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Takashi Iwai
At Fri, 19 Mar 2010 14:49:57 +0300, Dan Carpenter wrote: > > card->driver is 15 characters and a NULL, the original code could > cause a buffer overflow. > > Signed-off-by: Dan Carpenter This should rather a string without spaces because this string is used as an identifier in alsa-lib. Better

Re: RFC: Phase 1: Proposal to convert V4L1 drivers

2010-03-22 Thread Theodore Kilgore
On Mon, 22 Mar 2010, Hans de Goede wrote: > > [...] I've seen the same > problem (not streaming) with the "old" version when used with machines > with UHCI usb controllers (rather then OHCI), such as atom based > laptops. > > So maybe this is some timing issues, and your changes have spe

Re: RFC: Phase 2/3: Move the compat code into v4l1-compat. Convert apps.

2010-03-22 Thread Mauro Carvalho Chehab
Hans de Goede wrote: > Hi, > > On 03/22/2010 09:11 AM, Hans Verkuil wrote: >> On Sunday 21 March 2010 00:14:25 Hans de Goede wrote: >>> Hi, >>> >>> On 03/20/2010 10:21 AM, Hans Verkuil wrote: Hi all! The second phase that needs to be done to remove the v4l1 support from the >>>

Re: RFC: Phase 2/3: Move the compat code into v4l1-compat. Convert apps.

2010-03-22 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: > On Sunday 21 March 2010 00:14:25 Hans de Goede wrote: >> Yes it can, this for example already happens when using v4l1 apps with >> uvcvideo (which is not possible without libv4l1). > > In what way does libv4l1 still depend on the kernel's v4l1 compat layer? And > what is nee

RE: omap2 camera

2010-03-22 Thread Aguirre, Sergio
Hi Viral, > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Viral Mehta > Sent: Monday, March 22, 2010 5:20 AM > To: linux-media@vger.kernel.org > Subject: omap2 camera > > Hi list, > > I am using OMAP2430 board and

Re: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c

2010-03-22 Thread Dan Carpenter
On Sun, Mar 21, 2010 at 08:51:43PM +0200, Olimpiu Pascariu wrote: > >From 24e5efa163c1fa58f694fd8b44dc3488e0cc92d1 Mon Sep 17 00:00:00 2001 > From: Olimpiu Pascariu > Date: Sun, 21 Mar 2010 20:46:26 +0200 > Subject: [PATCH 5/5] Staging: cx25821: fix coding style issues in > cx25821-medusa-video.c

RE: [REPORT] Brainstorm meeting on V4L2 memory handling

2010-03-22 Thread Hiremath, Vaibhav
> -Original Message- > From: Pawel Osciak [mailto:p.osc...@samsung.com] > Sent: Monday, March 22, 2010 6:31 PM > To: Hiremath, Vaibhav; linux-media@vger.kernel.org > Subject: RE: [REPORT] Brainstorm meeting on V4L2 memory handling > > Hello! > > >Hiremath, Vaibhav wrote: > >> 1) Memory-to

RE: [REPORT] Brainstorm meeting on V4L2 memory handling

2010-03-22 Thread Pawel Osciak
Hello! >Hiremath, Vaibhav wrote: >> 1) Memory-to-memory devices >> >> Original thread with the proposal from Samsung: >> >> http://www.mail-archive.com/linux-samsung-...@vger.kernel.org/msg00391.html >> >[Hiremath, Vaibhav] Pawel, > >I wanted to start prototyping Resizer and Previewer driver to th

[patch] cx23885: strcpy() => strlcpy()

2010-03-22 Thread Dan Carpenter
cap->driver is a 16 char buffer and dev->name is a 32 char buffer. I don't see an actual problem, but we may as well make the static checkers happy. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c index 2ab97ad..6ff

Re: PXA camera and Planar YUV422 16 bit camera

2010-03-22 Thread Guennadi Liakhovetski
Hi Rodolfo On Wed, 17 Mar 2010, Rodolfo Giometti wrote: > Hello, > > I'm puzzled to know if the pxa_camera driver can manage a data depth > different from 8 bits. > > I'm currently trying to add a camera interface support to my PXA270 > based board with an adv7180 as soc camera device. > > For

TT s2-3200 does not scan the frequencies <5000

2010-03-22 Thread Armando Baía
I do not speak English but can understand. This text was translated by google. Do not want to be inconvenient. In December I reported that the board TT s2-3200 does not scan the frequencies <5000. Because there will be issues of more interest was not the case is not resolved, hence my insistence.

WG: Tuning very unreliable (Technisat Skystar HD2)

2010-03-22 Thread Bjoern Wuest
Hello alltogether, I am in the process of switching my home entertainment system from Windows to Linux. The distro of choice is OpenSuse 11.2 . Ultimately, I want to run MythTV with XFCE on it. My TV cards are two pieces of Technisat Skystar HD2. In Windows, my hardware works just fine. Yet, in

Re: RFC: Phase 1: Proposal to convert V4L1 drivers

2010-03-22 Thread Hans Verkuil
On Monday 22 March 2010 10:29:09 Hans de Goede wrote: > Hi, > > On 03/22/2010 01:17 AM, Hans Verkuil wrote: > > On Sunday 21 March 2010 23:45:04 Hans Verkuil wrote: > >> On Saturday 20 March 2010 09:58:49 Hans Verkuil wrote: > >>> These drivers have no hardware to test with: bw-qcam, c-qcam, arv,

omap2 camera

2010-03-22 Thread Viral Mehta
Hi list, I am using OMAP2430 board and I wanted to test camera module on that board. I am using latest 2.6.33 kernel. However, it looks like camera module is not supported with latest kernel. Anyone is having any idea? Also, do we require to have ex3691 sensor driver in mainline kernel in order

Questions to ngene/dvb_frontend driver [Original email was "Problems with ngene based DVB cards (Digital Devices Cine S2 Dual DVB-S2 , Mystique SaTiX S2 Dual)"]

2010-03-22 Thread Michael Repplinger
Hi, I read the problems described in email thread "Problems with ngene based DVB cards (Digital Devices Cine S2 Dual DVB-S2 , Mystique SaTiX S2 Dual)". Unfortunately, I just subscribed to this list so I cannot respond to the original mail directly but it can be found at the end of this mail. For t

Re: [PATCH] V4L/DVB: saa7146: IRQF_DISABLED causes only trouble

2010-03-22 Thread Bjørn Mork
Andy Walls writes: > On Sun, 2010-03-21 at 21:08 +0100, Bjørn Mork wrote: >> As discussed many times, e.g. in http://lkml.org/lkml/2007/7/26/401 >> mixing IRQF_DISABLED with IRQF_SHARED just doesn't make sense. >> >> Remove IRQF_DISABLED to avoid random unexpected behaviour. >> >> Ever since I s

Re: RFC: Phase 1: Proposal to convert V4L1 drivers

2010-03-22 Thread Hans de Goede
Hi, On 03/22/2010 01:17 AM, Hans Verkuil wrote: On Sunday 21 March 2010 23:45:04 Hans Verkuil wrote: On Saturday 20 March 2010 09:58:49 Hans Verkuil wrote: These drivers have no hardware to test with: bw-qcam, c-qcam, arv, w9966. However, all four should be easy to convert to v4l2, even withou

Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-03-22 Thread Wolfram Sang
On Sun, Mar 21, 2010 at 11:40:28PM -0700, Dmitry Torokhov wrote: > My standard question - are all of these need to be dynamically > allocated? I have my doubts for a few of them. Still, this would be a more intrusive change than just fixing the BUG appearance, so I'd like to leave that task for t

Re: RFC: Phase 2/3: Move the compat code into v4l1-compat. Convert apps.

2010-03-22 Thread Hans de Goede
Hi, On 03/22/2010 09:11 AM, Hans Verkuil wrote: On Sunday 21 March 2010 00:14:25 Hans de Goede wrote: Hi, On 03/20/2010 10:21 AM, Hans Verkuil wrote: Hi all! The second phase that needs to be done to remove the v4l1 support from the kernel is that libv4l1 should replace the v4l1-compat code

Re: RFC: Phase 2/3: Move the compat code into v4l1-compat. Convert apps.

2010-03-22 Thread Hans Verkuil
On Sunday 21 March 2010 00:14:25 Hans de Goede wrote: > Hi, > > On 03/20/2010 10:21 AM, Hans Verkuil wrote: > > Hi all! > > > > The second phase that needs to be done to remove the v4l1 support from the > > kernel is that libv4l1 should replace the v4l1-compat code from the kernel. > > > > I do no