[RFC, PATCH 2/2] gspca pac7302: add support for camera button

2009-11-18 Thread Németh Márton
From: Márton Németh Add support for snapshot button found on Labtec Webcam 2200. Signed-off-by: Márton Németh --- diff -r 182b5f8fa160 linux/drivers/media/video/gspca/pac7302.c --- a/linux/drivers/media/video/gspca/pac7302.c Sun Nov 15 10:05:30 2009 +0100 +++ b/linux/drivers/media/video/gspca/p

[RFC, PATCH 1/2] gspca: add input support for interrupt endpoints

2009-11-18 Thread Németh Márton
From: Márton Németh Add helper functions for interrupt endpoint based input handling. Signed-off-by: Márton Németh --- Hi, maybe a new configuration option should be also introduced? Regards, Márton Németh --- diff -r 182b5f8fa160 linux/drivers/media/video/gspca/Makefile --- a/linux/

Re: [PATCH v3] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Hans Verkuil
On Wednesday 18 November 2009 23:43:59 m-kariche...@ti.com wrote: > From: Muralidharan Karicheri > > Some minor updates (comment format) made to previous v3. > > This is v3 of the digital video timings APIs implementation. > This has updates based on comments received against v2 of the patch. Ho

Re: saa7134 (not very) new board 5168:0307

2009-11-18 Thread hermann pitton
Hi Tom, Am Mittwoch, den 18.11.2009, 14:06 +0100 schrieb tomloh...@gmail.com: > Hello list, > > looking from saa7134.h, this board 5168:0307 is not included > This cars is on some asus laptop and some medion laptop > It was previously working with this settings (1) card=55 tuner=54 > or (2) wit

[PATCH v3] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread m-karicheri2
From: Muralidharan Karicheri Some minor updates (comment format) made to previous v3. This is v3 of the digital video timings APIs implementation. This has updates based on comments received against v2 of the patch. Hopefully this can be merged to 2.6.33 if there are no more comments. This adds

RE: [PATCH v3] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
Randy, Thanks for your comments... > >Make sure that these ioctls (range) are added to/included in >Documentation/ioctl/ioctl-number.txt . > There is separate document for v4l2 APIs. These ioctls are added to that (See my patch with similar title) >Hm, are those supposed to be small 'v' instea

Re: [PATCH v3] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Randy Dunlap
On Wed, 18 Nov 2009 15:38:31 -0500 m-kariche...@ti.com wrote: > From: Muralidharan Karicheri > > This is v3 of the digital video timings APIs implementation. > This has updates based on comments received against v2 of the patch. Hopefully > this can be merged to 2.6.33 if there are no more comme

RE: Help in adding documentation

2009-11-18 Thread Karicheri, Muralidharan
Mauro, Thanks. I will use diff method, since just for this I don't have to learn yet another version control system :) Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: Mauro Car

IR Receiver on an Tevii S470

2009-11-18 Thread Matthias Fechner
Hi, I bought some days ago a Tevii S470 DVB-S2 (PCI-E) card and got it running with the driver from: http://mercurial.intuxication.org/hg/s2-liplianin But I was not successfull in got the IR receiver working. It seems that it is not supported yet by the driver. Is there maybe some code availa

[PATCH v3] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread m-karicheri2
From: Muralidharan Karicheri This is v3 of the digital video timings APIs implementation. This has updates based on comments received against v2 of the patch. Hopefully this can be merged to 2.6.33 if there are no more comments. This adds the above APIs to the v4l2 core. This is based on version

RE: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
Hans, Thanks for doing the 64-bit test. I will incorporate the below comments along with the other comments and will post v3 of the patch with you included in the sign off. Regards, Murali > >I did some quick 64-bit tests and discovered that we need to add the packed >attribute to struct v4l2_bt

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-11-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Nov 18 19:00:11 CET 2009 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 13370:7477df192a59 gcc version: gcc (

Re: Help in adding documentation

2009-11-18 Thread Mauro Carvalho Chehab
Karicheri, Muralidharan wrote: > Mauro, > > Is there specific way to create patch for this documentation? > > Can I just do following commands and send one patch? > > Baseline tree - v4l-dvb-base (original) > Changed tree - v4l-dvb-change > > diff -uNr v4l-dvb-base v4l-dvb-change >media-doc.pa

Re: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Hans Verkuil
On Wednesday 18 November 2009 20:01:43 Karicheri, Muralidharan wrote: > Hans, > > Thanks for reviewing this. I will try to send an updated patch today. > > BTW, I have posted the documentation patch to the list for review. I did some quick 64-bit tests and discovered that we need to add the pack

[PATCH 6/6] firedtv: reduce memset()s

2009-11-18 Thread Stefan Richter
Before each FCP transdaction, the entire 512 bytes of the FCP frame were cleared, then values filled in. Clear only the bytes between filled-in bytes and end of the - request frame, or - response frame if data from a larger response will be needed, or - whole frame if data from a variable le

[PATCH 5/6] firedtv: remove check for interrupting signal

2009-11-18 Thread Stefan Richter
FCP transactions as well as CMP transactions were serialized with mutex_lock_interruptible. It is extremely unlikly though that a signal will arrive while a concurrent process holds the mutex. And even if one does, the duration of a transaction is reasonably short (1.2 seconds if all retries time

[PATCH] V4L - Digital Video Timings API documentation

2009-11-18 Thread m-karicheri2
From: Muralidharan Karicheri Fixing a typo in the subject... This patch updates the v4l2-dvb documentation for the new video timings API added. Signed-off-by: Muralidharan Karicheri --- diff -uNr v4l-dvb-aba823ecaea6/linux/Documentation/DocBook/v4l/common.xml v4l-dvb-aba823ecaea6_new/linux/Do

[PATCH 4/6] firedtv: do not DMA-map stack addresses

2009-11-18 Thread Stefan Richter
This is a portability fix and reduces stack usage. The DMA mapping API cannot map on-stack addresses, as explained in Documentation/DMA-mapping.txt. Convert the two cases of on-stack packet payload buffers in firedtv (payload of write requests in avc_write and of lock requests in cmp_lock) to sla

[PATCH 3/6] firedtv: remove an unnecessary function argument

2009-11-18 Thread Stefan Richter
All read transactions initiated by firedtv are only quadlet-sized, hence the backend->read call can be simplified a little. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-1394.c |4 ++-- drivers/media/dvb/firewire/firedtv-avc.c |8 drivers/media/dvb/firewi

RE: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
Hans, Thanks for reviewing this. I will try to send an updated patch today. BTW, I have posted the documentation patch to the list for review. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Mess

[PATCH 2/6] firedtv: packet requeuing is likely to succeed

2009-11-18 Thread Stefan Richter
Packet DMA buffers are queued either initially all at once (then, a queueing failure will cause firedtv to release the DMA context as a whole) or subsequently one by one as they recycled after use (then a failure is extremely unlikely). Therefore we can be a little less cautious when counting at w

[PATCH 1/6] firedtv: shrink buffer pointer table

2009-11-18 Thread Stefan Richter
Cache only addresses of whole pages, not of each buffer chunk. Besides, page addresses can be obtained by page_address() instead of kmap() since they were allocated in lowmem. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-fw.c | 19 --- 1 file changed, 8

[PATCH 0/6] DVB: firedtv: simplifications and a portability fix

2009-11-18 Thread Stefan Richter
The following three patches are applicable after "firedtv: port to new firewire core" from 2009-11-08: [PATCH 1/6] firedtv: shrink buffer pointer table [PATCH 2/6] firedtv: packet requeuing is likely to succeed [PATCH 3/6] firedtv: remove an unnecessary function argument The rest of this patch se

Re: [PATCH] em28xx: fix for Dikom DK300 hybrid USB tuner (aka Kworld VS-DVB-T 323UR ) (digital mode)

2009-11-18 Thread andrea.amoros...@gmail.com
Devin Heitmueller ha scritto: On Mon, Nov 16, 2009 at 3:49 PM, andrea.amoros...@gmail.com wrote: The usb is the following: Bus 002 Device 010: ID eb1a:e312 eMPIA Technology, Inc. (I don't remember what it was previously, but it seems wrong how can I be sure about that?). I have put back the

[PATCH v2] V4L - Digital Video Timings API documentation

2009-11-18 Thread m-karicheri2
From: Muralidharan Karicheri This patch updates the v4l2-dvb documentation for the new video timings API added. Signed-off-by: Muralidharan Karicheri --- diff -uNr v4l-dvb-aba823ecaea6/linux/Documentation/DocBook/v4l/common.xml v4l-dvb-aba823ecaea6_new/linux/Documentation/DocBook/v4l/common.xm

[PATCH v2] V4L - Digital Video Timings API documentation

2009-11-18 Thread m-karicheri2
From: Muralidharan Karicheri This patch updates the v4l2-dvb documentation for the new video timings API added. Signed-off-by: Muralidharan Karicheri --- diff -uNr v4l-dvb-aba823ecaea6/linux/Documentation/DocBook/v4l/common.xml v4l-dvb-aba823ecaea6_new/linux/Documentation/DocBook/v4l/common.x

RE: Help in adding documentation

2009-11-18 Thread Karicheri, Muralidharan
Mauro, Is there specific way to create patch for this documentation? Can I just do following commands and send one patch? Baseline tree - v4l-dvb-base (original) Changed tree - v4l-dvb-change diff -uNr v4l-dvb-base v4l-dvb-change >media-doc.patch Murali Karicheri Software Design Engineer Texa

Re: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Hans Verkuil
On Wednesday 18 November 2009 18:03:44 m-kariche...@ti.com wrote: > From: Muralidharan Karicheri > > This is the second version of the digital video timings APIs implementation. > This adds comment from previous version. I would like to have this > merged to 2.6.33 Me too :-) > This adds the a

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Hiremath, Vaibhav
> -Original Message- > From: Karicheri, Muralidharan > Sent: Wednesday, November 18, 2009 10:36 PM > To: Hiremath, Vaibhav; linux-media@vger.kernel.org > Cc: hverk...@xs4all.nl > Subject: RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume > Support > > > > Murali Karicheri > Software

RE: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
I will be sending the patch for documentation today. FYI. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com >-Original Message- >From: Karicheri, Muralidharan >Sent: Wednesday, November 18, 2009 12:04 PM >To: linux-media@vger.

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Karicheri, Muralidharan
Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: Hiremath, Vaibhav >Sent: Wednesday, November 18, 2009 11:52 AM >To: Karicheri, Muralidharan; linux-media@vger.kernel.org >Cc: hv

[PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread m-karicheri2
From: Muralidharan Karicheri This is the second version of the digital video timings APIs implementation. This adds comment from previous version. I would like to have this merged to 2.6.33 This adds the above APIs to the v4l2 core. This is based on version v1.2 of the RFC titled "V4L - Support

Re: [PATCH 1/3] em-x270: don't use pxa_camera init() callback

2009-11-18 Thread Antonio Ospite
On Wed, 18 Nov 2009 11:10:06 +0100 (CET) Guennadi Liakhovetski wrote: > On Tue, 17 Nov 2009, Antonio Ospite wrote: > > > pxa_camera init() is going to be removed. > > My nitpick here would be - I would put it the other way round. We do not > remove .init() in platforms, because it is going to

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Hiremath, Vaibhav
> -Original Message- > From: Karicheri, Muralidharan > Sent: Wednesday, November 18, 2009 9:55 PM > To: Hiremath, Vaibhav; linux-media@vger.kernel.org > Cc: hverk...@xs4all.nl > Subject: RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume > Support > > Vaibhav, > > Just wondering how to

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Karicheri, Muralidharan
Vaibhav, Just wondering how to test this on DaVinci platforms. Could you tell what you did to test this? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: Hiremath, Vaibhav >Sent

RE: [PATCH V2] VPFE Capture: Add call back function for interrupt clear to vpfe_cfg

2009-11-18 Thread Hiremath, Vaibhav
> -Original Message- > From: Hiremath, Vaibhav > Sent: Wednesday, November 18, 2009 9:23 PM > To: linux-media@vger.kernel.org > Cc: hverk...@xs4all.nl; Karicheri, Muralidharan; Hiremath, Vaibhav > Subject: [PATCH V2] VPFE Capture: Add call back function for > interrupt clear to vpfe_cfg >

[PATCH V2] VPFE Capture: Add call back function for interrupt clear to vpfe_cfg

2009-11-18 Thread hvaibhav
From: Vaibhav Hiremath For the devices like AM3517, it is expected that driver clears the interrupt in ISR. Since this is device spcific, callback function added to the platform_data. Signed-off-by: Vaibhav Hiremath --- drivers/media/video/davinci/vpfe_capture.c | 24

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Hiremath, Vaibhav
> -Original Message- > From: Karicheri, Muralidharan > Sent: Wednesday, November 18, 2009 8:55 PM > To: Hiremath, Vaibhav; linux-media@vger.kernel.org > Cc: hverk...@xs4all.nl > Subject: RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume > Support > > Vaibhav, > > Did you validate susp

Re: Details about DVB frontend API

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 9:04 AM, Mauro Carvalho Chehab wrote: > Devin Heitmueller wrote: >> On Tue, Nov 17, 2009 at 5:53 PM, Mauro Carvalho Chehab >> wrote: >>> We shouldn't write API's thinking on some specific use case or aplication. >>> If there's a problem with zap, the fix should be there, n

Re: Details about DVB frontend API

2009-11-18 Thread Michael Krufky
On Wed, Nov 18, 2009 at 10:17 AM, Devin Heitmueller wrote: > On Wed, Nov 18, 2009 at 9:04 AM, Mauro Carvalho Chehab > wrote: >> Devin Heitmueller wrote: >>> On Tue, Nov 17, 2009 at 5:53 PM, Mauro Carvalho Chehab >>> wrote: We shouldn't write API's thinking on some specific use case or aplic

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Karicheri, Muralidharan
Vaibhav, Did you validate suspend & resume operations on AM3517? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: Hiremath, Vaibhav >Sent: Wednesday, November 18, 2009 6:35 AM >

RE: [PATCH] VPFE Capture: Add call back function for interrupt clear to vpfe_cfg

2009-11-18 Thread Hiremath, Vaibhav
> -Original Message- > From: Karicheri, Muralidharan > Sent: Wednesday, November 18, 2009 8:33 PM > To: Hiremath, Vaibhav; linux-media@vger.kernel.org > Cc: hverk...@xs4all.nl > Subject: RE: [PATCH] VPFE Capture: Add call back function for > interrupt clear to vpfe_cfg > > Vaibhav, > > I

Re: Details about DVB frontend API

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 9:04 AM, Mauro Carvalho Chehab wrote: > Devin Heitmueller wrote: >> On Tue, Nov 17, 2009 at 5:53 PM, Mauro Carvalho Chehab >> wrote: >>> We shouldn't write API's thinking on some specific use case or aplication. >>> If there's a problem with zap, the fix should be there, n

RE: [PATCH] V4L2: clear buf when vrfb buf not allocated

2009-11-18 Thread Hiremath, Vaibhav
> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Y, Kishore > Sent: Wednesday, November 18, 2009 7:20 PM > To: linux-media@vger.kernel.org > Cc: linux-o...@vger.kernel.org > Subject: [PATCH] V4L2: clear buf when vrfb

Re: new sensor for a t613 camera

2009-11-18 Thread leandro Costantino
Please, send me the patch for review :) On Tue, Nov 17, 2009 at 9:41 PM, Nicolau Werneck wrote: > Hello, people. > > I did it! I looked at the log and modified the driver to support my > webcam. It's working!! I'm sending an image attached. :] > > I'll clean up my code now, and submit a patch la

RE: [PATCH] VPFE Capture: Add call back function for interrupt clear to vpfe_cfg

2009-11-18 Thread Karicheri, Muralidharan
Vaibhav, In the interrupt handler, it is better to add something like below... The same piece of code is repeated many times... When ready to return IRQ_HANDLED goto clear_int; clear_int: if (vpfe_dev->cfg->clr_intr) vpfe_dev->cfg->clr_intr(irq); return

Re: Details about DVB frontend API

2009-11-18 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Tue, Nov 17, 2009 at 5:53 PM, Mauro Carvalho Chehab > wrote: >> We shouldn't write API's thinking on some specific use case or aplication. >> If there's a problem with zap, the fix should be there, not at the kernel. > > Your response suggests I must have poorly desc

[PATCH] V4L2: clear buf when vrfb buf not allocated

2009-11-18 Thread Y, Kishore
>From 15246e4dfa6853d9aef48a4b8633f93efe40ed81 Mon Sep 17 00:00:00 2001 From: Kishore Y Date: Thu, 12 Nov 2009 20:47:58 +0530 Subject: [PATCH] V4L2: clear buf when vrfb buf not allocated buffer memory is set to 0 only for the first time before the vrfb buffer is allocated Signed-off-by:

saa7134 (not very) new board 5168:0307

2009-11-18 Thread tomloh...@gmail.com
Hello list, looking from saa7134.h, this board 5168:0307 is not included This cars is on some asus laptop and some medion laptop It was previously working with this settings (1) card=55 tuner=54 or (2) with tuner = 86 ok, so with this settings, nothing : with card = 55 : [ 109.375445] Linux

Re: [PATCH/RFC] V4L core cleanups

2009-11-18 Thread Laurent Pinchart
Hi Sergio, On Wednesday 18 November 2009 02:31:23 Aguirre, Sergio wrote: > Laurent, > > > -Original Message- > > From: linux-media-ow...@vger.kernel.org > > [mailto:linux-media-ow...@vger.kernel.org] On Behalf Of > > Laurent Pinchart > > Sent: Tuesday, November 17, 2009 6:39 PM > > To: li

[PATCH/RFC v2] V4L core cleanups HG tree

2009-11-18 Thread Laurent Pinchart
Hi everybody, the V4L cleanup patches are now available from http://linuxtv.org/hg/~pinchartl/v4l-dvb-cleanup The tree will be rebased if needed (or rather dropped and recreated as hg doesn't provide a rebase operation), so please don't pull from it yet if you don't want to have to throw the p

Re: v4l: Add video_device_node_name function

2009-11-18 Thread Laurent Pinchart
Hi Hans, On Wednesday 18 November 2009 08:06:22 Hans Verkuil wrote: > On Wednesday 18 November 2009 01:38:42 Laurent Pinchart wrote: > > Many drivers access the device number (video_device::v4l2_devnode::num) > > in order to print the video device node name. Add and use a helper > > function to re

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
Hi Devin, On Wednesday 18 November 2009 10:36:45 Devin Heitmueller wrote: > On Wed, Nov 18, 2009 at 4:13 AM, Hans Verkuil wrote: > > I agree that it would help to split this patch up. Some cases are > > trivial, so they can be put together in one patch. When things get more > > complex it makes s

Re: New DibCom based ISDB-T device

2009-11-18 Thread Mauro Carvalho Chehab
Patrick Boettcher wrote: > Hi Mauro, > > On Tue, 17 Nov 2009, Mauro Carvalho Chehab wrote: > >> Hi Patrick, >> >> A friend of mine got a Geniatech S870 ISDB-T card. According to him, >> this device is based >> on stk8090 chipset and wants to use it in Brazil. >> >> The board has the following USB

[PATCH] VPFE Capture: Add call back function for interrupt clear to vpfe_cfg

2009-11-18 Thread hvaibhav
From: Vaibhav Hiremath For the devices like AM3517, it is expected that driver clears the interrupt in ISR. Since this is device spcific, callback function added to the platform_data. Signed-off-by: Vaibhav Hiremath --- drivers/media/video/davinci/vpfe_capture.c | 26

[PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread hvaibhav
From: Vaibhav Hiremath Validated on AM3517 Platform. Signed-off-by: Vaibhav Hiremath --- drivers/media/video/davinci/ccdc_hw_device.h |4 + drivers/media/video/davinci/dm644x_ccdc.c| 87 ++ drivers/media/video/davinci/vpfe_capture.c | 29 ++--- 3 files

Re: [PATCH 2/3] pcm990-baseboard: don't use pxa_camera init() callback

2009-11-18 Thread Juergen Beisert
On Mittwoch, 18. November 2009, Guennadi Liakhovetski wrote: > On Tue, 17 Nov 2009, Antonio Ospite wrote: > > pxa_camera init() is going to be removed. > > Configure PXA CIF pins directly in machine init function. > > Same comment as to patch 1/3. > > > Signed-off-by: Antonio Ospite > > Even thoug

Re: New DibCom based ISDB-T device

2009-11-18 Thread Patrick Boettcher
Hi Mauro, On Tue, 17 Nov 2009, Mauro Carvalho Chehab wrote: Hi Patrick, A friend of mine got a Geniatech S870 ISDB-T card. According to him, this device is based on stk8090 chipset and wants to use it in Brazil. The board has the following USB ID: Bus 002 Device 002: ID 10b8:1fa0 Di

Re: [PATCH 2/3] pcm990-baseboard: don't use pxa_camera init() callback

2009-11-18 Thread Guennadi Liakhovetski
On Tue, 17 Nov 2009, Antonio Ospite wrote: > pxa_camera init() is going to be removed. > Configure PXA CIF pins directly in machine init function. Same comment as to patch 1/3. > > Signed-off-by: Antonio Ospite Even though the change seems obvious, it better be tested - in case someone recon

Re: [PATCH 1/3] em-x270: don't use pxa_camera init() callback

2009-11-18 Thread Guennadi Liakhovetski
On Tue, 17 Nov 2009, Antonio Ospite wrote: > pxa_camera init() is going to be removed. My nitpick here would be - I would put it the other way round. We do not remove .init() in platforms, because it is going to be removed, but rather we perform initialisation statically, because we think this

Re: (Saa7134) Re: ADS-Tech Instant TV PCI, no remote support, giving up.

2009-11-18 Thread Morvan Le Meut
Hello, just a little update ( even if nobody seems to be interested :p ) : I've been using this configuration for a while, and because i tend to forget to reinstall that patch for each kernel update, i found out some strange things. First, very rarely ( it must have happened three times at most

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 4:42 AM, Laurent Pinchart wrote: > I will setup a test tree to help maintainers test the changes. I can split > some patches if needed, but how would that help exactly ? Hello Laurent, In this case, splitting up the patch would just make it easier to review, and potential

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
On Wednesday 18 November 2009 10:13:30 Hans Verkuil wrote: > > On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: > >> Very nice cleanup! > > > > The last time I saw one of these relatively innocent-looking changes > > being done across all drivers without testing, it introduced a rather > > nas

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
Hi Devin, On Wednesday 18 November 2009 09:56:12 Devin Heitmueller wrote: > On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: > > Very nice cleanup! > > The last time I saw one of these relatively innocent-looking changes > being done across all drivers without testing, it introduced a rather

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 4:13 AM, Hans Verkuil wrote: > I agree that it would help to split this patch up. Some cases are trivial, > so they can be put together in one patch. When things get more complex it > makes sense to put it in a separate patch for easier reviewing by the > relevant maintaine

Re: Details about DVB frontend API

2009-11-18 Thread Devin Heitmueller
On Tue, Nov 17, 2009 at 5:53 PM, Mauro Carvalho Chehab wrote: > We shouldn't write API's thinking on some specific use case or aplication. > If there's a problem with zap, the fix should be there, not at the kernel. Your response suggests I must have poorly described the problem. Zap is just one

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
On Wednesday 18 November 2009 08:01:48 Hans Verkuil wrote: > On Wednesday 18 November 2009 01:38:48 Laurent Pinchart wrote: > > Fix all device drivers to use the video_drvdata function instead of > > maintaining a local list of minor to private data mappings. Call > > video_set_drvdata to register

Re: v4l: Use the new video_device_node_name function

2009-11-18 Thread Laurent Pinchart
Hi Hans, On Wednesday 18 November 2009 07:29:40 Hans Verkuil wrote: > On Wednesday 18 November 2009 01:38:43 Laurent Pinchart wrote: > > Fix all device drivers to use the new video_device_node_name function. > > > > Signed-off-by: Laurent Pinchart > > Using video_device_node_name() is a great im

Re: Driver for NXP SAA7154

2009-11-18 Thread Hans Verkuil
> Hi Hans > > Thank you for your reply! > > On Wed, 18 Nov 2009 09:20:53 +0100 > "Hans Verkuil" wrote: >> > I wonder if there is work in progress for a Linux driver supporting >> > the NXP SAA7154 Multistandard video decoder with comb filter, > [..] >> > Datasheet: >> > http://www.nxp.com/documen

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Hans Verkuil
> On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: >> Very nice cleanup! > > The last time I saw one of these relatively innocent-looking changes > being done across all drivers without testing, it introduced a rather > nasty and hard to find OOPS into one of my drivers and I had to fix > it:

Re: Driver for NXP SAA7154

2009-11-18 Thread Andreas Feuersinger
Hi Hans Thank you for your reply! On Wed, 18 Nov 2009 09:20:53 +0100 "Hans Verkuil" wrote: > > I wonder if there is work in progress for a Linux driver supporting > > the NXP SAA7154 Multistandard video decoder with comb filter, [..] > > Datasheet: > > http://www.nxp.com/documents/data_sheet/SAA

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: > Very nice cleanup! The last time I saw one of these relatively innocent-looking changes being done across all drivers without testing, it introduced a rather nasty and hard to find OOPS into one of my drivers and I had to fix it: http://linu

Re: Driver for NXP SAA7154

2009-11-18 Thread Hans Verkuil
Hi Andreas, > > Hi, > > I wonder if there is work in progress for a Linux driver supporting > the NXP SAA7154 Multistandard video decoder with comb filter, component > input and RGB output chip. The chip provides some improvements of the > SAA7119 chip which is (partially?) supported by the kernel