[PATCH 6/14] drivers/media/video: Move dereference after NULL test

2009-10-16 Thread Julia Lawall
From: Julia Lawall In quickcam_messenger.c, if the NULL test on uvd is needed, then the dereference should be after the NULL test. In vpif_display.c, std_info is initialized to the address of a structure field. This seems unlikely to be NULL. If it could somehow be NULL, then the assignment sh

Re: Leadtek PVR2100 / DVR3100 Experience

2009-10-16 Thread Andy Walls
On Fri, 2009-10-16 at 15:05 +0100, David Nicol wrote: > Hi, > > Could anyone give first hand experience of the stability of the Leadtek > PVR2100 and/or the DVR3100 cards? > > Does analog capture work well in both cards over a prolonged period of > uptime? > > Any known issues with either card?

Re: tuner type

2009-10-16 Thread hermann pitton
Hi Dirk, Am Freitag, den 16.10.2009, 10:32 +0200 schrieb aval...@web.de: > Thanks alot, Herman. > What does ctx mean? I use opensuse 11.0. you will find the CTX (Creatix) revision and version printed on the board and also on a sticker on the card, mostly at the modem or ISDN part. With that infor

Re: New member, trying to setup a Pinnacle Quatro stick

2009-10-16 Thread Devin Heitmueller
On Fri, Oct 16, 2009 at 5:45 PM, ps1 wrote: > Hi, > > I recenly own a Pinnacle (or Pctv now) Quatro Stick (also known as  510e) > The product is a small USB stick, able to receive Analog TV, DVB-T TV, > Analog Radio and also DVB-C TV (That is, cable TV). > > The product is running under windows (e

Re: em28xx DVB modeswitching change: call for testers

2009-10-16 Thread xwang1976
Hi Devin, I've tested my Empire Dual TV. These are the results: 1) it is recognized as a different card (as you can see from the dmesg 2) it works perfectly in digital mode (even if itdetects less channel than the Dikom DK-300 (aka Kworld 323U?). It scans and tune channels and they can be seen a

New member, trying to setup a Pinnacle Quatro stick

2009-10-16 Thread ps1
Hi, I recenly own a Pinnacle (or Pctv now) Quatro Stick (also known as 510e) The product is a small USB stick, able to receive Analog TV, DVB-T TV, Analog Radio and also DVB-C TV (That is, cable TV). The product is running under windows (even if I'm not so impressed by the analog TV receptio

Re: [RFC] Video events, version 2.1

2009-10-16 Thread Hans Verkuil
On Friday 16 October 2009 15:39:44 Sakari Ailus wrote: > Hi, > > > Here's the version 2.1 of the video events RFC. It's based on Laurent > Pinchart's original RFC and version 2 which I wrote some time ago. This > time the changes are done based on discussion on the list. The old RFC > is available

Re: [PATCH 1/4] V4L2: Added New V4L2 CIDs VIDIOC_S/G_COLOR_SPACE_CONV

2009-10-16 Thread Hans Verkuil
On Friday 16 October 2009 14:26:52 Laurent Pinchart wrote: > Hi, > > On Friday 16 October 2009 12:19:20 hvaib...@ti.com wrote: > > From: Vaibhav Hiremath > > > > > > Signed-off-by: Vaibhav Hiremath > > --- > > drivers/media/video/v4l2-ioctl.c | 19 +++ > > include/linux/videode

Re: DVB-T scan file

2009-10-16 Thread Christoph Pfister
2009/10/15 Alex Ferrara : > I would like to contribute a DVB-T scan file for the transmitter at Goulburn > NSW Australia. > > Who is responsible for this? me > aF Christoph -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel

Re: Possible bug on libv4l read() emulation

2009-10-16 Thread Pablo Baena
I think I identified the problem, I used code extracted from: http://www.saillard.org/linux/pwc/files/capture.c, and the code was like: total_read_bytes = 0; do { read_bytes = read(fd, buffers[0].start, buffers[0].length); if (read_bytes < 0)

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-10-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Fri Oct 16 19:00:03 CEST 2009 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 13101:3919b17dc88e gcc version: gcc

Re: Possible bug on libv4l read() emulation

2009-10-16 Thread Hans de Goede
Hi, On 10/16/2009 12:00 AM, Pablo Baena wrote: I have a program where I use libv4l's read() emulation for simplicity. But with most v4l2 webcams I've tried, I get kernel panics. I have pics of the message if anyone cares to see them, I don't want to flood the mailing list. Basically, the names

Re: Bug in HVR1300. Found part of a patch, if reverted bug seems to be gone

2009-10-16 Thread Steven Toth
> there seems to be a bug in cx88 (HVR1300) that is responsible for not > switching channels, and not being able to scan. > Complete description can be found on launchpad: Noted. Thanks -- Steven Toth - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsub

Bug in HVR1300. Found part of a patch, if reverted bug seems to be gone

2009-10-16 Thread Frank Sagurna
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi list, there seems to be a bug in cx88 (HVR1300) that is responsible for not switching channels, and not being able to scan. Complete description can be found on launchpad: https://bugs.launchpad.net/mythtv/+bug/439163 (starting from comment #16)

Re: [PATCH v1 1/4] DM365 Platform support for VPFE

2009-10-16 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > I would like to wait on this one and re-submit a revised > patch. There is a plan to use sub device model for ccdc driver. So I > will re-submit the ccdc drivers with this change as well as the > corresponding platform code. Murali, OK, thanks for the update,

RE: [Resubmition PATCH] Davinci VPFE Capture: Take i2c adapter id through platform data

2009-10-16 Thread Karicheri, Muralidharan
Vaibhav, Thanks for the patch. See my comment below. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: davinci-linux-open-source-boun...@linux.davincidsp.com >[mailto:davinci-lin

RE: [PATCH v1 1/4] DM365 Platform support for VPFE

2009-10-16 Thread Karicheri, Muralidharan
Kevin, I would like to wait on this one and re-submit a revised patch. There is a plan to use sub device model for ccdc driver. So I will re-submit the ccdc drivers with this change as well as the corresponding platform code. Murali Karicheri Software Design Engineer Texas Instruments Inc. Ger

Re: Status of CX25821 PCI-E capture driver

2009-10-16 Thread Aleksandr V. Piskunov
On Fri, Oct 16, 2009 at 10:25:53AM -0400, Steven Toth wrote: > On Fri, Oct 16, 2009 at 8:46 AM, Donald Bailey wrote: > > I recently picked up a 16 port DVR card from China which uses two CX25821 > > chips.  I compiled the staging driver for it and was able to load it > > successfully with kernel 2

Re: [RFC] Video events, version 2.1

2009-10-16 Thread Michael Krufky
Let's please just use either my @linuxtv.org or @kernellabs.com email account for this... Thanks, Mike Sakari Ailus wrote: Hi, Here's the version 2.1 of the video events RFC. It's based on Laurent Pinchart's original RFC and version 2 which I wrote some time ago. This time the changes are

RE: [PATCH 1/6] Davinci VPFE Capture: Specify device pointer in videobuf_queue_dma_contig_init

2009-10-16 Thread Karicheri, Muralidharan
Acked-by Muralidharan Karicheri Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com >-Original Message- >From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >ow...@vger.kernel.org] On Behalf Of Hiremath, Vaibhav >Sent:

Re: Status of CX25821 PCI-E capture driver

2009-10-16 Thread Steven Toth
On Fri, Oct 16, 2009 at 8:46 AM, Donald Bailey wrote: > I recently picked up a 16 port DVR card from China which uses two CX25821 > chips.  I compiled the staging driver for it and was able to load it > successfully with kernel 2.6.32-rc2.  But I can't find any /dev devices to > get at the inputs.

RE: [PATCH 5/6] Davinci VPFE Capture: Add support for Control ioctls

2009-10-16 Thread Karicheri, Muralidharan
Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >ow...@vger.kernel.org] On Behalf Of Hiremath, Vaibhav >Sent: Tuesday, Oc

RE: [PATCH 4/6] Davinci VPFE Capture:Replaced IRQ_VDINT1 with vpfe_dev->ccdc_irq1

2009-10-16 Thread Karicheri, Muralidharan
Acked-by : Muralidharan Karicheri Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >ow...@vger.kernel.org] On Behalf Of Hi

Leadtek PVR2100 / DVR3100 Experience

2009-10-16 Thread David Nicol
Hi, Could anyone give first hand experience of the stability of the Leadtek PVR2100 and/or the DVR3100 cards? Does analog capture work well in both cards over a prolonged period of uptime? Any known issues with either card? Thanks in advance for any information. David Nicol -- To unsubscribe

[RFC] Video events, version 2.1

2009-10-16 Thread Sakari Ailus
Hi, Here's the version 2.1 of the video events RFC. It's based on Laurent Pinchart's original RFC and version 2 which I wrote some time ago. This time the changes are done based on discussion on the list. The old RFC is available here: http://www.spinics.net/lists/linux-media/msg10971.html>

Status of CX25821 PCI-E capture driver

2009-10-16 Thread Donald Bailey
I recently picked up a 16 port DVR card from China which uses two CX25821 chips. I compiled the staging driver for it and was able to load it successfully with kernel 2.6.32-rc2. But I can't find any /dev devices to get at the inputs. I created a character device with a major/minor of 81/0 b

Re: [RFC] Video events, version 2

2009-10-16 Thread Sakari Ailus
Laurent Pinchart wrote: That's not what I meant. The idea of a count field is to report the number of events still pending after that one, type aside. If v4l2_event::count equals 0 the userspace application will know there is no need to call VIDIOC_G_EVENT just to get a -EAGAIN. Thanks for t

Re: [RFC] Video events, version 2

2009-10-16 Thread Laurent Pinchart
On Friday 16 October 2009 14:34:28 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Friday 16 October 2009 09:36:51 Sakari Ailus wrote: > >> Hans Verkuil wrote: > >>> On Thursday 15 October 2009 23:11:33 Laurent Pinchart wrote: > For efficiency reasons a V4L2_G_EVENTS ioctl could also be p

Re: [RFC] Video events, version 2

2009-10-16 Thread Sakari Ailus
Laurent Pinchart wrote: On Friday 16 October 2009 09:36:51 Sakari Ailus wrote: Hans Verkuil wrote: On Thursday 15 October 2009 23:11:33 Laurent Pinchart wrote: For efficiency reasons a V4L2_G_EVENTS ioctl could also be provided to retrieve multiple events. struct v4l2_events { __u32 c

Re: [PATCH 2/4] V4L2: Added CID's V4L2_CID_ROTATE/BG_COLOR

2009-10-16 Thread Laurent Pinchart
Hi, On Friday 16 October 2009 12:20:03 hvaib...@ti.com wrote: > From: Vaibhav Hiremath Please include a documentation patch for the new controls. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.k

Re: [PATCH 1/4] V4L2: Added New V4L2 CIDs VIDIOC_S/G_COLOR_SPACE_CONV

2009-10-16 Thread Laurent Pinchart
Hi, On Friday 16 October 2009 12:19:20 hvaib...@ti.com wrote: > From: Vaibhav Hiremath > > > Signed-off-by: Vaibhav Hiremath > --- > drivers/media/video/v4l2-ioctl.c | 19 +++ > include/linux/videodev2.h| 14 ++ > include/media/v4l2-ioctl.h |4

RE: [Resubmition PATCH] Davinci VPFE Capture: Take i2c adapter id through platform data

2009-10-16 Thread Hiremath, Vaibhav
> -Original Message- > From: Hiremath, Vaibhav > Sent: Friday, October 16, 2009 3:57 PM > To: linux-media@vger.kernel.org > Cc: davinci-linux-open-sou...@linux.davincidsp.com; Hiremath, > Vaibhav > Subject: [Resubmition PATCH] Davinci VPFE Capture: Take i2c adapter > id through platform dat

[Resubmition PATCH] Davinci VPFE Capture: Take i2c adapter id through platform data

2009-10-16 Thread hvaibhav
From: Vaibhav Hiremath The I2C adapter ID is actually depends on Board and may vary, Davinci uses id=1, but in case of AM3517 id=3. Changes: - Fixed review comments (Typo) from Sergei Signed-off-by: Vaibhav Hiremath --- drivers/media/video/davinci/vpfe_capture.c |3 +-- include/me

[PATCH 3/4] V4L2: Add Capability and Flag field for Croma Key

2009-10-16 Thread hvaibhav
From: Vaibhav Hiremath Signed-off-by: Vaibhav Hiremath --- include/linux/videodev2.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index d77db6f..adff8d9 100644 --- a/include/linux/videodev2.h +++ b/include/linux

[PATCH 2/4] V4L2: Added CID's V4L2_CID_ROTATE/BG_COLOR

2009-10-16 Thread hvaibhav
From: Vaibhav Hiremath Signed-off-by: Vaibhav Hiremath --- drivers/media/video/v4l2-common.c |9 + include/linux/videodev2.h |4 +++- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/v4l2-common.c b/drivers/media/video/v4l2-common.c in

[PATCH 1/4] V4L2: Added New V4L2 CIDs VIDIOC_S/G_COLOR_SPACE_CONV

2009-10-16 Thread hvaibhav
From: Vaibhav Hiremath Signed-off-by: Vaibhav Hiremath --- drivers/media/video/v4l2-ioctl.c | 19 +++ include/linux/videodev2.h| 14 ++ include/media/v4l2-ioctl.h |4 3 files changed, 37 insertions(+), 0 deletions(-) diff --git a/drivers/

Re: [RFC] Video events, version 2

2009-10-16 Thread Laurent Pinchart
On Friday 16 October 2009 10:55:04 Sakari Ailus wrote: > Hans Verkuil wrote: > [clip] > > > I'm not keen on using pointers insides structures unless there is a very > > good reason to do so. In practice it complicates the driver code > > substantially due to all the kernel-to-userspace copies that

Re: [RFC] Video events, version 2

2009-10-16 Thread Sakari Ailus
Hans Verkuil wrote: [clip] I'm not keen on using pointers insides structures unless there is a very good reason to do so. In practice it complicates the driver code substantially due to all the kernel-to-userspace copies that need to be done that are normally handled by video_ioctl2. In addition

Re: [RFC] Video events, version 2

2009-10-16 Thread Hans Verkuil
> Hans Verkuil wrote: >> On Thursday 15 October 2009 23:11:33 Laurent Pinchart wrote: >>> Hi Sakari, >>> >>> On Wednesday 14 October 2009 19:48:33 Hans Verkuil wrote: On Wednesday 14 October 2009 15:02:14 Sakari Ailus wrote: > Here's the second version of the video events RFC. It's based

Re: [RFC] Video events, version 2

2009-10-16 Thread Laurent Pinchart
On Friday 16 October 2009 09:36:51 Sakari Ailus wrote: > Hans Verkuil wrote: > > On Thursday 15 October 2009 23:11:33 Laurent Pinchart wrote: > >> Hi Sakari, > >> > >> On Wednesday 14 October 2009 19:48:33 Hans Verkuil wrote: > >>> On Wednesday 14 October 2009 15:02:14 Sakari Ailus wrote: > He

Re: [RFC] Video events, version 2

2009-10-16 Thread Sakari Ailus
Hans Verkuil wrote: On Thursday 15 October 2009 23:11:33 Laurent Pinchart wrote: Hi Sakari, On Wednesday 14 October 2009 19:48:33 Hans Verkuil wrote: On Wednesday 14 October 2009 15:02:14 Sakari Ailus wrote: Here's the second version of the video events RFC. It's based on Laurent Pinchart's o