Re: [PATCH kselftest v3 1/3] selftests: vDSO: unconditionally build chacha test

2024-10-08 Thread Shuah Khan
On 10/7/24 15:45, Jason A. Donenfeld wrote: Rather than using symlinks to find the vgetrandom-chacha.S file for each arch, store this in a file that uses the compiler to determine architecture, and then make use of weak symbols to skip the test on architectures that don't provide the code. Signe

Re: [PATCH v4] Kunit to check the longest symbol length

2024-10-07 Thread Shuah Khan
On 9/24/24 11:23, Sergio González Collado wrote: The longest length of a symbol (KSYM_NAME_LEN) was increased to 512 in the reference [1]. This patch adds a kunit test to check the longest symbol length. This test can also help other efforts for longer symbol lenght, Spelling - length Can you

Re: [PATCH kselftest v2 4/4] selftests: vDSO: unconditionally build chacha test

2024-10-07 Thread Shuah Khan
On 10/5/24 22:40, Jason A. Donenfeld wrote: Rather than using symlinks to find the vgetrandom-chacha.S file for each arch, store this in a file that uses the compiler to determine architecture, and then make use of weak symbols to skip the test on architectures that don't provide the code. Signe

Re: [PATCH v5 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-10-02 Thread Shuah Khan
On 9/30/24 16:40, Yifei Liu wrote: step_after_suspend_test fails with device busy error while writing to /sys/power/state to start suspend. The test believes it failed to enter suspend state with $ sudo ./step_after_suspend_test TAP version 13 Bail out! Failed to enter Suspend state However, in

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-10-03 Thread Shuah Khan
On 9/23/24 20:57, Yu Liao wrote: Hi, On 2024/9/23 23:30, Shuah Khan wrote: On 9/20/24 09:31, Jason A. Donenfeld wrote: Indeed probably is what's wanted here. Yu Liao, Please send v2 as per the review comments. CLONE_NEWTIME was introduced in glibc-2.36, which was released in August

Re: [PATCH kselftest 0/3] getrandom & chacha cleanups

2024-10-03 Thread Shuah Khan
issed your point here. Nonetheless, maybe this moves things forward a bit. Jason Cc: Shuah Khan Cc: Greg KH Jason A. Donenfeld (3): selftests: vDSO: condition chacha build on chacha implementation selftests: vDSO: unconditionally build getrandom test selftests: vDSO: improve getrando

Re: [PATCH] selftests: Add kselftest framework to the testfile

2024-10-24 Thread Shuah Khan
On 10/24/24 10:55, Shivam Chaudhary wrote: This patch updates the existing test that checks for `open(O_TMPFILE)` and `linkat()` behaviors in mount namespaces to use the kselftest framework. This includes the following changes: - Replaced direct error handling with `ksft_test_result_*` macros

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Shuah Khan
nit_test_suites(&int_sqrt_test_suite); + +MODULE_DESCRIPTION("math.int_sqrt KUnit test suite"); +MODULE_LICENSE("GPL"); Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] Add Selftest to test fork() syscall

2024-10-23 Thread Shuah Khan
On 10/23/24 15:11, Shivam Chaudhary wrote: On 24/10/24 2:15 AM, Shuah Khan wrote: On 10/22/24 14:42, Shivam Chaudhary wrote: This test verifies the correct behavior of the fork() system call, which creates a child process by duplicating the parent process. The test checks the following

Re: [PATCH] Add Selftest to test fork() syscall

2024-10-23 Thread Shuah Khan
On 10/22/24 14:42, Shivam Chaudhary wrote: This test verifies the correct behavior of the fork() system call, which creates a child process by duplicating the parent process. The test checks the following: - The child PID returned by fork() is present in /proc. - The child PID is different from

Re: [PATCH net-next 4/8] selftests: net: lib: Move logging from forwarding/lib.sh here

2024-10-23 Thread Shuah Khan
ommon and to namespace conflicts in the future. Signed-off-by: Petr Machata Reviewed-by: Amit Cohen --- CC: Shuah Khan Acked-by: Shuah Khan for all patches 4/8 through 8/8 I have been cc'ed on. thanks, -- Shuah

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Shuah Khan
On 10/31/24 18:39, Andrew Morton wrote: On Thu, 31 Oct 2024 11:50:16 -0600 Shuah Khan wrote: On 10/30/24 07:43, Luis Felipe Hernandez wrote: Adds test suite for integer based square root function. The test suite is designed to verify the correctness of the int_sqrt() math library function

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-23 Thread Shuah Khan
On 9/20/24 09:31, Jason A. Donenfeld wrote: Indeed probably is what's wanted here. Yu Liao, Please send v2 as per the review comments. Shuah - I was taking patches for this code during the 6.12 development cycle, because it all interacted with the dev work I was doing. But I think that's di

Re: [External] : Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use time passed to check if suspend succeed

2024-09-23 Thread Shuah Khan
On 9/20/24 11:52, Yifei Liu wrote: Hi Shuah, On Sep 20, 2024, at 8:07 AM, Shuah Khan wrote: On 9/19/24 17:09, Yifei Liu wrote: Hi Shuah, On Sep 19, 2024, at 11:36 AM, Shuah Khan wrote: On 9/17/24 16:48, Yifei Liu wrote: We recently notice that the step_after_suspend_test would fail on

Re: [External] : Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-23 Thread Shuah Khan
On 9/23/24 15:18, Yifei Liu wrote: On Sep 23, 2024, at 1:56 PM, Shuah Khan wrote: On 9/23/24 14:47, Yifei Liu wrote: We recently notice that the step_after_suspend_test would noticed How about change this to find? Either is fine - it would found instead of find - or you could write it

Re: [PATCH 2/2] unicode: kunit: change tests filename and path

2024-09-23 Thread Shuah Khan
s good to me. Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-23 Thread Shuah Khan
On 9/23/24 14:47, Yifei Liu wrote: We recently notice that the step_after_suspend_test would noticed fail on our plenty devices. The test believesit failed to "several of our devices" believes it enter suspend state with Please do fix the above as pointed out earlier on v1. $ sudo ./

Re: [PATCH 1/2] unicode: kunit: refactor selftest to kunit tests

2024-09-23 Thread Shuah Khan
On 9/23/24 11:34, Gabriela Bittencourt wrote: Instead of creating 'test' functions, use kunit functions to test utf-8 support in unicode subsystem. Can you elaborate on the reefactoring changes. This will help others who would want to take on such refactoring in the future. Co-developed-by:

Re: [External] : Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use time passed to check if suspend succeed

2024-09-20 Thread Shuah Khan
On 9/19/24 17:09, Yifei Liu wrote: Hi Shuah, On Sep 19, 2024, at 11:36 AM, Shuah Khan wrote: On 9/17/24 16:48, Yifei Liu wrote: We recently notice that the step_after_suspend_test would fail on our plenty devices. The test believesit failed to What are "plenty devices" recent

Re: [PATCH v3 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-30 Thread Shuah Khan
On 9/23/24 16:50, Yifei Liu wrote: "step_after_suspend_test fails with device busy error while writing to /sys/power/state to start suspend." The test believes it failed to enter suspend state with $ sudo ./step_after_suspend_test TAP version 13 Bail out! Failed to enter Suspend state However,

Re: [PATCH] selftests: vDSO: align getrandom states to cache line

2024-10-01 Thread Shuah Khan
On 9/28/24 20:55, Jason A. Donenfeld wrote: This prevents false sharing, which makes a large difference on machines with several NUMA nodes, such as on a dual socket Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, where the "bench-multi" test goes from 2.7s down to 1.9s. While this is just test code, i

Re: [PATCH] selftests/proc/proc-empty-vm.c: Test for unmapped process

2024-09-30 Thread Shuah Khan
On 9/30/24 10:09, Siddharth Menon wrote: Check if VMsize is 0 to determine whether the process has been unmapped. The child process cannot signal the parent that it has unmapped itself, as it no longer exists. This includes unmapping the text segment, preventing the child from proceeding to the n

Re: [PATCH v4 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-30 Thread Shuah Khan
On 9/30/24 16:13, Shuah Khan wrote: On 9/30/24 14:36, Yifei Liu wrote: "step_after_suspend_test fails with device busy error while You don't need quotes writing to /sys/power/state to start suspend." Same here. The test believes it failed to enter suspend sta

Re: [PATCH v4 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-30 Thread Shuah Khan
On 9/30/24 14:36, Yifei Liu wrote: "step_after_suspend_test fails with device busy error while writing to /sys/power/state to start suspend." The test believes it failed to enter suspend state with $ sudo ./step_after_suspend_test TAP version 13 Bail out! Failed to enter Suspend state However,

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-19 Thread Shuah Khan
On 9/19/24 05:18, Yu Liao wrote: When building selftests/vDSO: $ make -C tools/testing/selftests TARGETS=vDSO I hit the following compilation error: vdso_test_getrandom.c:260:17: error: 'CLONE_NEWTIME' undeclared (first use in this function); did you mean 'CLONE_NEWIPC'? 260 | assert

Re: [PATCH] selftests: timers: Fix clock_adjtime for newer 32-bit arches

2024-09-19 Thread Shuah Khan
On 9/18/24 02:58, John Stultz wrote: On Wed, Sep 18, 2024 at 2:47 AM Khem Raj wrote: Newer 32-bit architectures e.g. riscv32 are using 64-bit time_t from get go, they have not wired __NR_clock_adjtime at all valid-adjtimex testcase fails to compile on such architectures. if this condition is f

Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use time passed to check if suspend succeed

2024-09-19 Thread Shuah Khan
On 9/17/24 16:48, Yifei Liu wrote: We recently notice that the step_after_suspend_test would fail on our plenty devices. The test believesit failed to What are "plenty devices" recently noticed? Typo - believesit? enter suspend state with $ sudo ./step_after_suspend_test TAP version 13 Bai

Re: [PATCH] selftests/mm: Define PKEY_UNRESTRICTED for pkey_sighandler_tests

2024-11-07 Thread Shuah Khan
On 11/7/24 06:16, Kevin Brodsky wrote: Commit 6e182dc9f268 ("selftests/mm: Use generic pkey register manipulation") makes use of PKEY_UNRESTRICTED in pkey_sighandler_tests. The macro has been proposed for addition to uapi headers [1], but the patch hasn't landed yet. Define PKEY_UNRESTRICTED in

Re: [PATCH] selftests/mm: Define PKEY_UNRESTRICTED for pkey_sighandler_tests

2024-11-07 Thread Shuah Khan
On 11/7/24 11:00, Catalin Marinas wrote: On Thu, Nov 07, 2024 at 09:50:20AM -0700, Shuah Khan wrote: On 11/7/24 06:16, Kevin Brodsky wrote: Commit 6e182dc9f268 ("selftests/mm: Use generic pkey register manipulation") makes use of PKEY_UNRESTRICTED in pkey_sighandler_tests. The macr

Re: [RFC v2] MAINTAINERS: split kselftest entry into 'framework' and 'all'

2024-11-18 Thread Shuah Khan
On 11/15/24 13:09, Jakub Kicinski wrote: The testing effort is increasing throughout the community. The tests are generally merged into the subsystem trees, and are of relatively narrow interest. The patch volume on linux-kselftest@vger.kernel.org makes it hard to follow the changes to the framew

Re: [brauner-github:vfs.all 205/231] WARNING: modpost: vmlinux: section mismatch in reference: initramfs_test_cases+0x0 (section: .data) -> initramfs_test_extract (section: .init.text)

2025-03-05 Thread Shuah Khan
On 3/5/25 05:56, David Disseldorp wrote: On Wed, 5 Mar 2025 11:47:01 +1100, David Disseldorp wrote: [cc'ing linux-kselftest and kunit-dev] + Adding David and Brendan David, Brendan, Any thoughts on how this can be fixed? Hi, On Wed, 5 Mar 2025 01:47:55 +0800, kernel test robot wrote: t

<    1   2   3   4   5