Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest

2024-02-27 Thread Shuah Khan
On 2/26/24 02:28, Maciej Wieczor-Retman wrote: Hi Shuah, On 2024-02-23 at 15:37:11 -0700, Shuah Khan wrote: Hi Reinette, Okay ran a quick test. Why does this test leave "/sys/fs/resctrl" mounted when it exits. Can we fix this to unmount before the test exits? I also wasn

Re: [PATCH v2 0/4] Improvements to livepatch kselftests on top of kselftest-next

2024-02-27 Thread Shuah Khan
On 2/21/24 10:17, Marcos Paulo de Souza wrote: The changes on lib.mk are both for simplification and also clarification, like in the case of not handling TEST_GEN_MODS_DIR directly. There is a new patch to solve one issue reported by build bot. These changes apply on top of the current kselftest

Re: kselftest/next kselftest-livepatch: 1 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f)

2024-02-28 Thread Shuah Khan
On 2/28/24 00:21, kernelci.org bot wrote: kselftest/next kselftest-livepatch: 1 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f) Regressions Summary --- platform| arch | lab | compiler | defconfig | regressions +--+--

Re: [PATCH v5] kselftest: Add basic test for probing the rust sample modules

2024-03-04 Thread Shuah Khan
On 3/1/24 09:28, Miguel Ojeda wrote: On Fri, Mar 1, 2024 at 4:22 PM Laura Nao wrote: Adding --first-time (you meant --first-time, right?) definitely makes sense, thanks for the pointer. I think having the modules being built-in should be treated as a skip, same as when they are not there at al

[GIT PULL] KUnit next update for Linux 6.9-rc1

2024-03-06 Thread Shuah Khan
Hi Linus, Please pull the following KUnit next update for Linux 6.8-rc1. This KUnit next update for Linux 6.9-rc1 consists of: -- fix to make kunit_bus_type const -- kunit tool change to Print UML command -- DRM device creation helpers are now using the new kunit device creation helpers. T

Re: [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output

2024-03-26 Thread Shuah Khan
On 3/26/24 10:08, Steven Rostedt wrote: Shuah, If Masami is OK with this, can you take this through your tree? Acked-by: Steven Rostedt (Google) -- Steve Yes. Will do once Masami gives me the okay. On Mon, 25 Mar 2024 16:15:49 + Mark Brown wrote: This series aims to improve the

Re: [PATCH v3] kselftest/clone3: Make test names for set_tid test stable

2024-03-26 Thread Shuah Khan
On 3/25/24 08:29, Mark Brown wrote: The test results reported for the clone3_set_tid tests interact poorly with automation for running kselftest since the reported test names include TIDs dynamically allocated at runtime. A lot of automation for running kselftest will compare runs by looking at t

Re: [PATCH] selftests/ftrace: Fix event filter target_func selection

2024-03-26 Thread Shuah Khan
On 3/20/24 18:09, Masami Hiramatsu (Google) wrote: On Wed, 20 Mar 2024 14:18:44 + Mark Rutland wrote: The event filter function test has been failing in our internal test farm: | # not ok 33 event filter function - test event filtering on functions Running the test in verbose mode indica

Re: [PATCH] selftests/harness: Prevent infinite loop due to Assert in FIXTURE_TEARDOWN

2024-03-26 Thread Shuah Khan
On 3/14/24 16:43, Shengyu Li wrote: This patch addresses an issue in the selftests/harness where an assertion within FIXTURE_TEARDOWN could trigger an infinite loop. The problem arises because the teardown procedure is meant to execute once, but the presence of failing assertions (ASSERT_EQ(0,

Re: [PATCH v2] selftests/seccomp: Try to fit runtime of benchmark into timeout

2024-03-26 Thread Shuah Khan
On 3/25/24 10:57, Mark Brown wrote: The seccomp benchmark runs five scenarios, one calibration run with no seccomp filters enabled then four further runs each adding a filter. The calibration run times itself for 15s and then each additional run executes for the same number of times. Currently t

Re: [PATCH 0/2] kselftest/tty: Improve integration with automated systems

2024-03-26 Thread Shuah Khan
On 3/6/24 15:51, Greg Kroah-Hartman wrote: On Wed, Mar 06, 2024 at 07:21:24PM +, Mark Brown wrote: This cleans up the output of the tty_tstamp_update selftest to play a bit more nicely with automated systems parsing the test output. To do this I've also added a new helper ksft_test_result()

Re: [PATCH 1/2] selftests: x86: test_vsyscall: conform test to TAP format output

2024-03-26 Thread Shuah Khan
On 3/14/24 04:32, Muhammad Usama Anjum wrote: Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Without using TAP messages, the passed/failed/skip test names cannot be found. Signed-off-by: Muhammad Usama Anju

Re: [PATCH 2/2] selftests: x86: test_mremap_vdso: conform test to TAP format output

2024-03-26 Thread Shuah Khan
On 3/14/24 04:32, Muhammad Usama Anjum wrote: Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum This one looks okay. Please address the problems on patch 1/2 and send v2

Re: [PATCH v3] kselftest/clone3: Make test names for set_tid test stable

2024-03-26 Thread Shuah Khan
On 3/26/24 13:17, Shuah Khan wrote: On 3/25/24 08:29, Mark Brown wrote: The test results reported for the clone3_set_tid tests interact poorly with automation for running kselftest since the reported test names include TIDs dynamically allocated at runtime. A lot of automation for running

Re: [PATCH] selftests/exec: execveat: Improve debug reporting

2024-03-26 Thread Shuah Khan
On 3/14/24 02:54, Muhammad Usama Anjum wrote: On 3/13/24 11:56 PM, Kees Cook wrote: Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution. Signed-off-by: Kees Cook --- Cc: Eric Biederman Cc: Shuah

Re: [PATCH v2] selftests: x86: skip the tests if prerequisites aren't fulfilled

2024-03-26 Thread Shuah Khan
On 3/14/24 05:44, Muhammad Usama Anjum wrote: Skip instead of failing when prerequisite conditions aren't fulfilled, such as invalid xstate values etc. This patch would make the tests show as skip when run by: make -C tools/testing/selftests/ TARGETS=x86 run_tests ... # timeout set to 4

Re: [PATCH v5 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-03-26 Thread Shuah Khan
On 3/4/24 23:08, Muhammad Usama Anjum wrote: Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Reviewed-by: T.J. Mercier Signed-off-by: Muhammad Usama Anjum --- Changes since v4: - close fds correctly with c

Re: [PATCH v5 2/2] selftests: dmabuf-heap: add config file for the test

2024-03-26 Thread Shuah Khan
On 3/4/24 23:08, Muhammad Usama Anjum wrote: The config fragment enlists all the config options needed for the test. This config is merged into the kernel's config on which this test is run. Reviewed-by: T.J. Mercier Signed-off-by: Muhammad Usama Anjum --- Changes since v1: - Add reviewed-by t

Re: [PATCH 1/2] selftests: x86: test_vsyscall: conform test to TAP format output

2024-03-27 Thread Shuah Khan
On 3/27/24 06:16, Muhammad Usama Anjum wrote: On 3/27/24 1:00 AM, Shuah Khan wrote: On 3/14/24 04:32, Muhammad Usama Anjum wrote: Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Without using TAP messages

Re: [PATCH v2] selftests: x86: skip the tests if prerequisites aren't fulfilled

2024-03-27 Thread Shuah Khan
On 3/26/24 15:20, Chang S. Bae wrote: On 3/26/2024 1:51 PM, Shuah Khan wrote: show that there are bo backwards compatibility issues In older kernels lacking AMX support [1], arch_prctl() returns EINVAL. With AMX support, the kernel will properly set 'features'. It is also worth n

Re: [PATCH] selftests/exec: execveat: Improve debug reporting

2024-03-27 Thread Shuah Khan
On 3/26/24 16:40, Kees Cook wrote: On Tue, Mar 26, 2024 at 02:46:02PM -0600, Shuah Khan wrote: On 3/14/24 02:54, Muhammad Usama Anjum wrote: On 3/13/24 11:56 PM, Kees Cook wrote: Children processes were reporting their status, duplicating the parent's. Remove that, and add some addit

Re: [BUG] seltests/iommu: runaway ./iommufd consuming 99% CPU after a failed assert()

2024-03-27 Thread Shuah Khan
On 3/27/24 10:38, Jason Gunthorpe wrote: On Wed, Mar 27, 2024 at 03:04:09PM +, Joao Martins wrote: On 27/03/2024 11:40, Jason Gunthorpe wrote: On Wed, Mar 27, 2024 at 10:41:52AM +, Joao Martins wrote: On 25/03/2024 13:52, Jason Gunthorpe wrote: On Mon, Mar 25, 2024 at 12:17:28PM +

Re: [PATCH v2 1/3] selftests: x86: test_vsyscall: reorder code to reduce #ifdef blocks

2024-03-28 Thread Shuah Khan
On 3/27/24 12:46, Muhammad Usama Anjum wrote: There are multiple #ifdef blocks inside functions where they return just 0 if #ifdef is false. This makes number of tests counting difficult. Move those functions inside one #ifdef block and move all of them together. This is preparatory patch for nex

Re: [PATCH v3] selftests: x86: skip the tests if prerequisites aren't fulfilled

2024-03-28 Thread Shuah Khan
On 3/27/24 05:17, Muhammad Usama Anjum wrote: Skip instead of failing when prerequisite conditions aren't fulfilled, such as invalid xstate values etc. This patch would make the tests show as skip when run by: make -C tools/testing/selftests/ TARGETS=x86 run_tests ... # timeout set to 4

Re: [PATCH v5 0/3] selftests/resctrl: Simplify test cleanup functions

2024-03-28 Thread Shuah Khan
On 3/27/24 17:08, Reinette Chatre wrote: Hi Shuah, On 2/27/2024 8:36 AM, Reinette Chatre wrote: Hi Shuah, Could you please consider this series for inclusion? I do admit that there has been a lot of resctrl selftest work recently. This should be it for a while as new work is still being worked

Re: kunit alltests runs broken in mainline

2024-03-28 Thread Shuah Khan
nd this in the next wireless pull, soon. You are welcome to send this with wireless pull if you like or I can include it in my pull request. Either way let me know: Acked-by: Shuah Khan CONFIG_DAMON_DBGFS_DEPRECATED=y The DAMON config was also breaking UML for us, BTW, and I don't

Re: [PATCH v3] selftests: x86: skip the tests if prerequisites aren't fulfilled

2024-03-29 Thread Shuah Khan
On 3/29/24 01:36, Ingo Molnar wrote: * Shuah Khan wrote: On 3/27/24 05:17, Muhammad Usama Anjum wrote: Skip instead of failing when prerequisite conditions aren't fulfilled, such as invalid xstate values etc. This patch would make the tests show as skip when run by: make -C

[GIT PULL] KUnit fixes update for Linux 6.9-rc2

2024-03-29 Thread Shuah Khan
Hi Linus, Please pull the following kunit fixes update for Linux 6.9rc2. This kunit update for Linux 6.9-rc2 consists of one urgent fix for --alltests build failure related to renaming of CONFIG_DAMON_DBGFS to DAMON_DBGFS_DEPRECATED to the missing config option. This is one of the two fixes to

Re: [PATCH v3] kselftest/clone3: Make test names for set_tid test stable

2024-03-29 Thread Shuah Khan
On 3/26/24 14:27, Mark Brown wrote: On Tue, Mar 26, 2024 at 02:20:08PM -0600, Shuah Khan wrote: I am seeing the following compile warnings. Please fix and send patch on top pf linux-kselftest fixes. Which toolchain and architecture are you using? These compile cleanly for me. This is what

[GIT PULL] Kselftest fixes update for Linux 6.9-rc2

2024-03-29 Thread Shuah Khan
Hi Linus, Please pull the following kselftest fixes update for Linux 6.9rc2. This kselftest fixes update for Linux 6.9-rc2 consists of fixes to seccomp and ftrace tests and a change to add config file for dmabuf-heap test to increase coverage. diff is attached. thanks, -- Shuah --

Re: [PATCH v2] selftests/ftrace: Limit length in subsystem-enable tests

2024-04-04 Thread Shuah Khan
On 2/26/24 09:59, Steven Rostedt wrote: On Mon, 26 Feb 2024 15:09:38 +0900 Masami Hiramatsu (Google) wrote: On Mon, 26 Feb 2024 11:18:16 +0800 Yuanhe Shu wrote: While sched* events being traced and sched* events continuously happen, "[xx] event tracing - enable/disable with subsystem level

Re: [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output

2024-04-04 Thread Shuah Khan
On 3/26/24 13:11, Shuah Khan wrote: On 3/26/24 10:08, Steven Rostedt wrote: Shuah, If Masami is OK with this, can you take this through your tree? Acked-by: Steven Rostedt (Google) -- Steve Yes. Will do once Masami gives me the okay Hi Masami, Are you okay with this patch? thanks

Re: [Bug Report] selftests: Clang: kselftests build errors in KernelCI

2024-04-04 Thread Shuah Khan
On 4/4/24 10:34, Nick Desaulniers wrote: Thanks for the report. We've been tracking getting this working for a while: https://github.com/ClangBuiltLinux/linux/issues/1698. Other fires have continued to take priority. On Thu, Apr 4, 2024 at 9:30 AM Muhammad Usama Anjum wrote: Hi, We have ca

Re: [PATCH v2] selftests/harness: Prevent infinite loop due to Assert in FIXTURE_TEARDOWN

2024-04-04 Thread Shuah Khan
On 3/26/24 15:13, Shengyu Li wrote: This patch addresses an issue in the selftests/harness where an assertion within FIXTURE_TEARDOWN could trigger an infinite loop. The problem arises because the teardown procedure is meant to execute once, but the presence of failing assertions (ASSERT_EQ(0, 1)

Re: [BUG] seltests/iommu: runaway ./iommufd consuming 99% CPU after a failed assert()

2024-04-04 Thread Shuah Khan
On 3/27/24 14:04, Mirsad Todorovac wrote: On 3/27/24 11:41, Joao Martins wrote: On 25/03/2024 13:52, Jason Gunthorpe wrote: On Mon, Mar 25, 2024 at 12:17:28PM +, Joao Martins wrote: However, I am not smart enough to figure out why ... Apparently, from the source, mmap() fails to allocat

Re: [PATCH] kselftest: Add missing signature to the comments

2024-04-04 Thread Shuah Khan
On 4/4/24 09:55, Muhammad Usama Anjum wrote: The comment on top of the file is used by many developers to glance over all the available functions. Add the recently added ksft_perror() to it. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/kselftest.h | 1 + 1 file changed, 1

Re: [PATCH 0/2] selftests: add ksft_exit_fail_perror()

2024-04-04 Thread Shuah Khan
On 4/4/24 10:14, Muhammad Usama Anjum wrote: In this series, ksft_exit_fail_perror() is being added which is helper function on top of ksft_exit_fail_msg(). It prints errno and its string form always. After writing and porting several kselftests, I've found out that most of times ksft_exit_fail_m

Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg()

2024-04-05 Thread Shuah Khan
On 4/5/24 07:17, Muhammad Usama Anjum wrote: "Bail out! " is not descriptive. It rather should be: "Failed: " and then this added prefix doesn't need to be added everywhere. Usually in the logs, we are searching for "Failed" or "Error" instead of "Bail out" so it must be replace. Remove Error/Fa

Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg()

2024-04-05 Thread Shuah Khan
On 4/5/24 09:32, Kees Cook wrote: On Fri, Apr 05, 2024 at 08:56:31AM -0600, Shuah Khan wrote: On 4/5/24 07:17, Muhammad Usama Anjum wrote: "Bail out! " is not descriptive. It rather should be: "Failed: " and then this added prefix doesn't need to be added everywhere

Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg()

2024-04-05 Thread Shuah Khan
On 4/5/24 14:38, Muhammad Usama Anjum wrote: Hi Tim, On 4/6/24 12:36 AM, Bird, Tim wrote: Sorry I didn't catch this on the original submission. -Original Message- From: Shuah Khan On 4/5/24 07: 17, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It

Re: [PATCH v4 RESEND 0/7] Handle faults in KUnit tests

2024-04-09 Thread Shuah Khan
On 4/8/24 01:46, Mickaël Salaün wrote: Hi, This patch series teaches KUnit to handle kthread faults as errors, and it brings a few related fixes and improvements. Shuah, everything should be OK now, could you please merge this series? All these tests pass (on top of v6.8): ./tools/testing/kuni

[GIT PULL] KUnit fixes update for Linux 6.6-rc2

2023-09-11 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes update for Linux 6.6-rc2. This kunit update for Linux 6.6-rc2 consists of important fixes to possible memory leak, null-ptr-deref, wild-memory-access, and error path bugs. diff is attached. thanks, -- Shuah --

[GIT PULL] Kselftest fixes update for Linux 6.6-rc2

2023-09-11 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest fixes update for Linux 6.6-rc2. This kselftest fixes update for Linux 6.6-rc2 consists of fixes -- kselftest runner script to propagate SIGTERM to runner child to avoid kselftest hang. -- to install symlinks required for test execution to avoid t

Re: [PATCH] ftrace/selftests: Add softlink to latest log directory

2023-09-11 Thread Shuah Khan
On 9/11/23 12:07, Steven Rostedt wrote: On Mon, 11 Sep 2023 09:21:05 +0900 Masami Hiramatsu (Google) wrote: On Fri, 8 Sep 2023 18:17:21 -0400 Steven Rostedt wrote: From: Steven Rostedt (Google) When I'm debugging something with the ftrace selftests and need to look at the logs, it becomes

Re: [FIX PATCH v2] selftests: tracing: Fix to unmount tracefs for recovering environment

2023-09-12 Thread Shuah Khan
On 9/11/23 19:24, Steven Rostedt wrote: On Tue, 12 Sep 2023 10:10:39 +0900 "Masami Hiramatsu (Google)" wrote: From: Masami Hiramatsu (Google) Fix to unmount the tracefs if the ftracetest mounted it for recovering system environment. If the tracefs is already mounted, this does nothing. Sugg

Re: [PATCH] selftests: seccomp: fix format-zero-length warnings

2024-06-06 Thread Shuah Khan
On 6/3/24 05:54, Amer Al Shanawany wrote: seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format string [-Wformat-zero-length] 197 | ksft_print_msg(""); |^~ seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format string [-Wforma

Re: [PATCH 0/2] Modify the watchdog selftest for execution with

2024-06-06 Thread Shuah Khan
On 6/6/24 03:57, Laura Nao wrote: Hi Shuah, On 5/6/24 13:13, Laura Nao wrote: The watchdog selftest script supports various parameters for testing different IOCTLs. The watchdog ping functionality is validated by starting a loop where the watchdog device is periodically pet, which can only be s

Re: [PATCH v2 2/2] selftests/lib.mk: silence some clang warnings that gcc already ignores

2024-06-07 Thread Shuah Khan
On 6/3/24 16:36, Nathan Chancellor wrote: On Fri, May 31, 2024 at 11:37:51AM -0700, John Hubbard wrote: gcc defaults to silence (off) for the following warnings, but clang defaults to the opposite. The warnings are not useful for the kernel itself, which is why they have remained disabled in gcc

Re: [PATCH 1/4] kselftests: vdso: vdso_test_clock_getres: conform test to TAP output

2024-06-07 Thread Shuah Khan
On 5/29/24 01:24, Muhammad Usama Anjum wrote: Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum The message doesn't match the change. This patch converts the test to use

Re: [PATCH 0/4] kselftests: vdso: conform tests to TAP output

2024-06-07 Thread Shuah Khan
On 5/29/24 01:24, Muhammad Usama Anjum wrote: Conform individual tests to TAP output. One patch conform one test. With this series, all vDSO tests become TAP conformant. Muhammad Usama Anjum (4): kselftests: vdso: vdso_test_clock_getres: conform test to TAP output kselftests: vdso: vdso_te

Re: [PATCH] tools/testing/selftests/x86: add dlclose function in the vdso_restorer.c

2024-06-07 Thread Shuah Khan
On 12/4/23 02:01, liujing wrote: in the main function of vdso_restorer.c,there is a dlopen function, but there is no dlclose function to close the file Explain the change this patch is making in addition to describing the problem. Also tell me how you found this problem. Signed-off-by: liuji

Re: [PATCH 0/8] selftests: x86: build suite with clang

2024-06-07 Thread Shuah Khan
On 5/27/24 23:04, Muhammad Usama Anjum wrote: Soft reminder On 5/1/24 5:29 PM, Muhammad Usama Anjum wrote: This series fixes build errors found by clang to allow the x86 suite to get built with the clang. Unfortunately, there is one bug [1] in the clang becuase of which extended asm isn't hand

Re: [PATCH 0/4] selftest: x86: conform tests to TAP format output

2024-06-07 Thread Shuah Khan
On 5/27/24 23:04, Muhammad Usama Anjum wrote: Kind reminder On 4/14/24 6:18 PM, Muhammad Usama Anjum wrote: In this series, 4 tests are being conformed to TAP. Muhammad Usama Anjum (4): selftests: x86: check_initial_reg_state: conform test to TAP format output selftests: x86: corrup

Re: [PATCH v2] selftests: seccomp: fix format-zero-length warnings

2024-06-07 Thread Shuah Khan
On 6/7/24 06:41, Amer Al Shanawany wrote: fix the following errors by removing empty print statements: seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format string [-Wformat-zero-length] 197 | ksft_print_msg(""); |^~ seccomp_benchmark.c:202

Re: [PATCH 0/2] Modify the watchdog selftest for execution with

2024-06-07 Thread Shuah Khan
On 6/7/24 03:53, Laura Nao wrote: Hi Shuah, On 6/7/24 01:03, Shuah Khan wrote: On 6/6/24 03:57, Laura Nao wrote: Hi Shuah, On 5/6/24 13:13, Laura Nao wrote: The watchdog selftest script supports various parameters for testing different IOCTLs. The watchdog ping functionality is validated by

Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation

2024-06-07 Thread Shuah Khan
On 6/6/24 12:02, Okan Tümüklü wrote: From: Mickaël Salaün Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), which will be actually tested on the parent and child sides with a following commit. Cc: Shuah Khan Reviewed-by: Kees Cook Reviewed-by: Christian Brauner L

Re: [PATCH v2] selftests: seccomp: fix format-zero-length warnings

2024-06-11 Thread Shuah Khan
On 6/10/24 10:59, Kees Cook wrote: On Fri, Jun 07, 2024 at 02:58:47PM -0600, Shuah Khan wrote: On 6/7/24 06:41, Amer Al Shanawany wrote: fix the following errors by removing empty print statements: seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format string [-Wformat-zero

Re: [PATCH] selftests: proc: remove unreached code and fix build warning

2024-06-11 Thread Shuah Khan
On 6/7/24 09:25, Alexey Dobriyan wrote: On Tue, Jun 04, 2024 at 08:25:31PM -0700, Andrew Morton wrote: On Mon, 3 Jun 2024 17:24:47 +0300 Alexey Dobriyan wrote: On Mon, Jun 03, 2024 at 02:42:20PM +0200, Amer Al Shanawany wrote: fix the following warning: proc-empty-vm.c:385:17: warning: ignor

Re: [PATCH] selftests: filesystems: fix warn_unused_result build warnings

2024-06-11 Thread Shuah Khan
On 6/3/24 05:17, Amer Al Shanawany wrote: On 5/4/24 19:17, Amer Al Shanawany wrote: On 4/19/24 18:41, Muhammad Usama Anjum wrote: On 4/17/24 11:49 PM, Amer Al Shanawany wrote: Fix the following warnings by adding return check and error messages. statmount_test.c: In function ‘cleanup_namespac

Re: [PATCH] selftests: filesystems: add return value checks

2024-06-11 Thread Shuah Khan
On 6/10/24 14:09, Abhinav Jain wrote: Add ksft_exit_fail_msg() return value checks for fchdir() & chroot() to address the selftests statmount test compile warnings statmount_test.c:127:2: warning: ignoring return value of ‘fchdir’, declared with attribute warn_unused_result [-Wunused-result]

Re: [PATCH] selftests: Add information about TAP conformance in tests

2024-06-11 Thread Shuah Khan
On 6/10/24 02:32, Muhammad Usama Anjum wrote: Although "TAP" word is being used already in documentation, but it hasn't been defined in informative way for developers that how to write TAP conformant tests and what are the benefits. Write a short brief about it. Signed-off-by: Muhammad Usama Anj

Re: [PATCH v2 1/4] kselftests: vdso: vdso_test_clock_getres: conform test to TAP output

2024-06-11 Thread Shuah Khan
On 6/9/24 23:41, Muhammad Usama Anjum wrote: Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Use kselftest_harness.h to conform to TAP as the number of tests depend on the available options at build time. The

Re: [PATCH v2 0/4] kselftests: vdso: conform tests to TAP output

2024-06-11 Thread Shuah Khan
On 6/9/24 23:41, Muhammad Usama Anjum wrote: Conform individual tests to TAP output. One patch conform one test. With this series, all vDSO tests become TAP conformant. First patch conform the test by using kselftest_harness.h. Other patches are conforming using default kselftest.h helpers. All

Re: [PATCH] selftests/sched: fix code format issues

2024-06-11 Thread Shuah Khan
On 6/10/24 23:18, aigourensheng wrote: There are extra spaces in the middle of #define. It is recommended to delete the spaces to make the code look more comfortable. Signed-off-by: aigourensheng --- tools/testing/selftests/sched/cs_prctl_test.c | 10 +- 1 file changed, 5 insertions(

Re: [PATCH v2 0/2] selftests/openat2, fchmodat2: fix clang build failures

2024-06-11 Thread Shuah Khan
On 5/31/24 19:45, John Hubbard wrote: These two subsystems require very similar fixes, so I'm sending them out together. Changes since the first version: 1) Rebased onto Linux 6.10-rc1. 2) Added a Reviewed-by tag from Ryan Roberts. See [1] for that. Related work: I've sent a separate fix that

Re: [PATCH v3 2/2] usercopy: Convert test_user_copy to KUnit test

2024-06-14 Thread Shuah Khan
On 6/12/24 13:59, Kees Cook wrote: Convert the runtime tests of hardened usercopy to standard KUnit tests. Additionally disable usercopy_test_invalid() for systems with separate address spaces (or no MMU) since it's not sensible to test for address confusion there (e.g. m68k). Co-developed-by:

Re: [PATCH v3 2/2] usercopy: Convert test_user_copy to KUnit test

2024-06-17 Thread Shuah Khan
On 6/17/24 13:00, Kees Cook wrote: On Fri, Jun 14, 2024 at 09:50:05AM -0600, Shuah Khan wrote: On 6/12/24 13:59, Kees Cook wrote: Convert the runtime tests of hardened usercopy to standard KUnit tests. Additionally disable usercopy_test_invalid() for systems with separate address spaces (or

[GIT PULL] Kselftest fixes for Linux 6.10-rc5

2024-06-18 Thread Shuah Khan
Hi Linus, Please pull this kselftest fixes update for Linux 6.10-rc5. This kselftest fixes update consists of 4 fixes to the following build warnings: - filesystems: warn_unused_result warnings - seccomp: format-zero-length warnings - fchmodat2: clang build warnings due to-static-libasan - open

Re: [PATCH v2] selftests: Add information about TAP conformance in tests

2024-06-18 Thread Shuah Khan
On 6/12/24 01:27, Muhammad Usama Anjum wrote: Although "TAP" word is being used already in documentation, but it hasn't been defined in informative way for developers that how to write TAP conformant tests and what are the benefits. Write a short brief about it. Signed-off-by: Muhammad Usama Anj

Re: [PATCH v7 00/16] selftests/resctrl: resctrl_val() related cleanups & improvements

2024-06-18 Thread Shuah Khan
On 6/10/24 09:14, Ilpo Järvinen wrote: Hi all, This series does a number of cleanups into resctrl_val() and generalizes it by removing test name specific handling from the function. v7: - Truly use "bound to", not bounded to. - Fix separator to use 3 dashes Applied the series to linux-kselft

Re: [PATCH 0/2] Modify the watchdog selftest for execution with

2024-06-21 Thread Shuah Khan
On 6/18/24 07:40, Laura Nao wrote: Hi Shuah, On 6/7/24 23:07, Shuah Khan wrote: On 6/7/24 03:53, Laura Nao wrote: Hi Shuah, On 6/7/24 01:03, Shuah Khan wrote: On 6/6/24 03:57, Laura Nao wrote: Hi Shuah, On 5/6/24 13:13, Laura Nao wrote: The watchdog selftest script supports various

Re: [PATCH v6 00/13] Centralize _GNU_SOURCE definition into lib.mk

2024-06-25 Thread Shuah Khan
On 6/25/24 14:52, Andrew Morton wrote: On Mon, 24 Jun 2024 23:26:09 + Edward Liaw wrote: Centralizes the definition of _GNU_SOURCE into lib.mk and addresses all resulting macro redefinition warnings. These patches will need to be merged in one shot to avoid redefinition warnings. Yes, p

Re: [PATCH v3] selftests/resctrl: Fix non-contiguous CBM for AMD

2024-06-26 Thread Shuah Khan
On 6/26/24 10:55, Reinette Chatre wrote: Hi Shuah, Could you please consider this fix for inclusion into kselftests? Thank you very much. Reinette On 6/11/24 3:18 PM, Babu Moger wrote: The non-contiguous CBM test fails on AMD with: Starting L3_NONCONT_CAT test ... Mounting resctrl to "/sys/f

Re: [PATCH] selftests/capabilities: Fix possible file leak in copy_fromat_to

2024-06-26 Thread Shuah Khan
On 6/26/24 01:20, Ma Ke wrote: The open() function returns -1 on error. openat() and open() initialize 'from' and 'to', and only 'from' validated with 'if' statement. If the initialization of variable 'to' fails, we should better check the value of 'to' and close 'from' to avoid possible file lea

Re: [PATCH] selftests/capabilities: Fix possible file leak in copy_fromat_to

2024-06-26 Thread Shuah Khan
On 6/26/24 13:33, Shuah Khan wrote: On 6/26/24 01:20, Ma Ke wrote: The open() function returns -1 on error. openat() and open() initialize 'from' and 'to', and only 'from' validated with 'if' statement. If the initialization of variable 'to' f

Re: [PATCH] selftest: acct: Add selftest for the acct() syscall

2024-06-26 Thread Shuah Khan
On 6/22/24 11:24, Abdulrasaq Lawani wrote: Noticed that there was no selftest for the acct() syscall which enables the kernel to record terminated processes into a specified file. This patch provides a test for the acct() syscall. Describe the functionality being tested. Add testcases to test

Re: [PATCH v2] selftests/capabilities: Fix possible file leak in copy_fromat_to

2024-06-27 Thread Shuah Khan
On 6/26/24 19:57, Ma Ke wrote: The open() function returns -1 on error. openat() and open() initialize 'from' and 'to', and only 'from' validated with 'if' statement. If the initialization of variable 'to' fails, we should better check the value of 'to' and close 'from' to avoid possible file lea

Re: [PATCH v7 1/1] selftests: Centralize -D_GNU_SOURCE= to CFLAGS in lib.mk

2024-06-27 Thread Shuah Khan
sting/selftests/tmpfs/Makefile| 1 - 15 files changed, 12 insertions(+), 15 deletions(-) Andrew, I am seeing merge conflicts with mm and exec tests. Might be better to have you take this through your tree? Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 2/2] selftests/watchdog: convert the test output to KTAP format

2024-06-27 Thread Shuah Khan
On 5/6/24 05:13, Laura Nao wrote: Modify the script output to conform to the KTAP format standard. The What is script here? number of tests executed is determined by the script arguments, and options such as -c, -f, -h, -i, and -p do not impact the total test count. No functional change is i

Re: [PATCH 1/2] selftests/watchdog: limit ping loop and allow configuring the number of pings

2024-06-27 Thread Shuah Khan
On 5/6/24 05:13, Laura Nao wrote: In order to run the watchdog selftest with the kselftest runner, the loop responsible for pinging the watchdog should be finite. This change limits the loop to 5 iterations by default and introduces a new '-c' option to adjust the number of pings as needed. Thi

Re: [PATCH 3/3] selftests: kselftest: also use strerror() on nolibc

2024-06-28 Thread Shuah Khan
strerror() and it seems -* inappropriate to add one, just print the errno. -*/ - ksft_print_msg("%s: %d)\n", msg, errno); -#endif } static inline __printf(1, 2) void ksft_test_result_pass(const char *msg, ...) -- 2.44.0 Sorry - this git lost in my Inb

Re: [PATCH 3/3] selftests: kselftest: also use strerror() on nolibc

2024-06-28 Thread Shuah Khan
: %d)\n", msg, errno); -#endif } static inline __printf(1, 2) void ksft_test_result_pass(const char *msg, ...) Sorry for the delay o this. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 0/3] tools/nolibc: implement strerror()

2024-06-28 Thread Shuah Khan
base-commit: a3063ba97f31e0364379a3ffc567203e3f79e877 change-id: 20240425-nolibc-strerror-67f4bfa03035 Best regards, -- Thomas Weißschuh Sorry for the delay o this. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2] kunit/usercopy: Disable testing on !CONFIG_MMU

2024-07-02 Thread Shuah Khan
-off-by: Kees Cook --- Resending as v2 with Shuah in To: --- Cc: Shuah Khan Cc: Brendan Higgins Cc: David Gow Cc: Rae Moar Cc: "Gustavo A. R. Silva" Cc: Andrew Morton Cc: linux-kselftest@vger.kernel.org Cc: kunit-...@googlegroups.com Cc: linux-harden...@vger.kernel.org Cc: linux...

Re: [PATCH v2] kunit/usercopy: Disable testing on !CONFIG_MMU

2024-07-02 Thread Shuah Khan
On 6/27/24 11:07, Kees Cook wrote: Hi Shuah, Can you please add this to your -next tree since it fixes test failures on non-MMU systems, after commit cf6219ee889f ("usercopy: Convert test_user_copy to KUnit test"). Applied to linux-kselftest kunit branch for next. thanks, -- Shuah

Re: [PATCH v3] selftests/capabilities: Fix possible file leak in copy_fromat_to

2024-07-02 Thread Shuah Khan
On 6/30/24 07:00, Ma Ke wrote: The open() function returns -1 on error. openat() and open() initialize 'from' and 'to', and only 'from' validated with 'if' statement. If the initialization of variable 'to' fails, we should better check the value of 'to' and close 'from' to avoid possible file lea

[GIT PULL] Kselftest fixes for Linux 6.10-rc7

2024-07-02 Thread Shuah Khan
Hi Linus, Please pull this kselftest fixes update for Linux 6.10-rc7. This kselftest fixes update for Linux 6.10-rc7 consists of one single patch to fix the non-contiguous CBM resctrl: - AMD supports non-contiguous CBM but does not report it via CPUID. This test should not use CPUID on AMD to

Re: [PATCH 1/2] selftests/watchdog: limit ping loop and allow configuring the number of pings

2024-07-03 Thread Shuah Khan
On 7/3/24 08:48, Laura Nao wrote: On 6/27/24 20:48, Shuah Khan wrote: On 5/6/24 05:13, Laura Nao wrote: In order to run the watchdog selftest with the kselftest runner, the loop responsible for pinging the watchdog should be finite. This change limits the loop to 5 iterations by default and

Re: [PATCH v3] selftests/timers: remove unused irqcount variable

2024-07-05 Thread Shuah Khan
On 7/3/24 21:11, John Stultz wrote: On Wed, Jul 3, 2024 at 7:42 PM John Hubbard wrote: When building with clang, via: make LLVM=1 -C tools/testing/selftest ...clang warns about an unused irqcount variable. clang is correct: the variable is incremented and then ignored. Fix this by dele

Re: [PATCH v4 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup

2024-07-05 Thread Shuah Khan
On 7/3/24 20:33, John Hubbard wrote: Hi, This is basically a resend, with a rebase onto today's latest Linux main, in order to show that the patches are still relevant and correct. Changes since v3: 1. Rebased onto Linux 6.10-rc6+. Cover letter for v3: Jason A. Donenfeld, I've added you beca

Re: [PATCH v2] selftest: acct: Add selftest for the acct() syscall

2024-07-05 Thread Shuah Khan
On 6/30/24 13:22, Abdulrasaq Lawani wrote: Noticed that there was no selftest for the acct() syscall which enables the kernel to record terminated processes into a specified file. The acct() system call enables or disables process accounting. If accounting is turned on, records for each terminat

Re: [PATCH v4 2/3] selftests/mm: remove partially duplicated "all:" target in Makefile

2024-07-05 Thread Shuah Khan
On 7/3/24 20:33, John Hubbard wrote: There were a couple of errors here: 1. TEST_GEN_PROGS was incorrectly prepending $(OUTPUT) to each program to be built. However, lib.mk already does that because it assumes "bare" program names are passed in, so this ended up creating $(OUTPUT)/$(OUTPUT)/file

Re: [PATCH v4 2/3] selftests/mm: remove partially duplicated "all:" target in Makefile

2024-07-05 Thread Shuah Khan
On 7/5/24 11:58, John Hubbard wrote: On 7/5/24 10:53, Shuah Khan wrote: On 7/3/24 20:33, John Hubbard wrote: There were a couple of errors here: 1. TEST_GEN_PROGS was incorrectly prepending $(OUTPUT) to each program to be built. However, lib.mk already does that because it assumes "

Re: [PATCH v5 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup

2024-07-05 Thread Shuah Khan
On 7/5/24 13:57, John Hubbard wrote: Hi Shuah, These are for 6.10, as we just discussed. Changes since v4: 1) Subject line on patch #2/3: s/mm/vDSO/ 2) Added Muhammad's review tag. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/?h=fixes for Linux 6.10

[GIT PULL] Kselftest fixes for Linux 6.10

2024-07-08 Thread Shuah Khan
Hi Linus, Please pull this kselftest fixes update for Linux 6.10. This kselftest fixes update for Linux 6.10 consists of fixes to clang build failures to timerns, vDSO tests and fixes to vDSO makefile. Note: makefile fixes are included to avoid conflicts during 6.11 merge window. diff is attac

Re: [RESEND] selftests/breakpoints:Remove unused variable

2024-07-09 Thread Shuah Khan
On 7/9/24 03:44, Zhu Jun wrote: This variable is never referenced in the code, just remove them. Please add information on how this problem was found. If you used a tool, include which tool and warning from the tool. Signed-off-by: Zhu Jun --- tools/testing/selftests/breakpoints/step_afte

Re: [RESEND] selftests/breakpoints:Add return value in main function

2024-07-09 Thread Shuah Khan
On 7/9/24 03:51, Zhu Jun wrote: Main function return value is int type, so add return value in the end Signed-off-by: Zhu Jun Please add information on how this problem was found. If you used a tool, include which tool and warning from the tool. thanks, -- Shuah

Re: [PATCH v4 0/7] selftests/x86: fix build errors and warnings found via clang

2024-07-09 Thread Shuah Khan
On 7/4/24 01:24, John Hubbard wrote: Changes since v3: 1) Rebased onto Linux 6.10-rc6+. 2) Added Muhammad's acks for the series. Cover letter for v3: Hi, Dave Hansen, Muhammad Usama Anjum, here is the combined series that we discussed yesterday [1]. As I mentioned then, this is a bit intrus

Re: [PATCH v3] selftest/timerns: fix clang build failures for abs() calls

2024-07-09 Thread Shuah Khan
On 7/3/24 21:44, Andrei Vagin wrote: On Wed, Jul 3, 2024 at 7:52 PM John Hubbard wrote: When building with clang, via: make LLVM=1 -C tools/testing/selftests ...clang warns about mismatches between the expected and required integer length being supplied to abs(3). Fix this by using the

Re: [PATCH v4 0/7] selftests/x86: fix build errors and warnings found via clang

2024-07-09 Thread Shuah Khan
On 7/9/24 14:40, John Hubbard wrote: On 7/9/24 1:34 PM, Shuah Khan wrote: On 7/4/24 01:24, John Hubbard wrote: ...>> Muhammad Usama Anjum (1):    selftests: x86: test_FISTTP: use fisttps instead of ambiguous fisttp Usama and John, I am seeing checkpatch warnings in this series.

<    1   2   3   4   5   >