ff-by: Johannes Nixdorf
Reviewed-by: Ido Schimmel
re, as there are multiple callers that modify the
> flags, but are not under a common lock (br_fdb_update is the exception
> for br->hash_lock, br_fdb_external_learn_add for RTNL).
>
> Signed-off-by: Johannes Nixdorf
Reviewed-by: Ido Schimmel
On Thu, Sep 21, 2023 at 01:19:44PM +0300, Nikolay Aleksandrov wrote:
> I'm not strongly against, just IMO it is unnecessary. I won't block the set
> because of this, but it would be nice to get input from others as
> well. If you can recompile your kernel to set a limit, it should be easier
> to ch
ckets per second
> # bridge fdb | grep -v permanent | wc -l
> 256
> # ip -d link show dev br
> 13: br: mtu 1500 [...]
> [...] fdb_n_learned 256 fdb_max_learned 256
>
> Signed-off-by: Johannes Nixdorf
Reviewed-by: Ido Schimmel
On Mon, Oct 16, 2023 at 03:27:23PM +0200, Johannes Nixdorf wrote:
> Set any new attributes added to br_policy to be parsed strictly, to
> prevent userspace from passing garbage.
>
> Signed-off-by: Johannes Nixdorf
Reviewed-by: Ido Schimmel
[ OK ]
>
> Tests passed: 83
> Tests failed: 0
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
[ OK ]
> TEST: ARP suppression [ OK ]
>
> ...
>
> TEST: NS suppression (VLAN 20) [ OK ]
>
> Tests passed: 148
> Tests failed: 0
>
> Acked-by: David Ahern
>
[ OK ]
>
> Tests passed: 620
> Tests failed: 0
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
VXLAN device - localbypass [ OK ]
>
> Tests passed: 6
> Tests failed: 0
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
[ OK ]
> Check VM connectivity through VXLAN (underlay in a VRF)[ OK ]
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
>
> Tests passed: 27
> Tests failed: 0
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
TEST: Nexthop get on non-existent id[ OK ]
>
> ...
>
> TEST: IPv6 resilient nexthop group torture test [ OK ]
>
> Tests passed: 234
> Tests failed: 0
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
th list receive tests
> TEST: Multipath route hit ratio (1.00) [ OK
> ]
>
> Tests passed: 225
> Tests failed: 0
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
t; ...
> TEST: vx10: Expected 5 FDB entries, got 5 [ OK ]
> TEST: Test entries with dst 192.0.2.1 [ OK ]
>
> Acked-by: David Ahern
> Signed-off-by: Hangbin Liu
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
: b408453053fb ("selftests: net: Add bridge backup port and backup nexthop
ID test")
Signed-off-by: Ido Schimmel
---
Jakub, you can apply to net if you want to, but I'm sending this to
net-next since I want to see if it helps the CI. I'm unable to reproduce
this locally.
---
tools/t
[FAIL]
[ 641.995910] br0: port 1(swp1) entered disabled state
# TEST: No forwarding out of vx0 [ OK ]
Fixes: b408453053fb ("selftests: net: Add bridge backup port and backup nexthop
ID test")
Signed-off-by: Ido Schimmel
---
Jakub, targeting a
On Thu, Feb 01, 2024 at 10:34:52AM +0100, Paolo Abeni wrote:
> What about adding an helper alike wait_local_port_listen(), checking
> for bridge link status in short intervals, to likely reduce the overall
> wait time?
What about the below?
diff --git a/tools/testing/selftests/net/test_bridge_bac
]
[ 641.995910] br0: port 1(swp1) entered disabled state
# TEST: No forwarding out of vx0 [ OK ]
Fixes: b408453053fb ("selftests: net: Add bridge backup port and backup nexthop
ID test")
Signed-off-by: Ido Schimmel
Reviewed-by: Petr Machata
---
Not
Fix various problems in the forwarding selftests so that they will pass
in the netdev CI instead of being ignored. See commit messages for
details.
Ido Schimmel (4):
selftests: forwarding: Fix layer 2 miss test flakiness
selftests: forwarding: Fix bridge MDB test flakiness
selftests
: 8c33266ae26a ("selftests: forwarding: Add layer 2 miss test cases")
Signed-off-by: Ido Schimmel
---
.../testing/selftests/net/forwarding/tc_flower_l2_miss.sh | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.s
tests: forwarding: Add bridge MDB test")
Signed-off-by: Ido Schimmel
---
tools/testing/selftests/net/forwarding/bridge_mdb.sh | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb.sh
b/tools/testing/selftests/net/forwarding/bri
]
[...]
They do not fail the test, but do clutter the output.
Fixes: b6d00da08610 ("selftests: forwarding: Add bridge MDB test")
Signed-off-by: Ido Schimmel
---
tools/testing/selftests/net/forwarding/bridge_mdb.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/too
]
[...]
# TEST: Locked port MAB redirect [FAIL]
# Locked entry created for redirected traffic
Fixes: 38c43a1ce758 ("selftests: forwarding: Add test case for traffic
redirection from a locked port")
Signed-off-by: Ido Schimmel
---
tools/testing/sel
test")
Signed-off-by: Ido Schimmel
---
Targeting at net-next because this is where 4acf4e62cd57 ("selftests:
forwarding: Add missing config entries") was applied to, but you can
apply to net as well.
---
tools/testing/selftests/net/forwarding/config | 7 +++
1 file changed, 7
Rename some test cases to avoid overlapping test names which is
problematic for the kernel test robot. No changes in the test's logic.
Suggested-by: Yujie Liu
Signed-off-by: Ido Schimmel
---
Yujie Liu, please verify this works for you.
---
tools/testing/selftests/net/test_vxlan_mdb.sh
On Tue, Mar 19, 2024 at 06:05:16AM +0100, Mirsad Todorovac wrote:
> On 3/18/24 04:35, Hangbin Liu wrote:
> > On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote:
> > > Hi,
> > >
> > > While running kselftest on vanilla torvalds tree kernel commit
> > > v6.8-11167-g4438a810f396,
> > >
On Wed, Mar 20, 2024 at 01:47:36AM +0100, Mirsad Todorovac wrote:
> On 3/19/24 15:25, Ido Schimmel wrote:
> > Will look into it today or later this week.
>
> Thank you for considering this.
Can you please try the following patch?
https://github.com/idos
On Tue, Aug 06, 2024 at 12:20:38PM +0800, Geliang Tang wrote:
> From: Geliang Tang
>
> So many "Address not found" messages occur at the end of forwarding tests
> when using "ip address del" command for an invalid address:
Can you give an example of an invalid address that triggers this
message?
On Wed, Aug 07, 2024 at 12:08:15PM +0800, Geliang Tang wrote:
> On Tue, 2024-08-06 at 10:40 +0300, Ido Schimmel wrote:
> > On Tue, Aug 06, 2024 at 12:20:38PM +0800, Geliang Tang wrote:
> > > From: Geliang Tang
> > >
> > > So many "Address not found
On Thu, Aug 08, 2024 at 04:53:51PM +0800, Geliang Tang wrote:
> Yes indeed, the addresses are deleted by NetworkManager. Does this mean
> that this test will be affected by the network environment in which it
> is running? Is it necessary to run this test in a new network
> namespace?
No. See tool
gt; present in the VLAN group of the ports
> - Double-tagged traffic is not forwarded when the PVID of the port is
> absent from the VLAN group of the ports
>
> The test passes with both veth and ocelot.
Thanks for the test. Passes with mlxsw as well.
>
> Signed-off-by: V
n my laptop running "ip link help" 16k times takes
> 25-30 seconds, so I think it's worth optimizing even for fastest
> setups.
>
> Signed-off-by: Jakub Kicinski
Reviewed-by: Ido Schimmel
Tested-by: Ido Schimmel
Thanks!
On Sat, Aug 17, 2024 at 11:38:48AM -0700, Jakub Kicinski wrote:
> A few tests check if nettest exists in the $PATH before adding
> $PWD to $PATH and re-checking. They don't discard stderr on
> the first check (and nettest is built as part of selftests,
> so it's pretty normal for it to not be avail
in the ability to selectively skip cases in its absence.
>
> Signed-off-by: Jakub Kicinski
Like Hangbin I am also not sure what "profile=1" is about, but looks
fine otherwise, so:
Reviewed-by: Ido Schimmel
Thanks!
On Thu, Aug 22, 2024 at 03:49:40PM +0200, Petr Machata wrote:
> In commit 8510801a9dbd ("selftests: drv-net: add ability to schedule
> cleanup with defer()"), a defer helper was added to Python selftests.
> The idea is to keep cleanup commands close to their dirtying counterparts,
> thereby making
lib.sh-provided one, which invokes the necessary defer cleanups as well.
>
> Signed-off-by: Petr Machata
Reviewed-by: Ido Schimmel
topped right after the function returns.
>
> Signed-off-by: Petr Machata
Reviewed-by: Ido Schimmel
On Thu, Aug 22, 2024 at 03:49:43PM +0200, Petr Machata wrote:
> Use defer scopes to manage qdisc lifetime.
>
> Signed-off-by: Petr Machata
Reviewed-by: Ido Schimmel
On Thu, Aug 22, 2024 at 03:49:44PM +0200, Petr Machata wrote:
> Tests interrupted part-way through leave behind a running mausezahn. Use
> defer to schedule a traffic stop after traffic is started.
Any reason not to convert the setup part to the defer mechanism as well?
>
> Signed-off-by: Petr M
+ Guillaume:
please see comment below about route_get_dst_pmtu_from_exception())
Original patch:
https://lore.kernel.org/netdev/20241104072753.77042-1-deli...@verdict.gg/
On Mon, Nov 04, 2024 at 07:27:50AM +, Vladimir Vdovin wrote:
> diff --git a/tools/testing/selftests/net/pmtu.sh
> b/tools/
Subject prefix should be "[PATCH net-next v6]" (v7 for next version,
obviously)
On Sat, Nov 02, 2024 at 04:29:35PM +, Vladimir Vdovin wrote:
> Check number of paths by fib_info_num_path(),
> and update_or_create_fnhe() for every path.
> Problem is that pmtu is cached only for the oif
> that ha
ashed with oif=ens17f1 its ok,
> if oif=ens17f0 it blackholes and still gets icmp msgs from ro3 to ens17f1,
> until lucky day when ro3 will send it through another flow to ens17f0.
>
> Signed-off-by: Vladimir Vdovin
Reviewed-by: Ido Schimmel
On Wed, Nov 06, 2024 at 01:30:07PM +, Vladimir Vdovin wrote:
> +test_pmtu_ipv4_mp_exceptions() {
> + setup namespaces routing multipath || return $ksft_skip
> +
> + trace "${ns_a}" veth_A-R1"${ns_r1}" veth_R1-A \
> + "${ns_r1}" veth_R1-B"${ns_b}" veth_B-R1 \
> +
On Thu, Nov 07, 2024 at 09:36:24AM +, Vladimir Vdovin wrote:
> +test_pmtu_ipv4_mp_exceptions() {
> + setup namespaces routing multipath || return $ksft_skip
> +
> + trace "${ns_a}" veth_A-R1"${ns_r1}" veth_R1-A \
> + "${ns_r1}" veth_R1-B"${ns_b}" veth_B-R1 \
> +
On Wed, Jan 29, 2025 at 03:36:01PM +0100, Anna Emese Nyiri wrote:
> diff --git a/tools/testing/selftests/net/test_so_rcv.sh
> b/tools/testing/selftests/net/test_so_rcv.sh
> new file mode 100755
> index ..12d37f9ab905
> --- /dev/null
> +++ b/tools/testing/selftests/net/test_so_rcv.sh
>
sleep in test_so_rcv.sh.
> The sleep was added to ensure that the listener process has
> enough time to start before the sender attempts to connect.
> - Rebased on net-next.
>
> v1:
>
> https://lore.kernel.org/netdev/20250129143601.16035-2-annaemeseny...@gmail.com/
>
> S
46 matches
Mail list logo
