[PATCH 5.10 070/406] selftests/harness: Actually report SKIP for signal tests

2023-09-17 Thread Greg Kroah-Hartman
5.10-stable review patch. If anyone has any objections, please let me know. -- From: Kees Cook [ Upstream commit b3d46e11fec0c5a8972e5061bb1462119ae5736d ] Tests that were expecting a signal were not correctly checking for a SKIP condition. Move the check before the signal che

[PATCH 6.5 250/285] selftests/ftrace: Fix dependencies for some of the synthetic event tests

2023-09-17 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Naveen N Rao [ Upstream commit 145036f88d693d7ef3aa8537a4b1aa22f8764647 ] Commit b81a3a100cca1b ("tracing/histogram: Add simple tests for stacktrace usage of synthetic events") changed the outp

[PATCH 5.15 060/511] selftests/harness: Actually report SKIP for signal tests

2023-09-17 Thread Greg Kroah-Hartman
5.15-stable review patch. If anyone has any objections, please let me know. -- From: Kees Cook [ Upstream commit b3d46e11fec0c5a8972e5061bb1462119ae5736d ] Tests that were expecting a signal were not correctly checking for a SKIP condition. Move the check before the signal che

Re: [RFC PATCH 2/2] kselftest: devices: Add board file for google,spherion

2023-10-25 Thread Greg Kroah-Hartman
On Tue, Oct 24, 2023 at 05:18:00PM -0400, Nícolas F. R. A. Prado wrote: > Add the list of devices expected to be probed from the USB and PCI > busses on the google,spherion machine. The USB host controller at > 1120 is shared between two busses, for USB2 and USB3, so an > additional match is us

Re: [RFC PATCH 2/2] kselftest: devices: Add board file for google,spherion

2023-10-27 Thread Greg Kroah-Hartman
On Wed, Oct 25, 2023 at 08:32:42AM -0400, Nícolas F. R. A. Prado wrote: > On Wed, Oct 25, 2023 at 12:32:15PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Oct 24, 2023 at 05:18:00PM -0400, Nícolas F. R. A. Prado wrote: > > > Add the list of devices expected to be probed fr

Re: [PATCH 1/3] MAINTAINERS: Introduce V: field for required tests

2023-11-16 Thread Greg Kroah-Hartman
On Thu, Nov 16, 2023 at 08:20:18PM +0700, Bagas Sanjaya wrote: > On Wed, Nov 15, 2023 at 07:43:49PM +0200, Nikolai Kondrashov wrote: > > Make scripts/checkpatch.pl ensure any added V: fields reference > > documented test suites only, and output a warning if a change to a > > subsystem doesn't certi

Re: [PATCH 1/4] kunit: Add APIs for managing devices

2023-12-05 Thread Greg Kroah-Hartman
On Tue, Dec 05, 2023 at 03:31:33PM +0800, david...@google.com wrote: > Tests for drivers often require a struct device to pass to other > functions. While it's possible to create these with > root_device_register(), or to use something like a platform device, this > is both a misuse of those APIs,

Re: [PATCH 1/4] kunit: Add APIs for managing devices

2023-12-06 Thread Greg Kroah-Hartman
On Wed, Dec 06, 2023 at 03:44:08PM +0800, David Gow wrote: > > But really, why is this a "raw" device_driver pointer and not a pointer > > to the driver type for your bus? > > So, this is where the more difficult questions start (and where my > knowledge of the driver model gets a bit shakier). >

Re: [PATCH v4 1/5] kunit: Add APIs for managing devices

2023-12-15 Thread Greg Kroah-Hartman
on test shutdown, but can be > manually unregistered earlier with kunit_device_unregister() in order > to, for example, test device release code. > > Reviewed-by: Matti Vaittinen > Reviewed-by: Maxime Ripard > Signed-off-by: David Gow Nice work! Reviewed-by: Greg Kroah-Hartman

[PATCH 6.7 370/641] kselftest/alsa - mixer-test: fix the number of parameters to ksft_exit_fail_msg()

2024-01-22 Thread Greg Kroah-Hartman
6.7-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit 8c51c13dc63d46e754c44215eabc0890a8bd9bfb ] Minor fix in the number of arguments to error reporting function in the test program as reported by GCC 13.2.0 warn

[PATCH 6.7 371/641] kselftest/alsa - mixer-test: Fix the print format specifier warning

2024-01-22 Thread Greg Kroah-Hartman
6.7-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit 3f47c1ebe5ca9c5883e596c7888dec4bec0176d8 ] The GCC 13.2.0 compiler issued the following warning: mixer-test.c: In function ‘ctl_value_index_valid’: mixer-tes

[PATCH 6.7 372/641] kselftest/alsa - conf: Stringify the printed errno in sysfs_get()

2024-01-22 Thread Greg Kroah-Hartman
6.7-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit fd38dd6abda589a8771e7872e4dea28c99c6a6ef ] GCC 13.2.0 reported the warning of the print format specifier: conf.c: In function ‘sysfs_get’: conf.c:181:72: war

[PATCH 6.1 243/417] kselftest/alsa - mixer-test: Fix the print format specifier warning

2024-01-22 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit 3f47c1ebe5ca9c5883e596c7888dec4bec0176d8 ] The GCC 13.2.0 compiler issued the following warning: mixer-test.c: In function ‘ctl_value_index_valid’: mixer-tes

[PATCH 6.1 242/417] kselftest/alsa - mixer-test: fix the number of parameters to ksft_exit_fail_msg()

2024-01-22 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit 8c51c13dc63d46e754c44215eabc0890a8bd9bfb ] Minor fix in the number of arguments to error reporting function in the test program as reported by GCC 13.2.0 warn

[PATCH 6.6 334/583] kselftest/alsa - mixer-test: fix the number of parameters to ksft_exit_fail_msg()

2024-01-22 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit 8c51c13dc63d46e754c44215eabc0890a8bd9bfb ] Minor fix in the number of arguments to error reporting function in the test program as reported by GCC 13.2.0 warn

[PATCH 6.6 335/583] kselftest/alsa - mixer-test: Fix the print format specifier warning

2024-01-22 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit 3f47c1ebe5ca9c5883e596c7888dec4bec0176d8 ] The GCC 13.2.0 compiler issued the following warning: mixer-test.c: In function ‘ctl_value_index_valid’: mixer-tes

[PATCH 6.6 336/583] kselftest/alsa - conf: Stringify the printed errno in sysfs_get()

2024-01-22 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Mirsad Todorovac [ Upstream commit fd38dd6abda589a8771e7872e4dea28c99c6a6ef ] GCC 13.2.0 reported the warning of the print format specifier: conf.c: In function ‘sysfs_get’: conf.c:181:72: war

Re: [PATCH 00/31] NT synchronization primitive driver

2024-02-14 Thread Greg Kroah-Hartman
On Wed, Feb 14, 2024 at 06:01:22PM -0600, Elizabeth Figura wrote: > On Wednesday, 14 February 2024 17:36:36 CST Elizabeth Figura wrote: > > This patch series introduces a new char misc driver, /dev/ntsync, which is > > used > > to implement Windows NT synchronization primitives. > > Ugh, sorry, I

Re: [PATCH 02/31] ntsync: Introduce NTSYNC_IOC_CREATE_SEM.

2024-02-14 Thread Greg Kroah-Hartman
On Wed, Feb 14, 2024 at 05:36:38PM -0600, Elizabeth Figura wrote: > This corresponds to the NT syscall NtCreateSemaphore(). > > Semaphores are one of three types of object to be implemented in this driver, > the others being mutexes and events. > > An NT semaphore contains a 32-bit counter, and i

Re: [PATCH] kunit: make kunit_bus_type const

2024-02-14 Thread Greg Kroah-Hartman
> structure as well, placing it into read-only memory which can not be > modified at runtime. > > Cc: Greg Kroah-Hartman > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Ricardo B. Marliere Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 00/31] NT synchronization primitive driver

2024-02-17 Thread Greg Kroah-Hartman
On Fri, Feb 16, 2024 at 07:31:12PM +0300, Alexey Dobriyan wrote: > > drivers/misc/ntsync.c | 1146 ++ > > Assuming this doesn't go into futex(2) or some other existing code... > > Can you start putting all of this into top-level "windows" directory? > I suspect

Re: [PATCH 02/31] ntsync: Introduce NTSYNC_IOC_CREATE_SEM.

2024-02-17 Thread Greg Kroah-Hartman
On Thu, Feb 15, 2024 at 01:22:01PM -0600, Elizabeth Figura wrote: > On Thursday, 15 February 2024 01:28:32 CST Greg Kroah-Hartman wrote: > > On Wed, Feb 14, 2024 at 05:36:38PM -0600, Elizabeth Figura wrote: > > > This corresponds to the NT syscall NtCreateSemaphore(). > >

Re: [PATCH 0/2] kselftest/tty: Improve integration with automated systems

2024-03-06 Thread Greg Kroah-Hartman
> KSFT_ code as a report, this is something I've wanted on other occasions > but restructured things to avoid needing it. This time I figured I'd > just add it since it keeps coming up. > > Signed-off-by: Mark Brown Acked-by: Greg Kroah-Hartman

Re: [PATCH v2 02/31] ntsync: Introduce NTSYNC_IOC_CREATE_SEM.

2024-03-07 Thread Greg Kroah-Hartman
On Mon, Feb 19, 2024 at 04:38:04PM -0600, Elizabeth Figura wrote: > This corresponds to the NT syscall NtCreateSemaphore(). > > Semaphores are one of three types of object to be implemented in this driver, > the others being mutexes and events. > > An NT semaphore contains a 32-bit counter, and i

[PATCH 6.1 106/600] selftests/harness: Actually report SKIP for signal tests

2023-09-11 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Kees Cook [ Upstream commit b3d46e11fec0c5a8972e5061bb1462119ae5736d ] Tests that were expecting a signal were not correctly checking for a SKIP condition. Move the check before the signal chec

[PATCH 6.5 019/739] selftests/harness: Actually report SKIP for signal tests

2023-09-11 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Kees Cook [ Upstream commit b3d46e11fec0c5a8972e5061bb1462119ae5736d ] Tests that were expecting a signal were not correctly checking for a SKIP condition. Move the check before the signal chec

[PATCH 6.4 105/737] selftests/harness: Actually report SKIP for signal tests

2023-09-11 Thread Greg Kroah-Hartman
6.4-stable review patch. If anyone has any objections, please let me know. -- From: Kees Cook [ Upstream commit b3d46e11fec0c5a8972e5061bb1462119ae5736d ] Tests that were expecting a signal were not correctly checking for a SKIP condition. Move the check before the signal chec

Re: [PATCH RFC 3/3] drivers/misc: add test driver and selftest for proclocal allocator

2024-07-03 Thread Greg Kroah-Hartman
On Fri, Jun 21, 2024 at 10:15:01PM +0200, Roman Kagan wrote: > Introduce a simple driver for functional and stress testing of proclocal > kernel allocator. The driver exposes a device node /dev/proclocal-test, > which allows userland programs to request creation of proclocal areas > and to obtain

Re: [PATCH v2 0/3] kselftest: Add test to report device log errors

2024-07-10 Thread Greg Kroah-Hartman
upply sbs-8-000b: driver failed to report `time_to_empty_now' > property: -5 > not ok 1 +power_supply:sbs-8-000b > Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0 > > [1] https://lore.kernel.org/all/cf4d8131-4b63-4c7a-9f27-5a0847c656c4@notapiano > > Signed-off-by: Nícolas F. R. A. Prado Acked-by: Greg Kroah-Hartman

Re: [PATCH v2 0/3] kselftest: Add test to report device log errors

2024-07-12 Thread Greg Kroah-Hartman
On Thu, Jul 11, 2024 at 03:56:25PM -0600, Shuah Khan wrote: > On 7/11/24 15:44, Nícolas F. R. A. Prado wrote: > > On Thu, Jul 11, 2024 at 01:53:37PM -0600, Shuah Khan wrote: > > > On 7/10/24 15:49, Shuah Khan wrote: > > > > On 7/10/24 07:11, Greg Kroah-Hartman wrote:

Re: [PATCH] selftests/net: fix gro.c compilation failure due to non-existent opt_ipproto_off

2024-07-15 Thread Greg Kroah-Hartman
On Fri, Jul 12, 2024 at 05:01:38PM -0700, John Hubbard wrote: > On 7/12/24 4:51 PM, John Hubbard wrote: > > Linux 6.6 does not have an opt_ipproto_off variable in gro.c at all (it > > was added in later kernel versions), so attempting to initialize one > > breaks the build. > > This is the first t

Re: [PATCH v3 04/30] ntsync: Introduce NTSYNC_IOC_WAIT_ANY.

2024-04-11 Thread Greg Kroah-Hartman
On Thu, Mar 28, 2024 at 07:05:55PM -0500, Elizabeth Figura wrote: > This corresponds to part of the functionality of the NT syscall > NtWaitForMultipleObjects(). Specifically, it implements the behaviour where > the third argument (wait_any) is TRUE, and it does not handle alertable waits. > Those

Re: [PATCH v3 03/30] ntsync: Introduce NTSYNC_IOC_SEM_POST.

2024-04-11 Thread Greg Kroah-Hartman
On Thu, Mar 28, 2024 at 07:05:54PM -0500, Elizabeth Figura wrote: > This corresponds to the NT syscall NtReleaseSemaphore(). > > This increases the semaphore's internal counter by the given value, and > returns > the previous value. If the counter would overflow the defined maximum, the > functio

Re: [PATCH v3 04/30] ntsync: Introduce NTSYNC_IOC_WAIT_ANY.

2024-04-11 Thread Greg Kroah-Hartman
On Thu, Apr 11, 2024 at 07:33:07PM -0500, Elizabeth Figura wrote: > > Rolling your own lock is tricky, and needs review from the locking > > maintainers. And probably some more documentation as to what is > > happening and why our normal types of locks can't be used here? > > Definitely. (Unfortu

Re: [PATCH v4 00/30] NT synchronization primitive driver

2024-04-16 Thread Greg Kroah-Hartman
On Tue, Apr 16, 2024 at 10:14:21AM +0200, Peter Zijlstra wrote: > On Mon, Apr 15, 2024 at 08:08:10PM -0500, Elizabeth Figura wrote: > > This patch series implements a new char misc driver, /dev/ntsync, which is > > used > > to implement Windows NT synchronization primitives. > > This patch series

Re: [PATCH v3 1/2] kunit: unregister the device on error

2024-04-18 Thread Greg Kroah-Hartman
nit_init_device() should unregister the device on bus registration error. >But it mistakenly tries to unregister the bus. Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Lin

Re: [PATCH v3 2/2] kunit: avoid memory leak on device register error

2024-04-18 Thread Greg Kroah-Hartman
t; Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers

Re: [PATCH v3 2/2] kunit: avoid memory leak on device register error

2024-04-19 Thread Greg Kroah-Hartman
On Fri, Apr 19, 2024 at 09:30:06AM -0300, Wander Lairson Costa wrote: > As a side note, the behavior of device_register() seems > counterintuitive and error-prone, IMO. If the function returns an > error, it should ensure it leaks no resource and shouldn't require the > caller to do any cleanup. I

Re: [PATCH v4 2/2] kunit: avoid memory leak on device register error

2024-04-19 Thread Greg Kroah-Hartman
On Fri, Apr 19, 2024 at 10:25:02AM -0300, Wander Lairson Costa wrote: > If the device register fails, free the allocated memory before > returning. > > Signed-off-by: Wander Lairson Costa > Fixes: d03c720e03bd ("kunit: Add APIs for managing devices") > --- > lib/kunit/device.c | 1 + > 1 file ch

Re: [PATCH v4 1/2] kunit: unregister the device on error

2024-04-19 Thread Greg Kroah-Hartman
son Costa > Fixes: d03c720e03bd ("kunit: Add APIs for managing devices") Reviewed-by: Greg Kroah-Hartman

Re: [PATCH v4 1/2] kunit: unregister the device on error

2024-04-19 Thread Greg Kroah-Hartman
On Fri, Apr 19, 2024 at 06:32:05PM +0200, Markus Elfring wrote: > > > kunit_init_device() should unregister the device on bus register error, > > > but mistakenly it tries to unregister the bus. > > > > > > Unregister the device instead of the bus. >

[PATCH 6.8 118/336] selftests/ftrace: Fix event filter target_func selection

2024-05-14 Thread Greg Kroah-Hartman
6.8-stable review patch. If anyone has any objections, please let me know. -- From: Mark Rutland [ Upstream commit 8ecab2e64572f1aecdfc5a8feae748abda6e3347 ] The event filter function test has been failing in our internal test farm: | # not ok 33 event filter function - test

[PATCH 6.6 116/301] selftests/ftrace: Fix event filter target_func selection

2024-05-14 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Mark Rutland [ Upstream commit 8ecab2e64572f1aecdfc5a8feae748abda6e3347 ] The event filter function test has been failing in our internal test farm: | # not ok 33 event filter function - test

Re: [PATCH v5 06/11] platform: Add test managed platform_device/driver APIs

2024-06-04 Thread Greg Kroah-Hartman
100644 Documentation/dev-tools/kunit/api/platformdevice.rst > create mode 100644 include/kunit/platform_device.h > create mode 100644 lib/kunit/platform-test.c > create mode 100644 lib/kunit/platform.c Reviewed-by: Greg Kroah-Hartman

[PATCH 6.6 206/213] selftests/rseq: Fix mm_cid test failure

2024-10-14 Thread Greg Kroah-Hartman
d-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/rseq/rseq.c | 110 tools/testing/selftests/rseq/rseq.h | 10 --- 2 files changed, 77 insertions(+), 43 deletions(-) --- a/tools/testing/selftests/rseq/rseq.c +++ b/tools/test

[PATCH 6.11 205/214] selftests/rseq: Fix mm_cid test failure

2024-10-14 Thread Greg Kroah-Hartman
d-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/rseq/rseq.c | 110 tools/testing/selftests/rseq/rseq.h | 10 --- 2 files changed, 77 insertions(+), 43 deletions(-) --- a/tools/testing/selftests/rseq/rseq.c +++ b/

[PATCH 6.6 372/393] selftests/rseq: Fix handling of glibc without rseq support

2025-02-05 Thread Greg Kroah-Hartman
Ananta Signed-off-by: Mathieu Desnoyers Cc: Raghavendra Rao Ananta Cc: Shuah Khan Cc: Peter Zijlstra Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Carlos O'Donell Cc: Florian Weimer Cc: Michael Jeanson Cc: linux-kselftest@vger.kernel.org Cc: sta...@vger.kernel.o

[PATCH 6.13 580/623] selftests/rseq: Fix handling of glibc without rseq support

2025-02-05 Thread Greg Kroah-Hartman
ra Rao Ananta Signed-off-by: Mathieu Desnoyers Cc: Raghavendra Rao Ananta Cc: Shuah Khan Cc: Peter Zijlstra Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Carlos O'Donell Cc: Florian Weimer Cc: Michael Jeanson Cc: linux-kselftest@vger.kernel.org Cc: sta...@vger.kernel.org

[PATCH 6.12 546/590] selftests/rseq: Fix handling of glibc without rseq support

2025-02-05 Thread Greg Kroah-Hartman
ra Rao Ananta Signed-off-by: Mathieu Desnoyers Cc: Raghavendra Rao Ananta Cc: Shuah Khan Cc: Peter Zijlstra Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Carlos O'Donell Cc: Florian Weimer Cc: Michael Jeanson Cc: linux-kselftest@vger.kernel.org Cc: sta...@vger.kernel.org

Re: [RFC PATCH 08/33] vfio: selftests: Validate 2M/1G HugeTLB are mapped as 2M/1G in IOMMU

2025-06-01 Thread Greg Kroah-Hartman
On Sat, May 31, 2025 at 10:09:34PM +0300, Andy Shevchenko wrote: > On Fri, May 30, 2025 at 02:12:36PM -0700, David Matlack wrote: > > On Fri, May 23, 2025 at 4:30 PM David Matlack wrote: > > ... > > > > + if (access("/sys/kernel/debug/iommu/intel", F_OK)) > > > + return intel