78 ("selftests/net: add lib.sh")
Suggested-by: Ido Schimmel
Suggested-by: Petr Machata
Reviewed-by: Ido Schimmel
Tested-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/net/forwarding/lib.sh | 27 ++-
1 file changed, 26 insertions(+), 1
From: Benjamin Poirier
Two small fixes for net selftests.
These patches were carved out of the following RFC series:
https://lore.kernel.org/netdev/20231222135836.992841-1-bpoir...@nvidia.com/
I'm planning to send the rest of the series to net-next after it opens up.
Benjamin Poiri
successfully.
Fixes: d43eff0b85ae ("selftests: bonding: up/down delay w/ slave link flapping")
Tested-by: Hangbin Liu
Reviewed-by: Hangbin Liu
Reviewed-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
.../selftests/drivers/net/bonding/mode-1-recovery-updelay.sh| 2 +-
.../selfte
iu
Reviewed-by: Vladimir Oltean
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/net/forwarding/lib.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 tools/testing/selftests/net/forwarding/lib.sh
diff --git a/tools/testing/selftests/net/forwardi
On 2024-01-15 18:02 -0800, Jakub Kicinski wrote:
> bonding tests also try to create bridge, veth and dummy
> interfaces. These are not currently listed in config.
>
> Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list
> management")
> Fixes: c078290a2b76 ("selftests: include b
") #
for nlmon
Suggested-by: Jakub Kicinski
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/drivers/net/bonding/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/drivers/net/bonding/config
b/tools/testing/selftests/drivers/net/bonding/config
index
On 2024-01-16 11:20 -0800, Jakub Kicinski wrote:
> On Tue, 16 Jan 2024 11:03:30 -0800 Jay Vosburgh wrote:
> > If I'm reading it right, this will sleep for 12, 22, 32 and 52
> > seconds for the passes through the loop in num_grat_arp(), so that would
> > be 118 seconds just for that.
>
> Hah, t
On 2024-01-16 11:29 -0800, Jakub Kicinski wrote:
> On Tue, 16 Jan 2024 14:21:51 -0500 Benjamin Poirier wrote:
> > real13m35.065s
> > user0m1.657s
> > sys 0m27.918s
> >
> > The test is not cpu bound; as Jay pointed out, it spends most of its
> &
Jakub Kicinski
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/drivers/net/bonding/settings | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/bonding/settings
b/tools/testing/selftests/drivers/net/bonding/settings
index 6091b45d2
On 2024-01-17 11:15 +0800, Hangbin Liu wrote:
> On Tue, Jan 16, 2024 at 02:47:46PM -0500, Benjamin Poirier wrote:
> > On 2024-01-16 11:29 -0800, Jakub Kicinski wrote:
> > > On Tue, 16 Jan 2024 14:21:51 -0500 Benjamin Poirier wrote:
> > > > real13m35.065s
> &
On 2024-01-16 09:32 +0100, Paolo Abeni wrote:
> On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote:
> > The lib.sh script is meant to be sourced from other scripts, not executed
> > directly. Therefore, remove the executable bits from lib.sh's permissions.
>
&
.sh now sources net/lib.sh, both of those files
must be exported along with tests which source net/forwarding/lib.sh.
Suggested-by: Hangbin Liu
Signed-off-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
.../selftests/drivers/net/bonding/Makefile| 3 ++-
.../selftests/d
In order to avoid duplicated files when both the bonding and forwarding
tests are exported together, add net/forwarding/lib.sh to TEST_INCLUDES and
include it via its relative path.
Reviewed-by: Petr Machata
Tested-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests
In order to avoid duplicated files when both the team and bonding tests are
exported together, add lag_lib.sh to TEST_INCLUDES.
Do likewise for net/forwarding/lib.sh regarding team and forwarding tests.
Reviewed-by: Petr Machata
Tested-by: Petr Machata
Signed-off-by: Benjamin Poirier
m/
Link: https://lore.kernel.org/netdev/ZXu7dGj7F9Ng8iIX@Laptop-X1/
Benjamin Poirier (5):
selftests: Introduce Makefile variable to list shared bash scripts
selftests: bonding: Add net/forwarding/lib.sh to TEST_INCLUDES
selftests: team: Add shared library scripts to TEST_INCLUDES
selftest
-by: Petr Machata
Tested-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
.../testing/selftests/drivers/net/dsa/Makefile | 17 +++--
.../drivers/net/dsa/bridge_locked_port.sh | 2 +-
.../selftests/drivers/net/dsa/bridge_mdb.sh | 2 +-
.../selftests/drivers/net/dsa
../../../net/lib.sh
v1 (from RFC):
* changed TEST_INCLUDES to take relative paths, like other TEST_* variables
(Vladimir Oltean)
* preserved common "$(MAKE) OUTPUT=... -C ... target" ordering in Makefile
(Petr Machata)
Reviewed-by: Petr Machata
Tested-by: Petr Machata
Signe
dir" as the absolute path to net/forwarding/.
Tested-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/net/forwarding/lib.sh| 9 +++--
tools/testing/selftests/net/forwarding/mirror_gre_lib.sh | 2 +-
.../selftests/net/forwarding/mirror_gre_topo_lib.sh
On 2024-01-24 10:24 -0800, Jay Vosburgh wrote:
[...]
> >diff --git a/tools/testing/selftests/drivers/net/bonding/bond_topo_2d1c.sh
> >b/tools/testing/selftests/drivers/net/bonding/bond_topo_2d1c.sh
> >index a509ef949dcf..0eb7edfb584c 100644
> >--- a/tools/testing/selftests/drivers/net/bonding/bond
On 2024-01-24 20:46 -0800, Jakub Kicinski wrote:
> On Wed, 24 Jan 2024 12:02:17 -0500 Benjamin Poirier wrote:
> > --- a/Documentation/dev-tools/kselftest.rst
> > +++ b/Documentation/dev-tools/kselftest.rst
> > @@ -255,9 +255,19 @@ Contributing new tests (details)
> >
asing approach. I
have dropped most review tags on account of this reordering.
RFC:
https://lore.kernel.org/netdev/20231222135836.992841-1-bpoir...@nvidia.com/
Link: https://lore.kernel.org/netdev/ZXu7dGj7F9Ng8iIX@Laptop-X1/
Benjamin Poirier (5):
selftests: Introduce Makefile variable to list
../../../net/lib.sh
v2:
Fix rst syntax in Documentation/dev-tools/kselftest.rst (Jakub Kicinski)
v1 (from RFC):
* changed TEST_INCLUDES to take relative paths, like other TEST_* variables
(Vladimir Oltean)
* preserved common "$(MAKE) OUTPUT=... -C ... target" ordering in Makefile
In order to avoid duplicated files when both the bonding and forwarding
tests are exported together, add net/forwarding/lib.sh to TEST_INCLUDES and
include it via its relative path.
Reviewed-by: Petr Machata
Tested-by: Petr Machata
Reviewed-by: Hangbin Liu
Signed-off-by: Benjamin Poirier
: Benjamin Poirier
---
tools/testing/selftests/drivers/net/team/Makefile | 6 +++---
tools/testing/selftests/drivers/net/team/dev_addr_lists.sh | 4 ++--
tools/testing/selftests/drivers/net/team/lag_lib.sh | 1 -
.../selftests/drivers/net/team/net_forwarding_lib.sh| 1 -
4
-by: Petr Machata
Tested-by: Petr Machata
Reviewed-by: Hangbin Liu
Signed-off-by: Benjamin Poirier
---
.../testing/selftests/drivers/net/dsa/Makefile | 17 +++--
.../drivers/net/dsa/bridge_locked_port.sh | 2 +-
.../selftests/drivers/net/dsa/bridge_mdb.sh | 2
t; as the absolute path to net/forwarding/.
Tested-by: Petr Machata
Reviewed-by: Hangbin Liu
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/net/forwarding/lib.sh| 9 +++--
tools/testing/selftests/net/forwarding/mirror_gre_lib.sh | 2 +-
.../selftests/net/forwarding/
.sh now sources net/lib.sh, both of those files
must be exported along with tests which source net/forwarding/lib.sh.
Suggested-by: Hangbin Liu
Reviewed-by: Hangbin Liu
Signed-off-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
.../selftests/drivers/net/bonding/Makefile| 3 ++-
...
Some small fixes for net selftests which follow from these recent commits:
dd2d40acdbb2 ("selftests: bonding: Add more missing config options")
49078c1b80b6 ("selftests: forwarding: Remove executable bits from lib.sh")
Benjamin Poirier (5):
selftests: team: Add mi
wards, the team device test passed.
Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list
management")
Reviewed-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/drivers/net/team/config | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
h")
Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test")
Fixes: 3bdd9fd29cb0 ("selftests/net: synchronize udpgro tests' tx and rx
connection")
Suggested-by: Paolo Abeni
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/net/net_helper.sh | 0
tools/testin
ot;)
Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Fixes: b99ac1841147 ("kselftests/net: add missed
setup_loopback.sh/setup_veth.sh to Makefile")
Fixes: f5173fe3e13b ("selftests: net: included needed helper in the install
targets")
Suggested-by: Petr Machata
Sig
("selftests/net/forwarding: define libs as
TEST_PROGS_EXTENDED")
Suggested-by: Petr Machata
Signed-off-by: Benjamin Poirier
---
tools/testing/selftests/net/forwarding/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/Makefil
answers: Operation not supported
TEST: team cleanup mode lacp[ OK ]
Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list
management")
Signed-off-by: Benjamin Poirier
---
.../testing/selftests/drivers/net/bonding/lag_li
On 2024-04-24 18:37 +0100, Simon Horman wrote:
> On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote:
> > Hi Aaron, Jakub, all,
> >
> > I have recently been exercising the Open vSwitch kernel selftests,
> > using vng, something like this:
> >
> > TESTDIR="tools/testing/selftests/net/
34 matches
Mail list logo