[PATCH net-next] selftests: forwarding: Avoid failures to source net/lib.sh

2024-01-04 Thread Benjamin Poirier
78 ("selftests/net: add lib.sh") Suggested-by: Ido Schimmel Suggested-by: Petr Machata Reviewed-by: Ido Schimmel Tested-by: Petr Machata Signed-off-by: Benjamin Poirier --- tools/testing/selftests/net/forwarding/lib.sh | 27 ++- 1 file changed, 26 insertions(+), 1

[PATCH net 0/2] selftests: net: Small fixes

2024-01-10 Thread Benjamin Poirier
From: Benjamin Poirier Two small fixes for net selftests. These patches were carved out of the following RFC series: https://lore.kernel.org/netdev/20231222135836.992841-1-bpoir...@nvidia.com/ I'm planning to send the rest of the series to net-next after it opens up. Benjamin Poiri

[PATCH net 1/2] selftests: bonding: Change script interpreter

2024-01-10 Thread Benjamin Poirier
successfully. Fixes: d43eff0b85ae ("selftests: bonding: up/down delay w/ slave link flapping") Tested-by: Hangbin Liu Reviewed-by: Hangbin Liu Reviewed-by: Petr Machata Signed-off-by: Benjamin Poirier --- .../selftests/drivers/net/bonding/mode-1-recovery-updelay.sh| 2 +- .../selfte

[PATCH net 2/2] selftests: forwarding: Remove executable bits from lib.sh

2024-01-10 Thread Benjamin Poirier
iu Reviewed-by: Vladimir Oltean Signed-off-by: Benjamin Poirier --- tools/testing/selftests/net/forwarding/lib.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 tools/testing/selftests/net/forwarding/lib.sh diff --git a/tools/testing/selftests/net/forwardi

Re: [PATCH net] selftests: bonding: add missing build configs

2024-01-16 Thread Benjamin Poirier
On 2024-01-15 18:02 -0800, Jakub Kicinski wrote: > bonding tests also try to create bridge, veth and dummy > interfaces. These are not currently listed in config. > > Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list > management") > Fixes: c078290a2b76 ("selftests: include b

[PATCH net] selftests: bonding: Add more missing config options

2024-01-16 Thread Benjamin Poirier
") # for nlmon Suggested-by: Jakub Kicinski Signed-off-by: Benjamin Poirier --- tools/testing/selftests/drivers/net/bonding/config | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config index

Re: [PATCH net] selftests: bonding: Add more missing config options

2024-01-16 Thread Benjamin Poirier
On 2024-01-16 11:20 -0800, Jakub Kicinski wrote: > On Tue, 16 Jan 2024 11:03:30 -0800 Jay Vosburgh wrote: > > If I'm reading it right, this will sleep for 12, 22, 32 and 52 > > seconds for the passes through the loop in num_grat_arp(), so that would > > be 118 seconds just for that. > > Hah, t

Re: [PATCH net] selftests: bonding: Add more missing config options

2024-01-16 Thread Benjamin Poirier
On 2024-01-16 11:29 -0800, Jakub Kicinski wrote: > On Tue, 16 Jan 2024 14:21:51 -0500 Benjamin Poirier wrote: > > real13m35.065s > > user0m1.657s > > sys 0m27.918s > > > > The test is not cpu bound; as Jay pointed out, it spends most of its > &

[PATCH net] selftests: bonding: Increase timeout to 1200s

2024-01-17 Thread Benjamin Poirier
Jakub Kicinski Signed-off-by: Benjamin Poirier --- tools/testing/selftests/drivers/net/bonding/settings | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/bonding/settings b/tools/testing/selftests/drivers/net/bonding/settings index 6091b45d2

Re: [PATCH net] selftests: bonding: Add more missing config options

2024-01-17 Thread Benjamin Poirier
On 2024-01-17 11:15 +0800, Hangbin Liu wrote: > On Tue, Jan 16, 2024 at 02:47:46PM -0500, Benjamin Poirier wrote: > > On 2024-01-16 11:29 -0800, Jakub Kicinski wrote: > > > On Tue, 16 Jan 2024 14:21:51 -0500 Benjamin Poirier wrote: > > > > real13m35.065s > &

Re: [PATCH net 2/2] selftests: forwarding: Remove executable bits from lib.sh

2024-01-19 Thread Benjamin Poirier
On 2024-01-16 09:32 +0100, Paolo Abeni wrote: > On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote: > > The lib.sh script is meant to be sourced from other scripts, not executed > > directly. Therefore, remove the executable bits from lib.sh's permissions. > &

[PATCH net-next 6/6] selftests: forwarding: Remove duplicated lib.sh content

2024-01-24 Thread Benjamin Poirier
.sh now sources net/lib.sh, both of those files must be exported along with tests which source net/forwarding/lib.sh. Suggested-by: Hangbin Liu Signed-off-by: Petr Machata Signed-off-by: Benjamin Poirier --- .../selftests/drivers/net/bonding/Makefile| 3 ++- .../selftests/d

[PATCH net-next 2/6] selftests: bonding: Add net/forwarding/lib.sh to TEST_INCLUDES

2024-01-24 Thread Benjamin Poirier
In order to avoid duplicated files when both the bonding and forwarding tests are exported together, add net/forwarding/lib.sh to TEST_INCLUDES and include it via its relative path. Reviewed-by: Petr Machata Tested-by: Petr Machata Signed-off-by: Benjamin Poirier --- tools/testing/selftests

[PATCH net-next 3/6] selftests: team: Add shared library scripts to TEST_INCLUDES

2024-01-24 Thread Benjamin Poirier
In order to avoid duplicated files when both the team and bonding tests are exported together, add lag_lib.sh to TEST_INCLUDES. Do likewise for net/forwarding/lib.sh regarding team and forwarding tests. Reviewed-by: Petr Machata Tested-by: Petr Machata Signed-off-by: Benjamin Poirier

[PATCH net-next 0/6] selftests: Add TEST_INCLUDES directive and adjust tests to use it

2024-01-24 Thread Benjamin Poirier
m/ Link: https://lore.kernel.org/netdev/ZXu7dGj7F9Ng8iIX@Laptop-X1/ Benjamin Poirier (5): selftests: Introduce Makefile variable to list shared bash scripts selftests: bonding: Add net/forwarding/lib.sh to TEST_INCLUDES selftests: team: Add shared library scripts to TEST_INCLUDES selftest

[PATCH net-next 4/6] selftests: dsa: Replace test symlinks by wrapper script

2024-01-24 Thread Benjamin Poirier
-by: Petr Machata Tested-by: Petr Machata Signed-off-by: Benjamin Poirier --- .../testing/selftests/drivers/net/dsa/Makefile | 17 +++-- .../drivers/net/dsa/bridge_locked_port.sh | 2 +- .../selftests/drivers/net/dsa/bridge_mdb.sh | 2 +- .../selftests/drivers/net/dsa

[PATCH net-next 1/6] selftests: Introduce Makefile variable to list shared bash scripts

2024-01-24 Thread Benjamin Poirier
../../../net/lib.sh v1 (from RFC): * changed TEST_INCLUDES to take relative paths, like other TEST_* variables (Vladimir Oltean) * preserved common "$(MAKE) OUTPUT=... -C ... target" ordering in Makefile (Petr Machata) Reviewed-by: Petr Machata Tested-by: Petr Machata Signe

[PATCH net-next 5/6] selftests: forwarding: Redefine relative_path variable

2024-01-24 Thread Benjamin Poirier
dir" as the absolute path to net/forwarding/. Tested-by: Petr Machata Signed-off-by: Benjamin Poirier --- tools/testing/selftests/net/forwarding/lib.sh| 9 +++-- tools/testing/selftests/net/forwarding/mirror_gre_lib.sh | 2 +- .../selftests/net/forwarding/mirror_gre_topo_lib.sh

Re: [PATCH net-next 2/6] selftests: bonding: Add net/forwarding/lib.sh to TEST_INCLUDES

2024-01-24 Thread Benjamin Poirier
On 2024-01-24 10:24 -0800, Jay Vosburgh wrote: [...] > >diff --git a/tools/testing/selftests/drivers/net/bonding/bond_topo_2d1c.sh > >b/tools/testing/selftests/drivers/net/bonding/bond_topo_2d1c.sh > >index a509ef949dcf..0eb7edfb584c 100644 > >--- a/tools/testing/selftests/drivers/net/bonding/bond

Re: [PATCH net-next 1/6] selftests: Introduce Makefile variable to list shared bash scripts

2024-01-25 Thread Benjamin Poirier
On 2024-01-24 20:46 -0800, Jakub Kicinski wrote: > On Wed, 24 Jan 2024 12:02:17 -0500 Benjamin Poirier wrote: > > --- a/Documentation/dev-tools/kselftest.rst > > +++ b/Documentation/dev-tools/kselftest.rst > > @@ -255,9 +255,19 @@ Contributing new tests (details) > >

[PATCH net-next v2 0/6] selftests: Add TEST_INCLUDES directive and adjust tests to use it

2024-01-26 Thread Benjamin Poirier
asing approach. I have dropped most review tags on account of this reordering. RFC: https://lore.kernel.org/netdev/20231222135836.992841-1-bpoir...@nvidia.com/ Link: https://lore.kernel.org/netdev/ZXu7dGj7F9Ng8iIX@Laptop-X1/ Benjamin Poirier (5): selftests: Introduce Makefile variable to list

[PATCH net-next v2 1/6] selftests: Introduce Makefile variable to list shared bash scripts

2024-01-26 Thread Benjamin Poirier
../../../net/lib.sh v2: Fix rst syntax in Documentation/dev-tools/kselftest.rst (Jakub Kicinski) v1 (from RFC): * changed TEST_INCLUDES to take relative paths, like other TEST_* variables (Vladimir Oltean) * preserved common "$(MAKE) OUTPUT=... -C ... target" ordering in Makefile

[PATCH net-next v2 2/6] selftests: bonding: Add net/forwarding/lib.sh to TEST_INCLUDES

2024-01-26 Thread Benjamin Poirier
In order to avoid duplicated files when both the bonding and forwarding tests are exported together, add net/forwarding/lib.sh to TEST_INCLUDES and include it via its relative path. Reviewed-by: Petr Machata Tested-by: Petr Machata Reviewed-by: Hangbin Liu Signed-off-by: Benjamin Poirier

[PATCH net-next v2 3/6] selftests: team: Add shared library scripts to TEST_INCLUDES

2024-01-26 Thread Benjamin Poirier
: Benjamin Poirier --- tools/testing/selftests/drivers/net/team/Makefile | 6 +++--- tools/testing/selftests/drivers/net/team/dev_addr_lists.sh | 4 ++-- tools/testing/selftests/drivers/net/team/lag_lib.sh | 1 - .../selftests/drivers/net/team/net_forwarding_lib.sh| 1 - 4

[PATCH net-next v2 4/6] selftests: dsa: Replace test symlinks by wrapper script

2024-01-26 Thread Benjamin Poirier
-by: Petr Machata Tested-by: Petr Machata Reviewed-by: Hangbin Liu Signed-off-by: Benjamin Poirier --- .../testing/selftests/drivers/net/dsa/Makefile | 17 +++-- .../drivers/net/dsa/bridge_locked_port.sh | 2 +- .../selftests/drivers/net/dsa/bridge_mdb.sh | 2

[PATCH net-next v2 5/6] selftests: forwarding: Redefine relative_path variable

2024-01-26 Thread Benjamin Poirier
t; as the absolute path to net/forwarding/. Tested-by: Petr Machata Reviewed-by: Hangbin Liu Signed-off-by: Benjamin Poirier --- tools/testing/selftests/net/forwarding/lib.sh| 9 +++-- tools/testing/selftests/net/forwarding/mirror_gre_lib.sh | 2 +- .../selftests/net/forwarding/

[PATCH net-next v2 6/6] selftests: forwarding: Remove duplicated lib.sh content

2024-01-26 Thread Benjamin Poirier
.sh now sources net/lib.sh, both of those files must be exported along with tests which source net/forwarding/lib.sh. Suggested-by: Hangbin Liu Reviewed-by: Hangbin Liu Signed-off-by: Petr Machata Signed-off-by: Benjamin Poirier --- .../selftests/drivers/net/bonding/Makefile| 3 ++- ...

[PATCH net 0/5] selftests: net: More small fixes

2024-01-31 Thread Benjamin Poirier
Some small fixes for net selftests which follow from these recent commits: dd2d40acdbb2 ("selftests: bonding: Add more missing config options") 49078c1b80b6 ("selftests: forwarding: Remove executable bits from lib.sh") Benjamin Poirier (5): selftests: team: Add mi

[PATCH net 1/5] selftests: team: Add missing config options

2024-01-31 Thread Benjamin Poirier
wards, the team device test passed. Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management") Reviewed-by: Petr Machata Signed-off-by: Benjamin Poirier --- tools/testing/selftests/drivers/net/team/config | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH net 3/5] selftests: net: Remove executable bits from library scripts

2024-01-31 Thread Benjamin Poirier
h") Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test") Fixes: 3bdd9fd29cb0 ("selftests/net: synchronize udpgro tests' tx and rx connection") Suggested-by: Paolo Abeni Signed-off-by: Benjamin Poirier --- tools/testing/selftests/net/net_helper.sh | 0 tools/testin

[PATCH net 4/5] selftests: net: List helper scripts in TEST_FILES Makefile variable

2024-01-31 Thread Benjamin Poirier
ot;) Fixes: 25ae948b4478 ("selftests/net: add lib.sh") Fixes: b99ac1841147 ("kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile") Fixes: f5173fe3e13b ("selftests: net: included needed helper in the install targets") Suggested-by: Petr Machata Sig

[PATCH net 5/5] selftests: forwarding: List helper scripts in TEST_FILES Makefile variable

2024-01-31 Thread Benjamin Poirier
("selftests/net/forwarding: define libs as TEST_PROGS_EXTENDED") Suggested-by: Petr Machata Signed-off-by: Benjamin Poirier --- tools/testing/selftests/net/forwarding/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/forwarding/Makefil

[PATCH net 2/5] selftests: bonding: Check initial state

2024-01-31 Thread Benjamin Poirier
answers: Operation not supported TEST: team cleanup mode lacp[ OK ] Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management") Signed-off-by: Benjamin Poirier --- .../testing/selftests/drivers/net/bonding/lag_li

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-24 Thread Benjamin Poirier
On 2024-04-24 18:37 +0100, Simon Horman wrote: > On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote: > > Hi Aaron, Jakub, all, > > > > I have recently been exercising the Open vSwitch kernel selftests, > > using vng, something like this: > > > > TESTDIR="tools/testing/selftests/net/