In case of fatal signal, or early abort at least cleanup the current
test case.
Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/openvswitch.sh | 2 ++
1 file changed, 2 insertions(+)
diff --g
he flows from a datapath allowing us to test for
explicit drop actions, and then clear the flows to build the
original test case.
Fixes: 4242029164d6 ("selftests: openvswitch: add explicit drop testcase")
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh | 17
would need additional skip logic anyway. Just draw
a line in the sand now.
Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
Reported-by: Paolo Abeni
Closes:
https://lore.kernel.org/lkml/8470c431e0930d2ea204a9363a60937289b7fdbe.ca...@redhat.com/
Signed-off-by: Aaron Con
Caught during code review.
Fixes: e52b07aa1a54 ("selftests: openvswitch: add flow dump support")
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/o
individual cases.
Aaron Conole (4):
selftests: openvswitch: Add version check for pyroute2
selftests: openvswitch: Catch cases where the tests are killed
selftests: openvswitch: Skip drop testing on older kernels
selftests: openvswitch: Fix the ct_tuple for v4
.../selftests/net/openvswitch
Paolo Abeni writes:
> On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote:
>> Paolo Abeni reports that on some systems the pyroute2 version isn't
>> new enough to run the test suite. Ensure that we support a minimum
>> version of 0.6 for all cases (which does
Paolo Abeni writes:
> On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote:
>> Kernels that don't have support for openvswitch drop reasons also
>> won't have the drop counter reasons, so we should skip the test
>> completely. It previously wasn't possi
Paolo Abeni writes:
> On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote:
>> Caught during code review.
>
> Since there are a few other small things, please additionally expand
> this changelog briefly describing the addressed problem and it's
> consequences.
ACK
individual cases.
Aaron Conole (4):
selftests: openvswitch: Add version check for pyroute2
selftests: openvswitch: Catch cases where the tests are killed
selftests: openvswitch: Skip drop testing on older kernels
selftests: openvswitch: Fix the ct_tuple for v4
.../selftests/net/openvswitch
In case of fatal signal, or early abort at least cleanup the current
test case.
Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/openvswitch.sh | 2 ++
1 file changed, 2 insertions(+)
diff --g
would need additional skip logic anyway. Just draw
a line in the sand now.
Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
Reported-by: Paolo Abeni
Closes:
https://lore.kernel.org/lkml/8470c431e0930d2ea204a9363a60937289b7fdbe.ca...@redhat.com/
Signed-off-by: Aaron
tests: openvswitch: add flow dump support")
Signed-off-by: Aaron Conole
---
v2: More detailed explanation for fix.
tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.p
he flows from a datapath allowing us to test for
explicit drop actions, and then clear the flows to build the
original test case.
Fixes: 4242029164d6 ("selftests: openvswitch: add explicit drop testcase")
Signed-off-by: Aaron Conole
---
v2: Address intermingled tabs vs. spaces
.../
icitly call for it, but we
do require it in setup() if I understand correctly. I don't think it
should hold up this patch though.
Acked-by: Aaron Conole
@faucet.nz/
> Link: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410476.html
> Suggested-by: Aaron Conole
> Signed-off-by: Brad Cowie
> ---
I tested this on a patched kernel and as well as an unpatched kernel and
got the following:
6.5.5-200: TEST: ip4-nat-related: ICMP related matches
.
Additionally, this series provides a selftest in 2/2 that can be used to
determine if the OVS module is allowing unbounded access. It can be
safely omitted where the ovs selftest framework isn't available.
Aaron Conole (2):
net: openvswitch: limit the number of recursions from act
ot;)
Signed-off-by: Aaron Conole
---
v1->v2: Switch to tracking the stack depth by using a depth argument rather than
a per-cpu counter.
net/openvswitch/flow_netlink.c | 49 +++---
1 file changed, 33 insertions(+), 16 deletions(-)
diff --git a/net/openvswitc
Add a test case into the netlink checks that will show the number of
nested action recursions won't exceed 16. Going to 17 on a small
clone call isn't enough to exhaust the stack on (most) systems, so
it should be safe to run even on systems that don't have the fix
applied.
Signe
/ \
-- \
make -C tools/testing/selftests/net/openvswitch \
TARGETS=openvswitch TEST_PROGS=openvswitch.sh run_tests
Aaron Conole (7):
selftests: openvswitch: add test case error directories to clean list
selftests: openvswitch: be more verbose with selftest debugging
selftests
Normally a spawned process under OVS is given a SIGTERM when the test
ends as part of cleanup. However, in case the process is still lingering
for some reason, we also send a SIGKILL to force it down faster.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/openvswitch.sh
Normally, the openvswitch selftests don't keep error files around, but
if debugging, there is an option to keep these files. The 'clean'
target should be informed that they exist to ensure they are deleted
properly.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/
rease the amount of details logged to the debug log by trapping all
'info' logs, and all 'ovs_sbx' commands.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/openvswitch.sh | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/to
timeout gets exceeded, while running under very slow debugging conditions.
The solution here is to cleanup the netns on executing the next test.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/openvswitch.sh | 4
1 file changed, 4 insertions(+)
diff --git a/tools/testing
, and also increase the opportunity to not miss processing
the upcall queue.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/openvswitch.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh
b/tools
different location.
Signed-off-by: Aaron Conole
---
.../testing/selftests/net/openvswitch/openvswitch.sh | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh
b/tools/testing/selftests/net/openvswitch/openvswitch.sh
index a2c106104fb8
file which includes a timeout value that should be sufficent
for such environments.
Signed-off-by: Aaron Conole
---
.../testing/selftests/net/openvswitch/config | 50 +++
.../selftests/net/openvswitch/settings| 1 +
2 files changed, 51 insertions(+)
create mode 100644
Paolo Abeni writes:
> On Fri, 2024-02-16 at 10:28 -0500, Aaron Conole wrote:
>> Many openvswitch test cases reused netns and interface names. This works
>> fine as long as the test case cleans up gracefully. However, if there is
>> some kind of ungraceful termination
Jakub Kicinski writes:
> On Fri, 16 Feb 2024 10:28:39 -0500 Aaron Conole wrote:
>> The series is a host of cleanups to the openvswitch selftest suite
>> which should be ready to run under the netdev selftest runners using
>> vng. For now, the testing has been done wit
Adrian Moreno writes:
> On 2/16/24 16:28, Aaron Conole wrote:
>> Normally a spawned process under OVS is given a SIGTERM when the test
>> ends as part of cleanup. However, in case the process is still lingering
>> for some reason, we also send a SIGKILL to force it down fas
Adrián Moreno writes:
> On Mon, Jun 03, 2024 at 03:00:03PM GMT, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>> > In the action formatting function ("dpstr"), the iteration is made over
>> > the nla_map, so if there are more than one attribute from
the ovs-dpctl.py utility rather than the
typical OVS userspace utilities.
NOTE: This could also be applied as-is. I'm trying to get the vng test
working in my environment, so I submitted as RFC because I didn't
get to test with the config change in 7/7.
Aaron Conole (6):
These will be used in upcoming commits to set specific attributes for
interacting with tunnels. Since set() will use the key parsing routine, we
also make sure to prepend it with an open paren, for the action parsing to
properly understand it.
Signed-off-by: Aaron Conole
---
.../selftests/net
This will be used when setting details about the tunnel to use as
transport. There is a difference between the ODP format between tunnel():
the 'key' flag is not actually a flag field, so we don't support it in the
same way that the vswitchd userspace supports displaying it.
Signe
an be added to the internal ovs test infrastructure, but that is work for
the future. For now, enable the most common cases - wide mega flows with
no other prerequisites.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/pmtu.sh | 87 ++---
1 file changed, 67 inser
: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 43 ---
1 file changed, 28 insertions(+), 15 deletions(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
index 5545e5cab1d6..2577a06c58cf 100644
ackets via these
tunnels, and will be used in an upcoming commit for testing the
path MTU.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 81 +--
1 file changed, 75 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/net/openv
sting
code will be unable to print all of the sets - it will only print the
first.
Refactor this code to be easier to read and support multiple actions of the
same type in an action list.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 45 ++-
1
The pmtu testing will require that the OVS module is installed,
so do that.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/net/config
b/tools/testing/selftests/net/config
index 04de7a6ba6f3
Hi Stefano,
Thanks for the review!
Stefano Brivio writes:
> On Thu, 13 Jun 2024 14:13:32 -0400
> Aaron Conole wrote:
>
>> The current pmtu test infrastucture requires an installed copy of the
>> ovs-vswitchd userspace. This means that any automated or constrained
>>
Adrián Moreno writes:
> On Mon, Jun 03, 2024 at 03:02:46PM GMT, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>> > Netlink flags, although they don't have payload at the netlink level,
>> > are represented as having a "True" value in pyroute2.
&
Adrian Moreno writes:
> Add a test to verify sampling packets via psample works.
>
> In order to do that, create a subcommand in ovs-dpctl.py to listen to
> on the psample multicast group and print samples.
>
> In order to also test simultaneous sFlow and psample actions and
> packet truncation,
Simon Horman writes:
> On Thu, Jun 13, 2024 at 02:13:27PM -0400, Aaron Conole wrote:
>> The OVS module can operate in conjunction with various types of
>> tunnel ports. These are created as either explicit tunnel vport
>> types, OR by creating a tunnel interface which act
Simon Horman writes:
> On Thu, Jun 13, 2024 at 02:13:31PM -0400, Aaron Conole wrote:
>> The current iteration of IPv6 support requires explicit fields to be set
>> in addition to not properly support the actual IPv6 addresses properly.
>> With this change, make it so that t
Adrián Moreno writes:
> On Thu, Jun 13, 2024 at 02:13:29PM GMT, Aaron Conole wrote:
>> These will be used in upcoming commits to set specific attributes for
>> interacting with tunnels. Since set() will use the key parsing routine, we
>> also make sure to prepend it with a
Simon Horman writes:
> On Thu, Jun 13, 2024 at 02:13:30PM -0400, Aaron Conole wrote:
>> This will be used when setting details about the tunnel to use as
>> transport. There is a difference between the ODP format between tunnel():
>> the 'key' flag is not act
the ovs-dpctl.py utility rather than the
typical OVS userspace utilities.
Aaron Conole (7):
selftests: openvswitch: Support explicit tunnel port creation.
selftests: openvswitch: Refactor actions parsing.
selftests: openvswitch: Add set() and set_masked() support.
selftests: openvswitch: Add
ackets via these
tunnels, and will be used in an upcoming commit for testing the
path MTU.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 81 +--
1 file changed, 75 insertions(+), 6 deletions(-)
sting
code will be unable to print all of the sets - it will only print the
first.
Refactor this code to be easier to read and support multiple actions of the
same type in an action list.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitc
This will be used when setting details about the tunnel to use as
transport. There is a difference between the ODP format between tunnel():
the 'key' flag is not actually a flag field, so we don't support it in the
same way that the vswitchd userspace supports displaying it.
Signe
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 37 +--
1 file changed, 34 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
index 4db20b38b481
ning, then try with the
ovs-vswitchd userspace tools.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/pmtu.sh | 145 +++-
1 file changed, 123 insertions(+), 22 deletions(-)
diff --git a/tools/testing/selftests/net/pmtu.sh
b/tools/testing/selftests/net/pmt
The pmtu testing will require that the OVS module is installed,
so do that.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/net/config
b/tools
Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 42 ---
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net/openvswitch
.setvalue(cell[1])
> File "[...]/pyroute2/netlink/__init__.py", line 1265, in setvalue
> nlv.setvalue(nla_tuple[1])
> ~^^^
> IndexError: list index out of range
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
Adrián Moreno writes:
> On Mon, Jun 17, 2024 at 07:18:05AM GMT, Adrián Moreno wrote:
>> On Fri, Jun 14, 2024 at 01:07:33PM GMT, Aaron Conole wrote:
>> > Adrian Moreno writes:
>> >
>> > > Add a test to verify sampling packets via psample works.
>
Aaron Conole writes:
> The current pmtu test infrastucture requires an installed copy of the
> ovs-vswitchd userspace. This means that any automated or constrained
> environments may not have the requisite tools to run the tests. However,
> the pmtu tests don't require any s
Aaron Conole writes:
> The current iteration of IPv6 support requires explicit fields to be set
> in addition to not properly support the actual IPv6 addresses properly.
> With this change, make it so that the ipv6() bare option is usable to
> create wildcarded flows to match bro
the ovs-dpctl.py utility rather than the
typical OVS userspace utilities.
Aaron Conole (7):
selftests: openvswitch: Support explicit tunnel port creation.
selftests: openvswitch: Refactor actions parsing.
selftests: openvswitch: Add set() and set_masked() support.
selftests: openvswitch: Add
ackets via these
tunnels, and will be used in an upcoming commit for testing the
path MTU.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 81 +--
1 file changed, 75 insertions(+), 6 deletions(-)
sting
code will be unable to print all of the sets - it will only print the
first.
Refactor this code to be easier to read and support multiple actions of the
same type in an action list.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitc
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 37 +--
1 file changed, 34 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
index 4db20b38b481
Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
v2: Drop the change in the v6 key class that removed the
str() conversion
.../selftests/net/openvswitch/ovs-dpctl.py| 36 ---
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/tools/testing
This will be used when setting details about the tunnel to use as
transport. There is a difference between the ODP format between tunnel():
the 'key' flag is not actually a flag field, so we don't support it in the
same way that the vswitchd userspace supports displaying it.
Signe
ning, then try with the
ovs-vswitchd userspace tools.
Reviewed-by: Stefano Brivio
Signed-off-by: Aaron Conole
---
v2: Fix a nit in the whitespace
tools/testing/selftests/net/pmtu.sh | 145 +++-
1 file changed, 123 insertions(+), 22 deletions(-)
diff --git a/tools/testing
The pmtu testing will require that the OVS module is installed,
so do that.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/net/config
b/tools
Jakub Kicinski writes:
> On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote:
>> This series enhances the ovs-dpctl utility to provide support for set()
>> and tunnel() flow specifiers, better ipv6 handling support, and the
>> ability to add tunnel vports, and LWT int
Aaron Conole writes:
> Jakub Kicinski writes:
>
>> On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote:
>>> This series enhances the ovs-dpctl utility to provide support for set()
>>> and tunnel() flow specifiers, better ipv6 handling support, and the
>>>
Jakub Kicinski writes:
> On Mon, 24 Jun 2024 12:53:45 -0400 Aaron Conole wrote:
>> Additionally, the "Cannot find device ..." text comes from an iproute2
>> utility output. The only place we actually interact with that is via
>> the call at pmtu.sh:973:
>>
Paolo Abeni writes:
> On Mon, 2024-06-24 at 12:53 -0400, Aaron Conole wrote:
>> Aaron Conole writes:
>>
>> > Jakub Kicinski writes:
>> >
>> > > On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote:
>> > > > This series enhances the
Jakub Kicinski writes:
> On Tue, 25 Jun 2024 09:20:29 -0400 Aaron Conole wrote:
>> > I'm still wondering if the issue is Kconfig-related (plus possibly bad
>> > interaction with vng). I don't see the OVS knob enabled in the self-
>> > tests config. If it&#
Jakub Kicinski writes:
> On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote:
>> > Sorry for not checking it earlier, looks like the runner was missing
>> > pyroute:
>> >
>> > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py
>>
the ovs-dpctl.py utility rather than the
typical OVS userspace utilities. The pmtu.sh can still fall back on
the Open vSwitch userspace utilities if the ovs-dpctl.py script can't
be used.
Aaron Conole (7):
selftests: openvswitch: Support explicit tunnel port creation.
selftests: openvs
ackets via these
tunnels, and will be used in an upcoming commit for testing the
path MTU.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 81 +--
1 file changed, 75 insertions(+), 6 deletions(-)
sting
code will be unable to print all of the sets - it will only print the
first.
Refactor this code to be easier to read and support multiple actions of the
same type in an action list.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitc
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 37 +--
1 file changed, 34 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
index 6bbe15daca74
This will be used when setting details about the tunnel to use as
transport. There is a difference between the ODP format between tunnel():
the 'key' flag is not actually a flag field, so we don't support it in the
same way that the vswitchd userspace supports displaying it.
Signe
Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
v2: Drop the change in the v6 key class that removed the
str() conversion
.../selftests/net/openvswitch/ovs-dpctl.py| 36 ---
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/tools/testing
The pmtu testing will require that the OVS module is installed,
so do that.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/net/config
b/tools
ning, then try with the
ovs-vswitchd userspace tools.
Additionally, make sure that when the pyroute2 package is not available
the ovs-dpctl utility will error out to properly signal an error has
occurred and skip using the internal utility.
Reviewed-by: Stefano Brivio
Signed-off-by: Aaron Conole
--
Adrian Moreno writes:
> The trunc action was supported decode-able but not parse-able. Add
> support for parsing the action string.
>
> Signed-off-by: Adrian Moreno
> ---
Reviewed-by: Aaron Conole
Adrian Moreno writes:
> Add sample and emit_sample action support to ovs-dpctl.py.
>
> Refactor common attribute parsing logic into an external function.
>
> Signed-off-by: Adrian Moreno
> ---
Reviewed-by: Aaron Conole
Adrian Moreno writes:
> The userspace action lacks parsing support plus it contains a bug in the
> name of one of its attributes.
>
> This patch makes userspace action work.
>
> Signed-off-by: Adrian Moreno
> ---
Reviewed-by: Aaron Conole
Simon Horman writes:
> On Tue, Jun 25, 2024 at 01:22:44PM -0400, Aaron Conole wrote:
>> The current pmtu test infrastucture requires an installed copy of the
>> ovs-vswitchd userspace. This means that any automated or constrained
>> environments may not have the requisite t
Jakub Kicinski writes:
> On Tue, 25 Jun 2024 13:22:38 -0400 Aaron Conole wrote:
>> Currently, if a user wants to run pmtu.sh and cover all the provided test
>> cases, they need to install the Open vSwitch userspace utilities. This
>> dependency is difficult for users as we
on upcall packet handler" \
> +$ovs_dir/s0.out | cut -d ":" -f 2 | tr -d ' ')
> +
> + ovs_add_flow "test_psample" psample \
> +"in_port(2),eth(),eth_type(0x0800),ipv4()" \
> +
> "sample
Adrian Moreno writes:
> Add sample and psample action support to ovs-dpctl.py.
>
> Refactor common attribute parsing logic into an external function.
>
> Signed-off-by: Adrian Moreno
> ---
Reviewed-by: Aaron Conole
> .../selftests/net/openvswitch/
Adrián Moreno writes:
> On Mon, Jul 01, 2024 at 02:38:44PM GMT, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>> > Add a test to verify sampling packets via psample works.
>> >
>> > In order to do that, create a subcommand in ovs-dpctl.py to listen
tests (except that patch 3/3 does make some of the debugging a bit
easier by making some output more verbose).
Aaron Conole (3):
selftests: openvswitch: Bump timeout to 15 minutes.
selftests: openvswitch: Attempt to autoload module.
selftests: openvswitch: Be more verbose with selftest debugging
We found that since some tests rely on the TCP SYN timeouts to cause flow
misses, the default test suite timeout of 45 seconds is quick to be
exceeded. Bump the timeout to 15 minutes.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/settings | 1 +
1 file changed, 1
can be autoloaded then we should just attempt to load it and run
the tests. This is especially true in the CI environments, where the CI
tests should be able to rely on auto loading to get the test suite running.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh
rease the amount of details logged to the debug log by trapping all
'info' logs, and all 'ovs_sbx' commands.
Signed-off-by: Aaron Conole
---
NOTE: There is a conflict here with a patch on list that adds psample
support, but it should be simple to resolve, since the confl
Jakub Kicinski writes:
> On Tue, 2 Jul 2024 09:28:27 -0400 Aaron Conole wrote:
>> These patches aim to make using the openvswitch testsuite more reliable.
>> These should address the major sources of flakiness in the openvswitch
>> test suite allowing the CI infrastru
like this does resolve the issue in question on the -dbg
environment:
https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=openvswitch-sh
Thanks Adrian! Also, thanks for including the fractional sleep.
Reviewed-by: Aaron Conole
rings.
>
> Signed-off-by: Adrian Moreno
> ---
Thanks, Adrian.
Reviewed-by: Aaron Conole
Simon Horman writes:
> Hi Aaron, Jakub, all,
>
> I have recently been exercising the Open vSwitch kernel selftests,
> using vng, something like this:
>
> TESTDIR="tools/testing/selftests/net/openvswitch"
>
> vng -v --run . --user root --cpus 2 \
> --overlay-rwdir "$P
Benjamin Poirier writes:
> On 2024-04-24 18:37 +0100, Simon Horman wrote:
>> On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote:
>> > Hi Aaron, Jakub, all,
>> >
>> > I have recently been exercising the Open vSwitch kernel selftests,
>> > using vng, something like this:
>> >
>> >TE
Jakub Kicinski writes:
> On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote:
>> I have recently been exercising the Open vSwitch kernel selftests,
>> using vng,
>
> Speaking of ovs tests, we currently don't run them in CI (and suffer
> related skips in pmtu.sh) because Amazon Linux doesn't hav
Simon Horman writes:
> On Wed, Apr 24, 2024 at 02:14:09PM -0400, Aaron Conole wrote:
>> Simon Horman writes:
>>
>> > Hi Aaron, Jakub, all,
>> >
>> > I have recently been exercising the Open vSwitch kernel selftests,
>> > using vng, somet
Jakub Kicinski writes:
> On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote:
>> openvswitch.sh does not appear to have any dependencies on Open vSwitch
>> user-space. My understanding is that, rather, it makes use of
>> tools/testing/selftests/net/openvswitch/ovs-dpctl.py to talk to the Kernel
Adrian Moreno writes:
> In the action formatting function ("dpstr"), the iteration is made over
> the nla_map, so if there are more than one attribute from the same type
> we only print the first one.
>
> Fix this by iterating over the actual attributes.
>
> Signed-off-by: Adrian Moreno
> ---
>
1 - 100 of 102 matches
Mail list logo
