Re: [PATCH net-next v2 9/9] selftests: openvswitch: add emit_sample test

2024-06-17 Thread Adrián Moreno
On Fri, Jun 14, 2024 at 01:07:33PM GMT, Aaron Conole wrote: > Adrian Moreno writes: > > > Add a test to verify sampling packets via psample works. > > > > In order to do that, create a subcommand in ovs-dpctl.py to listen to > > on the psample multicast group and print samples. > > > > In order to

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Miaohe Lin
On 2024/6/15 0:30, Jiaqi Yan wrote: > On Fri, Jun 14, 2024 at 1:35 AM Lance Yang wrote: >> >> Hi Jiaqi, >> >> On Wed, Jun 12, 2024 at 5:56 AM Jiaqi Yan wrote: >>> >>> Correctable memory errors are very common on servers with large >>> amount of memory, and are corrected by ECC. Soft offline is ke

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Oscar Salvador
On 2024-06-17 09:31, Miaohe Lin wrote: IMHO, it might not be suitable to use EAGAIN. Because it means "Resource temporarily unavailable" and this can be solved by simply retry later without any further actions taken. But I might be wrong. We usually use 'EOPNOTSUPP' when we fail due to a setti

[PATCH v1 0/2] KVM: arm64: Making BT Field in ID_AA64PFR1_EL1 writable

2024-06-17 Thread Shaoqin Huang
In this patch series, we try to make more register fields writable like ID_AA64PFR1_EL1.BT since this can benifit the migration between some of the machines which have different BT values. Changelog: -- RFCv1 -> v1: * Fix the compilation error. * Delete the machine specific information

[PATCH v1 2/2] KVM: selftests: aarch64: Add writable test for ID_AA64PFR1_EL1

2024-06-17 Thread Shaoqin Huang
Add test for the BT field in the ID_AA64PFR1_EL1 register. Signed-off-by: Shaoqin Huang --- tools/testing/selftests/kvm/aarch64/set_id_regs.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/kvm/aarch64/set_id_regs.c b/tools/testing/selftests/kvm/aarch64/set_id_

Re: [PATCH] selftests/mm:fix test_prctl_fork_exec return failure

2024-06-17 Thread David Hildenbrand
On 17.06.24 07:29, aigourensheng wrote: after calling fork() in the test_prctl_fork_exec() function, the global variable ksm_full_scans_fd is initialized to 0 in the child process upon entering the main function of ./ksm_functional_tests. In the function call chain test_child_ksm() -> __mmap_and_

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Miaohe Lin
On 2024/6/17 15:51, Oscar Salvador wrote: > On 2024-06-17 09:31, Miaohe Lin wrote: > >> IMHO, it might not be suitable to use EAGAIN. Because it means >> "Resource temporarily unavailable" and >> this can be solved by simply retry later without any further actions >> taken. But I might be wrong. >

[PATCH net] selftests: openvswitch: Use bash as interpreter

2024-06-17 Thread Simon Horman
openvswitch.sh makes use of substitutions of the form ${ns:0:1}, to obtain the first character of $ns. Empirically, this is works with bash but not dash. When run with dash these evaluate to an empty string and printing an error to stdout. # dash -c 'ns=client; echo "${ns:0:1}"' 2>error # cat er

[PATCH mptcp-next v3 0/6] use network helpers, part 7

2024-06-17 Thread Geliang Tang
From: Geliang Tang v3: - rename start_client to client_socket - Use connect_to_addr in connect_to_fd_opt v2: - update patch 2, extract a new helper start_client. - drop patch 3, keep must_fail in network_helper_opts. Drop type and noconnect from network_helper_opts. And use start_server_str

[PATCH mptcp-next v3 1/6] selftests/bpf: Drop type from network_helper_opts

2024-06-17 Thread Geliang Tang
From: Geliang Tang The opts.{type, noconnect} is at least a bit non intuitive or unnecessary. The only use case now is in test_bpf_ip_check_defrag_ok which ends up bypassing most (or at least some) of the connect_to_fd_opts() logic. It's much better that test should have its own connect_to_fd_opt

[PATCH mptcp-next v3 2/6] selftests/bpf: Use connect_to_addr in connect_to_fd_opt

2024-06-17 Thread Geliang Tang
From: Geliang Tang This patch moves "post_socket_cb" and "noconnect" into connect_to_addr(), then connect_to_fd_opts() can be implemented by getsockname() and connect_to_addr(). This change makes connect_to_* interfaces more unified. Signed-off-by: Geliang Tang --- tools/testing/selftests/bpf/

[PATCH mptcp-next v3 3/6] selftests/bpf: Add client_socket helper

2024-06-17 Thread Geliang Tang
From: Geliang Tang This patch extracts a new helper client_socket() from connect_to_fd_opts() to create the client socket, but don't connect to the server. Then connect_to_fd_opts() can be implemented using client_socket() and connect_fd_to_addr(). This helper can be used in connect_to_addr() too

[PATCH mptcp-next v3 4/6] selftests/bpf: Drop noconnect from network_helper_opts

2024-06-17 Thread Geliang Tang
From: Geliang Tang In test_bpf_ip_check_defrag_ok(), the new helper client_socket() can be used to replace connect_to_fd_opts() with "noconnect" opts, and the strcut member "noconnect" of network_helper_opts can be dropped now, always connect to server in connect_to_fd_opts(). Signed-off-by: Gel

[PATCH mptcp-next v3 5/6] selftests/bpf: Use start_server_str in mptcp

2024-06-17 Thread Geliang Tang
From: Geliang Tang Since start_server_str() is added now, it can be used in mptcp.c in start_mptcp_server() instead of using helpers make_sockaddr() and start_server_addr() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Eduard Zingerman --- tools/testing/selftests/bpf/prog_tests/

[PATCH mptcp-next v3 6/6] selftests/bpf: Use start_server_str in test_tcp_check_syncookie_user

2024-06-17 Thread Geliang Tang
From: Geliang Tang Since start_server_str() is added now, it can be used in script test_tcp_check_syncookie_user.c instead of start_server_addr() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Eduard Zingerman --- .../bpf/test_tcp_check_syncookie_user.c | 29 ++-

Re: [PATCH mptcp-next v3 0/6] use network helpers, part 7

2024-06-17 Thread Geliang Tang
Sorry, v3 breaks the CI. Changes Requested. -Geliang On Mon, 2024-06-17 at 16:33 +0800, Geliang Tang wrote: > From: Geliang Tang > > v3: >  - rename start_client to client_socket >  - Use connect_to_addr in connect_to_fd_opt > > v2: >  - update patch 2, extract a new helper start_client. >  -

Re: [PATCH net] selftests: openvswitch: Use bash as interpreter

2024-06-17 Thread Przemek Kitszel
On 6/17/24 10:28, Simon Horman wrote: openvswitch.sh makes use of substitutions of the form ${ns:0:1}, to obtain the first character of $ns. Empirically, this is works with bash but not dash. When run with dash these evaluate to an empty string and printing an error to stdout. # dash -c 'ns=cl

Re: [PATCH net] selftests: openvswitch: Use bash as interpreter

2024-06-17 Thread Simon Horman
On Mon, Jun 17, 2024 at 12:05:11PM +0200, Przemek Kitszel wrote: > On 6/17/24 10:28, Simon Horman wrote: > > openvswitch.sh makes use of substitutions of the form ${ns:0:1}, to > > obtain the first character of $ns. Empirically, this is works with bash > > but not dash. When run with dash these eva

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Lance Yang
On Mon, Jun 17, 2024 at 4:16 PM Miaohe Lin wrote: > > On 2024/6/17 15:51, Oscar Salvador wrote: > > On 2024-06-17 09:31, Miaohe Lin wrote: > > > >> IMHO, it might not be suitable to use EAGAIN. Because it means > >> "Resource temporarily unavailable" and > >> this can be solved by simply retry lat

Re: [RFC net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

2024-06-17 Thread Adrián Moreno
On Thu, Jun 13, 2024 at 02:13:29PM GMT, Aaron Conole wrote: > These will be used in upcoming commits to set specific attributes for > interacting with tunnels. Since set() will use the key parsing routine, we > also make sure to prepend it with an open paren, for the action parsing to > properly u

Re: [RFC PATCH v1 0/2] KVM: arm64: Making BT Field in ID_AA64PFR1_EL1 writable

2024-06-17 Thread Shaoqin Huang
Hi Marc, On 6/13/24 16:42, Marc Zyngier wrote: On Thu, 13 Jun 2024 09:31:45 +0100, Shaoqin Huang wrote: If we don't care about the FEAT_CNTSC right now. Could I fix the compile issue and respin this again without the background of enabling migration between MtCollins and AmpereOne, and just k

Re: [PATCH net-next v12 01/13] netdev: add netdev_rx_queue_restart()

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Add netdev_rx_queue_restart() function to netdev_rx_queue.h see nit below Reviewed-by: Pavel Begunkov Signed-off-by: David Wei Signed-off-by: Mina Almasry --- v11: - Fix not checking dev->queue_mgmt_ops (Pavel). - Fix ndo_queue_mem_free call that p

[PATCH AUTOSEL 6.9 25/44] selftests: cachestat: Fix build warnings on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit bc4d5f5d2debf8bb65fba188313481549ead8576 ] Fix warnings like: test_cachestat.c: In function ‘print_cachestat’: test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka ‘

[PATCH AUTOSEL 6.9 26/44] selftests/openat2: Fix build warnings on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 84b6df4c49a1cc2854a16937acd5fd3e6315d083 ] Fix warnings like: openat2_test.c: In function ‘test_openat2_flags’: openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘l

[PATCH AUTOSEL 6.9 27/44] selftests/overlayfs: Fix build error on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit e8b8c5264d4ebd248f60a5cef077fe615806e7a0 ] Fix build error on ppc64: dev_in_maps.c: In function ‘get_file_dev_and_inode’: dev_in_maps.c:60:59: error: format ‘%llu’ expects argument of type ‘long long unsigned int *’, but argument 7 has type ‘__u64 *

[PATCH AUTOSEL 6.9 28/44] selftests/futex: pass _GNU_SOURCE without a value to the compiler

2024-06-17 Thread Sasha Levin
From: John Hubbard [ Upstream commit cb708ab9f584f159798b60853edcf0c8b67ce295 ] It's slightly better to set _GNU_SOURCE in the source code, but if one must do it via the compiler invocation, then the best way to do so is this: $(CC) -D_GNU_SOURCE= ...because otherwise, if this form is used

Re: [PATCH net-next v12 03/13] netdev: support binding dma-buf to netdevice

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from

[PATCH AUTOSEL 6.6 22/35] selftests: cachestat: Fix build warnings on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit bc4d5f5d2debf8bb65fba188313481549ead8576 ] Fix warnings like: test_cachestat.c: In function ‘print_cachestat’: test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka ‘

[PATCH AUTOSEL 6.6 23/35] selftests/openat2: Fix build warnings on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 84b6df4c49a1cc2854a16937acd5fd3e6315d083 ] Fix warnings like: openat2_test.c: In function ‘test_openat2_flags’: openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘l

[PATCH AUTOSEL 6.6 24/35] selftests/futex: pass _GNU_SOURCE without a value to the compiler

2024-06-17 Thread Sasha Levin
From: John Hubbard [ Upstream commit cb708ab9f584f159798b60853edcf0c8b67ce295 ] It's slightly better to set _GNU_SOURCE in the source code, but if one must do it via the compiler invocation, then the best way to do so is this: $(CC) -D_GNU_SOURCE= ...because otherwise, if this form is used

[PATCH AUTOSEL 6.1 20/29] selftests/openat2: Fix build warnings on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 84b6df4c49a1cc2854a16937acd5fd3e6315d083 ] Fix warnings like: openat2_test.c: In function ‘test_openat2_flags’: openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘l

[PATCH AUTOSEL 6.1 21/29] selftests/futex: pass _GNU_SOURCE without a value to the compiler

2024-06-17 Thread Sasha Levin
From: John Hubbard [ Upstream commit cb708ab9f584f159798b60853edcf0c8b67ce295 ] It's slightly better to set _GNU_SOURCE in the source code, but if one must do it via the compiler invocation, then the best way to do so is this: $(CC) -D_GNU_SOURCE= ...because otherwise, if this form is used

[PATCH AUTOSEL 5.15 14/21] selftests/openat2: Fix build warnings on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 84b6df4c49a1cc2854a16937acd5fd3e6315d083 ] Fix warnings like: openat2_test.c: In function ‘test_openat2_flags’: openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘l

[PATCH AUTOSEL 5.10 06/13] selftests/openat2: Fix build warnings on ppc64

2024-06-17 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit 84b6df4c49a1cc2854a16937acd5fd3e6315d083 ] Fix warnings like: openat2_test.c: In function ‘test_openat2_flags’: openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘l

Re: [PATCH net-next v12 04/13] netdev: netdevice devmem allocator

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory regi

Re: [PATCH net] selftests: mptcp: userspace_pm: fixed subtest names

2024-06-17 Thread Simon Horman
On Fri, Jun 14, 2024 at 07:15:29PM +0200, Matthieu Baerts (NGI0) wrote: > It is important to have fixed (sub)test names in TAP, because these > names are used to identify them. If they are not fixed, tracking cannot > be done. > > Some subtests from the userspace_pm selftest were using random numb

Re: [PATCH net-next v12 06/13] page_pool: devmem support

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack

[PATCH-cgroup v2 1/5] cgroup/cpuset: Fix remote root partition creation problem

2024-06-17 Thread Waiman Long
Since commit 181c8e091aae ("cgroup/cpuset: Introduce remote partition"), a remote partition can be created underneath a non-partition root cpuset as long as its exclusive_cpus are set to distribute exclusive CPUs down to its children. The generate_sched_domains() function, however, doesn't take int

[PATCH-cgroup v2 0/5] cgroup/cpuset: Fix miscellaneous issues

2024-06-17 Thread Waiman Long
v2: - Fix test_cpuset_prs.sh problems reported by test robot - Relax restriction imposed between cpuset.cpus.exclusive and cpuset.cpus of sibling cpusets. - Make cpuset.cpus.exclusive independent of cpuset.cpus. - Update test_cpuset_prs.sh accordingly. [v1] https://lore.kernel.org

[PATCH-cgroup v2 2/5] selftest/cgroup: Fix test_cpuset_prs.sh problems reported by test robot

2024-06-17 Thread Waiman Long
The test robot reported two different problems when running the test_cpuset_prs.sh test. # ./test_cpuset_prs.sh: line 106: echo: write error: Input/output error # : # Effective cpus changed to 0-1,4-7 after test 4! The write error is caused by writing to /dev/console. It looks like some syste

[PATCH-cgroup v2 5/5] selftest/cgroup: Update test_cpuset_prs.sh to match changes

2024-06-17 Thread Waiman Long
Unlike the list of isolated CPUs, it is not easy to programamatically determine what sched domains are being created by the scheduler just by examinng the data in various kernfs filesystems. The easiest way to get this information is by enabling /sys/kernel/debug/sched/verbose file to make those in

Re: [PATCH net-next v12 07/13] memory-provider: dmabuf devmem memory provider

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The p

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Jiaqi Yan
On Mon, Jun 17, 2024 at 3:34 AM Lance Yang wrote: > > On Mon, Jun 17, 2024 at 4:16 PM Miaohe Lin wrote: > > > > On 2024/6/17 15:51, Oscar Salvador wrote: > > > On 2024-06-17 09:31, Miaohe Lin wrote: > > > > > >> IMHO, it might not be suitable to use EAGAIN. Because it means > > >> "Resource tempo

[PATCH-cgroup v2 3/5] cgroup/cpuset: Delay setting of CS_CPU_EXCLUSIVE until valid partition

2024-06-17 Thread Waiman Long
The CS_CPU_EXCLUSIVE flag is currently set whenever cpuset.cpus.exclusive is set to make sure that the exclusivity test will be run to ensure its exclusiveness. At the same time, this flag can be changed whenever the partition root state is changed. For example, the CS_CPU_EXCLUSIVE flag will be re

[PATCH-cgroup v2 4/5] cgroup/cpuset: Make cpuset.cpus.exclusive independent of cpuset.cpus

2024-06-17 Thread Waiman Long
The "cpuset.cpus.exclusive.effective" value is currently limited to a subset of its "cpuset.cpus". This makes the exclusive CPUs distribution hierarchy subsumed within the larger "cpuset.cpus" hierarchy. We have to decide on what CPUs are used locally and what CPUs can be passed down as exclusive C

Re: [PATCH v17 5/5] x86: vdso: Wire up getrandom() vDSO implementation

2024-06-17 Thread Jason A. Donenfeld
On Fri, Jun 14, 2024 at 06:53:09PM -0700, John Hubbard wrote: > I'm adding linux-kselftest to Cc for visibility, and I've also Cc'd you > on a related selftests/vDSO series I just now posted [1]. > be part of TEST_GEN_PROGS. Fixing it requires other changes, though, as > I've done in [2]. If you c

Re: [PATCH V3] rcutorture: Add CFcommon.arch for the various arch's need

2024-06-17 Thread Mark Rutland
On Tue, Jun 11, 2024 at 07:57:29PM -0700, Paul E. McKenney wrote: > On Wed, Jun 12, 2024 at 01:35:27AM +, Zhouyi Zhou wrote: > > Add CFcommon.arch for the various arch's need for rcutorture. > > > > According to [1] and [2], this patch > > Fixes: a6fda6dab93c ("rcutorture: Tweak kvm options")

Re: [PATCH net-next v12 10/13] tcp: RX path for devmem TCP

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header

Re: [PATCH V3] rcutorture: Add CFcommon.arch for the various arch's need

2024-06-17 Thread Paul E. McKenney
On Mon, Jun 17, 2024 at 05:28:14PM +0100, Mark Rutland wrote: > On Tue, Jun 11, 2024 at 07:57:29PM -0700, Paul E. McKenney wrote: > > On Wed, Jun 12, 2024 at 01:35:27AM +, Zhouyi Zhou wrote: > > > Add CFcommon.arch for the various arch's need for rcutorture. > > > > > > According to [1] and [2

Re: [ovs-dev] [RFC net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation.

2024-06-17 Thread Aaron Conole
Simon Horman writes: > On Thu, Jun 13, 2024 at 02:13:27PM -0400, Aaron Conole wrote: >> The OVS module can operate in conjunction with various types of >> tunnel ports. These are created as either explicit tunnel vport >> types, OR by creating a tunnel interface which acts as an anchor >> for th

Re: [ovs-dev] [RFC net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments.

2024-06-17 Thread Aaron Conole
Simon Horman writes: > On Thu, Jun 13, 2024 at 02:13:31PM -0400, Aaron Conole wrote: >> The current iteration of IPv6 support requires explicit fields to be set >> in addition to not properly support the actual IPv6 addresses properly. >> With this change, make it so that the ipv6() bare option i

[PATCH v3 0/3] Userspace controls soft-offline pages

2024-06-17 Thread Jiaqi Yan
Correctable memory errors are very common on servers with large amount of memory, and are corrected by ECC, but with two pain points to users: 1. Correction usually happens on the fly and adds latency overhead 2. Not-fully-proved theory states excessive correctable memory errors can develop into

[PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Jiaqi Yan
Correctable memory errors are very common on servers with large amount of memory, and are corrected by ECC. Soft offline is kernel's additional recovery handling for memory pages having (excessive) corrected memory errors. Impacted page is migrated to a healthy page if it is in-use; the original pa

[PATCH v3 2/3] selftest/mm: test enable_soft_offline behaviors

2024-06-17 Thread Jiaqi Yan
Add regression and new tests when hugepage has correctable memory errors, and how userspace wants to deal with it: * if enable_soft_offline=1, mapped hugepage is soft offlined * if enable_soft_offline=0, mapped hugepage is intact Free hugepages case is not explicitly covered by the tests. Hugepag

[PATCH v3 3/3] docs: mm: add enable_soft_offline sysctl

2024-06-17 Thread Jiaqi Yan
Add the documentation for soft offline behaviors / costs, and what the new enable_soft_offline sysctl is for. Signed-off-by: Jiaqi Yan --- Documentation/admin-guide/sysctl/vm.rst | 33 + 1 file changed, 33 insertions(+) diff --git a/Documentation/admin-guide/sysctl/vm.rs

Re: [RFC net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

2024-06-17 Thread Aaron Conole
Adrián Moreno writes: > On Thu, Jun 13, 2024 at 02:13:29PM GMT, Aaron Conole wrote: >> These will be used in upcoming commits to set specific attributes for >> interacting with tunnels. Since set() will use the key parsing routine, we >> also make sure to prepend it with an open paren, for the a

Re: [PATCH v1 0/2] KVM: arm64: Making BT Field in ID_AA64PFR1_EL1 writable

2024-06-17 Thread Oliver Upton
On Mon, Jun 17, 2024 at 03:51:29AM -0400, Shaoqin Huang wrote: > In this patch series, we try to make more register fields writable like > ID_AA64PFR1_EL1.BT since this can benifit the migration between some of the > machines which have different BT values. > > Changelog: > -- > RFCv1 -> v

[PATCH] kunit/usercopy: Disable testing on !CONFIG_MMU

2024-06-17 Thread Kees Cook
Since arch_pick_mmap_layout() is an inline for non-MMU systems, disable this test there. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202406160505.ubge6tmy-...@intel.com/ Signed-off-by: Kees Cook --- Cc: Brendan Higgins Cc: David Gow Cc: Rae Moar Cc: "Gustavo

Re: [PATCH net-next v12 05/13] page_pool: convert to use netmem

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Abstrace the memory type from the page_pool so we can later add support for new memory types. Convert the page_pool to use the new netmem type abstraction, rather than use struct page directly. As of this patch the netmem type is a no-op abstraction: it's al

Re: [ovs-dev] [RFC net-next 4/7] selftests: openvswitch: Add support for tunnel() key.

2024-06-17 Thread Aaron Conole
Simon Horman writes: > On Thu, Jun 13, 2024 at 02:13:30PM -0400, Aaron Conole wrote: >> This will be used when setting details about the tunnel to use as >> transport. There is a difference between the ODP format between tunnel(): >> the 'key' flag is not actually a flag field, so we don't suppo

[PATCH net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-17 Thread Aaron Conole
Currently, if a user wants to run pmtu.sh and cover all the provided test cases, they need to install the Open vSwitch userspace utilities. This dependency is difficult for users as well as CI environments, because the userspace build and setup may require lots of support and devel packages to be

[PATCH net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation.

2024-06-17 Thread Aaron Conole
The OVS module can operate in conjunction with various types of tunnel ports. These are created as either explicit tunnel vport types, OR by creating a tunnel interface which acts as an anchor for the lightweight tunnel support. This patch adds the ability to add tunnel ports to an OVS datapath f

[PATCH net-next 2/7] selftests: openvswitch: Refactor actions parsing.

2024-06-17 Thread Aaron Conole
Until recently, the ovs-dpctl utility was used with a limited actions set and didn't need to have support for multiple similar actions. However, when adding support for tunnels, it will be important to support multiple set() actions in a single flow. When printing these actions, the existing code

[PATCH net-next 4/7] selftests: openvswitch: Add support for tunnel() key.

2024-06-17 Thread Aaron Conole
This will be used when setting details about the tunnel to use as transport. There is a difference between the ODP format between tunnel(): the 'key' flag is not actually a flag field, so we don't support it in the same way that the vswitchd userspace supports displaying it. Signed-off-by: Aaron

[PATCH net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

2024-06-17 Thread Aaron Conole
These will be used in upcoming commits to set specific attributes for interacting with tunnels. Since set() will use the key parsing routine, we also make sure to prepend it with an open paren, for the action parsing to properly understand it. Reviewed-by: Simon Horman Tested-by: Simon Horman S

[PATCH net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

2024-06-17 Thread Aaron Conole
The current pmtu test infrastucture requires an installed copy of the ovs-vswitchd userspace. This means that any automated or constrained environments may not have the requisite tools to run the tests. However, the pmtu tests don't require any special classifier processing. Indeed they are only

[PATCH net-next 7/7] selftests: net: add config for openvswitch

2024-06-17 Thread Aaron Conole
The pmtu testing will require that the OVS module is installed, so do that. Reviewed-by: Simon Horman Tested-by: Simon Horman Signed-off-by: Aaron Conole --- tools/testing/selftests/net/config | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/net/config b/tools/

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-17 Thread Pavel Begunkov
On 6/11/24 07:34, Christoph Hellwig wrote: On Fri, Jun 07, 2024 at 02:45:55PM +0100, Pavel Begunkov wrote: On 6/5/24 09:24, Christoph Hellwig wrote: On Mon, Jun 03, 2024 at 03:52:32PM +0100, Pavel Begunkov wrote: The question for Christoph is what exactly is the objection here? Why we would no

Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal

2024-06-17 Thread David Hildenbrand
On 14.06.24 20:02, John Hubbard wrote: On 6/14/24 5:41 AM, David Hildenbrand wrote: On 14.06.24 14:28, David Hildenbrand wrote: On 14.06.24 04:30, John Hubbard wrote: The selftests/mm build isn't exactly "broken", according to the current documentation, which still claims that one must run "ma

[PATCH net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments.

2024-06-17 Thread Aaron Conole
The current iteration of IPv6 support requires explicit fields to be set in addition to not properly support the actual IPv6 addresses properly. With this change, make it so that the ipv6() bare option is usable to create wildcarded flows to match broad swaths of ipv6 traffic. Reviewed-by: Simon H

Re: [PATCH net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

2024-06-17 Thread Stefano Brivio
On Mon, 17 Jun 2024 14:02:17 -0400 Aaron Conole wrote: > The current pmtu test infrastucture requires an installed copy of the > ovs-vswitchd userspace. This means that any automated or constrained > environments may not have the requisite tools to run the tests. However, > the pmtu tests don't

Re: [PATCH v3 2/2] usercopy: Convert test_user_copy to KUnit test

2024-06-17 Thread Kees Cook
On Fri, Jun 14, 2024 at 09:50:05AM -0600, Shuah Khan wrote: > On 6/12/24 13:59, Kees Cook wrote: > > Convert the runtime tests of hardened usercopy to standard KUnit tests. > > > > Additionally disable usercopy_test_invalid() for systems with separate > > address spaces (or no MMU) since it's not

Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Andrew Morton
On Mon, 17 Jun 2024 17:05:43 + Jiaqi Yan wrote: > Correctable memory errors are very common on servers with large > amount of memory, and are corrected by ECC. Soft offline is kernel's > additional recovery handling for memory pages having (excessive) > corrected memory errors. Impacted page

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-17 Thread Pavel Begunkov
On 6/10/24 23:15, Jason Gunthorpe wrote: On Mon, Jun 10, 2024 at 08:20:08PM +0100, Pavel Begunkov wrote: On 6/10/24 16:16, David Ahern wrote: There is no reason you shouldn't be able to use your fast io_uring completion and lifecycle flow with DMABUF backed memory. Those are not widly differe

Re: [PATCH v3 2/2] usercopy: Convert test_user_copy to KUnit test

2024-06-17 Thread Shuah Khan
On 6/17/24 13:00, Kees Cook wrote: On Fri, Jun 14, 2024 at 09:50:05AM -0600, Shuah Khan wrote: On 6/12/24 13:59, Kees Cook wrote: Convert the runtime tests of hardened usercopy to standard KUnit tests. Additionally disable usercopy_test_invalid() for systems with separate address spaces (or no

Shuah, Andy L: [PATCH v3 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup

2024-06-17 Thread John Hubbard
On 6/14/24 4:34 PM, John Hubbard wrote: On 6/14/24 4:31 PM, John Hubbard wrote: Hi, Jason A. Donenfeld, I've added you because I ended up looking through your latest "implement getrandom() in vDSO" series [1], which also touches this Makefile, so just a heads up about upcoming (minor) merge con

Re: [PATCH bpf-next v4 06/12] bpf: selftests: Fix bpf_session_cookie() kfunc prototype

2024-06-17 Thread Andrii Nakryiko
On Mon, Jun 10, 2024 at 6:04 AM Jiri Olsa wrote: > > On Sat, Jun 08, 2024 at 03:16:02PM -0600, Daniel Xu wrote: > > The prototype defined in bpf_kfuncs.h was not in line with how the > > actual kfunc was defined. This causes compilation errors when kfunc > > prototypes are generated from BTF. > >

Re: [PATCH V3] rcutorture: Add CFcommon.arch for the various arch's need

2024-06-17 Thread Zhouyi Zhou
On Tue, Jun 18, 2024 at 12:47 AM Paul E. McKenney wrote: > > On Mon, Jun 17, 2024 at 05:28:14PM +0100, Mark Rutland wrote: > > On Tue, Jun 11, 2024 at 07:57:29PM -0700, Paul E. McKenney wrote: > > > On Wed, Jun 12, 2024 at 01:35:27AM +, Zhouyi Zhou wrote: > > > > Add CFcommon.arch for the vari

Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Jiaqi Yan
On Mon, Jun 17, 2024 at 12:13 PM Andrew Morton wrote: > > On Mon, 17 Jun 2024 17:05:43 + Jiaqi Yan wrote: > > > Correctable memory errors are very common on servers with large > > amount of memory, and are corrected by ECC. Soft offline is kernel's > > additional recovery handling for memory

Re: [PATCH v9 2/3] KVM: selftests: aarch64: Introduce pmu_event_filter_test

2024-06-17 Thread Raghavendra Rao Ananta
Hi Shaoqin On Thu, Jun 13, 2024 at 1:28 AM Shaoqin Huang wrote: > +static void prepare_expected_pmce(struct kvm_pmu_event_filter *filter) > +{ > + struct pmu_common_event_ids pmce_mask = { ~0, ~0 }; > + bool first_filter = true; > + int i; > + > + while (filter && filter

Re: [PATCH v9 3/3] KVM: selftests: aarch64: Add invalid filter test in pmu_event_filter_test

2024-06-17 Thread Raghavendra Rao Ananta
Hi Shaoqin, On Thu, Jun 13, 2024 at 1:27 AM Shaoqin Huang wrote: > > Add the invalid filter test which sets the filter beyond the event > space and sets the invalid action to double check if the > KVM_ARM_VCPU_PMU_V3_FILTER will return the expected error. > > Reviewed-by: Eric Auger > Signed-off

Re: [PATCH net] selftests: mptcp: userspace_pm: fixed subtest names

2024-06-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 14 Jun 2024 19:15:29 +0200 you wrote: > It is important to have fixed (sub)test names in TAP, because these > names are used to identify them. If they are not fixed, tracking cannot > be done. > > Some subtests fr

Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal

2024-06-17 Thread John Hubbard
On 6/17/24 11:11 AM, David Hildenbrand wrote: On 14.06.24 20:02, John Hubbard wrote: On 6/14/24 5:41 AM, David Hildenbrand wrote: On 14.06.24 14:28, David Hildenbrand wrote: On 14.06.24 04:30, John Hubbard wrote: ... ... thinking again, are some of these headers arch-specific (IOW, generatin

[PATCH v3 0/6] cleanups, fixes, and progress towards avoiding "make headers"

2024-06-17 Thread John Hubbard
Changes since v2: a) After some disussion with David Hildenbrand, simplified the "fix missing __NR_mseal" patch down to just two lines of diff, after all. b) Improved the "kvm, mdwe fixes to avoid requiring "make headers"" patch by taking a snapshot of the prctl.h, instead of manually creating de

[PATCH v3 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal

2024-06-17 Thread John Hubbard
The selftests/mm build isn't exactly "broken", according to the current documentation, which still claims that one must run "make headers", before building the kselftests. However, according to the new plan to get rid of that requirement [1], they are future-broken: attempting to build selftests/mm

[PATCH v3 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items

2024-06-17 Thread John Hubbard
Clean up and move some copy-pasted items into a new mseal_helpers.h. 1. The test macros can be made safer and simpler, by observing that they are invariably called when about to return. This means that the macros do not need an intrusive label to goto; they can simply return. 2. PKEY* items. We c

[PATCH v3 3/6] selftests/mm: mseal, self_elf: rename TEST_END_CHECK to REPORT_TEST_PASS

2024-06-17 Thread John Hubbard
Now that the test macros are factored out into their final location, and simplified, it's time to rename TEST_END_CHECK to something that represents its new functionality: REPORT_TEST_PASS. Acked-by: David Hildenbrand Reviewed-by: Jeff Xu Tested-by: Jeff Xu Signed-off-by: John Hubbard --- too

[PATCH v3 5/6] selftests/mm: kvm, mdwe fixes to avoid requiring "make headers"

2024-06-17 Thread John Hubbard
On Ubuntu 23.04, the kvm and mdwe selftests/mm build fails due to missing a few items that are found in prctl.h. Here is an excerpt of the build failures: ksm_tests.c:252:13: error: use of undeclared identifier 'PR_SET_MEMORY_MERGE' ... mdwe_test.c:26:18: error: use of undeclared identifier 'PR_SE

[PATCH v3 4/6] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h

2024-06-17 Thread John Hubbard
On Ubuntu 23.04, on a clean git tree, the selftests/mm build fails due 10 or 20 missing items, all of which are found in fs.h, which is created via "make headers". However, as per [1], the idea is to stop requiring "make headers", and instead, take a snapshot of the files and check them in. Here a

[PATCH v3 6/6] selftests/mm: remove local __NR_* definitions

2024-06-17 Thread John Hubbard
This continues the work on getting the selftests to build without requiring people to first run "make headers" [1]. Now that the system call numbers are in the correct, checked-in locations in the kernel tree (./tools/include/uapi/asm/unistd*.h), make sure that the mm selftests include that file (

Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-17 Thread Miaohe Lin
On 2024/6/18 7:17, Jiaqi Yan wrote: > On Mon, Jun 17, 2024 at 12:13 PM Andrew Morton > wrote: >> >> On Mon, 17 Jun 2024 17:05:43 + Jiaqi Yan wrote: >> >>> Correctable memory errors are very common on servers with large >>> amount of memory, and are corrected by ECC. Soft offline is kernel's >

[PATCH bpf-next v4 0/6] use network helpers, part 7

2024-06-17 Thread Geliang Tang
From: Geliang Tang v4: - fix errors reported by CI. v3: - rename start_client to client_socket - Use connect_to_addr in connect_to_fd_opt v2: - update patch 2, extract a new helper start_client. - drop patch 3, keep must_fail in network_helper_opts. Drop type and noconnect from network_he

[PATCH bpf-next v4 1/6] selftests/bpf: Drop type from network_helper_opts

2024-06-17 Thread Geliang Tang
From: Geliang Tang The opts.{type, noconnect} is at least a bit non intuitive or unnecessary. The only use case now is in test_bpf_ip_check_defrag_ok which ends up bypassing most (or at least some) of the connect_to_fd_opts() logic. It's much better that test should have its own connect_to_fd_opt

[PATCH bpf-next v4 2/6] selftests/bpf: Use connect_to_addr in connect_to_fd_opt

2024-06-17 Thread Geliang Tang
From: Geliang Tang This patch moves "post_socket_cb" and "noconnect" into connect_to_addr(), then connect_to_fd_opts() can be implemented by getsockname() and connect_to_addr(). This change makes connect_to_* interfaces more unified. Signed-off-by: Geliang Tang --- tools/testing/selftests/bpf/

[PATCH bpf-next v4 3/6] selftests/bpf: Add client_socket helper

2024-06-17 Thread Geliang Tang
From: Geliang Tang This patch extracts a new helper client_socket() from connect_to_fd_opts() to create the client socket, but don't connect to the server. Then connect_to_fd_opts() can be implemented using client_socket() and connect_fd_to_addr(). This helper can be used in connect_to_addr() too

[PATCH bpf-next v4 4/6] selftests/bpf: Drop noconnect from network_helper_opts

2024-06-17 Thread Geliang Tang
From: Geliang Tang In test_bpf_ip_check_defrag_ok(), the new helper client_socket() can be used to replace connect_to_fd_opts() with "noconnect" opts, and the strcut member "noconnect" of network_helper_opts can be dropped now, always connect to server in connect_to_fd_opts(). Signed-off-by: Gel

[PATCH bpf-next v4 5/6] selftests/bpf: Use start_server_str in mptcp

2024-06-17 Thread Geliang Tang
From: Geliang Tang Since start_server_str() is added now, it can be used in mptcp.c in start_mptcp_server() instead of using helpers make_sockaddr() and start_server_addr() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Eduard Zingerman --- tools/testing/selftests/bpf/prog_tests/

[PATCH bpf-next v4 6/6] selftests/bpf: Use start_server_str in test_tcp_check_syncookie_user

2024-06-17 Thread Geliang Tang
From: Geliang Tang Since start_server_str() is added now, it can be used in script test_tcp_check_syncookie_user.c instead of start_server_addr() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Eduard Zingerman --- .../bpf/test_tcp_check_syncookie_user.c | 29 ++-

Re: [PATCH v1 0/2] KVM: arm64: Making BT Field in ID_AA64PFR1_EL1 writable

2024-06-17 Thread Shaoqin Huang
Hi Oliver, On 6/18/24 01:40, Oliver Upton wrote: On Mon, Jun 17, 2024 at 03:51:29AM -0400, Shaoqin Huang wrote: In this patch series, we try to make more register fields writable like ID_AA64PFR1_EL1.BT since this can benifit the migration between some of the machines which have different BT va

[PATCH v2 0/2] Allow userspace to change ID_AA64PFR1_EL1

2024-06-17 Thread Shaoqin Huang
Allow userspace to change the guest-visible value of the register with some severe limitation: - No changes to features not virtualized by KVM (MPAM_frac, RAS_frac) Also add the selftest for it. Changelog: -- v1 -> v2: * Tackling the full register instead of single field. * Changin

  1   2   >