Re: selftests/livepatch fails on s390

2023-12-20 Thread Petr Mladek
On Tue 2023-12-19 09:50:18, Joe Lawrence wrote: > On 12/19/23 04:45, Alexander Gordeev wrote: > > On Mon, Dec 18, 2023 at 05:44:54PM -0500, Joe Lawrence wrote: > > > >> @@ -280,7 +268,13 @@ function set_pre_patch_ret { > >> function start_test { > >>local test="$1" > >> > >> - save_dmesg >

Re: selftests/livepatch fails on s390

2023-12-19 Thread Alexander Gordeev
On Tue, Dec 19, 2023 at 09:50:18AM -0500, Joe Lawrence wrote: > There is a loop_util() utility function in the script that could be used > to wait, like: > > log "$last_dmesg_msg" > loop_until "dmesg | grep -q '$last_dmesg_msg'" || > die "Can't find canary dmesg entry, bu

Re: selftests/livepatch fails on s390

2023-12-19 Thread Joe Lawrence
On 12/19/23 04:45, Alexander Gordeev wrote: > On Mon, Dec 18, 2023 at 05:44:54PM -0500, Joe Lawrence wrote: > >> @@ -280,7 +268,13 @@ function set_pre_patch_ret { >> function start_test { >> local test="$1" >> >> -save_dmesg >> +# Dump something unique into the dmesg log, then stas

Re: selftests/livepatch fails on s390

2023-12-19 Thread Alexander Gordeev
On Mon, Dec 18, 2023 at 05:44:54PM -0500, Joe Lawrence wrote: Hi Joe! ... > > If we pre-trim the timestamps, the output is what we expect: > > > > $ comm --nocheck-order -13 \ > > <(sed 's/^\[[ 0-9.]*\] //' /tmp/A) \ > > <(sed 's/^\[[ 0-9.]*\] //' /tmp/B) > > message four > > >

Re: selftests/livepatch fails on s390

2023-12-18 Thread Joe Lawrence
On Mon, Dec 18, 2023 at 11:44:23AM -0500, Joe Lawrence wrote: > > [ ... snip ... ] > > If we pre-trim the timestamps, the output is what we expect: > > $ comm --nocheck-order -13 \ > <(sed 's/^\[[ 0-9.]*\] //' /tmp/A) \ > <(sed 's/^\[[ 0-9.]*\] //' /tmp/B) > message four > > ho

Re: selftests/livepatch fails on s390

2023-12-18 Thread Joe Lawrence
On 12/18/23 05:44, Alexander Gordeev wrote: > Hi all, > > The livepatch selftest somehow fails in -next on s390 due to what > appears to me as 'comm' usage issue. E.g the removal of timestamp- > less line "with link type OSD_10GIG." in the below output forces > 'comm' to produce the correct resul