Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-12-05 Thread Johannes Weiner
On Mon, Dec 04, 2023 at 04:30:44PM -0800, Chris Li wrote: > On Thu, Nov 30, 2023 at 12:35 PM Johannes Weiner wrote: > > > > On Thu, Nov 30, 2023 at 12:07:41PM -0800, Nhat Pham wrote: > > > On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox > > > wrote: > > > > > > > > On Thu, Nov 30, 2023 at 11:40:

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-12-04 Thread Chengming Zhou
On 2023/12/5 01:48, Nhat Pham wrote: > On Mon, Dec 4, 2023 at 12:30 AM Chengming Zhou > wrote: >> >> On 2023/12/1 04:35, Johannes Weiner wrote: >>> On Thu, Nov 30, 2023 at 12:07:41PM -0800, Nhat Pham wrote: On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox wrote: > > On Thu, Nov

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-12-04 Thread Chris Li
On Thu, Nov 30, 2023 at 12:35 PM Johannes Weiner wrote: > > On Thu, Nov 30, 2023 at 12:07:41PM -0800, Nhat Pham wrote: > > On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox wrote: > > > > > > On Thu, Nov 30, 2023 at 11:40:18AM -0800, Nhat Pham wrote: > > > > This patch changes list_lru interface so

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-12-04 Thread Nhat Pham
On Mon, Dec 4, 2023 at 12:30 AM Chengming Zhou wrote: > > On 2023/12/1 04:35, Johannes Weiner wrote: > > On Thu, Nov 30, 2023 at 12:07:41PM -0800, Nhat Pham wrote: > >> On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox > >> wrote: > >>> > >>> On Thu, Nov 30, 2023 at 11:40:18AM -0800, Nhat Pham wro

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-12-04 Thread Chengming Zhou
On 2023/12/1 04:35, Johannes Weiner wrote: > On Thu, Nov 30, 2023 at 12:07:41PM -0800, Nhat Pham wrote: >> On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox wrote: >>> >>> On Thu, Nov 30, 2023 at 11:40:18AM -0800, Nhat Pham wrote: This patch changes list_lru interface so that the caller must ex

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-11-30 Thread Johannes Weiner
On Thu, Nov 30, 2023 at 12:07:41PM -0800, Nhat Pham wrote: > On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox wrote: > > > > On Thu, Nov 30, 2023 at 11:40:18AM -0800, Nhat Pham wrote: > > > This patch changes list_lru interface so that the caller must explicitly > > > specify numa node and memcg wh

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-11-30 Thread Nhat Pham
On Thu, Nov 30, 2023 at 11:57 AM Matthew Wilcox wrote: > > On Thu, Nov 30, 2023 at 11:40:18AM -0800, Nhat Pham wrote: > > This patch changes list_lru interface so that the caller must explicitly > > specify numa node and memcg when adding and removing objects. The old > > list_lru_add() and list_l

Re: [PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-11-30 Thread Matthew Wilcox
On Thu, Nov 30, 2023 at 11:40:18AM -0800, Nhat Pham wrote: > This patch changes list_lru interface so that the caller must explicitly > specify numa node and memcg when adding and removing objects. The old > list_lru_add() and list_lru_del() are renamed to list_lru_add_obj() and > list_lru_del_obj(

[PATCH v8 1/6] list_lru: allows explicit memcg and NUMA node selection

2023-11-30 Thread Nhat Pham
The interface of list_lru is based on the assumption that the list node and the data it represents belong to the same allocated on the correct node/memcg. While this assumption is valid for existing slab objects LRU such as dentries and inodes, it is undocumented, and rather inflexible for certain