Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-07 Thread Zi Yan
On 26 Feb 2024, at 15:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_list_to_order for pagecache THPs. > Also add test cases for split_huge_page_to_list_to_order via both > debugfs. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 34

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-04 Thread Zi Yan
On 4 Mar 2024, at 10:57, Zi Yan wrote: > On 4 Mar 2024, at 10:44, Aishwarya TCV wrote: > >> On 04/03/2024 14:58, Zi Yan wrote: >>> On 4 Mar 2024, at 4:50, Aishwarya TCV wrote: >>> On 01/03/2024 21:10, Zi Yan wrote: > On 1 Mar 2024, at 15:02, Zi Yan wrote: > >> On 1 Mar 2024, at 14

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-04 Thread Zi Yan
On 4 Mar 2024, at 13:25, Aishwarya TCV wrote: > On 04/03/2024 15:57, Zi Yan wrote: >> On 4 Mar 2024, at 10:44, Aishwarya TCV wrote: >> >>> On 04/03/2024 14:58, Zi Yan wrote: On 4 Mar 2024, at 4:50, Aishwarya TCV wrote: > On 01/03/2024 21:10, Zi Yan wrote: >> On 1 Mar 2024, at 15:

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-04 Thread Aishwarya TCV
On 04/03/2024 15:57, Zi Yan wrote: > On 4 Mar 2024, at 10:44, Aishwarya TCV wrote: > >> On 04/03/2024 14:58, Zi Yan wrote: >>> On 4 Mar 2024, at 4:50, Aishwarya TCV wrote: >>> On 01/03/2024 21:10, Zi Yan wrote: > On 1 Mar 2024, at 15:02, Zi Yan wrote: > >> On 1 Mar 2024, at 14:

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-04 Thread Aishwarya TCV
On 04/03/2024 14:58, Zi Yan wrote: > On 4 Mar 2024, at 4:50, Aishwarya TCV wrote: > >> On 01/03/2024 21:10, Zi Yan wrote: >>> On 1 Mar 2024, at 15:02, Zi Yan wrote: >>> On 1 Mar 2024, at 14:37, Zi Yan wrote: > On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > >> On 26/02/2024

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-04 Thread Zi Yan
On 4 Mar 2024, at 10:44, Aishwarya TCV wrote: > On 04/03/2024 14:58, Zi Yan wrote: >> On 4 Mar 2024, at 4:50, Aishwarya TCV wrote: >> >>> On 01/03/2024 21:10, Zi Yan wrote: On 1 Mar 2024, at 15:02, Zi Yan wrote: > On 1 Mar 2024, at 14:37, Zi Yan wrote: > >> On 1 Mar 2024, at

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-04 Thread Zi Yan
On 4 Mar 2024, at 4:50, Aishwarya TCV wrote: > On 01/03/2024 21:10, Zi Yan wrote: >> On 1 Mar 2024, at 15:02, Zi Yan wrote: >> >>> On 1 Mar 2024, at 14:37, Zi Yan wrote: >>> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan >>

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-04 Thread Aishwarya TCV
On 01/03/2024 21:10, Zi Yan wrote: > On 1 Mar 2024, at 15:02, Zi Yan wrote: > >> On 1 Mar 2024, at 14:37, Zi Yan wrote: >> >>> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: >>> On 26/02/2024 20:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_list_to_o

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 15:02, Zi Yan wrote: > On 1 Mar 2024, at 14:37, Zi Yan wrote: > >> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: >> >>> On 26/02/2024 20:55, Zi Yan wrote: From: Zi Yan It is used to test split_huge_page_to_list_to_order for pagecache THPs. Also add test cases

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 14:37, Zi Yan wrote: > On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > >> On 26/02/2024 20:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>> Also add test cases for split_huge_page_to_list_to_order via both >>>

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 9:27, Mark Brown wrote: > On Fri, Mar 01, 2024 at 02:18:16PM +, Ryan Roberts wrote: > >> Although I agree it might be a tall order create and mount an XFS fs in >> run_vmtests.sh. Perhaps it might be good enough to add an optional param to >> the >> test to pass a path when

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan >> >> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >> Also add test cases for split_huge_page_to_list_to_order via both >> debugfs. >> >> Signed-off-by: Zi Yan >> --- >>

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 9:27, Mark Brown wrote: > On Fri, Mar 01, 2024 at 02:18:16PM +, Ryan Roberts wrote: > >> Although I agree it might be a tall order create and mount an XFS fs in >> run_vmtests.sh. Perhaps it might be good enough to add an optional param to >> the >> test to pass a path when

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 9:23, Ryan Roberts wrote: > On 01/03/2024 14:00, Zi Yan wrote: >> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: >> >>> On 26/02/2024 20:55, Zi Yan wrote: From: Zi Yan It is used to test split_huge_page_to_list_to_order for pagecache THPs. Also add test cases f

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 02:18:16PM +, Ryan Roberts wrote: > Although I agree it might be a tall order create and mount an XFS fs in > run_vmtests.sh. Perhaps it might be good enough to add an optional param to > the > test to pass a path when running the test manually, and if that's not > pr

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 01:09:04PM +, Ryan Roberts wrote: > On 01/03/2024 12:52, Zi Yan wrote: > > I can do that. But is this a new requirement that self tests have to be > > finish > > in CI/CD environment? Can you provide a guideline for it? > I'm not sure what's written down, but certain

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 14:00, Zi Yan wrote: > On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > >> On 26/02/2024 20:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>> Also add test cases for split_huge_page_to_list_to_order via both >>> debu

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 13:53, Zi Yan wrote: > On 1 Mar 2024, at 8:09, Ryan Roberts wrote: > >> On 01/03/2024 12:52, Zi Yan wrote: >>> On 1 Mar 2024, at 5:33, Ryan Roberts wrote: >>> On 01/03/2024 09:51, Aishwarya TCV wrote: > > > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 07:56:41AM -0500, Zi Yan wrote: > On 1 Mar 2024, at 7:11, Mark Brown wrote: > > Mounting on /mnt would also be a bit of an issue, that's something > > people are relatively likely to have used for something so could be > > disruptive. If the test is going to do a new mount

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan >> >> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >> Also add test cases for split_huge_page_to_list_to_order via both >> debugfs. >> >> Signed-off-by: Zi Yan >> --- >>

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 8:09, Ryan Roberts wrote: > On 01/03/2024 12:52, Zi Yan wrote: >> On 1 Mar 2024, at 5:33, Ryan Roberts wrote: >> >>> On 01/03/2024 09:51, Aishwarya TCV wrote: On 26/02/2024 20:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_l

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 12:52, Zi Yan wrote: > On 1 Mar 2024, at 5:33, Ryan Roberts wrote: > >> On 01/03/2024 09:51, Aishwarya TCV wrote: >>> >>> >>> On 26/02/2024 20:55, Zi Yan wrote: From: Zi Yan It is used to test split_huge_page_to_list_to_order for pagecache THPs. Also add test cas

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 7:11, Mark Brown wrote: > On Fri, Mar 01, 2024 at 10:33:15AM +, Ryan Roberts wrote: > >> - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT >> ...); >> where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist, >> then the open wil

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 5:33, Ryan Roberts wrote: > On 01/03/2024 09:51, Aishwarya TCV wrote: >> >> >> On 26/02/2024 20:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>> Also add test cases for split_huge_page_to_list_to_order via bot

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 10:33:15AM +, Ryan Roberts wrote: > - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT ...); > where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist, > then the open will fail I think? I'm pretty sure that's what's happeni

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 09:51, Aishwarya TCV wrote: > > > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan >> >> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >> Also add test cases for split_huge_page_to_list_to_order via both >> debugfs. >> >> Signed-off-by: Zi Yan >> --- >>

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Aishwarya TCV
On 26/02/2024 20:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_list_to_order for pagecache THPs. > Also add test cases for split_huge_page_to_list_to_order via both > debugfs. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 34

[PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-02-26 Thread Zi Yan
From: Zi Yan It is used to test split_huge_page_to_list_to_order for pagecache THPs. Also add test cases for split_huge_page_to_list_to_order via both debugfs. Signed-off-by: Zi Yan --- mm/huge_memory.c | 34 -- .../selftests/mm/split_huge_page_test.c |