Re: [PATCH v5] net: ipv4: Cache pmtu for all packet paths if multipath enabled

2024-11-02 Thread Vladimir Vdovin
On Sat Nov 2, 2024 at 11:49 AM MSK, Paolo Abeni wrote: > Hi, > > On 11/1/24 18:34, Vladimir Vdovin wrote: > > On Fri Nov 1, 2024 at 4:45 PM MSK, Jakub Kicinski wrote: > >> On Fri, 1 Nov 2024 10:48:57 + Vladimir Vdovin wrote: > >>> + pmtu_ipv4_mp_exceptions ipv4: PMTU multipath nh excep

Re: [PATCH v5] net: ipv4: Cache pmtu for all packet paths if multipath enabled

2024-11-02 Thread Paolo Abeni
Hi, On 11/1/24 18:34, Vladimir Vdovin wrote: > On Fri Nov 1, 2024 at 4:45 PM MSK, Jakub Kicinski wrote: >> On Fri, 1 Nov 2024 10:48:57 + Vladimir Vdovin wrote: >>> + pmtu_ipv4_mp_exceptions ipv4: PMTU multipath nh exceptions >>> 0" >> >> This new test seems to fail in

Re: [PATCH v5] net: ipv4: Cache pmtu for all packet paths if multipath enabled

2024-11-01 Thread Vladimir Vdovin
On Fri Nov 1, 2024 at 4:45 PM MSK, Jakub Kicinski wrote: > On Fri, 1 Nov 2024 10:48:57 + Vladimir Vdovin wrote: > > + pmtu_ipv4_mp_exceptions ipv4: PMTU multipath nh exceptions > > 0" > > This new test seems to fail in our CI: > > # TEST: ipv4: PMTU multipath nh excepti

Re: [PATCH v5] net: ipv4: Cache pmtu for all packet paths if multipath enabled

2024-11-01 Thread Jakub Kicinski
On Fri, 1 Nov 2024 10:48:57 + Vladimir Vdovin wrote: > + pmtu_ipv4_mp_exceptions ipv4: PMTU multipath nh exceptions > 0" This new test seems to fail in our CI: # TEST: ipv4: PMTU multipath nh exceptions[FAIL] # there are not enough cach

[PATCH v5] net: ipv4: Cache pmtu for all packet paths if multipath enabled

2024-11-01 Thread Vladimir Vdovin
Check number of paths by fib_info_num_path(), and update_or_create_fnhe() for every path. Problem is that pmtu is cached only for the oif that has received icmp message "need to frag", other oifs will still try to use "default" iface mtu. V5: - make self test cleaner V4: - fix selftest, do ro