Re: [PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-07-23 Thread Shuah Khan
On 7/22/24 22:30, Dev Jain wrote: On 7/22/24 20:28, Shuah Khan wrote: On 7/15/24 05:49, Dev Jain wrote: On 6/30/24 20:48, Oleg Nesterov wrote: I see nothing wrong, but perhaps this test can be simplified? Feel free to ignore. Say, On 06/27, Dev Jain wrote: +void handler_usr(int signo, sig

Re: [PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-07-22 Thread Dev Jain
On 7/22/24 20:28, Shuah Khan wrote: On 7/15/24 05:49, Dev Jain wrote: On 6/30/24 20:48, Oleg Nesterov wrote: I see nothing wrong, but perhaps this test can be simplified? Feel free to ignore. Say, On 06/27, Dev Jain wrote: +void handler_usr(int signo, siginfo_t *info, void *uc) +{ +    in

Re: [PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-07-22 Thread Shuah Khan
On 7/15/24 05:49, Dev Jain wrote: On 6/30/24 20:48, Oleg Nesterov wrote: I see nothing wrong, but perhaps this test can be simplified? Feel free to ignore. Say, On 06/27, Dev Jain wrote: +void handler_usr(int signo, siginfo_t *info, void *uc) +{ +    int ret; + +    /* + * Break out of i

Re: [PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-07-15 Thread Dev Jain
On 6/30/24 20:48, Oleg Nesterov wrote: I see nothing wrong, but perhaps this test can be simplified? Feel free to ignore. Say, On 06/27, Dev Jain wrote: +void handler_usr(int signo, siginfo_t *info, void *uc) +{ + int ret; + + /* +* Break out of infinite recursion caused

Re: [PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-06-30 Thread Oleg Nesterov
I see nothing wrong, but perhaps this test can be simplified? Feel free to ignore. Say, On 06/27, Dev Jain wrote: > > +void handler_usr(int signo, siginfo_t *info, void *uc) > +{ > + int ret; > + > + /* > + * Break out of infinite recursion caused by raise(SIGUSR1) invoked > + *

Re: [PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-06-27 Thread Mark Brown
On Thu, Jun 27, 2024 at 09:22:15AM +0530, Dev Jain wrote: > This test asserts the relation between blocked signal, delivered signal, > and ucontext. The ucontext is mangled with, by adding a signal mask to > it; on return from the handler, the thread must block the corresponding > signal. Reviewed

[PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-06-26 Thread Dev Jain
This test asserts the relation between blocked signal, delivered signal, and ucontext. The ucontext is mangled with, by adding a signal mask to it; on return from the handler, the thread must block the corresponding signal. In the test description, I have also described signal delivery and blockag