Re: [PATCH v4 1/2] selftests/resctrl: Fix schemata write error check

2023-09-28 Thread Maciej Wieczór-Retman
On 2023-09-28 at 14:25:23 -0700, Reinette Chatre wrote: >Hi Maciej, > >On 9/27/2023 11:46 PM, Maciej Wieczór-Retman wrote: >> On 2023-09-27 at 15:15:06 -0700, Reinette Chatre wrote: >>> On 9/22/2023 1:10 AM, Maciej Wieczor-Retman wrote: > diff --git a/tools/testing/selftests/resctrl/resctrlfs.

Re: [PATCH v4 1/2] selftests/resctrl: Fix schemata write error check

2023-09-28 Thread Reinette Chatre
Hi Maciej, On 9/27/2023 11:46 PM, Maciej Wieczór-Retman wrote: > On 2023-09-27 at 15:15:06 -0700, Reinette Chatre wrote: >> On 9/22/2023 1:10 AM, Maciej Wieczor-Retman wrote: >>> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c >>> b/tools/testing/selftests/resctrl/resctrlfs.c >>> index

Re: [PATCH v4 1/2] selftests/resctrl: Fix schemata write error check

2023-09-27 Thread Maciej Wieczór-Retman
Hi, thanks for the review! On 2023-09-27 at 15:15:06 -0700, Reinette Chatre wrote: >Hi Maciej, > >On 9/22/2023 1:10 AM, Maciej Wieczor-Retman wrote: >> Writing bitmasks to the schemata can fail when the bitmask doesn't >> adhere to constraints defined by what a particular CPU supports. >> Some exa

Re: [PATCH v4 1/2] selftests/resctrl: Fix schemata write error check

2023-09-27 Thread Reinette Chatre
Hi Maciej, On 9/22/2023 1:10 AM, Maciej Wieczor-Retman wrote: > Writing bitmasks to the schemata can fail when the bitmask doesn't > adhere to constraints defined by what a particular CPU supports. > Some example of constraints are max length or having contiguous bits. > The driver should properly

Re: [PATCH v4 1/2] selftests/resctrl: Fix schemata write error check

2023-09-22 Thread Ilpo Järvinen
On Fri, 22 Sep 2023, Maciej Wieczor-Retman wrote: > Writing bitmasks to the schemata can fail when the bitmask doesn't > adhere to constraints defined by what a particular CPU supports. > Some example of constraints are max length or having contiguous bits. > The driver should properly return erro

[PATCH v4 1/2] selftests/resctrl: Fix schemata write error check

2023-09-22 Thread Maciej Wieczor-Retman
Writing bitmasks to the schemata can fail when the bitmask doesn't adhere to constraints defined by what a particular CPU supports. Some example of constraints are max length or having contiguous bits. The driver should properly return errors when any rule concerning bitmask format is broken. Resc