Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-03-03 Thread Google
On Thu, 29 Feb 2024 22:41:34 -0500 Steven Rostedt wrote: > On Thu, 29 Feb 2024 17:52:16 +0900 > Masami Hiramatsu (Google) wrote: > > > Lol, I haven't allocate the entry data size when initialize rethook. > > That's a bug. > > Please try below. > > I'll wait to review patches 5,6,7 as I'm guess

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-29 Thread Steven Rostedt
On Thu, 29 Feb 2024 17:52:16 +0900 Masami Hiramatsu (Google) wrote: > Lol, I haven't allocate the entry data size when initialize rethook. > That's a bug. > Please try below. I'll wait to review patches 5,6,7 as I'm guessing this will have a v3? -- Steve

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-29 Thread Google
On Thu, 29 Feb 2024 16:13:20 +0900 Masami Hiramatsu (Google) wrote: > On Thu, 29 Feb 2024 15:38:55 +0900 > Masami Hiramatsu (Google) wrote: > > > Hmm, this seems arch_rethook_trampoline caused the issue. > > > > And curiously, it depends on the number of stored data. > > > > OK: > > /sys/kern

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-28 Thread Google
On Thu, 29 Feb 2024 15:38:55 +0900 Masami Hiramatsu (Google) wrote: > Hmm, this seems arch_rethook_trampoline caused the issue. > > And curiously, it depends on the number of stored data. > > OK: > /sys/kernel/tracing # echo 'f vfs_read%return $arg1 $arg2 $arg3' >> > dynamic_events > /sys/ker

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-28 Thread Google
On Thu, 29 Feb 2024 14:51:39 +0900 Masami Hiramatsu (Google) wrote: > On Wed, 28 Feb 2024 17:23:34 +0100 > Jiri Olsa wrote: > > > On Mon, Feb 26, 2024 at 12:57:53PM +0900, Masami Hiramatsu (Google) wrote: > > > Hi, > > > > > > Here is version 2 series of patches to support accessing function e

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-28 Thread Google
On Wed, 28 Feb 2024 17:23:34 +0100 Jiri Olsa wrote: > On Mon, Feb 26, 2024 at 12:57:53PM +0900, Masami Hiramatsu (Google) wrote: > > Hi, > > > > Here is version 2 series of patches to support accessing function entry data > > from function *return* probes (including kretprobe and fprobe-exit eve

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-28 Thread Jiri Olsa
On Mon, Feb 26, 2024 at 12:57:53PM +0900, Masami Hiramatsu (Google) wrote: > Hi, > > Here is version 2 series of patches to support accessing function entry data > from function *return* probes (including kretprobe and fprobe-exit event). > > In this version, I added another cleanup [4/7], update

[PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-25 Thread Masami Hiramatsu (Google)
Hi, Here is version 2 series of patches to support accessing function entry data from function *return* probes (including kretprobe and fprobe-exit event). In this version, I added another cleanup [4/7], updated README[5/7], added testcases[6/7] and updated document[7/7]. This allows us to acces