Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-02-01 Thread Jakub Kicinski
On Fri, 2 Feb 2024 02:30:52 + Dmitry Safonov wrote: > > Actually, I think there may be an easier fix: > > > > 4. Make sure that client close()s TCP-AO first, making it twsk. > >And also make sure that net-ns counters read post server's close(). > > > > Will do this, let's see if this fixe

Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-02-01 Thread Dmitry Safonov
On 2/1/24 23:37, Dmitry Safonov wrote: > On 2/1/24 22:25, Dmitry Safonov wrote: >> Hi Jakub, >> >> On 2/1/24 21:21, Jakub Kicinski wrote: >>> On Thu, 1 Feb 2024 00:50:46 + Dmitry Safonov wrote: Please, let me know if there will be other issues with tcp-ao tests :) Going to work o

Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-02-01 Thread Dmitry Safonov
On 2/1/24 22:25, Dmitry Safonov wrote: > Hi Jakub, > > On 2/1/24 21:21, Jakub Kicinski wrote: >> On Thu, 1 Feb 2024 00:50:46 + Dmitry Safonov wrote: >>> Please, let me know if there will be other issues with tcp-ao tests :) >>> >>> Going to work on tracepoints and some other TCP-AO stuff for n

Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-02-01 Thread Dmitry Safonov
Hi Jakub, On 2/1/24 21:21, Jakub Kicinski wrote: > On Thu, 1 Feb 2024 00:50:46 + Dmitry Safonov wrote: >> Please, let me know if there will be other issues with tcp-ao tests :) >> >> Going to work on tracepoints and some other TCP-AO stuff for net-next. > > Since you're being nice and helpful

Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-02-01 Thread Jakub Kicinski
On Thu, 1 Feb 2024 00:50:46 + Dmitry Safonov wrote: > Please, let me know if there will be other issues with tcp-ao tests :) > > Going to work on tracepoints and some other TCP-AO stuff for net-next. Since you're being nice and helpful I figured I'll try testing TCP-AO with debug options enab

Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-01-31 Thread Dmitry Safonov
On 2/1/24 00:36, Jakub Kicinski wrote: > On Tue, 30 Jan 2024 03:51:51 + Dmitry Safonov wrote: >> Two typo fixes, noticed by Mohammad's review. >> And a fix for an issue that got uncovered. > > I can confirm that all tests pass now :) > Thank you! Thanks Jakub! Please, let me know if there wi

Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-01-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 30 Jan 2024 03:51:51 + you wrote: > Changes in v2: > - Dropped "selftests/net: Clean-up double assignment", going to send it > to net-next with other changes (Simon) > - Added a patch to rectify RST selftest

Re: [PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-01-31 Thread Jakub Kicinski
On Tue, 30 Jan 2024 03:51:51 + Dmitry Safonov wrote: > Two typo fixes, noticed by Mohammad's review. > And a fix for an issue that got uncovered. I can confirm that all tests pass now :) Thank you!

[PATCH v2 0/3] selftests/net: A couple of typos fixes in key-management/rst tests

2024-01-29 Thread Dmitry Safonov
Changes in v2: - Dropped "selftests/net: Clean-up double assignment", going to send it to net-next with other changes (Simon) - Added a patch to rectify RST selftests. - Link to v1: https://lore.kernel.org/r/20240118-tcp-ao-test-key-mgmt-v1-0-3583ca147...@arista.com Two typo fixes, noticed by M