Re: [PATCH net v6 0/2] Enhance network interface feature testing

2024-08-15 Thread Jakub Kicinski
On Thu, 15 Aug 2024 16:34:42 +0530 Abhinav Jain wrote: > > > One more: > > > > > > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP > > > address" > > > > > > I think the SKIP -> XFAIL conversion should be a separate patch (for > > > total of 3 patches in the series). > > >

Re: [PATCH net v6 0/2] Enhance network interface feature testing

2024-08-15 Thread Abhinav Jain
On Wed, 14 Aug 2024 17:57:48 -0700, Jakub Kicinski wrote: > On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote: > > On Wed, 14 Aug 2024 19:15:15 + Abhinav Jain wrote: > > > Changes in v6: > > > Use XFAIL for ethtool operations that are unsupported instead of SKIP. > > > > One more: > >

Re: [PATCH net v6 0/2] Enhance network interface feature testing

2024-08-14 Thread Jakub Kicinski
On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote: > On Wed, 14 Aug 2024 19:15:15 + Abhinav Jain wrote: > > Changes in v6: > > Use XFAIL for ethtool operations that are unsupported instead of SKIP. > > One more: > > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev:

Re: [PATCH net v6 0/2] Enhance network interface feature testing

2024-08-14 Thread Jakub Kicinski
On Wed, 14 Aug 2024 19:15:15 + Abhinav Jain wrote: > Changes in v6: > Use XFAIL for ethtool operations that are unsupported instead of SKIP. One more: tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address" I think the SKIP -> XFAIL conversion should be a separa

[PATCH net v6 0/2] Enhance network interface feature testing

2024-08-14 Thread Abhinav Jain
This small series includes fixes for creation of veth pairs for networkless kernels & adds tests for turning the different network interface features on and off in selftests/net/netdevice.sh script. Changes in v6: Use XFAIL for ethtool operations that are unsupported instead of SKIP. Changes in v