Re: [PATCH net v2] selftests: net: cope with slow env in gro.sh test

2024-02-12 Thread Paolo Abeni
On Fri, 2024-02-09 at 11:15 -0800, Jakub Kicinski wrote: > On Wed, 7 Feb 2024 19:36:46 +0100 Paolo Abeni wrote: > > +if [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" ]]; then > > +echo "Ignoring errors due to slow environment" 1>&2 > > +exit_code=0 > > +fi > > Would i

Re: [PATCH net v2] selftests: net: cope with slow env in gro.sh test

2024-02-09 Thread Jakub Kicinski
On Wed, 7 Feb 2024 19:36:46 +0100 Paolo Abeni wrote: > +if [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" ]]; then > +echo "Ignoring errors due to slow environment" 1>&2 > +exit_code=0 > +fi Would it make sense to also add "&& $exit_code -ne 0" ? It may be useful to se

Re: [PATCH net v2] selftests: net: cope with slow env in gro.sh test

2024-02-07 Thread Matthieu Baerts
Hi Paolo, On 07/02/2024 19:36, Paolo Abeni wrote: > The gro self-tests sends the packets to be aggregated with > multiple write operations. > > When running is slow environment, it's hard to guarantee that > the GRO engine will wait for the last packet in an intended > train. > > The above cause

[PATCH net v2] selftests: net: cope with slow env in gro.sh test

2024-02-07 Thread Paolo Abeni
The gro self-tests sends the packets to be aggregated with multiple write operations. When running is slow environment, it's hard to guarantee that the GRO engine will wait for the last packet in an intended train. The above causes almost deterministic failures in our CI for the 'large' test-case