Re: [PATCH net v2] bonding: Correctly support GSO ESP offload

2025-01-24 Thread Hangbin Liu
On Fri, Jan 24, 2025 at 10:35:40AM +, Cosmin Ratiu wrote: > On Fri, 2025-01-24 at 09:54 +, Hangbin Liu wrote: > > On Fri, Jan 24, 2025 at 10:57:44AM +0200, Cosmin Ratiu wrote: > > > --- > > >  drivers/net/bonding/bond_main.c | 19 ++- > > >  1 file changed, 10 insertions(+),

Re: [PATCH net v2] bonding: Correctly support GSO ESP offload

2025-01-24 Thread Cosmin Ratiu
On Fri, 2025-01-24 at 09:54 +, Hangbin Liu wrote: > On Fri, Jan 24, 2025 at 10:57:44AM +0200, Cosmin Ratiu wrote: > > --- > >  drivers/net/bonding/bond_main.c | 19 ++- > >  1 file changed, 10 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/net/bonding/bond_main.c > >

Re: [PATCH net v2] bonding: Correctly support GSO ESP offload

2025-01-24 Thread Hangbin Liu
On Fri, Jan 24, 2025 at 10:57:44AM +0200, Cosmin Ratiu wrote: > --- > drivers/net/bonding/bond_main.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 7b78c2bada81..e45bba240cbc

[PATCH net v2] bonding: Correctly support GSO ESP offload

2025-01-24 Thread Cosmin Ratiu
The referenced fix is incomplete. It correctly computes bond_dev->gso_partial_features across slaves, but unfortunately netdev_fix_features discards gso_partial_features from the feature set if NETIF_F_GSO_PARTIAL isn't set in bond_dev->features. This is visible with ethtool -k bond0 | grep esp: t

[PATCH net v2] bonding: Correctly support GSO ESP offload

2025-01-24 Thread Cosmin Ratiu
V2: Removed unnecessary Change-Id Changed "bond->features" to "bond_dev->features" in commit message.