Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-22 Thread David Ahern
On 4/22/24 7:48 AM, Jakub Kicinski wrote: > On Sun, 21 Apr 2024 13:32:24 -0600 David Ahern wrote: >> On 4/21/24 1:17 PM, Eric Dumazet wrote: >>> I wonder if NLM_F_DUMP_FILTERED should not be reported to user space ? >> >> good point. We do set that flag for other dumps when a filter has been >> u

Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-22 Thread Eric Dumazet
On Mon, Apr 22, 2024 at 3:48 PM Jakub Kicinski wrote: > > On Sun, 21 Apr 2024 13:32:24 -0600 David Ahern wrote: > > On 4/21/24 1:17 PM, Eric Dumazet wrote: > > > I wonder if NLM_F_DUMP_FILTERED should not be reported to user space ? > > > > good point. We do set that flag for other dumps when a fi

Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-22 Thread Jakub Kicinski
On Sun, 21 Apr 2024 13:32:24 -0600 David Ahern wrote: > On 4/21/24 1:17 PM, Eric Dumazet wrote: > > I wonder if NLM_F_DUMP_FILTERED should not be reported to user space ? > > good point. We do set that flag for other dumps when a filter has been > used to limit data returned. That flag appears

Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-21 Thread David Ahern
On 4/21/24 1:17 PM, Eric Dumazet wrote: > I wonder if NLM_F_DUMP_FILTERED should not be reported to user space ? good point. We do set that flag for other dumps when a filter has been used to limit data returned.

Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-21 Thread Eric Dumazet
On Sat, Apr 20, 2024 at 4:35 AM Jakub Kicinski wrote: > > Having to filter the right ifindex in the tests is a bit tedious. > Add support for dumping qstats for a single ifindex. > > Signed-off-by: Jakub Kicinski > --- > Documentation/netlink/specs/netdev.yaml | 1 + > net/core/netdev-genl-gen.

Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-20 Thread David Ahern
On 4/19/24 8:35 PM, Jakub Kicinski wrote: > Having to filter the right ifindex in the tests is a bit tedious. > Add support for dumping qstats for a single ifindex. > > Signed-off-by: Jakub Kicinski > --- > Documentation/netlink/specs/netdev.yaml | 1 + > net/core/netdev-genl-gen.c

[PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-19 Thread Jakub Kicinski
Having to filter the right ifindex in the tests is a bit tedious. Add support for dumping qstats for a single ifindex. Signed-off-by: Jakub Kicinski --- Documentation/netlink/specs/netdev.yaml | 1 + net/core/netdev-genl-gen.c | 1 + net/core/netdev-genl.c | 52 ++