Re: [PATCH net] selftests: net: avoid waiting for server in amt.sh forever when it fails.

2024-05-09 Thread Taehee Yoo
On Fri, May 10, 2024 at 1:23 AM Jakub Kicinski wrote: > Hi Jakub, Thanks a lot for the review and looking into the bug. > On Wed, 8 May 2024 04:06:43 + Taehee Yoo wrote: > > In the forwarding testcase, it opens a server and a client with the nc. > > The server receives the correct message f

Re: [PATCH net] selftests: net: avoid waiting for server in amt.sh forever when it fails.

2024-05-09 Thread Taehee Yoo
On Thu, May 9, 2024 at 6:36 PM Paolo Abeni wrote: > Hi Paolo, Thank you for the review! > On Wed, 2024-05-08 at 04:06 +, Taehee Yoo wrote: > > > @@ -210,40 +217,52 @@ check_features() > > > > test_ipv4_forward() > > { > > - RESULT4=$(ip netns exec "${LISTENER}" nc -w 1 -l -u 239.0.0.1 4000)

Re: [PATCH net] selftests: net: avoid waiting for server in amt.sh forever when it fails.

2024-05-09 Thread Taehee Yoo
On Thu, May 9, 2024 at 5:38 PM Simon Horman wrote: > Hi Simon, Thanks a lot for the review! > On Wed, May 08, 2024 at 04:06:43AM +, Taehee Yoo wrote: > > In the forwarding testcase, it opens a server and a client with the nc. > > The server receives the correct message from NC, it prints OK.

Re: [PATCH net] selftests: net: avoid waiting for server in amt.sh forever when it fails.

2024-05-09 Thread Jakub Kicinski
On Wed, 8 May 2024 04:06:43 + Taehee Yoo wrote: > In the forwarding testcase, it opens a server and a client with the nc. > The server receives the correct message from NC, it prints OK. > The server prints FAIL if it receives the wrong message from the client. > > But If the server can't rec

Re: [PATCH net] selftests: net: avoid waiting for server in amt.sh forever when it fails.

2024-05-09 Thread Paolo Abeni
On Wed, 2024-05-08 at 04:06 +, Taehee Yoo wrote: > @@ -210,40 +217,52 @@ check_features() > > test_ipv4_forward() > { > - RESULT4=$(ip netns exec "${LISTENER}" nc -w 1 -l -u 239.0.0.1 4000) > + echo "" > $RESULT > + bash -c "$(ip netns exec "${LISTENER}" \ > + timeo

Re: [PATCH net] selftests: net: avoid waiting for server in amt.sh forever when it fails.

2024-05-09 Thread Simon Horman
On Wed, May 08, 2024 at 04:06:43AM +, Taehee Yoo wrote: > In the forwarding testcase, it opens a server and a client with the nc. > The server receives the correct message from NC, it prints OK. > The server prints FAIL if it receives the wrong message from the client. > > But If the server ca

[PATCH net] selftests: net: avoid waiting for server in amt.sh forever when it fails.

2024-05-07 Thread Taehee Yoo
In the forwarding testcase, it opens a server and a client with the nc. The server receives the correct message from NC, it prints OK. The server prints FAIL if it receives the wrong message from the client. But If the server can't receive any message, it will not close so the amt.sh waits forever