Re: [PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close()

I spent some time checking and nobody but __sock_create (net/socket.c) and vsock_release can set sock->sk to NULL. I also ran checkpatch, everything LGTM. Thanks for the fix! Reviewed-by: Luigi Leonardi

Re: [PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close()

On Thu, Nov 21, 2024 at 8:54 PM Michal Luczaj wrote: > > On 11/21/24 10:22, Stefano Garzarella wrote: > > On Mon, Nov 18, 2024 at 10:03:43PM +0100, Michal Luczaj wrote: > >> vsock defines a BPF callback to be invoked when close() is called. However, > >> this callback is never actually executed. A

Re: [PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close()

On 11/21/24 10:22, Stefano Garzarella wrote: > On Mon, Nov 18, 2024 at 10:03:43PM +0100, Michal Luczaj wrote: >> vsock defines a BPF callback to be invoked when close() is called. However, >> this callback is never actually executed. As a result, a closed vsock >> socket is not automatically remove

Re: [PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close()

On Mon, Nov 18, 2024 at 10:03:43PM +0100, Michal Luczaj wrote: vsock defines a BPF callback to be invoked when close() is called. However, this callback is never actually executed. As a result, a closed vsock socket is not automatically removed from the sockmap/sockhash. Introduce a dummy vsock_

[PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close()

vsock defines a BPF callback to be invoked when close() is called. However, this callback is never actually executed. As a result, a closed vsock socket is not automatically removed from the sockmap/sockhash. Introduce a dummy vsock_close() and make vsock_release() call proto::close. Note: change