Re: [PATCH 1/3] userfaultfd: UFFDIO_REMAP: rmap preparation

2023-09-14 Thread Suren Baghdasaryan
On Thu, Sep 14, 2023 at 10:56 AM Matthew Wilcox wrote: > > On Thu, Sep 14, 2023 at 08:26:11AM -0700, Suren Baghdasaryan wrote: > > From: Andrea Arcangeli > > > > As far as the rmap code is concerned, UFFDIO_REMAP only alters the > > page->mapping and page->index. It does it while holding the page

Re: [PATCH 1/3] userfaultfd: UFFDIO_REMAP: rmap preparation

2023-09-14 Thread Matthew Wilcox
On Thu, Sep 14, 2023 at 08:26:11AM -0700, Suren Baghdasaryan wrote: > From: Andrea Arcangeli > > As far as the rmap code is concerned, UFFDIO_REMAP only alters the > page->mapping and page->index. It does it while holding the page folio->mapping and folio->index. It does it while holding the fo

[PATCH 1/3] userfaultfd: UFFDIO_REMAP: rmap preparation

2023-09-14 Thread Suren Baghdasaryan
From: Andrea Arcangeli As far as the rmap code is concerned, UFFDIO_REMAP only alters the page->mapping and page->index. It does it while holding the page lock. However folio_referenced() is doing rmap walks without taking the folio lock first, so folio_lock_anon_vma_read() must be updated to re-