Em 24 de setembro de 2024 23:40:27 GMT+02:00, Gabriel Krisman Bertazi
escreveu:
>André Almeida writes:
>
>> Hey!
>>
>> On 9/23/24 19:34, Gabriela Bittencourt wrote:
>>> Instead of creating 'test' functions, use kunit functions to test
>>> utf-8 support in unicode subsystem.
>>
>> I think it w
André Almeida writes:
> Hey!
>
> On 9/23/24 19:34, Gabriela Bittencourt wrote:
>> Instead of creating 'test' functions, use kunit functions to test
>> utf-8 support in unicode subsystem.
>
> I think it would be nice to explain in the commit message what are the
> benefits of this change, why refa
Hey!
On 9/23/24 19:34, Gabriela Bittencourt wrote:
Instead of creating 'test' functions, use kunit functions to test
utf-8 support in unicode subsystem.
I think it would be nice to explain in the commit message what are the
benefits of this change, why refactoring into KUnit is a good idea?
Gabriela Bittencourt writes:
>
> -static ssize_t utf8len(const struct unicode_map *um, enum utf8_normalization
> n,
> - const char *s)
> +static ssize_t utf8len(const struct unicode_map *um, enum utf8_normalization
> n, const char *s)
> {
Please, do not make indentation-only chang
On 9/23/24 11:34, Gabriela Bittencourt wrote:
Instead of creating 'test' functions, use kunit functions to test
utf-8 support in unicode subsystem.
Can you elaborate on the reefactoring changes. This will help
others who would want to take on such refactoring in the future.
Co-developed-by:
Instead of creating 'test' functions, use kunit functions to test
utf-8 support in unicode subsystem.
Co-developed-by: Pedro Orlando
Signed-off-by: Pedro Orlando
Co-developed-by: Danilo Pereira
Signed-off-by: Danilo Pereira
Signed-off-by: Gabriela Bittencourt
---
fs/unicode/.kunitconfig|
