Re: [PATCH 1/2] mseal: Fix is_madv_discard()

On Wed, 7 Aug 2024 20:25:45 +0100 Pedro Falcato wrote: > On Wed, Aug 7, 2024 at 7:58 PM Andrew Morton > wrote: > > > > On Wed, 7 Aug 2024 18:33:35 +0100 Pedro Falcato > > wrote: > > > > > is_madv_discard did its check wrong. MADV_ flags are not bitwise, > > > they're normal sequential number

Re: [PATCH 1/2] mseal: Fix is_madv_discard()

On Wed, Aug 7, 2024 at 7:58 PM Andrew Morton wrote: > > On Wed, 7 Aug 2024 18:33:35 +0100 Pedro Falcato > wrote: > > > is_madv_discard did its check wrong. MADV_ flags are not bitwise, > > they're normal sequential numbers. So, for instance: > > behavior & (/* ... */ | MADV_REMOVE) > > >

Re: [PATCH 1/2] mseal: Fix is_madv_discard()

On Wed, 7 Aug 2024 18:33:35 +0100 Pedro Falcato wrote: > is_madv_discard did its check wrong. MADV_ flags are not bitwise, > they're normal sequential numbers. So, for instance: > behavior & (/* ... */ | MADV_REMOVE) > > tagged both MADV_REMOVE and MADV_RANDOM (bit 0 set) as > discard op

[PATCH 1/2] mseal: Fix is_madv_discard()

is_madv_discard did its check wrong. MADV_ flags are not bitwise, they're normal sequential numbers. So, for instance: behavior & (/* ... */ | MADV_REMOVE) tagged both MADV_REMOVE and MADV_RANDOM (bit 0 set) as discard operations. This is obviously incorrect, so use a switch statement inst