Re: [PATCH 03/24] selftests/resctrl: Refactor get_cbm_mask()

2023-11-03 Thread Ilpo Järvinen
On Thu, 2 Nov 2023, Reinette Chatre wrote: > On 10/24/2023 2:26 AM, Ilpo Järvinen wrote: > > > @@ -229,6 +228,31 @@ int get_cbm_mask(char *cache_type, char *cbm_mask) > > return 0; > > } > > > > +/* > > + * get_cbm_mask - Get cbm bit mask > > I know you just copied code here but please kee

Re: [PATCH 03/24] selftests/resctrl: Refactor get_cbm_mask()

2023-11-02 Thread Reinette Chatre
Hi Ilpo, On 10/24/2023 2:26 AM, Ilpo Järvinen wrote: ... > @@ -229,6 +228,31 @@ int get_cbm_mask(char *cache_type, char *cbm_mask) > return 0; > } > > +/* > + * get_cbm_mask - Get cbm bit mask I know you just copied code here but please keep an eye out for acronyms to be written in cap

Re: [PATCH 03/24] selftests/resctrl: Refactor get_cbm_mask()

2023-10-27 Thread Maciej Wieczór-Retman
On 2023-10-24 at 12:26:13 +0300, Ilpo Järvinen wrote: >Callers of get_cbm_mask() are required to pass a string into which the >CBM bit mask is read. Neither CAT nor CMT tests need the mask as string "CBM bit mask" -> "CBM" / "capacity bitmask (CBM)"? Generally isn't cbm_mask an odd name because o

[PATCH 03/24] selftests/resctrl: Refactor get_cbm_mask()

2023-10-24 Thread Ilpo Järvinen
Callers of get_cbm_mask() are required to pass a string into which the CBM bit mask is read. Neither CAT nor CMT tests need the mask as string but just convert it into an unsigned long value. The bit mask reader can only read .../cbm_mask files. Generalize the bit mask reading function into get_b