Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread Shuah Khan
On 12/22/23 03:09, Johannes Berg wrote: Hi, Thanks for taking a look! On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: The two initial KUnit patches look fine, modulo a couple of minor docs issues and checkpatch warnings. I can run checkpatch (even if I can't always take it seriously), bu

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread David Gow
On Fri, 22 Dec 2023 at 18:09, Johannes Berg wrote: > > Hi, > > Thanks for taking a look! > > On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: > > The two initial KUnit patches look fine, modulo a couple of minor docs > > issues and checkpatch warnings. > > I can run checkpatch (even if I can't

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread Johannes Berg
Hi, Thanks for taking a look! On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: > The two initial KUnit patches look fine, modulo a couple of minor docs > issues and checkpatch warnings.  I can run checkpatch (even if I can't always take it seriously), but do you want to comment more specifica

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread David Gow
On Fri, 22 Dec 2023 at 05:47, Shuah Khan wrote: > > On 12/21/23 13:40, Johannes Berg wrote: > > On Thu, 2023-12-21 at 13:06 -0700, Shuah Khan wrote: > >> On 12/21/23 12:39, Johannes Berg wrote: > > This patchset adds a couple of helpers for kunit as well as tests for > cfg80211 and

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Shuah Khan
On 12/21/23 13:40, Johannes Berg wrote: On Thu, 2023-12-21 at 13:06 -0700, Shuah Khan wrote: On 12/21/23 12:39, Johannes Berg wrote: This patchset adds a couple of helpers for kunit as well as tests for cfg80211 and mac80211 that use them. I can take this through the wireless tree, but then

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Johannes Berg
On Thu, 2023-12-21 at 13:06 -0700, Shuah Khan wrote: > On 12/21/23 12:39, Johannes Berg wrote: > > > > > > This patchset adds a couple of helpers for kunit as well as tests for > > > cfg80211 and mac80211 that use them. > > > > I can take this through the wireless tree, but then I'd like to have

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Shuah Khan
On 12/21/23 12:39, Johannes Berg wrote: This patchset adds a couple of helpers for kunit as well as tests for cfg80211 and mac80211 that use them. I can take this through the wireless tree, but then I'd like to have ACKs from kunit folks for the kunit patches: We have run into conflicts in

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Johannes Berg
> > This patchset adds a couple of helpers for kunit as well as tests for > cfg80211 and mac80211 that use them. I can take this through the wireless tree, but then I'd like to have ACKs from kunit folks for the kunit patches: > kunit: add parameter generation macro using description from arra

[PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-20 Thread benjamin
From: Benjamin Berg This patchset adds a couple of helpers for kunit as well as tests for cfg80211 and mac80211 that use them. Benjamin Berg (3): kunit: add parameter generation macro using description from array kunit: add a convenience allocation wrapper for SKBs wifi: cfg80211: tests: a