Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-10-07 Thread Yu Liao
On 2024/10/4 6:21, Shuah Khan wrote: > Please send me v2 with sched.h included explicitly. It is better do do so > than having it come from indirectly. > Sorry for the late response, I have sent the v2 patch. https://lore.kernel.org/all/20241008023332.19902-1-liaoy...@huawei.com/ Best regards,

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-10-03 Thread Shuah Khan
On 9/23/24 20:57, Yu Liao wrote: Hi, On 2024/9/23 23:30, Shuah Khan wrote: On 9/20/24 09:31, Jason A. Donenfeld wrote: Indeed probably is what's wanted here. Yu Liao, Please send v2 as per the review comments. CLONE_NEWTIME was introduced in glibc-2.36, which was released in August 2022.

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-23 Thread Yu Liao
Hi, On 2024/9/23 23:30, Shuah Khan wrote: > On 9/20/24 09:31, Jason A. Donenfeld wrote: >> Indeed probably is what's wanted here. >> > > Yu Liao, Please send v2 as per the review comments. > CLONE_NEWTIME was introduced in glibc-2.36, which was released in August 2022. As Christophe mentioned,

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-23 Thread Shuah Khan
On 9/20/24 09:31, Jason A. Donenfeld wrote: Indeed probably is what's wanted here. Yu Liao, Please send v2 as per the review comments. Shuah - I was taking patches for this code during the 6.12 development cycle, because it all interacted with the dev work I was doing. But I think that's di

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-20 Thread Jason A. Donenfeld
Indeed probably is what's wanted here. Shuah - I was taking patches for this code during the 6.12 development cycle, because it all interacted with the dev work I was doing. But I think that's died down now and things can return to normal. Do you want to take these like you usually do now? Or is

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-20 Thread Christophe Leroy
Le 20/09/2024 à 03:54, Yu Liao a écrit : [Vous ne recevez pas souvent de courriers de liaoy...@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] On 2024/9/20 0:51, Shuah Khan wrote: diff --git a/tools/testing/selftests/vDSO/vdso_test_getran

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-19 Thread Yu Liao
On 2024/9/20 0:51, Shuah Khan wrote: >> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c >> b/tools/testing/selftests/vDSO/vdso_test_getrandom.c >> index 72a1d9b43a84..84f2bbb2d5e0 100644 >> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c >> +++ b/tools/testing/selftests/vD

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-19 Thread Shuah Khan
On 9/19/24 05:18, Yu Liao wrote: When building selftests/vDSO: $ make -C tools/testing/selftests TARGETS=vDSO I hit the following compilation error: vdso_test_getrandom.c:260:17: error: 'CLONE_NEWTIME' undeclared (first use in this function); did you mean 'CLONE_NEWIPC'? 260 | assert

[PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-19 Thread Yu Liao
When building selftests/vDSO: $ make -C tools/testing/selftests TARGETS=vDSO I hit the following compilation error: vdso_test_getrandom.c:260:17: error: 'CLONE_NEWTIME' undeclared (first use in this function); did you mean 'CLONE_NEWIPC'? 260 | assert(unshare(CLONE_NEWTIME) == 0);