Re: [PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-24 Thread Shuah Khan
On 4/24/24 10:10, Nathan Chancellor wrote: On Wed, Apr 24, 2024 at 10:00:12AM -0600, Shuah Khan wrote: Signed-off-by: Nathan Chancellor --- clone patch tools/testing/selftests/clone3/clone3_clear_sighand.c| 2 +- tools/testing/selftests/clone3/clone3_set_tid.c

Re: [PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-24 Thread Nathan Chancellor
On Wed, Apr 24, 2024 at 10:00:12AM -0600, Shuah Khan wrote: > On 4/24/24 09:05, Nathan Chancellor wrote: > > On Wed, Apr 24, 2024 at 07:44:31AM -0600, Shuah Khan wrote: > > > On 4/17/24 09:37, Nathan Chancellor wrote: > > > > Commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that > > > > u

Re: [PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-24 Thread Shuah Khan
On 4/24/24 09:05, Nathan Chancellor wrote: On Wed, Apr 24, 2024 at 07:44:31AM -0600, Shuah Khan wrote: On 4/17/24 09:37, Nathan Chancellor wrote: Commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn") marked functions that call exit() as __no

Re: [PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-24 Thread Nathan Chancellor
On Wed, Apr 24, 2024 at 07:44:31AM -0600, Shuah Khan wrote: > On 4/17/24 09:37, Nathan Chancellor wrote: > > Commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that > > unconditionally call exit() as __noreturn") marked functions that call > > exit() as __noreturn but it did not change the

Re: [PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-24 Thread Shuah Khan
On 4/17/24 09:37, Nathan Chancellor wrote: Commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn") marked functions that call exit() as __noreturn but it did not change the return type of these functions from 'void' to 'int' like it should have

Re: [PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-22 Thread Thomas Gleixner
On Wed, Apr 17 2024 at 08:37, Nathan Chancellor wrote: > into the more idiomatic > > if (ret) > ksft_exit_fail(); > ksft_exit_pass(); > > as well as a few style clean ups now that the code is shorter. Reviewed-by: Thomas Gleixner

Re: [PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-19 Thread Muhammad Usama Anjum
On 4/17/24 8:37 PM, Nathan Chancellor wrote: > Commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that > unconditionally call exit() as __noreturn") marked functions that call > exit() as __noreturn but it did not change the return type of these > functions from 'void' to 'int' like it shou

[PATCH] selftests: Make ksft_exit functions return void instead of int

2024-04-17 Thread Nathan Chancellor
Commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn") marked functions that call exit() as __noreturn but it did not change the return type of these functions from 'void' to 'int' like it should have (since a noreturn function by definition cann