Re: [PATCH] selftests/bpf:fix a resource leak in main()

2024-07-12 Thread Stanislav Fomichev
On 07/12, Markus Elfring wrote: > > The requested resources should be closed before return in main(), otherwise > > resource leak will occur. Add a check of cg_fd before close(). > > > > Fixes: 435f90a338ae ("selftests/bpf: add a test case for sock_ops > > perf-event notification") > > Signed-off-

Re: [PATCH] selftests/bpf:fix a resource leak in main()

2024-07-12 Thread Markus Elfring
> The requested resources should be closed before return in main(), otherwise > resource leak will occur. Add a check of cg_fd before close(). > > Fixes: 435f90a338ae ("selftests/bpf: add a test case for sock_ops perf-event > notification") > Signed-off-by: Ma Ke Please reconsider such informati

Re: [PATCH] selftests/bpf:fix a resource leak in main()

2024-07-11 Thread Stanislav Fomichev
On 07/11, Ma Ke wrote: > The requested resources should be closed before return in main(), otherwise > resource leak will occur. Add a check of cg_fd before close(). > > Fixes: 435f90a338ae ("selftests/bpf: add a test case for sock_ops perf-event > notification") > Signed-off-by: Ma Ke > --- >

[PATCH] selftests/bpf:fix a resource leak in main()

2024-07-11 Thread Ma Ke
The requested resources should be closed before return in main(), otherwise resource leak will occur. Add a check of cgfd before close(). Fixes: 5ecd8c22739b ("selftests/bpf: Selftest for bpf_skb_ancestor_cgroup_id") Signed-off-by: Ma Ke --- tools/testing/selftests/bpf/test_skb_cgroup_id_user.c

[PATCH] selftests/bpf:fix a resource leak in main()

2024-07-11 Thread Ma Ke
The requested resources should be closed before return in main(), otherwise resource leak will occur. Add a check of cg_fd before close(). Fixes: 1f5fa9ab6e2e ("selftests/bpf: Test BPF_CGROUP_SYSCTL") Signed-off-by: Ma Ke --- tools/testing/selftests/bpf/test_sysctl.c | 3 ++- 1 file changed, 2 i

[PATCH] selftests/bpf:fix a resource leak in main()

2024-07-11 Thread Ma Ke
The requested resources should be closed before return in main(), otherwise resource leak will occur. Add a check of cg_fd before close(). Fixes: 435f90a338ae ("selftests/bpf: add a test case for sock_ops perf-event notification") Signed-off-by: Ma Ke --- tools/testing/selftests/bpf/test_tcpno