Re: [PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn

2024-04-12 Thread Bill Wendling
On Fri, Apr 12, 2024 at 9:08 AM Bill Wendling wrote: > > On Thu, Apr 11, 2024 at 11:45 AM Nathan Chancellor wrote: > > > > After commit 6d029c25b71f ("selftests/timers/posix_timers: Reimplement > > check_timer_distribution()"), clang warns: > > > > tools/testing/selftests/timers/../kselftest.h:

Re: [PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn

2024-04-12 Thread Nathan Chancellor
On Fri, Apr 12, 2024 at 02:05:47PM +0200, Thomas Gleixner wrote: > On Thu, Apr 11 2024 at 11:45, Nathan Chancellor wrote: > > I have based this change on timers/urgent, as the commit that introduces > > this particular warning is there and it is marked for stable, even > > though this appears to be

Re: [PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn

2024-04-12 Thread Bill Wendling
On Thu, Apr 11, 2024 at 11:45 AM Nathan Chancellor wrote: > > After commit 6d029c25b71f ("selftests/timers/posix_timers: Reimplement > check_timer_distribution()"), clang warns: > > tools/testing/selftests/timers/../kselftest.h:398:6: warning: variable > 'major' is used uninitialized whenever '

Re: [PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn

2024-04-12 Thread Thomas Gleixner
On Thu, Apr 11 2024 at 11:45, Nathan Chancellor wrote: > I have based this change on timers/urgent, as the commit that introduces > this particular warning is there and it is marked for stable, even > though this appears to be a generic kselftest issue. I think it makes > the most sense for this ch

Re: [PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn

2024-04-11 Thread Shuah Khan
On 4/11/24 12:45, Nathan Chancellor wrote: After commit 6d029c25b71f ("selftests/timers/posix_timers: Reimplement check_timer_distribution()"), clang warns: tools/testing/selftests/timers/../kselftest.h:398:6: warning: variable 'major' is used uninitialized whenever '||' condition is true [

[PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn

2024-04-11 Thread Nathan Chancellor
After commit 6d029c25b71f ("selftests/timers/posix_timers: Reimplement check_timer_distribution()"), clang warns: tools/testing/selftests/timers/../kselftest.h:398:6: warning: variable 'major' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized] 398 | i