Re: [PATCH v2] lib/math: Add int_sqrt test suite

2024-10-25 Thread Andy Shevchenko
re.kernel.org/all/20241009162719.0adae...@canb.auug.org.au/ > > Again, I appreciate your time and review. I hope this answered some of your > questions. > I'll continue to follow this thread so as to make any additional fixes > from further reviews before sending out the next version. Okay, I will wait for new Linux next tags. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2] lib/math: Add int_sqrt test suite

2024-10-25 Thread Andy Shevchenko
Linux Next... ... > +#include > +#include > +#include > +#include > +#include linux/limits.h, of course. Sorry that I wasn't clear about this, but it's kinda rule of thumb that all headers in 99.999% kernel-space related files in the Linux kernel are from in-project folders and not from outside. -- With Best Regards, Andy Shevchenko

Re: [PATCH] lib/math: Add int_sqrt test suite

2024-10-24 Thread Andy Shevchenko
_div64.o > obj-$(CONFIG_TEST_MULDIV64) += test_mul_u64_u64_div_u64.o > obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o > +obj-y += tests/ > \ No newline at end of file ^^^ Please, fix this. ... > +#include + limits.h > +#include + module.h + string.h -- With Best Regards, Andy Shevchenko

Re: [PATCH v6] lib: add basic KUnit test for lib/math

2024-05-16 Thread Andy Shevchenko
series and add > changes on top of that for new macros. > > Kindly let me know your thoughts on this. Wow, blast from the past! But good finding, it would be good to have more math.h related test cases. -- With Best Regards, Andy Shevchenko

Re: [kselftests/powerpc] Primitives test build failure with linux-next

2024-02-29 Thread Andy Shevchenko
ed by following commit > > commit 66a5c40f60f5d88ad8d47ba6a4ba05892853fa1f > kernel.h: removed REPEAT_BYTE from kernel.h Thanks for the report. What is missing here are the steps to reproduce it here. E.g., I have an x86_64 machine, I can use QEMU if required. -- With Best Regards, Andy Shevchenko

Re: selftests: gpio: crash on arm64

2023-11-14 Thread andy . shevchenko
Tue, Nov 07, 2023 at 07:21:32PM +0530, Naresh Kamboju kirjoitti: > On Tue, 20 Jun 2023 at 22:11, Andy Shevchenko > wrote: > > On Tue, Apr 11, 2023 at 10:57:28AM +0200, Linus Walleij wrote: > > > On Mon, Apr 10, 2023 at 11:16 AM Naresh Kamboju > > > wr