Re: [PATCH] selftests: bpf: remove unused variables

2023-10-13 Thread Yafang Shao
On Fri, Oct 13, 2023 at 9:35 AM zhujun2 wrote: > > These variables are never referenced in the code, just remove them. You can't remove them because they are really referenced in the CHECK() marco. Sending a patch without even testing a build is bad :( > > Signed-off-by: zhujun2 > --- > tools/

Re: [PATCH 2/3] Revert "bpf: Fix issue in verifying allow_ptr_leaks"

2023-09-18 Thread Yafang Shao
On Mon, Sep 18, 2023 at 7:52 PM Luis Gerhorst wrote: > > On 15/09/2023 04:26, Yafang Shao wrote: > > On Wed, Sep 13, 2023 at 8:30 PM Luis Gerhorst wrote: > >> > >> This reverts commit d75e30dddf73449bc2d10bb8e2f1a2c446bc67a2. > >> > >> To mi

Re: [PATCH 2/3] Revert "bpf: Fix issue in verifying allow_ptr_leaks"

2023-09-14 Thread Yafang Shao
On Wed, Sep 13, 2023 at 8:30 PM Luis Gerhorst wrote: > > This reverts commit d75e30dddf73449bc2d10bb8e2f1a2c446bc67a2. > > To mitigate Spectre v1, the verifier relies on static analysis to deduct > constant pointer bounds, which can then be enforced by rewriting pointer > arithmetic [1] or index m