Re: [PATCH] kselftests: dmabuf-heaps: Ensure the driver name is null-terminated

2024-07-08 Thread T.J. Mercier
On Mon, Jul 8, 2024 at 6:47 AM Zenghui Yu wrote: > > Even if a vgem device is configured in, we will skip the import_vgem_fd() > test almost every time. > > TAP version 13 > 1..11 > # Testing heap: system > # === > # Testing allocation and importing: >

Re: [PATCH v4 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-03-04 Thread T.J. Mercier
if (ret) { > - printf("FAIL (Allocation Failed!)\n"); > - ret = -1; > - goto out; > + ksft_test_result_fail("FAIL (Allocation Failed!)\n"); > + return; Might as well setup goto out to clean u

Re: [PATCH v3 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread T.J. Mercier
On Thu, Feb 29, 2024 at 1:21 AM Muhammad Usama Anjum wrote: > > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v2: > - Minor improvements in te

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread T.J. Mercier
On Thu, Feb 29, 2024 at 1:14 AM Muhammad Usama Anjum wrote: > > On 2/28/24 11:47 PM, T.J. Mercier wrote: > > On Wed, Feb 28, 2024 at 3:46 AM Muhammad Usama Anjum > > wrote: > >> > >> On 2/27/24 10:18 PM, T.J. Mercier wrote: > >>> On Tue, Feb 27, 2

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread T.J. Mercier
On Thu, Feb 29, 2024 at 1:03 AM Muhammad Usama Anjum wrote: > > On 2/28/24 11:51 PM, T.J. Mercier wrote: > > On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum > > wrote: > > > > .. > > > >> +static int numer_of_heaps(void) > >> +{ >

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-28 Thread T.J. Mercier
On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum wrote: ... > +static int numer_of_heaps(void) > +{ > + DIR *d = opendir(DEVPATH); > + struct dirent *dir; > + int heaps = 0; > + > + while ((dir = readdir(d))) { > + if (!strncmp(dir->d_name, ".", 2)) > +

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-28 Thread T.J. Mercier
On Wed, Feb 28, 2024 at 3:46 AM Muhammad Usama Anjum wrote: > > On 2/27/24 10:18 PM, T.J. Mercier wrote: > > On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum > > wrote: > >> > >> Conform the layout, informational and status messages to TAP. No > >

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-27 Thread T.J. Mercier
On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum wrote: > > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v1: > - Update some more error h

Re: [PATCH 2/2] selftests: dmabuf-heap: add config file for the test

2024-02-26 Thread T.J. Mercier
ode 100644 > index 0..34bd294836df0 > --- /dev/null > +++ b/tools/testing/selftests/dmabuf-heaps/config > @@ -0,0 +1,4 @@ > +CONFIG_DMABUF_HEAPS=y > +CONFIG_DMABUF_HEAPS_SYSTEM=y > +CONFIG_DRM_VGEM=y > + > -- > 2.42.0 Reviewed-by: T.J. Mercier

Re: [PATCH 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-26 Thread T.J. Mercier
On Sun, Feb 25, 2024 at 11:59 PM Muhammad Usama Anjum wrote: > > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > .../selftests/dmabuf-heaps/dmabuf-heap.c