[PATCH v4 2/2] selftests/amd-pstate: Added option to provide perf binary path

2023-10-12 Thread Swapnil Sapkal
In selftests/amd-pstate, distro `perf` is used to capture `perf stat` while running microbenchmarks. Distro `perf` is not working with upstream kernel. Fix this by providing an option to give the perf binary path. Reviewed-by: Mario Limonciello Signed-off-by: Swapnil Sapkal --- tools/testing

[PATCH v4 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-10-12 Thread Swapnil Sapkal
In selftests/amd-pstate, tbench and gitsource microbenchmarks are used to compare the performance with different governors. In current implementation the relative path to run `amd_pstate_tracer.py` is broken. Fix this by using absolute paths. Signed-off-by: Swapnil Sapkal --- .../x86

[PATCH v4 0/2] Fix issues observed in selftests/amd-pstate

2023-10-12 Thread Swapnil Sapkal
binary path to handle the case where distro perf does not work. Changelog v3->v4: * Addressed review comments from v3 Swapnil Sapkal (2): selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut selftests/amd-pstate: Added option to provide perf binary path .../

Re: [PATCH v3 2/2] selftests/amd-pstate: Added option to provide perf binary path

2023-10-11 Thread Swapnil Sapkal
Hello Mario, On 10/7/2023 12:29 AM, Mario Limonciello wrote: On 10/3/2023 00:10, Swapnil Sapkal wrote: In selftests/amd-pstate, distro `perf` is used to capture `perf stat` while running microbenchmarks. Distro `perf` is not working with upstream kernel. Fixed this by providing an option to

Re: [PATCH v3 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-10-11 Thread Swapnil Sapkal
Hello Mario, Thanks for reviewing. On 10/7/2023 12:35 AM, Mario Limonciello wrote: On 10/3/2023 00:10, Swapnil Sapkal wrote: In selftests/amd-pstate, tbench and gitsource microbenchmarks are used to compare the performance with different governors. In Current s/Current/current/ I will fix

[PATCH v3 2/2] selftests/amd-pstate: Added option to provide perf binary path

2023-10-02 Thread Swapnil Sapkal
In selftests/amd-pstate, distro `perf` is used to capture `perf stat` while running microbenchmarks. Distro `perf` is not working with upstream kernel. Fixed this by providing an option to give the perf binary path. Signed-off-by: Swapnil Sapkal --- tools/testing/selftests/amd-pstate

[PATCH v3 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-10-02 Thread Swapnil Sapkal
In selftests/amd-pstate, tbench and gitsource microbenchmarks are used to compare the performance with different governors. In Current implementation relative path to run `amd_pstate_tracer.py` are broken. Fixed this by using absolute paths. Signed-off-by: Swapnil Sapkal --- .../x86

[PATCH v3 0/2] Fix issues observed in selftests/amd-pstate

2023-10-02 Thread Swapnil Sapkal
path to handle the case where distro perf does not work. Changelog v2->v3: * Split the patch into two patches Swapnil Sapkal (2): selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut selftests/amd-pstate: Added option to provide perf binary path .../

Re: [PATCH v2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-09-29 Thread Swapnil Sapkal
Hello Mario, Thanks for taking a look at this patch. On 9/23/2023 3:52 AM, Mario Limonciello wrote: On 9/19/2023 05:33, Swapnil Sapkal wrote: In selftests/amd-pstate, tbench and gitsource microbenchmarks are used to compare the performance with different governors. In Current implementation

[PATCH v2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-09-19 Thread Swapnil Sapkal
stats while running these microbenchmarks. Distro `perf` is not working with upstream kernel. Fixed this by providing an option to give the perf binary path. Signed-off-by: Swapnil Sapkal --- .../x86/amd_pstate_tracer/amd_pstate_trace.py | 2 +- .../testing/selftests/amd-pstate/gitsource.sh | 14

Re: [PATCH 2/2] tools/power/x86/intel_pstate_tracer: Use pygnuplot package for Gnuplot

2023-09-19 Thread Swapnil Sapkal
Hello Doug, Sorry for delay in response. On 9/18/2023 3:13 AM, Doug Smythies wrote: On 2023.09.17 15:17 Doug wrote: On Fri, Sep 15, 2023 at 2:31 PM Mario Limonciello On 9/15/2023 16:15, Doug Smythies wrote: On 2023.09.15 03:41 Swapnil Sapkal wrote: ... Not really related, but for a few

[PATCH 2/2] tools/power/x86/intel_pstate_tracer: Use pygnuplot package for Gnuplot

2023-09-15 Thread Swapnil Sapkal
-off-by: Swapnil Sapkal --- tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py | 1 - tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py b/tools/power/x86

[PATCH 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-09-15 Thread Swapnil Sapkal
stats while running these microbenchmarks. Distro `perf` is not working with upstream kernel. Fixed this by providing an option to give the perf binary path. Signed-off-by: Swapnil Sapkal --- .../x86/amd_pstate_tracer/amd_pstate_trace.py | 2 +- .../testing/selftests/amd-pstate/gitsource.sh | 14

[PATCH 0/2] Fix issues observed with selftests/amd-pstate

2023-09-15 Thread Swapnil Sapkal
importing the Gnuplot in intel_pstate_tracer.py. Swapnil Sapkal (2): selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut tools/power/x86/intel_pstate_tracer: Use pygnuplot package for Gnuplot .../x86/amd_pstate_tracer/amd_pstate_trace.py | 3 +-- .../intel_pstate_tracer.py