RE: [xdp-hints] Re: [Intel-wired-lan] [PATCH iwl-next, v3 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-07 Thread Song, Yoong Siang
On Thursday, March 7, 2024 9:39 PM, Kurt Kanzenbach wrote: >Hi Maciej, > >On Wed Mar 06 2024, Maciej Fijalkowski wrote: >> On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote: >>> - tstamp->skb = NULL; >>> + /* Copy the tx hardware timestamp in

[PATCH iwl-next,v3 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-03 Thread Song Yoong Siang
xsk_tx_metadata_complete(). Co-developed-by: Lai Peter Jun Ann Signed-off-by: Lai Peter Jun Ann Signed-off-by: Song Yoong Siang Acked-by: John Fastabend --- drivers/net/ethernet/intel/igc/igc.h | 71 -- drivers/net/ethernet/intel/igc/igc_main.c | 113 -- drivers/net/ethernet

[PATCH iwl-next,v3 1/2] selftests/bpf: xdp_hw_metadata reduce sleep interval

2024-03-03 Thread Song Yoong Siang
: Song Yoong Siang Acked-by: John Fastabend Acked-by: Stanislav Fomichev --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c index

[PATCH iwl-next,v3 0/2] XDP Tx Hardware Timestamp for igc driver

2024-03-03 Thread Song Yoong Siang
inicius & John). V2 -> V3 - Improve tstamp reg searching loop for better readability. - In igc_ptp_free_tx_buffer(), add comment to inform user that tstamp->xsk_tx_buffer and tstamp->skb are in union. Song Yoong Siang (2): selftests/bpf: xdp_hw_metadata reduce sleep interval igc:

RE: [PATCH iwl-next,v2 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-02 Thread Song, Yoong Siang
On Sunday, March 3, 2024 9:59 AM, John Fastabend wrote: >Song, Yoong Siang wrote: >> On Saturday, March 2, 2024 1:55 AM, John Fastabend >> wrote: >> >Song Yoong Siang wrote: >> >> This patch adds support to per-packet Tx hardware timestamp request to >

RE: [PATCH iwl-next,v2 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-01 Thread Song, Yoong Siang
On Saturday, March 2, 2024 1:55 AM, John Fastabend wrote: >Song Yoong Siang wrote: >> This patch adds support to per-packet Tx hardware timestamp request to >> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that >> user needs to enable Tx HW timestamp cap

[PATCH iwl-next,v2 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-01 Thread Song Yoong Siang
xsk_tx_metadata_complete(). Co-developed-by: Lai Peter Jun Ann Signed-off-by: Lai Peter Jun Ann Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc.h | 71 -- drivers/net/ethernet/intel/igc/igc_main.c | 108 -- drivers/net/ethernet/intel/igc/igc_ptp.c | 40

[PATCH iwl-next,v2 1/2] selftests/bpf: xdp_hw_metadata reduce sleep interval

2024-03-01 Thread Song Yoong Siang
: Song Yoong Siang --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c index 878d68db0325..bdf5d8180067 100644 --- a/tools/testing

[PATCH iwl-next,v2 0/2] XDP Tx Hardware Timestamp for igc driver

2024-03-01 Thread Song Yoong Siang
n early return if none of the 4 ts registers is available (Vinicius). - Create helper functions to clear tx buffer and skb for tstamp (John). - Perform throughput test with mix traffic (Vinicius & John). Song Yoong Siang (2): selftests/bpf: xdp_hw_metadata reduce sleep interval igc: Add

RE: [xdp-hints] Re: [PATCH bpf-next v3 2/3] net: stmmac: add Launch Time support to XDP ZC

2023-12-17 Thread Song, Yoong Siang
Hi all, Fyi, I submitted a patch [1] to enable tx metadata for igc driver as a preparation to add launch time to it. After the patch is accepted, I will include igc driver in next version of launch time patch set. [1] https://patchwork.kernel.org/project/netdevbpf/patch/20231215162158.951925-1

RE: [PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC

2023-12-05 Thread Song, Yoong Siang
On Tuesday, December 5, 2023 10:55 PM, Willem de Bruijn wrote: >Song, Yoong Siang wrote: >> On Monday, December 4, 2023 10:58 PM, Willem de Bruijn wrote: >> >Song, Yoong Siang wrote: >> >> On Friday, December 1, 2023 11:02 PM, Jesper Dangaard Brouer wrote: >> &g

RE: [PATCH bpf-next v3 2/3] net: stmmac: add Launch Time support to XDP ZC

2023-12-05 Thread Song, Yoong Siang
On Monday, December 4, 2023 10:55 PM, Willem de Bruijn wrote: >Jesper Dangaard Brouer wrote: >> >> >> On 12/3/23 17:51, Song Yoong Siang wrote: >> > This patch enables Launch Time (Time-Based Scheduling) support to XDP zero >> > copy via XDP Tx metadata f

RE: [xdp-hints] Re: [PATCH bpf-next v3 3/3] selftests/bpf: add Launch Time request to xdp_hw_metadata

2023-12-05 Thread Song, Yoong Siang
On Monday, December 4, 2023 11:00 PM, Willem de Bruijn wrote: >Jesper Dangaard Brouer wrote: >> >> >> On 12/3/23 17:51, Song Yoong Siang wrote: >> > This patch is tested with stmmac on Intel Tiger Lake platform. Refer to >> > result below, the delta between p

RE: [PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC

2023-12-05 Thread Song, Yoong Siang
On Monday, December 4, 2023 10:58 PM, Willem de Bruijn wrote: >Song, Yoong Siang wrote: >> On Friday, December 1, 2023 11:02 PM, Jesper Dangaard Brouer wrote: >> >On 12/1/23 07:24, Song Yoong Siang wrote: >> >> This patch enables txtime support to XDP zero copy via X

[PATCH bpf-next v3 3/3] selftests/bpf: add Launch Time request to xdp_hw_metadata

2023-12-03 Thread Song Yoong Siang
sec) XDP RX-time: 1677762699254901232 (sec:1677762699.2549) delta to User TX-complete-time sec:0.0101 (10099.631 usec) HW RX-time: 167776269925455 (sec:1677762699.2547) delta to HW TX-complete-time sec:0.0100 (10024.307 usec) 0x558336d397a8: complete rx idx=143 addr=9e100 Signed-off-by: Song Yoong Siang --

[PATCH bpf-next v3 2/3] net: stmmac: add Launch Time support to XDP ZC

2023-12-03 Thread Song Yoong Siang
This patch enables Launch Time (Time-Based Scheduling) support to XDP zero copy via XDP Tx metadata framework. Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 + 2 files changed, 15

[PATCH bpf-next v3 1/3] xsk: add Launch Time HW offload to XDP Tx metadata

2023-12-03 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 Documentation/networking/xsk-tx-metadata.rst | 4 include/net/xdp_sock.h | 10 ++ include/net

[PATCH bpf-next v3 0/3] xsk: TX metadata Launch Time support

2023-12-03 Thread Song Yoong Siang
68-1-yoong.siang.s...@intel.com/ Song Yoong Siang (3): xsk: add Launch Time HW offload to XDP Tx metadata net: stmmac: add Launch Time support to XDP ZC selftests/bpf: add Launch Time request to xdp_hw_metadata Documentation/netlink/specs/netdev.yaml | 4 Documentation/networking/xs

RE: [PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC

2023-12-03 Thread Song, Yoong Siang
On Friday, December 1, 2023 11:02 PM, Jesper Dangaard Brouer wrote: >On 12/1/23 07:24, Song Yoong Siang wrote: >> This patch enables txtime support to XDP zero copy via XDP Tx >> metadata framework. >> >> Signed-off-by: Song Yoong Siang >> --- >> drive

RE: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

2023-12-03 Thread Song, Yoong Siang
On Saturday, December 2, 2023 10:16 PM, Willem de Bruijn wrote: >Jesper Dangaard Brouer wrote: >> >> >> On 12/1/23 16:09, Willem de Bruijn wrote: >> > Song, Yoong Siang wrote: >> >> On Friday, December 1, 2023 6:46 PM, Jesper Dangaard Brouer > wrote: &g

RE: [PATCH bpf-next 1/3] xsk: add launch time support to XDP Tx metadata

2023-12-03 Thread Song, Yoong Siang
On Saturday, December 2, 2023 11:29 AM, Jakub Kicinski wrote: >On Fri, 1 Dec 2023 00:20:26 +0800 Song Yoong Siang wrote: >> +name: launch-time >> +doc: >> + HW Time-Based Scheduling (TBS) is supported by the driver. > >Does this mean fifo "

RE: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

2023-12-01 Thread Song, Yoong Siang
On Friday, December 1, 2023 6:46 PM, Jesper Dangaard Brouer wrote: >On 12/1/23 07:24, Song Yoong Siang wrote: >> This series expands XDP TX metadata framework to include ETF HW offload. >> >> Changes since v1: >> - rename Time-Based Scheduling (TBS) to Earliest TxT

[PATCH bpf-next v2 3/3] selftests/bpf: Add txtime to xdp_hw_metadata

2023-11-30 Thread Song Yoong Siang
.0101 (10090.557 usec) HW RX-time: 1677764655807717783 (sec:1677764655.8077) delta to HW TX-complete-time sec:0.0100 (10023.965 usec) 0x5626d54de7a8: complete rx idx=128 addr=80100 Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 18 +- 1

[PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC

2023-11-30 Thread Song Yoong Siang
This patch enables txtime support to XDP zero copy via XDP Tx metadata framework. Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 + 2 files changed, 15 insertions(+) diff --git a

[PATCH bpf-next v2 1/3] xsk: add ETF support to XDP Tx metadata

2023-11-30 Thread Song Yoong Siang
struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 Documentation/networking/xsk-tx-metadata.rst | 5 + include/net/xdp_sock.h | 9 + include/net/xdp_sock_drv.h

[PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

2023-11-30 Thread Song Yoong Siang
...@intel.com/ Song Yoong Siang (3): xsk: add ETF support to XDP Tx metadata net: stmmac: Add txtime support to XDP ZC selftests/bpf: Add txtime to xdp_hw_metadata Documentation/netlink/specs/netdev.yaml| 4 Documentation/networking/xsk-tx-metadata.rst | 5 + drivers/net/ethernet

RE: [PATCH bpf-next 1/3] xsk: add launch time support to XDP Tx metadata

2023-11-30 Thread Song, Yoong Siang
On Friday, December 1, 2023 4:29 AM, Willem de Bruijn wrote: >Song Yoong Siang wrote: >> This patch extends the XDP Tx metadata framework to include Time-Based >> Scheduling (TBS) support where the NIC will schedule a packet for >> transmission at a pre-determined time ca

[PATCH bpf-next 3/3] selftests/bpf: Add launch time to xdp_hw_metadata

2023-11-30 Thread Song Yoong Siang
.557 usec) HW RX-time: 1677764655807717783 (sec:1677764655.8077) delta to HW TX-complete-time sec:0.0100 (10023.965 usec) 0x5626d54de7a8: complete rx idx=128 addr=80100 Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 18 +- 1 file change

[PATCH bpf-next 2/3] net: stmmac: Add launch time support to XDP ZC

2023-11-30 Thread Song Yoong Siang
This patch enables launch time support to XDP zero copy via XDP Tx metadata framework. Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 + 2 files changed, 15 insertions(+) diff

[PATCH bpf-next 1/3] xsk: add launch time support to XDP Tx metadata

2023-11-30 Thread Song Yoong Siang
struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 Documentation/networking/xsk-tx-metadata.rst | 5 + include/net/xdp_sock.h | 10 ++ include/net/xdp_sock_drv.h

[PATCH bpf-next 0/3] xsk: TX metadata launch time support

2023-11-30 Thread Song Yoong Siang
This series expands XDP TX metadata framework to include HW launch time offload. Song Yoong Siang (3): xsk: add launch time support to XDP Tx metadata net: stmmac: Add launch time support to XDP ZC selftests/bpf: Add launch time to xdp_hw_metadata Documentation/netlink/specs/netdev.yaml