Re: [PATCH 0/4] drivers: base: Don't match device with NULL of_node/fwnode/etc + tests

2024-12-11 Thread Rob Herring
drivers: base: test: Add ...find_device_by...(... NULL) tests > > drivers/base/core.c | 8 ++--- > drivers/base/test/Kconfig| 1 + > drivers/base/test/platform-device-test.c | 42 ++++++++ > 3 files changed, 40 insertions(+), 11 deletions(-) Reviewed-by: Rob Herring (Arm)

Re: [PATCH 02/13] dt-bindings: thead: add a vlen register length property

2024-06-09 Thread Rob Herring (Arm)
On Sun, 09 Jun 2024 21:45:07 -0700, Charlie Jenkins wrote: > Add a property analogous to the vlenb CSR so that software can detect > the vector length of each CPU prior to it being brought online. > Currently software has to assume that the vector length read from the > boot CPU applies to all po

Re: [PATCH v5 01/11] of/platform: Allow overlays to create platform devices from the root node

2024-06-05 Thread Rob Herring (Arm)
ate() with NULL as the first argument. > > Loosen the requirement here so that platform devices can be created for > nodes created as children of the root node via DT overlays even if the > platform bus wasn't populated for the root node. > > Cc: Rob Herring > Cc: Saravana Kannan

Re: [PATCH v5 05/11] of: Add a KUnit test for overlays and test managed APIs

2024-06-05 Thread Rob Herring
t; with fake platform devices and device nodes via overlays compiled into > the kernel image. > > Cc: Rob Herring > Cc: Saravana Kannan > Cc: Daniel Latypov > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae Moar > Reviewed-by: Rob Herring (Arm) > Signed

Re: [PATCH v5 07/11] dt-bindings: test: Add single clk consumer

2024-06-04 Thread Rob Herring
On Tue, Jun 4, 2024 at 1:28 PM Stephen Boyd wrote: > > Quoting Rob Herring (2024-06-04 06:05:26) > > On Mon, Jun 03, 2024 at 03:38:04PM -0700, Stephen Boyd wrote: > > > Describe a binding for a device that consumes a single clk in DT. This > > > will initially be u

Re: [PATCH v5 07/11] dt-bindings: test: Add single clk consumer

2024-06-04 Thread Rob Herring
On Mon, Jun 03, 2024 at 03:38:04PM -0700, Stephen Boyd wrote: > Describe a binding for a device that consumes a single clk in DT. This > will initially be used by a KUnit test to clk_get() the clk registered > by of_fixed_clk_setup() and test that it is setup properly. > > Cc: Ro

Re: [PATCH v5 07/11] dt-bindings: test: Add single clk consumer

2024-06-04 Thread Rob Herring (Arm)
On Mon, 03 Jun 2024 15:38:04 -0700, Stephen Boyd wrote: > Describe a binding for a device that consumes a single clk in DT. This > will initially be used by a KUnit test to clk_get() the clk registered > by of_fixed_clk_setup() and test that it is setup properly. > > Cc: Ro

Re: [PATCH v4 00/10] clk: Add kunit tests for fixed rate and parent data

2024-05-15 Thread Rob Herring
On Wed, May 15, 2024 at 4:15 PM Stephen Boyd wrote: > > Quoting Rob Herring (2024-05-15 06:06:09) > > On Tue, May 14, 2024 at 4:29 PM Stephen Boyd wrote: > > > > > > powerpc doesn't mark the root node with OF_POPULATED_BUS. If I set that > > > in

Re: [PATCH v4 00/10] clk: Add kunit tests for fixed rate and parent data

2024-05-15 Thread Rob Herring
On Tue, May 14, 2024 at 4:29 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2024-05-02 18:27:42) > > Quoting David Gow (2024-05-01 01:08:11) > > > > > > The other thing I've noted so far is that the > > > of_apply_kunit_platform_device and of_overlay_apply_kunit_cleanup > > > tests fail (and BUG

Re: [PATCH v4 04/10] of: Add a KUnit test for overlays and test managed APIs

2024-04-23 Thread Rob Herring
t; with fake platform devices and device nodes via overlays compiled into > the kernel image. > > Cc: Rob Herring > Cc: Saravana Kannan > Cc: Daniel Latypov > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae Moar > Signed-off-by: Stephen Boyd > --- > drivers/of/

Re: [PATCH v4 01/10] of: Add test managed wrappers for of_overlay_apply()/of_node_put()

2024-04-23 Thread Rob Herring
t overwrite properties in the live tree. The easiest way to > do this is to add and remove nodes with a 'kunit-' prefix, almost > guaranteeing that the same node won't be present in the tree loaded at > boot. > > Suggested-by: Rob Herring > Cc: Rob Herring > Cc:

Re: [PATCH v3 04/29] riscv: zicfilp / zicfiss in dt-bindings (extensions.yaml)

2024-04-15 Thread Rob Herring
On Wed, Apr 10, 2024 at 02:37:21PM -0700, Deepak Gupta wrote: > On Wed, Apr 10, 2024 at 4:58 AM Rob Herring wrote: > > > > On Wed, Apr 03, 2024 at 04:34:52PM -0700, Deepak Gupta wrote: > > > Make an entry for cfi extensions in extensions.yaml. > > >

Re: [PATCH v3 04/29] riscv: zicfilp / zicfiss in dt-bindings (extensions.yaml)

2024-04-10 Thread Rob Herring
On Wed, Apr 03, 2024 at 04:34:52PM -0700, Deepak Gupta wrote: > Make an entry for cfi extensions in extensions.yaml. > > Signed-off-by: Deepak Gupta > --- > .../devicetree/bindings/riscv/extensions.yaml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/

Re: [PATCH v4 0/7] of: populate of_root node if bootloader doesn't

2024-03-08 Thread Rob Herring
On Fri, Feb 16, 2024 at 05:05:49PM -0800, Stephen Boyd wrote: > Arch maintainers, please ack/review patches. > > This is a resend of a series from Frank last year[1]. I worked in Rob's > review comments to unconditionally call unflatten_device_tree() and > fixup/audit calls to of_have_populated_dt

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-28 Thread Rob Herring
On Tue, Feb 27, 2024 at 05:34:58PM +, Mark Rutland wrote: > On Fri, Feb 23, 2024 at 11:17:02AM -0700, Rob Herring wrote: > > On Fri, Feb 23, 2024 at 3:23 AM Will Deacon wrote: > > > > > > On Thu, Feb 22, 2024 at 05:03:17PM -0700, Rob Herring wrote: > > >

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-23 Thread Rob Herring
On Fri, Feb 23, 2024 at 3:23 AM Will Deacon wrote: > > On Thu, Feb 22, 2024 at 05:03:17PM -0700, Rob Herring wrote: > > On Fri, Feb 16, 2024 at 05:05:54PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > >

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-22 Thread Rob Herring
and copy the 'initial_boot_params' data. > > Cc: Rob Herring > Cc: Frank Rowand > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: > Signed-off-by: Stephen Boyd > --- > arch/arm64/kernel/setup.c | 3 +-- > 1 file changed, 1 insertion(

Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware

2024-02-21 Thread Rob Herring
oved because it prevents > > overlays from creating platform devices when the empty root node is > > used. > > > > [sb...@kernel.org: Update of_have_populated_dt() to treat this empty dtb > > as not populated. Drop setup_of() initcall] > > > > Signed-off-by:

Re: [PATCH v3 7/7] of: Add KUnit test to confirm DTB is loaded

2024-02-13 Thread Rob Herring
: > > > > > Add a KUnit test that confirms a DTB has been loaded, i.e. there is a > > > > > root node, and that the of_have_populated_dt() API works properly. > > > > > > > > > > Cc: Rob Herring > > > > > Cc:

Re: [PATCH v2 1/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-02 Thread Rob Herring
On Wed, Jan 31, 2024 at 02:59:53PM -0800, Stephen Boyd wrote: > Quoting Rob Herring (2024-01-31 12:54:05) > > On Mon, Jan 29, 2024 at 04:45:00PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > > on platf

Re: [PATCH v2 1/7] arm64: Unconditionally call unflatten_device_tree()

2024-01-31 Thread Rob Herring
but the > bootloader has loaded a DTB so that we don't allow both ACPI and DT to > be used during boot. If there isn't a valid initial_boot_params dtb then > unflatten_device_tree() returns early so this is fine. > > Cc: Rob Herring > Cc: Frank Rowand > Cc: Catal

Re: [PATCH] selftests: Move KTAP bash helpers to selftests common folder

2024-01-22 Thread Rob Herring
esting/selftests/{dt => kselftest}/ktap_helpers.sh | 6 ++ > 4 files changed, 9 insertions(+), 6 deletions(-) > rename tools/testing/selftests/{dt => kselftest}/ktap_helpers.sh (94%) Acked-by: Rob Herring

Re: [PATCH v2] kselftest: dt: Stop relying on dirname to improve performance

2024-01-22 Thread Rob Herring
On Mon, Jan 22, 2024 at 11:29:18AM -0300, Nícolas F. R. A. Prado wrote: > When walking directory trees, instead of looking for specific files and > running dirname to get the parent folder, traverse all folders and > ignore the ones not containing the desired files. This avoids the need > to call d

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-19 Thread Rob Herring
On Thu, Jan 18, 2024 at 03:26:43PM +, Mark Rutland wrote: > On Tue, Jan 16, 2024 at 05:27:18PM -0800, Stephen Boyd wrote: > > Quoting Mark Rutland (2024-01-16 03:51:14) > > > Hi Stephen, > > > > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > > Call this function uncond

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-18 Thread Rob Herring
On Thu, Jan 18, 2024 at 2:46 AM Geert Uytterhoeven wrote: > > Hi Rob, > > On Wed, Jan 17, 2024 at 6:41 PM Rob Herring wrote: > > On Tue, Jan 16, 2024 at 05:18:15PM -0800, Stephen Boyd wrote: > > > Quoting Rob Herring (2024-01-15 12:32:30) > > > > On Fri, Ja

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-17 Thread Rob Herring
On Tue, Jan 16, 2024 at 05:27:18PM -0800, Stephen Boyd wrote: > Quoting Mark Rutland (2024-01-16 03:51:14) > > Hi Stephen, > > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > > on platforms that don

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-17 Thread Rob Herring
On Tue, Jan 16, 2024 at 05:18:15PM -0800, Stephen Boyd wrote: > Quoting Rob Herring (2024-01-15 12:32:30) > > On Fri, Jan 12, 2024 at 12:07:47PM -0800, Stephen Boyd wrote: > > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > index da9826accb1b..9628e48baa15

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-15 Thread Rob Herring
7;t > fully initialized. > > Signed-off-by: Frank Rowand > Link: > https://lore.kernel.org/r/20230317053415.2254616-2-frowand.l...@gmail.com > Cc: Rob Herring > [sb...@kernel.org: Update of_have_populated_dt() to treat this empty dtb > as not populated. Drop se

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-15 Thread Rob Herring
27;t see an issue with that. There was worry when ACPI was added that systems would pass both DT and ACPI tables and that the kernel must only use ACPI. That was more to force ACPI adoption, but I'm not sure if that actually exists in any early system. I think we're past forcing ado

Re: [PATCH v3 3/3] kselftest: Add new test for detecting unprobed Devicetree devices

2023-11-06 Thread Rob Herring
On Thu, Nov 2, 2023 at 12:36 PM Mark Brown wrote: > > On Thu, Nov 02, 2023 at 07:15:58PM +0530, Naresh Kamboju wrote: > > On Thu, 2 Nov 2023 at 17:41, Aishwarya TCV wrote: > > > > https://storage.kernelci.org/mainline/master/v6.6-9152-gdeefd5024f07/arm64/defconfig%2Bkselftest/gcc-10/logs/kselftes

Re: [PATCH v3 0/3] Add a test to catch unprobed Devicetree devices

2023-09-20 Thread Rob Herring
On Wed, Sep 20, 2023 at 10:03:06AM -0400, Nícolas F. R. A. Prado wrote: > On Mon, Aug 28, 2023 at 05:13:09PM -0400, Nícolas F. R. A. Prado wrote: > > > > Regressions that cause a device to no longer be probed by a driver can > > have a big impact on the platform's functionality, and despite being