Re: [PATCH v3] kunit: fix longest symbol length test

2025-07-03 Thread Randy Dunlap
On 5/14/25 2:00 PM, Randy Dunlap wrote: > > > On 5/14/25 12:24 PM, Sergio González Collado wrote: >> The kunit test that checks the longests symbol length [1], has triggered >> warnings in some pilelines when symbol prefixes are used [2][3]. The test >> will to de

Re: [PATCH v3] kunit: fix longest symbol length test

2025-05-14 Thread Randy Dunlap
03b37-c4d9-4a92-9be2-75aaf8c19...@infradead.org/T/#t > [4] > https://lore.kernel.org/linux-kselftest/20250427200916.GA1661412@ax162/T/#t > > Reviewed-by: Rae Moar > Signed-off-by: Sergio González Collado Works for me. Thanks. Acked-by: Randy Dunlap Tested-by: Randy Dunlap > --- > v

Re: [PATCH v2] kunit: fix longest symbol length test

2025-05-12 Thread Randy Dunlap
Hi, On 5/2/25 7:37 AM, Sergio González Collado wrote: > The kunit test that checks the longests symbol length [1], has triggered > warnings in some pilelines when symbol prefixes are used [2]. The test > is adjunsted to depend on !PREFIX_SYMBOLS and !CFI_CLANG as sujested in [3] > > [1] > https:

Re: [PATCH v3 7/7] Docs/admin-guide/mm/workingset_report: document sysfs and memcg interfaces

2024-08-13 Thread Randy Dunlap
Hi, On 8/13/24 9:56 AM, Yuanchu Xie wrote: > Add workingset reporting documentation for better discoverability of > its sysfs and memcg interfaces. Also document the required kernel > config to enable workingset reporting. > > Change-Id: Ib9dfc9004473baa6ef26ca7277d220b6199517de > Signed-off-by:

Re: [PATCH 2/3] bitmap: Rename module

2024-07-30 Thread Randy Dunlap
On 7/30/24 12:51 AM, Muhammad Usama Anjum wrote: > On 7/29/24 7:09 PM, Randy Dunlap wrote: >> >> >> On 7/29/24 1:07 AM, Muhammad Usama Anjum wrote: >>> On 7/27/24 10:35 PM, Yury Norov wrote: >>>> On Fri, Jul 26, 2024 at 04:06:57PM +0500, Muhammad

Re: [PATCH 2/3] bitmap: Rename module

2024-07-29 Thread Randy Dunlap
On 7/29/24 1:07 AM, Muhammad Usama Anjum wrote: > On 7/27/24 10:35 PM, Yury Norov wrote: >> On Fri, Jul 26, 2024 at 04:06:57PM +0500, Muhammad Usama Anjum wrote: >>> Rename module to bitmap_kunit and rename the configuration option >>> compliant with kunit framework. >> >> ... , so those enablin

Re: [PATCH v5 4/4] docs: mm: add enable_soft_offline sysctl

2024-06-25 Thread Randy Dunlap
Hi-- On 6/24/24 9:33 AM, Jiaqi Yan wrote: > Add the documentation for soft offline behaviors / costs, and what > the new enable_soft_offline sysctl is for. > > Acked-by: Oscar Salvador > > Signed-off-by: Jiaqi Yan > --- > Documentation/admin-guide/sysctl/vm.rst | 32 +

Re: [PATCH v9 05/39] arm64/gcs: Document the ABI for Guarded Control Stacks

2024-06-25 Thread Randy Dunlap
On 6/25/24 7:57 AM, Mark Brown wrote: > Add some documentation of the userspace ABI for Guarded Control Stacks. > > Reviewed-by: Thiago Jung Bauermann > Signed-off-by: Mark Brown > --- > Documentation/arch/arm64/gcs.rst | 233 > + > Documentation/arch/a

Re: [PATCH RFT v6 1/9] Documentation: userspace-api: Add shadow stack API documentation

2024-06-25 Thread Randy Dunlap
Hi, On 6/23/24 4:23 AM, Mark Brown wrote: > There are a number of architectures with shadow stack features which we are > presenting to userspace with as consistent an API as we can (though there > are some architecture specifics). Especially given that there are some > important considerations fo

Re: [PATCH 1/2] tools: kernel-chktaint: Fix bashism, simplify code

2024-06-21 Thread Randy Dunlap
e: > * remove "x" in the comparison (not needed for decades) > * use $# for checking number of arguments > * cleanup whitespace > > Fixes: 4ab5a5d2a4a22 ("tools: add a kernel-chktaint to tools/debugging") > Signed-off-by: Petr Vorel Acked-by: Randy Dunlap

Re: [PATCH v2 1/1] mm/memfd: add documentation for MFD_NOEXEC_SEAL MFD_EXEC

2024-06-11 Thread Randy Dunlap
On 6/10/24 8:49 PM, jef...@chromium.org wrote: > From: Jeff Xu > > Add documentation for memfd_create flags: MFD_NOEXEC_SEAL > and MFD_EXEC > > Cc: sta...@vger.kernel.org > Signed-off-by: Jeff Xu > > --- > Documentation/userspace-api/index.rst | 1 + > Documentation/userspace-api/mfd

Re: [PATCH v1 1/1] mm/memfd: add documentation for MFD_NOEXEC_SEAL MFD_EXEC

2024-06-10 Thread Randy Dunlap
Hi-- On 6/7/24 1:35 PM, jef...@chromium.org wrote: > From: Jeff Xu > > Add documentation for memfd_create flags: FMD_NOEXEC_SEAL s/FMD/MFD/ > and MFD_EXEC > > Signed-off-by: Jeff Xu > --- > Documentation/userspace-api/index.rst | 1 + > Documentation/userspace-api/mfd_noexec.rst | 86

Re: [PATCH v2 8/8] Docs/admin-guide/mm/workingset_report: document sysfs and memcg interfaces

2024-06-06 Thread Randy Dunlap
Hi, Just a couple of nits below: On 6/3/24 7:05 PM, Yuanchu Xie wrote: > Add workingset reporting documentation for better discoverability of > its sysfs and memcg interfaces. Also document the required kernel > config to enable workingset reporting. > > Signed-off-by: Yuanchu Xie > --- > Docu

Re: [PATCH v4 27/27] docs: ntsync: Add documentation for the ntsync uAPI.

2024-04-15 Thread Randy Dunlap
On 4/15/24 6:08 PM, Elizabeth Figura wrote: > Add an overall explanation of the driver architecture, and complete and > precise > specification for its intended behaviour. > > Reviewed-by: Bagas Sanjaya > Signed-off-by: Elizabeth Figura Tested-by: Ran

Re: [PATCH v4 01/14] lib: Add TLV parser

2024-04-15 Thread Randy Dunlap
On 4/15/24 12:19 PM, Jarkko Sakkinen wrote: > On Mon Apr 15, 2024 at 5:24 PM EEST, Roberto Sassu wrote: >> From: Roberto Sassu >> >> Add a parser of a generic TLV format: > > What is TLV? type-length-value i.e., a descriptor that contains a value. IIUC. -- #Randy https://people.kernel.org

Re: [RFC PATCH net-next v7 13/14] net: add devmem TCP documentation

2024-03-26 Thread Randy Dunlap
Hi, On 3/26/24 15:50, Mina Almasry wrote: > Add documentation outlining the usage and details of devmem TCP. > > Signed-off-by: Mina Almasry > > --- > > v7: > - Applied docs suggestions (Jakub). > > v2: > > - Missing spdx (simon) > - add to index.rst (simon) > > --- > Documentation/network

Re: [PATCH v4 2/7] HID: bpf: export hid_hw_output_report as a BPF kfunc

2024-03-15 Thread Randy Dunlap
On 3/15/24 07:44, Benjamin Tissoires wrote: > +/** > + * hid_bpf_hw_output_report - Send an output report to a HID device > + * > + * @ctx: the HID-BPF context previously allocated in > hid_bpf_allocate_context() > + * @buf: a %PTR_TO_MEM buffer > + * @buf__sz: the size of the data to transfer

Re: [PATCH v4 5/7] HID: bpf: allow to inject HID event from BPF

2024-03-15 Thread Randy Dunlap
On 3/15/24 07:44, Benjamin Tissoires wrote: > It can be interesting to inject events from BPF as if the event were > to come from the device. > For example, some multitouch devices do not all the time send a proximity > out event, and we might want to send it for the physical device. > > Compar

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-02 Thread Randy Dunlap
On 3/2/24 14:10, Guenter Roeck wrote: > On Thu, Feb 29, 2024 at 12:21 PM Linus Torvalds > wrote: >> >> On Thu, 29 Feb 2024 at 01:23, Nikolai Kondrashov wrote: >>> >>> However, I think a better approach would be *not* to add the .gitlab-ci.yaml >>> file in the root of the source tree, but inste

Re: [PATCH 01/31] ntsync: Introduce the ntsync driver and character device.

2024-02-14 Thread Randy Dunlap
Hi, On 2/14/24 15:36, Elizabeth Figura wrote: > ntsync uses a misc device as the simplest and least intrusive uAPI interface. > > Each file description on the device represents an isolated NT instance, > intended > to correspond to a single NT virtual machine. > > Signed-off-by: Elizabeth Figur

Re: [PATCH v3 02/13] security: Introduce the digest_cache LSM

2024-02-09 Thread Randy Dunlap
Hi-- On 2/9/24 06:09, Roberto Sassu wrote: > diff --git a/security/digest_cache/Kconfig b/security/digest_cache/Kconfig > new file mode 100644 > index ..0c47d5151f07 > --- /dev/null > +++ b/security/digest_cache/Kconfig > @@ -0,0 +1,17 @@ > +# SPDX-License-Identifier: GPL-2.0 > +config

Re: [PATCH RFT v5 1/7] Documentation: userspace-api: Add shadow stack API documentation

2024-02-03 Thread Randy Dunlap
Hi, On 2/2/24 16:04, Mark Brown wrote: > There are a number of architectures with shadow stack features which we are > presenting to userspace with as consistent an API as we can (though there > are some architecture specifics). Especially given that there are some > important considerations for u

Re: [RFC PATCH v4 4/4] mseal:add documentation

2024-01-16 Thread Randy Dunlap
On 1/16/24 12:13, Jonathan Corbet wrote: > jef...@chromium.org writes: > >> From: Jeff Xu >> >> Add documentation for mseal(). >> >> Signed-off-by: Jeff Xu >> --- >> Documentation/userspace-api/mseal.rst | 181 ++ >> 1 file changed, 181 insertions(+) >> create mode 1

Re: [PATCH v6 0/4] Introduce mseal()

2024-01-12 Thread Randy Dunlap
On 1/12/24 20:53, Jeff Xu wrote: > On Fri, Jan 12, 2024 at 6:20 PM Randy Dunlap wrote: >> >> >> >> On 1/11/24 15:41, jef...@chromium.org wrote: >>> From: Jeff Xu >>> >>> This patchset proposes a new mseal() syscall for the Linux kernel.

Re: [PATCH v6 0/4] Introduce mseal()

2024-01-12 Thread Randy Dunlap
On 1/11/24 15:41, jef...@chromium.org wrote: > From: Jeff Xu > > This patchset proposes a new mseal() syscall for the Linux kernel. > Jeff, Building arm64 defconfig, on linux-next-20240112, I get: CC arch/arm64/kernel/asm-offsets.s In file included from ../include/uapi/linux/mman.h:5

Re: [PATCH v6 4/4] mseal:add documentation

2024-01-12 Thread Randy Dunlap
Hi Jeff, On 1/11/24 15:41, jef...@chromium.org wrote: > From: Jeff Xu > > Add documentation for mseal(). > > Signed-off-by: Jeff Xu > --- > Documentation/userspace-api/mseal.rst | 181 ++ > 1 file changed, 181 insertions(+) > create mode 100644 Documentation/userspac

Re: [RFC PATCH v5 4/4] mseal:add documentation

2024-01-10 Thread Randy Dunlap
On 1/9/24 07:45, jef...@chromium.org wrote: > From: Jeff Xu > > Add documentation for mseal(). > > Signed-off-by: Jeff Xu > --- > Documentation/userspace-api/mseal.rst | 181 ++ > 1 file changed, 181 insertions(+) > create mode 100644 Documentation/userspace-api/mse

Re: [RFC PATCH v4 4/4] mseal:add documentation

2024-01-04 Thread Randy Dunlap
On 1/4/24 10:51, jef...@chromium.org wrote: > From: Jeff Xu > > Add documentation for mseal(). > > Signed-off-by: Jeff Xu > --- > Documentation/userspace-api/mseal.rst | 181 ++ > 1 file changed, 181 insertions(+) > create mode 100644 Documentation/userspace-api/mse

Re: [PATCH] kunit: Fix some comments which were mistakenly kerneldoc

2023-12-22 Thread Randy Dunlap
ng devices") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202312181920.h4epah20-...@intel.com/ > Signed-off-by: David Gow Reviewed-by: Randy Dunlap Thanks. > --- > lib/kunit/device.c | 6 +++--- > 1 file changed, 3 inse

Re: [PATCH][next] selftests/net: Fix various spelling mistakes in TCP-AO tests

2023-12-18 Thread Randy Dunlap
On 12/18/23 05:30, Colin Ian King wrote: > There are a handful of spelling mistakes in test messages in the > TCP-AIO selftests. Fix these. > > Signed-off-by: Colin Ian King Reviewed-by: Randy Dunlap Thanks. > --- > tools/testing/selftests/net/tcp_ao/connect-deny.c

Re: [RFC PATCH v2 1/8] mseal: Add mseal(2) syscall.

2023-10-17 Thread Randy Dunlap
nit: On 10/17/23 02:08, jef...@chromium.org wrote: | diff --git a/mm/Kconfig b/mm/Kconfig | index 264a2df5ecf5..db8a567cb4d3 100644 | --- a/mm/Kconfig | +++ b/mm/Kconfig | @@ -1258,6 +1258,14 @@ config LOCK_MM_AND_FIND_VMA | bool | depends on !STACK_GROWSUP | | +config MSEAL | +