Re: [PATCH net-next] selftests: net: give up on the cmsg_time accuracy on slow machines

2025-01-16 Thread Przemek Kitszel
hat) [fine for me] Return XFAIL for the most timing sensitive test on slow machines. code change looks fine for me, and does exactly that, so: Reviewed-by: Przemek Kitszel Before: # ./cmsg_time.sh Case UDPv4 - TXTIME rel returned '8074us - 7397us < 4000', expected &#

Re: [RFC PATCH net-next 1/5] selftests: forwarding: Introduce deferred commands

2024-08-26 Thread Przemek Kitszel
On 8/26/24 17:20, Petr Machata wrote: Przemek Kitszel writes: On 8/22/24 15:49, Petr Machata wrote: In commit 8510801a9dbd ("selftests: drv-net: add ability to schedule cleanup with defer()"), a defer helper was added to Python selftests. The idea is to keep cleanup commands clos

Re: [RFC PATCH net-next 1/5] selftests: forwarding: Introduce deferred commands

2024-08-26 Thread Przemek Kitszel
On 8/22/24 15:49, Petr Machata wrote: In commit 8510801a9dbd ("selftests: drv-net: add ability to schedule cleanup with defer()"), a defer helper was added to Python selftests. The idea is to keep cleanup commands close to their dirtying counterparts, thereby making it more transparent what is cl

Re: [PATCH net] selftests: openvswitch: Use bash as interpreter

2024-06-17 Thread Przemek Kitszel
_ct_connect_v4' Adding DP/Bridge IF: sbx:test_ct_connect_v4 dp:ct4 {, , } ./openvswitch.sh: 322: eval: Bad substitution create namespaces Resolve this by making openvswitch.sh a bash script. Fixes: 918423fda910 ("selftests: openvswitch: add an initial flow programming case")

Re: [PATCH net-next] selftests: avoid using SKIP(exit()) in harness fixure setup

2024-03-05 Thread Przemek Kitszel
erent_type(variant->device_number0)) - SKIP(exit(0), "DEVICE_COHERENT not available"); + SKIP(return, "DEVICE_COHERENT not available"); ASSERT_GE(self->fd0, 0); self->fd1 = hmm_open(variant->device_number1); ASSERT_G

Re: [PATCH v4 00/12] selftests: kselftest_harness: support using xfail

2024-03-05 Thread Przemek Kitszel
On 3/5/24 00:04, Jakub Kicinski wrote: On Mon, 4 Mar 2024 22:20:03 + Mark Brown wrote: On Wed, Feb 28, 2024 at 04:59:07PM -0800, Jakub Kicinski wrote: When running selftests for our subsystem in our CI we'd like all tests to pass. Currently some tests use SKIP for cases they expect to fail

Re: [PATCH net 0/2] selftests: net: Small fixes

2024-01-11 Thread Przemek Kitszel
| 2 +- tools/testing/selftests/net/forwarding/lib.sh | 0 3 files changed, 2 insertions(+), 2 deletions(-) mode change 100755 => 100644 tools/testing/selftests/net/forwarding/lib.sh Reviewed-by: Przemek Kitszel

Re: [PATCH v2 net-next] selftests/net: change shebang to bash to support "source"

2023-12-29 Thread Przemek Kitszel
of shellcheck in the future, it will catch this particular bug, with following warning: SC3046: In POSIX sh, 'source' in place of '.' is undefined. Being specific, and requiring bash looks fine for me. Reviewed-by: Przemek Kitszel