Re: [PATCHv2 net-next 01/14] selftests/net: add lib.sh

2023-11-30 Thread Po-Hsu Lin
On Thu, Nov 30, 2023 at 12:01 PM Hangbin Liu wrote: > > Add a lib.sh for net selftests. This file can be used to define commonly > used variables and functions. Some commonly used functions can be moved > from forwarding/lib.sh to this lib file. e.g. busywait(). > > Add function setup_ns() for use

Re: [PATCHv2 net] selftests: pmtu.sh: fix result checking

2023-10-30 Thread Po-Hsu Lin
[ $exitcode=$ksft_skip ] && exitcode=0 > + [ $exitcode -eq $ksft_skip ] && exitcode=0 > ;; > $ksft_skip) > [ $all_skipped = true ] && exitcode=$ksft_skip > -- > 2.41.0 > Acked-by: Po-Hsu Lin Looking good to me, thanks!

Re: [PATCH net] selftests: pmtu.sh: fix result checking

2023-10-30 Thread Po-Hsu Lin
On Mon, Oct 30, 2023 at 5:46 PM Hangbin Liu wrote: > > In the PMTU test, when all previous tests are skipped and the new test > passes, the exit code is set to 0. However, the current check mistakenly > treats this as an assignment, causing the check to pass every time. > > Consequently, regardles