Re: [PATCH HID 4/7] HID: bpf: allow BPF programs to force using hid-generic

2024-09-02 Thread Peter Hutterer
On Tue, Sep 03, 2024 at 01:14:34AM +0900, Benjamin Tissoires wrote: > The use case is when we fix a device through HID-BPF, 99% of the cases > we want the device to use hid-generic now instead of a dedicated device. s/dedicated device/dedicated driver/ in the commit message > That's because the d

Re: [PATCH v4 3/3] selftests/hid: Add HIDIOCREVOKE tests

2024-08-26 Thread Peter Hutterer
elf->hidraw_fd, buf, sizeof(buf)); > + ASSERT_EQ(err, -1) TH_LOG("read_hidraw"); do you want to check for errno == ENODEV here to avoid false positives? Shouldn't really happen in this test suite but it costs very little. Same for the various cases below. With or without - series: Reviewed-by: Peter Hutterer Cheers, Peter

Re: [PATCH 19/18] selftests/hid: skip tests with HID-BPF if udev-hid-bpf is not installed

2024-05-06 Thread Peter Hutterer
wanted to apply this series given that it wasn't reviewed in a month, apologies. Reviewed-by: Peter Hutterer (I have a few improvement suggestions for the hidtools code but it's better to do those there and then sync back). Cheers, Peter > but I thought that maybe I should n

Re: [PATCH 12/12] selftests/hid: tablets: be stricter for some transitions

2023-11-30 Thread Peter Hutterer
_OF_RANGE: > p.x += 1 > p.y -= 1 > events = self.post(uhdev, p) > -self.validate_transitions(cur_state, p, evdev, events) > +self.validate_transitions(cur_state, p, evdev, events, > allow_intermediate_st

Re: [PATCH 09/12] selftests/hid: tablets: add variants of states with buttons

2023-11-30 Thread Peter Hutterer
On Wed, Nov 29, 2023 at 04:24:34PM +0100, Benjamin Tissoires wrote: > Turns out that there are transitions that are unlikely to happen: > for example, having both the tip switch and a button being changed > at the same time (in the same report) would require either a very talented > and precise use

Re: [PATCH 02/12] selftests/hid: vmtest.sh: allow finer control on the build steps

2023-11-30 Thread Peter Hutterer
On Wed, Nov 29, 2023 at 04:24:27PM +0100, Benjamin Tissoires wrote: > vmtest.sh works great for a one shot test, but not so much for CI where > I want to build (with different configs) the bzImage in a separate > job than the one I am running it. > > Add a "build_only" option to specify whether we