-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 ++
tools/testing/selftests/net/mptcp/mptcp_join.sh| 3 ++-
tools/testing/selftests/net/mptcp/mptcp_sockopt.sh | 1 +
tools/testing/selftests/net/mptcp/pm_netlink.sh| 2 ++
tools/testing/selftests/net
It is now added by the MPTCP lib automatically, see the parent commit.
The time in the TAP output might be sligly different from the one
displayed before, but that's OK.
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_connect.s
l.org/dev-tools/ktap.html [3]
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
b/tools/testing/self
proves the precision of the first subtests in all
MPTCP subtests.
Link: https://github.com/linux-netdev/nipa/pull/36
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (3):
selftests: mptcp: lib: add time per subtests in TAP output
sefltests: mptcp: connect: remote time in
, and drop the other one.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
b/tools/testing/selftests/n
From: Geliang Tang
The four checksum tests are similar, only one line is different. So
a for-loop can be used to simplify these tests.
Signed-off-by: Geliang Tang
Reviewed-by: Matthieu Baerts (NGI0)
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh
wed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 36 -
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/selftests/net/mptcp/mptc
sending
it, which is more unusual.
Also before, the 'invert' message was printed after a few checks, but it
was not clear which ones exactly.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 89 +
Before, the check names had to be very short. It is no longer the case
now that these checks are printed on a dedicated line.
Then, it looks better to have more explicit names.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh
there are dropped, or there
are errors.
While at it, the "no MPC reuse with single endpoint" subtest has been
modified to force a bind() error.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 89 ++
reported like before.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 45 -
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing
\
join_corrupted_pkts=4 \
chk_join_nr 1 1 1
It will then be easier to add new optional parameters.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 31 ++---
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a
Baerts (NGI0)
---
net/mptcp/mib.c | 4
net/mptcp/mib.h | 4
net/mptcp/subflow.c | 21 ++---
3 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c
index 7884217f33eb..ec0d461cb921 100644
--- a/net/mptcp/mib.c
+++ b/net/mptcp
, to avoid
having to set it in the 'rebuild_header' hook, which will cause a new
iteration of the endpoint entries.
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 11
net/mptcp/pm_netlink.c | 66 ++---
.
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index f891bc714668..275959581586 100644
--- a/net/mptcp/pm_netlink.c
me checks
not suggesting one specific direction
- Patch 9: mute errors of mptcp_connect when ran in the background
- Patch 10: simplify checksum_tests by using a for-loop
- Patch 11: remove 'define' re-definitions
Signed-off-by: Matthieu Baerts (NGI0)
---
Geliang Tang (1):
e introduced by this commit
ID.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
v2:
- Make the connection longer, to have time to finish all the endpoints
manipulations wh
plicated subflows created by the client.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 4 +++-
net/mptcp/pm_netlink.c | 9 +
net/mptcp/proto
add netlink event support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 74 -
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++
2 files changed, 75 insertions(+), 3
7dc7 ("mptcp: add netlink event support")
Cc: sta...@vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/protocol.c | 6 ++
net/mptcp/protocol.h | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --g
ssue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
v2:
- Make the connection longer, to have time to finish all the endpoints
manipula
vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 3ff273e219f2..a93450ded50a 100644
--
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 5a84a55e37cc..3ff273e219f2 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/sel
54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git
int, the same
variable is updated if the address match the one of the initial subflow.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 13 +++
to be, but not the ones being closed.
Fixes: d84ad04941c3 ("mptcp: skip connecting the connected address")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletion
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 42d4e7b5f65d..ed2205ef7208 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -765,9
is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (
")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index ec45ab4c66ab..42d4
cking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 8d2f97854c64..ec45ab4c66ab 100644
--- a
low -- has been reached. A fix for v5.10.
Patch 15 validates the previous patch.
Signed-off-by: Matthieu Baerts (NGI0)
---
Changes in v2:
- Patches 11,15/15: allow the connection to run for longer, should fix
the issue seen on the Netdev CI, with a debug kconfig.
- Link to v1:
https://lore.ke
ug(\".*[^n]\)\(\"[,)]\)/\1\\\n\2/g"
So in case of conflicts, simply drop the modifications, and launch this
command.
Fixes: f870fa0b5768 ("mptcp: Add MPTCP socket stubs")
Cc: sta...@vger.kernel.org
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
ne
ing: the 'backup' flag was
set by accident instead of the 'request_bkup' one. Now that the latter
has been fixed, get_retrans() needs to be adapted as well.
Fixes: b6a66e521a20 ("mptcp: sched: check both directions for backup")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat
pm out of transfer")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b
ing a FIN+ACK in return.
Fixes: 40947e13997a ("mptcp: schedule worker when subflow is closed")
Cc: sta...@vger.kernel.org
Link: https://github.com/multipath-tcp/packetdrill/pull/154 [1]
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/protocol.c | 5 +
can follow the 'Fixes' commit and be backported up to
v5.7.
Patch 4 adds a missing \n at the end of pr_debug(), causing debug
messages to be displayed with a delay, which confuses the debugger. A
fix for v5.6.
Signed-off-by: Matthieu Baerts (NGI0)
---
Note: Peter's email address h
e introduced by this commit
ID.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 30 -
1 file changed,
plicated subflows created by the client.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 4 +++-
net/mptcp/pm_netlink.c | 9 +
net/mptcp/proto
add netlink event support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 74 -
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++
2 files changed, 75 insertions(+), 3
7dc7 ("mptcp: add netlink event support")
Cc: sta...@vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/protocol.c | 6 ++
net/mptcp/protocol.h | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --g
ssue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 23 +--
1 file
vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 90b7c8b45027..591ae2ffb4dd 100644
--
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 75c8aede7026..90b7c8b45027 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/sel
54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git
int, the same
variable is updated if the address match the one of the initial subflow.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 13 +++
to be, but not the ones being closed.
Fixes: d84ad04941c3 ("mptcp: skip connecting the connected address")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletion
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 042cd65d974a..380647f7bc33 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -765,9
is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (
")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 9ee68ab4665e..042c
cking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 3e4ad801786f..9ee68ab4665e 100644
--- a
low -- has been reached. A fix for v5.10.
Patch 15 validates the previous patch.
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (15):
mptcp: pm: reuse ID 0 after delete and re-add
mptcp: pm: fix RM_ADDR ID for the initial subflow
selftests: mptcp: join: check r
...@redhat.com
Fixes: 01cacb00b35c ("mptcp: add netlink-based PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 64 +++---
1 file changed, 34 insertions(+), 30 deletion
example, but
that's always a bit cryptic. Packetdrill seems better fitted for that.
Fixes: 4f49d63352da ("selftests: mptcp: add fullmesh testcases")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_j
.
Note that msk->mpc_endpoint_id might not be set when receiving the first
ADD_ADDR from the server. So better to compare the addresses.
Fixes: 1a0d6136c5f0 ("mptcp: local addresses fullmesh")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
-
")
Cc: sta...@vger.kernel.org
Acked-by: Geliang Tang
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 3 ---
net/mptcp/pm_netlink.c | 4
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/pm.c b/net/mptcp/pm.c
ind
The limits might have changed in between, it is best to check them
before accepting new ADD_ADDR.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c |
lve that is to decrement the counter only if the attached
subflow was an MP_JOIN to a remote id that was not 0, and initiated by
the host receiving the RM_ADDR.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-of
g available, and the decrement is
done no matter if a subflow using this ID is currently available,
because the subflow could have been closed before.
Fixes: 06faa2271034 ("mptcp: remove multi addresses and subflows in PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-o
Note that it is not a bug fix, but it will help backporting the
following commits.
Fixes: 0ee4261a3681 ("mptcp: implement mptcp_pm_remove_subflow")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 10 --
ne
lows in PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 30 +
1 file changed, 30 insertions(+)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/selftest
se cases.
Note that mptcp_pm_remove_addrs_and_subflows() helper is only called for
flushing operations, not to remove a specific set of addresses and
subflows.
Fixes: 06faa2271034 ("mptcp: remove multi addresses and subflows in PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed
this patch here is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: b6c08380860b ("mptcp: remove addr and subflow in PM netlink")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Ma
ecremented if the ID was
marked as being used to reflect the reality, but also to allow adding
new endpoints after that.
Fixes: b6c08380860b ("mptcp: remove addr and subflow in PM netlink")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
--
org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/selftests/net/mptcp/mp
PM netlink")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 4cae2aa7be5c..26f0329e16bb 10
the fullmesh mode sets the ID 0 when a new subflow
using the source address of the initial subflow is created. Patch 13
covers this case. This issue is present since v5.15.
- Patch 14 avoid possible UaF when selecting an address from the
endpoints list.
Signed-off-by: Matthieu Baerts (NG
/uapi/linux/if_xdp.h' differs
from latest version at 'include/uapi/linux/if_xdp.h'
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/include/uapi/linux/if_xdp.h | 173 --
tools/lib/bpf/Makefile| 3 -
2 files changed, 176 deletions(-)
l required to use 'tools/include/uapi' -- APIDIR,
which corresponds to TOOLS_INCLUDES from lib.mk -- for the BPF programs,
not to conflict with what is already defined in vmlinux.h.
Link:
https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
[1]
See patch 1/2 for more details
about that.
Link:
https://lore.kernel.org/all/08f925cd-e267-4a6b-84b1-792515c4e...@kernel.org/T/#u
[1]
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (2):
selftests: bpf: use KHDR_INCLUDES for the UAPI headers
selftests: bpf: remove
after the end of some tests, and
help with the debugging of some issues. That's why this modification is
seen as a "fix".
Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Acked-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/lib.sh
using setsockopts.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/76
Signed-off-by: Geliang Tang
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
Notes:
- v2 -> v3:
- Use './mptcp_pm_nl_ctl' instead of 'ip mptcp', not supported by
MPTCP repo https://github.com/multipath-tcp/mptcp_net-next (the
"scripts" branch), and it has been adapted by Geliang.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/76
Co-developed-by: Geliang Tang
Signed-off-by: Geliang Tang
Signed-off-by: Nicolas Rybowski
Reviewed
Tessares, but he did this work
while working for them, and his email address is no longer available.
- A new MPTCP BPF subtest validating the new BPF program added in the
first patch.
Signed-off-by: Matthieu Baerts (NGI0)
---
Changes in v4:
- Drop former patch 2/3: MPTCP's pm_nl_ctl req
h here is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: 86e39e04482b ("mptcp: keep track of local endpoint still available for
each msk")
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
--
in-kernel path-manager. With this
PM, mptcp_pm_alloc_anno_list() should only fail in case of memory
pressure.
Fixes: b6c08380860b ("mptcp: remove addr and subflow in PM netlink")
Cc: sta...@vger.kernel.org
Suggested-by: Paolo Abeni
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Ba
lable for
each msk")
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 40 -
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/too
OK to assume that the
limits should be properly configured before establishing new
connections.
Fixes: 86e39e04482b ("mptcp: keep track of local endpoint still available for
each msk")
Cc: sta...@vger.kernel.org
Suggested-by: Paolo Abeni
Reviewed-by: Mat Martineau
Signed-off-by: Matthi
not possible.
Fixes: 09f12c3ab7a5 ("mptcp: allow to use port and non-signal in set_flags")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net
That will simplify the following commits.
No functional changes intended.
Suggested-by: Paolo Abeni
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/net/mptcp
good --
but it still need to be verified by running the selftests -- if not, no
need to worry, many CIs will use the selftests from the last stable
version to validate previous stable releases.
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (7):
mptcp: fully established after ADD_
ineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/options.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index 8a68382a4fe9..ac2f1a54cc43 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -958,7 +
e previous
commit: this patch here is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: 4596a2c1b7f5 ("mptcp: allow creating non-backup subflows")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/507
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 12
net/mptcp/pm_netlink.c | 18 ++
net/mptcp/pm_userspace.c | 18 ++
net/mptcp/prot
in the selftests,
but it will help to validate a new fix for an issue introduced by this
commit ID.
Fixes: 4596a2c1b7f5 ("mptcp: allow creating non-backup subflows")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testin
allow creating non-backup subflows")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/mib.c | 2 ++
net/mptcp/mib.h | 2 ++
net/mptcp/subflow.c | 6 ++
3 files changed, 10 insertions(+)
diff --git a/net/mptcp/mib.c b/net/m
ned-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index ea9e5817b9e9..59527335c68e 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -471,7 +471,6 @@ static void __mptc
org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/options.c | 2 +-
net/mptcp/protocol.h | 1 +
net/mptcp/subflow.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index 8e8dcfbc2993..8a68382a4fe9 10
ote that the use of these two flags in the path-manager are going to be
fixed in the next commits, but this change here is needed not to modify
the behaviour.
Fixes: f296234c98a8 ("mptcp: Add handling of incoming MP_JOIN requests")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
lftest as well.
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (7):
mptcp: sched: check both directions for backup
mptcp: distinguish rcv vs sent backup flag in requests
mptcp: pm: only set request_bkup flag when sending MP_PRIO
mptcp: mib: count MPJ wi
: Liu Jing
Reviewed-by: Matthieu Baerts (NGI0)
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_connect.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c
b/tools/testing/selftests/net/mptc
From: Paolo Abeni
pm_nl_check_endpoint() currently calls an not existing helper
to mark the test as failed. Fix the wrong call.
Fixes: 03668c65d153 ("selftests: mptcp: join: rework detailed report")
Cc: sta...@vger.kernel.org
Signed-off-by: Paolo Abeni
Reviewed-by: Matthieu Ba
From: Paolo Abeni
Delete and re-create a signal endpoint and ensure that the PM
actually deletes and re-create the subflow.
Signed-off-by: Paolo Abeni
Reviewed-by: Matthieu Baerts (NGI0)
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 29
that.
Address the issue properly updating the signaled address counter
every time the NL PM removes such addresses.
Fixes: 01cacb00b35c ("mptcp: add netlink-based PM")
Cc: sta...@vger.kernel.org
Signed-off-by: Paolo Abeni
Reviewed-by: Matthieu Baerts (NGI0)
Signed-off-by: Matthieu Ba
sake.
Fixes: 8b1c94da1e48 ("mptcp: only send RM_ADDR in nl_cmd_remove")
Cc: sta...@vger.kernel.org
Signed-off-by: Paolo Abeni
Reviewed-by: Matthieu Baerts (NGI0)
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 17 +
1 file changed, 13 insertions(
roduced in v6.6., and the other one in v5.17.
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/501 [1]
Signed-off-by: Matthieu Baerts (NGI0)
---
Liu Jing (1):
selftests: mptcp: always close input's FD if opened
Paolo Abeni (4):
mptcp: fix user-space PM announce
any spaces in their names. Still, better
to fix them to easily spot new issues.
Fixes: f265d3119a29 ("selftests: mptcp: lib: use setup/cleanup_ns helpers")
Signed-off-by: Matthieu Baerts (NGI0)
---
Notes:
- The mentioned commit is currently only in 'net-next', not in '
using setsockopts.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/76
Signed-off-by: Geliang Tang
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
Notes:
- v2 -> v3:
- Use './mptcp_pm_nl_ctl' instead of 'ip mptcp', not supported by
ERS needs to be updated since a new file is added in a non
covered place.
Signed-off-by: Geliang Tang
Reviewed-by: Matthieu Baerts (NGI0)
Signed-off-by: Matthieu Baerts (NGI0)
---
MAINTAINERS | 1 +
tools/testing/selftests/bpf/Makefile | 3 ++-
tools/te
1 - 100 of 259 matches
Mail list logo
