Hi Hangbin,
On 26/01/2025 03:03, Hangbin Liu wrote:
> On Thu, Jan 23, 2025 at 01:51:27PM +0100, Matthieu Baerts wrote:
>>> openvswitch/Makefile CFLAGS currently do not appear to be used, but
>>> fix it anyway for the case when new tests are introduced in future.
>&g
o-as-needed -O2 -g
> +CFLAGS += -Wall -Wl,--no-as-needed -O2 -g
(small detail: I guess the double whitespaces after the '=' were there
to keep the alignment with the next line, so probably there should be
only one now, but I don't think this alone is enough to ask for a v2!)
elftests/net/mptcp/Makefile
>>> @@ -2,7 +2,7 @@
>>>
>>> top_srcdir = ../../../../..
>>>
>>> -CFLAGS = -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include
>>> $(KHDR_INCLUDES)
>>> +CFLAGS += -Wall -Wl,--no-as-n
Hi Willem, Jakub,
On 16/01/2025 14:05, Willem de Bruijn wrote:
> Jakub Kicinski wrote:
>> The following tests are failing on debug kernels:
>>
>> tcp_tcp_info_tcp-info-rwnd-limited.pkt
>> tcp_tcp_info_tcp-info-sndbuf-limited.pkt
(...)
> We'll take a look after this change whether we can make
Hi Willem,
On 20/09/2024 00:03, Matthieu Baerts wrote:
> On 19/09/2024 14:43, Willem de Bruijn wrote:
>> From: Willem de Bruijn
(...)
>> We have been doing this for debug builds outside ksft too.
>>
>> Previous setting was 1. A manual 50 runs in virtme-ng showed
r=vmksft-packetdrill-dbg
(Your patch has been introduced in the net-next-2024-09-19--15-00 branch.)
Personally, I would not be chocked if the tolerance was even 10x higher
to cope with this very slow environment where we care less about timing
I think. But if less works, that's good:
Acked-by: M
Hi Willem,
On 12/09/2024 02:52, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> 1/3: run in nets, as discussed, and add missing CONFIGs
> 2/3: import tcp/zerocopy
> 3/3: import tcp/slow_start
Thank you for the v2. This new version looks good to me:
Acked-by: Matthieu Bae
Hi Willem,
On 09/09/2024 15:15, Willem de Bruijn wrote:
> Matthieu Baerts wrote:
>> Hi Jakub,
>>
>> On 07/09/2024 02:04, Jakub Kicinski wrote:
>>> On Fri, 06 Sep 2024 19:28:08 -0400 Willem de Bruijn wrote:
>>>>>> No, we opted for this design exactl
Hi Jakub,
On 07/09/2024 02:04, Jakub Kicinski wrote:
> On Fri, 06 Sep 2024 19:28:08 -0400 Willem de Bruijn wrote:
No, we opted for this design exactly to use existing kselftest infra,
rather than reimplementing that in our wrapper, as I did in the RFC.
>>>
>>> OK, I understood from the
On 06/09/2024 17:36, Willem de Bruijn wrote:
> Matthieu Baerts wrote:
>> Hi Willem,
>>
>> On 06/09/2024 01:15, Willem de Bruijn wrote:
>>> From: Willem de Bruijn
>>>
>>> Lay the groundwork to import into kselftests the over 150 packetdrill
&
Hi Willem,
On 06/09/2024 01:15, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Lay the groundwork to import into kselftests the over 150 packetdrill
> TCP/IP conformance tests on github.com/google/packetdrill.
>
> Florian recently added support for packetdrill tests in nf_conntrack,
> in
-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 ++
tools/testing/selftests/net/mptcp/mptcp_join.sh| 3 ++-
tools/testing/selftests/net/mptcp/mptcp_sockopt.sh | 1 +
tools/testing/selftests/net/mptcp/pm_netlink.sh| 2 ++
tools/testing/selftests/net
It is now added by the MPTCP lib automatically, see the parent commit.
The time in the TAP output might be sligly different from the one
displayed before, but that's OK.
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_connect.s
l.org/dev-tools/ktap.html [3]
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
b/tools/testing/self
proves the precision of the first subtests in all
MPTCP subtests.
Link: https://github.com/linux-netdev/nipa/pull/36
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (3):
selftests: mptcp: lib: add time per subtests in TAP output
sefltests: mptcp: connect: remote time in
, and drop the other one.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
b/tools/testing/selftests/n
From: Geliang Tang
The four checksum tests are similar, only one line is different. So
a for-loop can be used to simplify these tests.
Signed-off-by: Geliang Tang
Reviewed-by: Matthieu Baerts (NGI0)
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh
wed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 36 -
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/selftests/net/mptcp/mptc
sending
it, which is more unusual.
Also before, the 'invert' message was printed after a few checks, but it
was not clear which ones exactly.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 89 +
Before, the check names had to be very short. It is no longer the case
now that these checks are printed on a dedicated line.
Then, it looks better to have more explicit names.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh
there are dropped, or there
are errors.
While at it, the "no MPC reuse with single endpoint" subtest has been
modified to force a bind() error.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 89 ++
reported like before.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 45 -
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing
\
join_corrupted_pkts=4 \
chk_join_nr 1 1 1
It will then be easier to add new optional parameters.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 31 ++---
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a
such information from the kernel, and understand
why subflows have not been created.
While at it, some pr_debug() have been added, just in case the errno
needs to be printed.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/509
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu
, to avoid
having to set it in the 'rebuild_header' hook, which will cause a new
iteration of the endpoint entries.
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 11
net/mptcp/pm_netlink.c | 66 ++---
.
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index f891bc714668..275959581586 100644
--- a/net/mptcp/pm_netlink.c
me checks
not suggesting one specific direction
- Patch 9: mute errors of mptcp_connect when ran in the background
- Patch 10: simplify checksum_tests by using a for-loop
- Patch 11: remove 'define' re-definitions
Signed-off-by: Matthieu Baerts (NGI0)
---
Geliang Tang (1):
Hi Willem, Paolo,
Thank you for this series, that would be great to have the CI validating
these packetdrill tests!
(Having the Netdev CI validating these packetdrill tests was part of my
suggestions for the discussion we will have at NetConf :) )
On 28/08/2024 16:03, Willem de Bruijn wrote:
> P
e introduced by this commit
ID.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
v2:
- Make the connection longer, to have time to finish all the endpoints
manipulations wh
plicated subflows created by the client.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 4 +++-
net/mptcp/pm_netlink.c | 9 +
net/mptcp/proto
add netlink event support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 74 -
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++
2 files changed, 75 insertions(+), 3
7dc7 ("mptcp: add netlink event support")
Cc: sta...@vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/protocol.c | 6 ++
net/mptcp/protocol.h | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --g
ssue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
v2:
- Make the connection longer, to have time to finish all the endpoints
manipula
vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 3ff273e219f2..a93450ded50a 100644
--
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 5a84a55e37cc..3ff273e219f2 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/sel
54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git
int, the same
variable is updated if the address match the one of the initial subflow.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 13 +++
to be, but not the ones being closed.
Fixes: d84ad04941c3 ("mptcp: skip connecting the connected address")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletion
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 42d4e7b5f65d..ed2205ef7208 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -765,9
is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (
")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index ec45ab4c66ab..42d4
cking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 8d2f97854c64..ec45ab4c66ab 100644
--- a
low -- has been reached. A fix for v5.10.
Patch 15 validates the previous patch.
Signed-off-by: Matthieu Baerts (NGI0)
---
Changes in v2:
- Patches 11,15/15: allow the connection to run for longer, should fix
the issue seen on the Netdev CI, with a debug kconfig.
- Link to v1:
https://lore.ke
On 27/08/2024 05:33, Jakub Kicinski wrote:
> On Mon, 26 Aug 2024 19:11:17 +0200 Matthieu Baerts (NGI0) wrote:
>> Matthieu Baerts (NGI0) (4):
>> mptcp: close subflow when receiving TCP+FIN
>> selftests: mptcp: join: cannot rm sf if closed
>> mptcp:
Hi Jakub,
On 27/08/2024 04:29, Jakub Kicinski wrote:
> On Mon, 26 Aug 2024 17:58:59 +0200 Matthieu Baerts (NGI0) wrote:
>> Matthieu Baerts (NGI0) (15):
>> mptcp: pm: reuse ID 0 after delete and re-add
>> mptcp: pm: fix RM_ADDR ID for the initial subflow
>>
ug(\".*[^n]\)\(\"[,)]\)/\1\\\n\2/g"
So in case of conflicts, simply drop the modifications, and launch this
command.
Fixes: f870fa0b5768 ("mptcp: Add MPTCP socket stubs")
Cc: sta...@vger.kernel.org
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
ne
ing: the 'backup' flag was
set by accident instead of the 'request_bkup' one. Now that the latter
has been fixed, get_retrans() needs to be adapted as well.
Fixes: b6a66e521a20 ("mptcp: sched: check both directions for backup")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat
pm out of transfer")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b
ing a FIN+ACK in return.
Fixes: 40947e13997a ("mptcp: schedule worker when subflow is closed")
Cc: sta...@vger.kernel.org
Link: https://github.com/multipath-tcp/packetdrill/pull/154 [1]
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/protocol.c | 5 +
can follow the 'Fixes' commit and be backported up to
v5.7.
Patch 4 adds a missing \n at the end of pr_debug(), causing debug
messages to be displayed with a delay, which confuses the debugger. A
fix for v5.6.
Signed-off-by: Matthieu Baerts (NGI0)
---
Note: Peter's email address h
e introduced by this commit
ID.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 30 -
1 file changed,
plicated subflows created by the client.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 4 +++-
net/mptcp/pm_netlink.c | 9 +
net/mptcp/proto
add netlink event support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 74 -
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++
2 files changed, 75 insertions(+), 3
7dc7 ("mptcp: add netlink event support")
Cc: sta...@vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/protocol.c | 6 ++
net/mptcp/protocol.h | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --g
ssue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 23 +--
1 file
vger.kernel.org
Tested-by: Arınç ÜNAL
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 90b7c8b45027..591ae2ffb4dd 100644
--
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 75c8aede7026..90b7c8b45027 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm
;)
Cc: sta...@vger.kernel.org
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/sel
54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git
int, the same
variable is updated if the address match the one of the initial subflow.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 13 +++
to be, but not the ones being closed.
Fixes: d84ad04941c3 ("mptcp: skip connecting the connected address")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletion
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 042cd65d974a..380647f7bc33 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -765,9
is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: 3ad14f54bd74 ("mptcp: more accurate MPC endpoint tracking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (
")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 9ee68ab4665e..042c
cking")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 3e4ad801786f..9ee68ab4665e 100644
--- a
low -- has been reached. A fix for v5.10.
Patch 15 validates the previous patch.
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (15):
mptcp: pm: reuse ID 0 after delete and re-add
mptcp: pm: fix RM_ADDR ID for the initial subflow
selftests: mptcp: join: check r
Hi Alexei,
Thank you for your reply!
On 24/08/2024 00:28, Alexei Starovoitov wrote:
> On Sat, Aug 17, 2024 at 7:51 AM Matthieu Baerts wrote:
>>
>> Hi Alexei,
>>
>> Thank you for the review.
>>
>> On 17/08/2024 09:22, Alexei Starovoitov wrote:
>>>
Hi Manu,
On 21/08/2024 22:32, Manu Bretelle wrote:
>
>
>> On Aug 13, 2024, at 6:12 PM, Martin KaFai Lau wrote:
>>
>>>
>> On 8/5/24 2:52 AM, Matthieu Baerts (NGI0) wrote:
>>> +static int endpoint_init(char *flags)
>>> +{
>>> + SY
evert the printk configuration at the end of the test (Jakub)
> * Fix the modprobe stderr redirection (Jakub)
Thank you for the v6! It looks good to me:
Acked-by: Matthieu Baerts (NGI0)
(...)
> diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh
> b/tools/testing/self
...@redhat.com
Fixes: 01cacb00b35c ("mptcp: add netlink-based PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 64 +++---
1 file changed, 34 insertions(+), 30 deletion
example, but
that's always a bit cryptic. Packetdrill seems better fitted for that.
Fixes: 4f49d63352da ("selftests: mptcp: add fullmesh testcases")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_j
.
Note that msk->mpc_endpoint_id might not be set when receiving the first
ADD_ADDR from the server. So better to compare the addresses.
Fixes: 1a0d6136c5f0 ("mptcp: local addresses fullmesh")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
-
")
Cc: sta...@vger.kernel.org
Acked-by: Geliang Tang
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 3 ---
net/mptcp/pm_netlink.c | 4
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/pm.c b/net/mptcp/pm.c
ind
The limits might have changed in between, it is best to check them
before accepting new ADD_ADDR.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c |
lve that is to decrement the counter only if the attached
subflow was an MP_JOIN to a remote id that was not 0, and initiated by
the host receiving the RM_ADDR.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-of
g available, and the decrement is
done no matter if a subflow using this ID is currently available,
because the subflow could have been closed before.
Fixes: 06faa2271034 ("mptcp: remove multi addresses and subflows in PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-o
Note that it is not a bug fix, but it will help backporting the
following commits.
Fixes: 0ee4261a3681 ("mptcp: implement mptcp_pm_remove_subflow")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm.c | 10 --
ne
lows in PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 30 +
1 file changed, 30 insertions(+)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/selftest
se cases.
Note that mptcp_pm_remove_addrs_and_subflows() helper is only called for
flushing operations, not to remove a specific set of addresses and
subflows.
Fixes: 06faa2271034 ("mptcp: remove multi addresses and subflows in PM")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed
this patch here is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: b6c08380860b ("mptcp: remove addr and subflow in PM netlink")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Ma
ecremented if the ID was
marked as being used to reflect the reality, but also to allow adding
new endpoints after that.
Fixes: b6c08380860b ("mptcp: remove addr and subflow in PM netlink")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
--
org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
b/tools/testing/selftests/net/mptcp/mp
PM netlink")
Cc: sta...@vger.kernel.org
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/pm_netlink.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 4cae2aa7be5c..26f0329e16bb 10
the fullmesh mode sets the ID 0 when a new subflow
using the source address of the initial subflow is created. Patch 13
covers this case. This issue is present since v5.15.
- Patch 14 avoid possible UaF when selecting an address from the
endpoints list.
Signed-off-by: Matthieu Baerts (NG
Hi Alexei,
Thank you for the review.
On 17/08/2024 09:22, Alexei Starovoitov wrote:
> On Fri, Aug 16, 2024 at 7:56 PM Matthieu Baerts (NGI0)
> wrote:
>>
>> Instead of duplicating UAPI header files in 'tools/include/uapi', the
>> BPF selftests can also look at
/uapi/linux/if_xdp.h' differs
from latest version at 'include/uapi/linux/if_xdp.h'
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/include/uapi/linux/if_xdp.h | 173 --
tools/lib/bpf/Makefile| 3 -
2 files changed, 176 deletions(-)
l required to use 'tools/include/uapi' -- APIDIR,
which corresponds to TOOLS_INCLUDES from lib.mk -- for the BPF programs,
not to conflict with what is already defined in vmlinux.h.
Link:
https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
[1]
See patch 1/2 for more details
about that.
Link:
https://lore.kernel.org/all/08f925cd-e267-4a6b-84b1-792515c4e...@kernel.org/T/#u
[1]
Signed-off-by: Matthieu Baerts (NGI0)
---
Matthieu Baerts (NGI0) (2):
selftests: bpf: use KHDR_INCLUDES for the UAPI headers
selftests: bpf: remove
On 16/08/2024 16:50, Breno Leitao wrote:
> On Fri, Aug 16, 2024 at 04:02:51PM +0200, Matthieu Baerts wrote:
>> Hi Breno,
>>
>> On 16/08/2024 15:24, Breno Leitao wrote:
>>> Adds a selftest that creates two virtual interfaces, assigns one to a
>>> new name
pointing to the destination IP address.
>
> The test then checks if the message was received properly on the
> destination interface.
>
> Signed-off-by: Breno Leitao
> ---
> Changelog:
>
> v4:
> * Avoid sleeping in waiting for sockets and files (Matthieu Baerts)
Hi Martin,
Thank you for your reply!
On 15/08/2024 00:37, Martin KaFai Lau wrote:
> On 8/14/24 3:04 AM, Matthieu Baerts wrote:
>> Hi Martin,
>>
>> Thank you for your reply!
>>
>> On 14/08/2024 03:12, Martin KaFai Lau wrote:
>>> On 8/5/24 2:52 AM, Matt
(Petr Machata)
> * Use setup_ns in a better way (Matthieu Baerts)
> * Add dependencies in TEST_INCLUDES (Hangbin Liu)
Thank you for the v3!
I only looked here at how 'setup_ns' was used, (and a few other
Bash-related stuff), but not at the test itself.
I have a few comments, but I do
quot; &> /dev/null; then
> eval "${ns_name}=${ns_name,,}-$(mktemp -u XX)"
> else
> cleanup_ns "${!ns_name}"
>
> CC'd Geliang Tang , Hangbin Liu ,
> Matthieu Baerts (NGI0) who were in the
Hi Martin,
Thank you for your reply!
On 14/08/2024 03:12, Martin KaFai Lau wrote:
> On 8/5/24 2:52 AM, Matthieu Baerts (NGI0) wrote:
>> +static int endpoint_init(char *flags)
>> +{
>> + SYS(fail, "ip -net %s link add veth1 type veth peer name veth2",
>> NS
after the end of some tests, and
help with the debugging of some issues. That's why this modification is
seen as a "fix".
Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Acked-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
tools/testing/selftests/net/lib.sh
using setsockopts.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/76
Signed-off-by: Geliang Tang
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
---
Notes:
- v2 -> v3:
- Use './mptcp_pm_nl_ctl' instead of 'ip mptcp', not supported by
MPTCP repo https://github.com/multipath-tcp/mptcp_net-next (the
"scripts" branch), and it has been adapted by Geliang.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/76
Co-developed-by: Geliang Tang
Signed-off-by: Geliang Tang
Signed-off-by: Nicolas Rybowski
Reviewed
Tessares, but he did this work
while working for them, and his email address is no longer available.
- A new MPTCP BPF subtest validating the new BPF program added in the
first patch.
Signed-off-by: Matthieu Baerts (NGI0)
---
Changes in v4:
- Drop former patch 2/3: MPTCP's pm_nl_ctl req
h here is not fixing anything wrong in the selftests,
but it validates the previous fix for an issue introduced by this commit
ID.
Fixes: 86e39e04482b ("mptcp: keep track of local endpoint still available for
each msk")
Reviewed-by: Mat Martineau
Signed-off-by: Matthieu Baerts (NGI0)
--
1 - 100 of 335 matches
Mail list logo
